[GitHub] [kafka] jolshan commented on a diff in pull request #13840: MINOR: Upgrade Scala for Java 20/21 support

["jolshan (via GitHub)" <gi...@apache.org>]

jolshan commented on code in PR #13840:
URL: https://github.com/apache/kafka/pull/13840#discussion_r1227308577


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -2499,15 +2499,16 @@ class ReplicaManagerTest {
                                                          time: Time,
                                                          threadNamePrefix: Option[String],
                                                          replicationQuotaManager: ReplicationQuotaManager): ReplicaFetcherManager = {
+        val rm = this

Review Comment:
   do we want to replace "this" in the line below with rm? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org