[GitHub] [hadoop] jiwq commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka

[GitBox <gi...@apache.org>]

jiwq commented on a change in pull request #812: HDDS-1511. Space tracking for Open Containers in HDDS Volumes. Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/812#discussion_r283139017
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java
 ##########
 @@ -321,10 +370,20 @@ public long getWriteBytes() {
 
   /**
    * Increase the number of bytes write into the container.
+   * Also decrement committed bytes against the bytes written.
    * @param bytes the number of bytes write into the container.
    */
   public void incrWriteBytes(long bytes) {
+    long unused = getMaxSize() - getBytesUsed();
 
 Review comment:
   Maybe we need a new method to decrement the bytes  such as named `decrWriteBytes`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org