You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/08/25 18:27:20 UTC
Review Request 25027: SQOOP-1467 Sqoop2: Make MAccountableEntity
inherit from MValidatedElement rather then MPersistableEntity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25027/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1467
https://issues.apache.org/jira/browse/SQOOP-1467
Repository: sqoop-SQOOP-1367
Description
-------
I've changed the inheritance as suggested on JIRA. I've also removed the "name" concept from MJob and MConnection to re-use the implementation in MNamedElement.
Diffs
-----
common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 781331b
common/src/main/java/org/apache/sqoop/model/MConnection.java da9691f
common/src/main/java/org/apache/sqoop/model/MJob.java 3835113
common/src/main/java/org/apache/sqoop/model/MNamedElement.java 42c9954
common/src/main/java/org/apache/sqoop/model/MValidatedElement.java 0eafad8
Diff: https://reviews.apache.org/r/25027/diff/
Testing
-------
Tests in model module seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request 25027: SQOOP-1467 Sqoop2: Make MAccountableEntity
inherit from MValidatedElement rather then MPersistableEntity
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25027/#review51414
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Aug. 25, 2014, 4:27 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25027/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 4:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1467
> https://issues.apache.org/jira/browse/SQOOP-1467
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> I've changed the inheritance as suggested on JIRA. I've also removed the "name" concept from MJob and MConnection to re-use the implementation in MNamedElement.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 781331b
> common/src/main/java/org/apache/sqoop/model/MConnection.java da9691f
> common/src/main/java/org/apache/sqoop/model/MJob.java 3835113
> common/src/main/java/org/apache/sqoop/model/MNamedElement.java 42c9954
> common/src/main/java/org/apache/sqoop/model/MValidatedElement.java 0eafad8
>
> Diff: https://reviews.apache.org/r/25027/diff/
>
>
> Testing
> -------
>
> Tests in model module seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 25027: SQOOP-1467 Sqoop2: Make MAccountableEntity
inherit from MValidatedElement rather then MPersistableEntity
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25027/#review51406
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Aug. 25, 2014, 4:27 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25027/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 4:27 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1467
> https://issues.apache.org/jira/browse/SQOOP-1467
>
>
> Repository: sqoop-SQOOP-1367
>
>
> Description
> -------
>
> I've changed the inheritance as suggested on JIRA. I've also removed the "name" concept from MJob and MConnection to re-use the implementation in MNamedElement.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 781331b
> common/src/main/java/org/apache/sqoop/model/MConnection.java da9691f
> common/src/main/java/org/apache/sqoop/model/MJob.java 3835113
> common/src/main/java/org/apache/sqoop/model/MNamedElement.java 42c9954
> common/src/main/java/org/apache/sqoop/model/MValidatedElement.java 0eafad8
>
> Diff: https://reviews.apache.org/r/25027/diff/
>
>
> Testing
> -------
>
> Tests in model module seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>