You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2021/01/11 10:47:00 UTC

[jira] [Resolved] (PHOENIX-6309) Use maven enforcer to ban imports

     [ https://issues.apache.org/jira/browse/PHOENIX-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Istvan Toth resolved PHOENIX-6309.
----------------------------------
    Resolution: Fixed

Committed to 4.x and master.
Thank you [~vjasani]

> Use maven enforcer to ban imports
> ---------------------------------
>
>                 Key: PHOENIX-6309
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6309
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 5.0.0, 4.15.0
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>
> We are already using mvn enforcer plugin for hbase version evaluations. We can extend it's usage to restrict-imports-enforcer-rule enforcer and ban imports from illegal packages (as per our project guidelines)
> e.g restrict usage of org.apache.commons.logging, com.google.common (in the presence of phoenix-thirdparty in Phoenix 5.x) etc.
> While doing backports from 4.x to master and vice-versa, it's quite common for these branch specific imports rules to get ignored by devs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)