You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/06 05:34:30 UTC

[GitHub] [airflow] uranusjr commented on pull request #20591: Removed duplicated TaskInstance.dag_run in Dag.get_task_instances()

uranusjr commented on pull request #20591:
URL: https://github.com/apache/airflow/pull/20591#issuecomment-1006298162


   I wish SQLAlchemy should be smarter about this and automatically ignore the duplicated join; this makes this sort of query-agumenting more robust (because removing duplicated join means the outer `order_by()` may break in the future if the implementation of `_get_task_instances()` changes). But this is what it is, we all know SQLAlchemy is far from perfect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org