You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/18 13:46:35 UTC
[GitHub] [druid] AshishKapoor opened a new pull request #11947: 11946 fix keyboard event keyCode method
AshishKapoor opened a new pull request #11947:
URL: https://github.com/apache/druid/pull/11947
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Fixes #11946.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
Replace Keyboard event `keyCode` method with `code`.
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
Should fix the TypeScript error respectively.
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
##### Key changed/added classes in this PR
web-console/src/bootstrap/react-table-custom-pagination.tsx
web-console/src/entry.ts
web-console/src/views/query-view/query-output/column-rename-input/column-rename-input.tsx
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AshishKapoor commented on pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
AshishKapoor commented on pull request #11947:
URL: https://github.com/apache/druid/pull/11947#issuecomment-1000245853
> This is a great change, but can you please check the correct capitalization? Does this work?
Can you suggest steps to test these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AshishKapoor commented on a change in pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
AshishKapoor commented on a change in pull request #11947:
URL: https://github.com/apache/druid/pull/11947#discussion_r774299348
##########
File path: web-console/src/bootstrap/react-table-custom-pagination.tsx
##########
@@ -123,7 +123,7 @@ export class ReactTableCustomPagination extends React.PureComponent<
value={tempPage || String(page + 1)}
onBlur={this.applyTempPage}
onKeyPress={e => {
- if (e.which === 13 || e.keyCode === 13) {
+ if (e.key === 'enter') {
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AshishKapoor commented on a change in pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
AshishKapoor commented on a change in pull request #11947:
URL: https://github.com/apache/druid/pull/11947#discussion_r774299272
##########
File path: web-console/src/views/query-view/query-output/column-rename-input/column-rename-input.tsx
##########
@@ -44,12 +44,12 @@ export const ColumnRenameInput = React.memo(function ColumnRenameInput(
value={newName}
onChange={(e: any) => setNewName(e.target.value)}
onKeyDown={(e: React.KeyboardEvent<HTMLInputElement>) => {
- switch (e.keyCode) {
- case 13: // Enter
+ switch (e.key) {
+ case 'enter': // Enter
Review comment:
Done! Changed to 'Enter' and 'Tab'. Also, removed unwanted comments.
For testing and reference https://css-tricks.com/snippets/javascript/javascript-keycodes/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #11947:
URL: https://github.com/apache/druid/pull/11947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] AshishKapoor commented on pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
AshishKapoor commented on pull request #11947:
URL: https://github.com/apache/druid/pull/11947#issuecomment-973953634
Hey, @vogievetsky @suneet-s please review this small PR.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #11947: [Web Console] fix deprecated keyboard event method "keyCode" with "key"
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #11947:
URL: https://github.com/apache/druid/pull/11947#discussion_r774190078
##########
File path: web-console/src/views/query-view/query-output/column-rename-input/column-rename-input.tsx
##########
@@ -44,12 +44,12 @@ export const ColumnRenameInput = React.memo(function ColumnRenameInput(
value={newName}
onChange={(e: any) => setNewName(e.target.value)}
onKeyDown={(e: React.KeyboardEvent<HTMLInputElement>) => {
- switch (e.keyCode) {
- case 13: // Enter
+ switch (e.key) {
+ case 'enter': // Enter
Review comment:
Also now we do not need the comment. Yay for self documenting code.
##########
File path: web-console/src/bootstrap/react-table-custom-pagination.tsx
##########
@@ -123,7 +123,7 @@ export class ReactTableCustomPagination extends React.PureComponent<
value={tempPage || String(page + 1)}
onBlur={this.applyTempPage}
onKeyPress={e => {
- if (e.which === 13 || e.keyCode === 13) {
+ if (e.key === 'enter') {
Review comment:
I think the correct string here is `'Enter'` not `'enter'`
##########
File path: web-console/src/views/query-view/query-output/column-rename-input/column-rename-input.tsx
##########
@@ -44,12 +44,12 @@ export const ColumnRenameInput = React.memo(function ColumnRenameInput(
value={newName}
onChange={(e: any) => setNewName(e.target.value)}
onKeyDown={(e: React.KeyboardEvent<HTMLInputElement>) => {
- switch (e.keyCode) {
- case 13: // Enter
+ switch (e.key) {
+ case 'enter': // Enter
Review comment:
Ditto on the capitalization here and everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org