You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/06/02 22:44:12 UTC
[Impala-ASF-CR] IMPALA-14051: Use batch insert HMS API to fire insert events
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22869 )
Change subject: IMPALA-14051: Use batch insert HMS API to fire insert events
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/22869/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22869/2//COMMIT_MSG@10
PS2, Line 10: HMS API addWriteNotificationLogInBatch().
"HMS API addWriteNotificationLogInBatch() available starting from Hive 4."
If you can also mention the Hive JIRA number, that will be great.
http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:
http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@440
PS2, Line 440: Fires a listener event of the type ACID_WRITE on a transactional table in metastore.
Is this improvement limited to Hive ACID table? If yes, please mention it in commit message.
http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@457
PS2, Line 457: rqst
nit: "req" is better.
http://gerrit.cloudera.org:8080/#/c/22869/2/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@466
PS2, Line 466: rqst
nit: "batchedReq" is better.
--
To view, visit http://gerrit.cloudera.org:8080/22869
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4a2691631fe9e9e1dc07714c69580a4ace6a8b
Gerrit-Change-Number: 22869
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jun 2025 22:44:12 +0000
Gerrit-HasComments: Yes