You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by "DrDub (via GitHub)" <gi...@apache.org> on 2024/03/08 05:43:14 UTC
[PR] Fix #2 (broken image on home page) [uima-site]
DrDub opened a new pull request, #3:
URL: https://github.com/apache/uima-site/pull/3
Fix broken / old images
Changed copyright year on pages
If the changes are good to go, I'll add to this PR the generated `docs/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985139248
AFAIK `xdocs` only has the `.xml` files that are transformed via velocity. All static content (e.g. also the board reports, documentation, etc.) goes directoy to `docs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985118729
Home page deeplink is removed. The images went into `docs/images`. `xdocs/images` actually doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985079731
> Are you planning to go live wit this page and then gradually move it to a new foundation or is the idea to stick with the existing site until this repo here has undergone full transformation?
Yes, I like gradual changes so we can make sure we are all in the same page (pun intended).
And... X is gone ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985102619
I was planning to squash the commits here following the review. The format you describe sounds good.
I agree with the self-contained bit. Let me upload these two images and update the PR. There might be other instances of deep linking in the site. Maybe open another issue for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985074871
I'd drop X at this point.
Are you planning to stick to the old Velocity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985078361
Are you planning to go live wit this page and then gradually move it to a new foundation or is the idea to stick with the existing site until this repo here has undergone full transformation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985094599
IMHO the site should be self-contained. E.g. are currently linking to an asset on S3 and community-over-code which should I think should be copied into the site proper to avoid rot if we forget to removed them in time.
Formally, we usually use the following format for commit messages in other repos:
```
Issue #NUM: Title of the issue per GitHub
- Change one
- Change two
```
I think if we switch to an issue-driven process in this repo as well, the same convention should be followed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub merged PR #3:
URL: https://github.com/apache/uima-site/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985076619
Nope. Just trying to build ways to work together. Once we have this working then we can do PRs with changes to velocity, etc. and discuss them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "DrDub (via GitHub)" <gi...@apache.org>.
DrDub commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985086257
LGTM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985103241
> There might be other instances of deep linking in the site. Maybe open another issue for that?
Maybe - or just fix them along naturally as part of other changes. I have no strong opinion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #2 (broken image on home page) [uima-site]
Posted by "reckart (via GitHub)" <gi...@apache.org>.
reckart commented on PR #3:
URL: https://github.com/apache/uima-site/pull/3#issuecomment-1985083707
I normally like gradual change as well, but if we are moving to a new site build system, that is a pretty fundamental change - and one single massive PR at that point. So I guess at least we'd have one cataclysmic change here.
But anyway, going away from Subversion is already a good step and trimming down the existing page at the same time is also good, so let's do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uima.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org