You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com> on 2017/04/05 05:52:06 UTC
Review Request 58198: Repetitive operation 'Link' in hdfs.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58198/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20675
https://issues.apache.org/jira/browse/AMBARI-20675
Repository: ambari
Description
-------
the method of install_snappy is repetitive in hdfs.py
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284
Diff: https://reviews.apache.org/r/58198/diff/1/
Testing
-------
done it
Thanks,
zhangxiaolu zhangxiaolu
Re: Review Request 58198: Repetitive operation 'Link' in hdfs.py
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58198/#review171145
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
Line 132 (original)
<https://reviews.apache.org/r/58198/#comment244034>
If it does have to be removed, same should be done fo r HDFS 3.0
- Alejandro Fernandez
On April 5, 2017, 5:52 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58198/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 5:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20675
> https://issues.apache.org/jira/browse/AMBARI-20675
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the method of install_snappy is repetitive in hdfs.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284
>
>
> Diff: https://reviews.apache.org/r/58198/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58198: Repetitive operation 'Link' in hdfs.py
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58198/#review171129
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
Lines 129-131 (original), 129-131 (patched)
<https://reviews.apache.org/r/58198/#comment244017>
There should be a test to cover this case.
- Nate Cole
On April 5, 2017, 1:52 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58198/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 1:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20675
> https://issues.apache.org/jira/browse/AMBARI-20675
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the method of install_snappy is repetitive in hdfs.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284
>
>
> Diff: https://reviews.apache.org/r/58198/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58198: Repetitive operation 'Link' in hdfs.py
Posted by zhangxiaolu zhangxiaolu <zh...@cmss.chinamobile.com>.
> On \u56db\u6708 5, 2017, 12:16 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
> > Line 132 (original)
> > <https://reviews.apache.org/r/58198/diff/1/?file=1684959#file1684959line132>
> >
> > these symlinks are for different instruction sets. Could you please elaborate why this change is required?
Yes, you're right. so_target_dir_x86 is for 'linux-is386-32' and so target_dir_x64 is for 'linux-amd64-64'.Soory, I'm wrong.I will revoke this patch.Sorry.
- zhangxiaolu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58198/#review171116
-----------------------------------------------------------
On \u56db\u6708 5, 2017, 5:52 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58198/
> -----------------------------------------------------------
>
> (Updated \u56db\u6708 5, 2017, 5:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20675
> https://issues.apache.org/jira/browse/AMBARI-20675
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the method of install_snappy is repetitive in hdfs.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284
>
>
> Diff: https://reviews.apache.org/r/58198/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>
Re: Review Request 58198: Repetitive operation 'Link' in hdfs.py
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58198/#review171116
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
Line 132 (original)
<https://reviews.apache.org/r/58198/#comment243998>
these symlinks are for different instruction sets. Could you please elaborate why this change is required?
- Dmitro Lisnichenko
On April 5, 2017, 8:52 a.m., zhangxiaolu zhangxiaolu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58198/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 8:52 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Dmytro Sen, Jaimin Jetly, Nate Cole, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20675
> https://issues.apache.org/jira/browse/AMBARI-20675
>
>
> Repository: ambari
>
>
> Description
> -------
>
> the method of install_snappy is repetitive in hdfs.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py 1264284
>
>
> Diff: https://reviews.apache.org/r/58198/diff/1/
>
>
> Testing
> -------
>
> done it
>
>
> Thanks,
>
> zhangxiaolu zhangxiaolu
>
>