You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tian-pengfei (via GitHub)" <gi...@apache.org> on 2023/06/12 15:10:48 UTC
[GitHub] [shenyu] tian-pengfei opened a new pull request, #4729: [type:fix]fix SofaServiceEventListenerTest.testBuildMetaDataDTO
tian-pengfei opened a new pull request, #4729:
URL: https://github.com/apache/shenyu/pull/4729
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
I think the `SofaServiceEventListenerTest.testBuildMetaDataDTO` method has a problem.
Sometimes the expected one's timeMillis is diffrent from the actual's ,Because of the difference of creation time
So, Removes comparing timeMillis in MetaDataRegisterDTO#equals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] dragon-zhang merged pull request #4729: [type:fix]fix SofaServiceEventListenerTest.testBuildMetaDataDTO
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang merged PR #4729:
URL: https://github.com/apache/shenyu/pull/4729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4729: [type:fix]fix SofaServiceEventListenerTest.testBuildMetaDataDTO
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei commented on PR #4729:
URL: https://github.com/apache/shenyu/pull/4729#issuecomment-1588468323
> the `hashCode` maybe also need changes, too ?
yes I will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4729: [type:fix]fix SofaServiceEventListenerTest.testBuildMetaDataDTO
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei commented on PR #4729:
URL: https://github.com/apache/shenyu/pull/4729#issuecomment-1588404993
> the `equals` maybe also need changes, too ?
That depends on whether comparing two objects to be equal should take into account the time they was created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4729: [type:fix]fix SofaServiceEventListenerTest.testBuildMetaDataDTO
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4729:
URL: https://github.com/apache/shenyu/pull/4729#issuecomment-1588460401
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4729?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4729](https://app.codecov.io/gh/apache/shenyu/pull/4729?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d8e273d) into [master](https://app.codecov.io/gh/apache/shenyu/commit/3cb2debaf04955740cc0b88632e4440e21b958df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3cb2deb) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #4729 +/- ##
============================================
- Coverage 66.18% 66.15% -0.04%
+ Complexity 8004 7995 -9
============================================
Files 1103 1103
Lines 32157 32145 -12
Branches 2908 2904 -4
============================================
- Hits 21284 21265 -19
- Misses 9179 9184 +5
- Partials 1694 1696 +2
```
[see 17 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4729/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org