Re: [PR] fix(cal-heatmap): calendar heatmap rendering null month fix [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #36315:
URL: https://github.com/apache/superset/pull/36315#issuecomment-4353715409

   @Bunbunw @CoolDude937 — gentle ping on this one. Since my [Dec 16 comment](https://github.com/apache/superset/pull/36315#issuecomment-2546098000) the branch has fallen behind master and is now showing conflicts, and the four items I raised are still open:
   
   1. `Math.min` / `Math.max` removal in `cal-heatmap.js` — backward-range / negative-range safety
   2. UTC vs local-time inconsistency between the new `getMonthDomain` and the existing `getWeekDomain` / `getYearDomain`
   3. Strengthening the `toContain('YYYY-MM-DD')` assertions in `cal-heatmap.test.ts` (e.g. full ISO equality) so an off-by-hour bug can't sneak through
   4. A small Python test in `tests/integration_tests/viz_tests.py` for the new `CalHeatmapViz` month-domain branch — also requested by @copilot-pull-request-reviewer on `superset/viz.py:805`, and Codecov has the patch at 0% coverage
   
   If you're able to rebase on master and tackle those, I'm happy to take another pass. If you've moved on or would rather hand it off, just let me know and we can figure out next steps. Thanks again for the contribution and the patience!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org