You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/30 04:54:44 UTC

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #18718: Pre-judgment database name is null.

strongduanmu commented on code in PR #18718:
URL: https://github.com/apache/shardingsphere/pull/18718#discussion_r910604621


##########
shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementContext.java:
##########
@@ -98,6 +98,9 @@ public InsertStatementContext(final Map<String, ShardingSphereDatabase> database
     
     private ShardingSphereSchema getSchema(final Map<String, ShardingSphereDatabase> databases, final String defaultDatabaseName) {
         String databaseName = tablesContext.getDatabaseName().orElse(defaultDatabaseName);
+        if (null == databaseName) {

Review Comment:
   @zjcnb In what scenario will databaseName be empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org