You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2024/03/25 04:02:57 UTC
[PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
zy-kkk opened a new pull request, #32747:
URL: https://github.com/apache/doris/pull/32747
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017205189
<details>
<summary>TPC-DS: <b>Total hot run time: 185556 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472, data reload: false
query1 936 372 359 359
query2 7356 1969 1971 1969
query3 6711 208 213 208
query4 31396 21290 21336 21290
query5 4268 507 413 413
query6 261 177 166 166
query7 4636 288 277 277
query8 232 168 167 167
query9 9124 2286 2251 2251
query10 585 240 258 240
query11 15388 14282 14530 14282
query12 135 95 87 87
query13 1636 426 410 410
query14 11961 11011 10855 10855
query15 262 196 190 190
query16 8120 275 255 255
query17 1931 568 547 547
query18 2038 284 281 281
query19 252 158 159 158
query20 95 91 88 88
query21 201 124 124 124
query22 4980 4779 4774 4774
query23 33456 32446 32728 32446
query24 10652 2867 2896 2867
query25 611 386 407 386
query26 1183 155 156 155
query27 2468 347 351 347
query28 6997 1857 1855 1855
query29 886 659 630 630
query30 298 150 149 149
query31 979 750 740 740
query32 99 57 54 54
query33 768 265 259 259
query34 1086 477 470 470
query35 822 630 610 610
query36 1019 901 887 887
query37 124 78 81 78
query38 3530 3398 3410 3398
query39 1489 1455 1430 1430
query40 219 115 115 115
query41 51 49 49 49
query42 103 92 99 92
query43 470 460 461 460
query44 1192 721 722 721
query45 282 262 241 241
query46 1128 716 698 698
query47 1886 1819 1827 1819
query48 441 369 364 364
query49 1137 355 335 335
query50 769 370 375 370
query51 6720 6616 6653 6616
query52 107 94 90 90
query53 344 279 272 272
query54 322 248 252 248
query55 83 78 80 78
query56 247 236 238 236
query57 1199 1138 1135 1135
query58 244 210 217 210
query59 2713 2619 2577 2577
query60 280 255 270 255
query61 114 114 112 112
query62 686 479 461 461
query63 316 281 279 279
query64 5509 4130 3935 3935
query65 3039 3007 3002 3002
query66 874 378 373 373
query67 15371 14782 14657 14657
query68 7002 530 517 517
query69 640 375 377 375
query70 1274 1134 1100 1100
query71 517 285 277 277
query72 6721 2704 2539 2539
query73 725 304 310 304
query74 8195 6679 6650 6650
query75 4005 2791 2843 2791
query76 4941 861 877 861
query77 670 272 260 260
query78 11031 10174 10060 10060
query79 11512 533 514 514
query80 2278 376 391 376
query81 512 209 215 209
query82 350 196 204 196
query83 237 142 141 141
query84 287 80 79 79
query85 1220 317 318 317
query86 357 293 279 279
query87 3730 3521 3527 3521
query88 5587 2284 2300 2284
query89 479 365 367 365
query90 2031 175 175 175
query91 176 147 136 136
query92 57 48 48 48
query93 6399 495 481 481
query94 1336 178 175 175
query95 441 332 322 322
query96 596 274 276 274
query97 3048 2907 2865 2865
query98 238 210 208 208
query99 1127 915 905 905
Total cold run time: 312536 ms
Total hot run time: 185556 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017169762
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017412417
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select: 21.8 seconds inserted 10000000 Rows, about 458K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #32747:
URL: https://github.com/apache/doris/pull/32747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017467737
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017208482
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 20.0 seconds inserted 10000000 Rows, about 500K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017408318
<details>
<summary>TPC-DS: <b>Total hot run time: 185632 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472, data reload: false
query1 922 354 347 347
query2 7360 1924 1829 1829
query3 6702 210 215 210
query4 31794 21250 21312 21250
query5 4369 407 413 407
query6 279 179 173 173
query7 4623 291 282 282
query8 231 178 174 174
query9 9287 2252 2268 2252
query10 560 243 262 243
query11 14852 14250 14450 14250
query12 130 87 90 87
query13 1618 412 406 406
query14 12028 11108 11448 11108
query15 286 210 194 194
query16 7982 266 254 254
query17 1981 606 546 546
query18 1936 295 285 285
query19 346 160 153 153
query20 92 84 88 84
query21 204 132 125 125
query22 4977 4806 4778 4778
query23 33340 32400 32876 32400
query24 10766 2914 2856 2856
query25 583 355 366 355
query26 1223 159 150 150
query27 2576 358 350 350
query28 6988 1863 1842 1842
query29 873 626 603 603
query30 299 145 148 145
query31 946 727 721 721
query32 91 59 52 52
query33 759 247 251 247
query34 1056 490 501 490
query35 823 605 610 605
query36 1031 916 902 902
query37 118 76 72 72
query38 3552 3436 3437 3436
query39 1615 1436 1458 1436
query40 205 110 109 109
query41 49 44 44 44
query42 109 96 90 90
query43 471 429 433 429
query44 1226 724 708 708
query45 280 274 237 237
query46 1112 697 698 697
query47 1943 1816 1853 1816
query48 439 347 340 340
query49 1099 343 344 343
query50 759 370 362 362
query51 6743 6502 6615 6502
query52 115 87 91 87
query53 340 274 275 274
query54 304 245 239 239
query55 90 74 74 74
query56 230 218 225 218
query57 1211 1137 1141 1137
query58 238 203 201 201
query59 2815 2590 2532 2532
query60 274 326 254 254
query61 113 112 111 111
query62 678 451 462 451
query63 304 281 272 272
query64 5330 4085 4029 4029
query65 3066 3051 3032 3032
query66 874 375 371 371
query67 15155 14875 14704 14704
query68 6199 518 514 514
query69 608 389 384 384
query70 1276 1209 1193 1193
query71 493 285 280 280
query72 6923 2832 2671 2671
query73 715 314 317 314
query74 6966 6694 6640 6640
query75 3939 2778 2884 2778
query76 4344 869 886 869
query77 624 264 276 264
query78 10972 10165 10045 10045
query79 8375 517 516 516
query80 1891 382 388 382
query81 544 217 225 217
query82 1550 198 202 198
query83 320 142 140 140
query84 287 85 77 77
query85 1633 318 305 305
query86 483 306 307 306
query87 3682 3553 3569 3553
query88 4878 2273 2271 2271
query89 523 363 374 363
query90 1961 173 175 173
query91 174 162 142 142
query92 59 46 47 46
query93 6463 507 481 481
query94 1233 172 172 172
query95 432 323 324 323
query96 595 271 269 269
query97 3099 2880 2860 2860
query98 235 219 214 214
query99 1238 912 910 910
Total cold run time: 307484 ms
Total hot run time: 185632 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017746747
Only when jdbcclient is created, close is needed, such as when creating MySQL Catalog. If jdbcmysqlclient is not created correctly because some parameters are incorrect, there is no need to close jdbcclient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017393813
<details>
<summary>TPC-H: <b>Total hot run time: 37649 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472, data reload: false
------ Round 1 ----------------------------------
q1 17655 4105 4108 4105
q2 2105 161 148 148
q3 10583 1158 1209 1158
q4 10223 747 772 747
q5 7459 2967 2956 2956
q6 198 121 120 120
q7 1035 598 558 558
q8 9326 1981 1968 1968
q9 7363 6569 6506 6506
q10 8449 3465 3571 3465
q11 438 224 217 217
q12 428 196 193 193
q13 17788 2854 2863 2854
q14 230 215 202 202
q15 506 461 457 457
q16 503 368 368 368
q17 931 533 594 533
q18 7031 6429 6342 6342
q19 1743 1458 1386 1386
q20 529 259 246 246
q21 3589 2910 2834 2834
q22 341 286 297 286
Total cold run time: 108453 ms
Total hot run time: 37649 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4098 4046 4073 4046
q2 330 228 231 228
q3 2905 2804 2832 2804
q4 1822 1556 1520 1520
q5 5399 5299 5293 5293
q6 201 114 114 114
q7 2212 1863 1864 1863
q8 3113 3275 3226 3226
q9 8641 8611 8639 8611
q10 3792 3731 3774 3731
q11 548 447 437 437
q12 705 537 538 537
q13 16920 2839 2853 2839
q14 286 250 257 250
q15 486 445 457 445
q16 469 409 408 408
q17 1719 1498 1465 1465
q18 7426 7181 7079 7079
q19 1996 1476 1477 1476
q20 1894 1741 1702 1702
q21 4786 4718 4633 4633
q22 507 436 444 436
Total cold run time: 70255 ms
Total hot run time: 53143 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017169879
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017351583
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [opt](jdbc catalog) close when jdbcClient is not empty [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32747:
URL: https://github.com/apache/doris/pull/32747#issuecomment-2017195624
<details>
<summary>TPC-H: <b>Total hot run time: 37532 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7bea55cd0be7d61b68a33efb22cf9529a5803472, data reload: false
------ Round 1 ----------------------------------
q1 17693 4199 4071 4071
q2 2120 158 155 155
q3 10584 1110 1186 1110
q4 10228 736 756 736
q5 7465 2951 2965 2951
q6 207 124 123 123
q7 1038 570 566 566
q8 9330 2031 1949 1949
q9 7111 6564 6548 6548
q10 8438 3441 3616 3441
q11 436 226 220 220
q12 411 193 188 188
q13 17798 2836 2905 2836
q14 227 197 206 197
q15 514 450 456 450
q16 502 371 363 363
q17 944 621 569 569
q18 7009 6415 6335 6335
q19 3687 1411 1482 1411
q20 568 262 250 250
q21 3610 2843 2779 2779
q22 337 284 289 284
Total cold run time: 110257 ms
Total hot run time: 37532 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4103 4059 4058 4058
q2 319 231 229 229
q3 2934 2838 2828 2828
q4 1817 1542 1539 1539
q5 5268 5278 5326 5278
q6 196 114 115 114
q7 2206 1855 1833 1833
q8 3104 3270 3277 3270
q9 8637 8686 8709 8686
q10 3773 3740 3729 3729
q11 554 441 436 436
q12 707 519 582 519
q13 16908 2840 2842 2840
q14 298 253 248 248
q15 490 471 457 457
q16 460 438 424 424
q17 1716 1525 1452 1452
q18 7414 7143 7101 7101
q19 2437 1497 1529 1497
q20 1914 1713 1693 1693
q21 4784 4713 4660 4660
q22 513 433 447 433
Total cold run time: 70552 ms
Total hot run time: 53324 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org