[GitHub] HyukjinKwon commented on a change in pull request #23400: [SPARK-26499] [SQL] JdbcUtils.makeGetter does not handle ByteType

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23400: [SPARK-26499] [SQL] JdbcUtils.makeGetter does not handle ByteType
URL: https://github.com/apache/spark/pull/23400#discussion_r244527519
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
 ##########
 @@ -56,6 +56,17 @@ class JDBCSuite extends QueryTest
       Some(StringType)
   }
 
+  val testH2DialectTinyInt = new JdbcDialect {
+    override def canHandle(url: String): Boolean = url.startsWith("jdbc:h2")
+    override def getCatalystType(sqlType: Int, typeName: String, size: Int, md: MetadataBuilder) :
+    Option[DataType] = {
 
 Review comment:
   Not a big deal but there's style guide https://github.com/databricks/scala-style-guide (see http://spark.apache.org/contributing.html)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org