You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2023/02/21 06:28:03 UTC
[GitHub] [skywalking-query-protocol] wankai123 opened a new pull request, #108: Deprecate scope from entity
wankai123 opened a new pull request, #108:
URL: https://github.com/apache/skywalking-query-protocol/pull/108
Backend query service would get Scope by condition's `metrics name` from `ValueColumnMetadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #108: Deprecate scope from entity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #108:
URL: https://github.com/apache/skywalking-query-protocol/pull/108#discussion_r1112595465
##########
metrics-v2.graphqls:
##########
@@ -34,13 +34,14 @@ enum MetricsType {
}
input Entity {
- # 1. scope=All, no name is required.
- # 2. scope=Service, ServiceInstance and Endpoint, set necessary serviceName/serviceInstanceName/endpointName
- # 3. Scope=ServiceRelation, ServiceInstanceRelation, EndpointRelation and ProcessRelation
+ # Deprecated from 9.4.0
+ # Backend query service would get Scope by condition's `metrics name` from `ValueColumnMetadata`, and override the Scope here.
+ scope: Scope
+ # 1. metrics scope=Service, ServiceInstance and Endpoint, set necessary serviceName/serviceInstanceName/endpointName
Review Comment:
```suggestion
# 1. metrics Scope=Service, ServiceInstance and Endpoint, set necessary serviceName/serviceInstanceName/endpointName
```
##########
metrics-v2.graphqls:
##########
@@ -34,13 +34,14 @@ enum MetricsType {
}
input Entity {
- # 1. scope=All, no name is required.
- # 2. scope=Service, ServiceInstance and Endpoint, set necessary serviceName/serviceInstanceName/endpointName
- # 3. Scope=ServiceRelation, ServiceInstanceRelation, EndpointRelation and ProcessRelation
+ # Deprecated from 9.4.0
+ # Backend query service would get Scope by condition's `metrics name` from `ValueColumnMetadata`, and override the Scope here.
Review Comment:
```suggestion
# Scope could be sensed automatically through given metric name.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #108: Deprecate scope from entity
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #108:
URL: https://github.com/apache/skywalking-query-protocol/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org