[GitHub] [superset] hhhonzik commented on a diff in pull request #24949: fix(opensearch): fix opensearch time conversion

["hhhonzik (via GitHub)" <gi...@apache.org>]

hhhonzik commented on code in PR #24949:
URL: https://github.com/apache/superset/pull/24949#discussion_r1291172369


##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -123,7 +123,7 @@ def convert_dttm(
         sqla_type = cls.get_sqla_column_type(target_type)
 
         if isinstance(sqla_type, types.DateTime):
-            return f"""'{dttm.isoformat(timespec="seconds")}'"""
+            return f"""'{dttm.isoformat(sep=" ", timespec="seconds")}'"""

Review Comment:
   @john-bodley Sorry i ignored them in the first place. Turns out there is a test for this and i didn't update it. 



##########
superset/db_engine_specs/elasticsearch.py:
##########
@@ -123,7 +123,7 @@ def convert_dttm(
         sqla_type = cls.get_sqla_column_type(target_type)
 
         if isinstance(sqla_type, types.DateTime):
-            return f"""'{dttm.isoformat(timespec="seconds")}'"""
+            return f"""'{dttm.isoformat(sep=" ", timespec="seconds")}'"""

Review Comment:
   @john-bodley Sorry i ignored them in the first place. Turns out there is a test for this and i didn't update it. All fixed now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org