You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/06/02 00:10:10 UTC
[GitHub] [pinot] walterddr opened a new pull request, #10831: [multisage][perf] do not canonicalize row when schema exactly matches
walterddr opened a new pull request, #10831:
URL: https://github.com/apache/pinot/pull/10831
we do not need to canonicalize row-by-row when v1 and v2 schema exactly matches (and requires no conversion)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #10831: [multisage][perf] do not canonicalize row when schema exactly matches
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #10831:
URL: https://github.com/apache/pinot/pull/10831#issuecomment-1613939351
closing this PR doesn't seem to make the most bang on the buck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr closed pull request #10831: [multisage][perf] do not canonicalize row when schema exactly matches
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed pull request #10831: [multisage][perf] do not canonicalize row when schema exactly matches
URL: https://github.com/apache/pinot/pull/10831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10831: [multisage][perf] do not canonicalize row when schema exactly matches
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10831:
URL: https://github.com/apache/pinot/pull/10831#issuecomment-1573008954
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10831](https://app.codecov.io/gh/apache/pinot/pull/10831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (451a50a) into [master](https://app.codecov.io/gh/apache/pinot/commit/6dbd9e23fef8d326fa2f2467ae8a10e2b3fdb428?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6dbd9e2) will **decrease** coverage by `10.53%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10831 +/- ##
=============================================
- Coverage 34.25% 23.72% -10.53%
+ Complexity 462 58 -404
=============================================
Files 2170 2154 -16
Lines 116650 116218 -432
Branches 17654 17597 -57
=============================================
- Hits 39959 27577 -12382
- Misses 73201 85791 +12590
+ Partials 3490 2850 -640
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `23.72% <0.00%> (+0.14%)` | :arrow_up: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ot/core/operator/blocks/InstanceResponseBlock.java](https://app.codecov.io/gh/apache/pinot/pull/10831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvSW5zdGFuY2VSZXNwb25zZUJsb2NrLmphdmE=) | `67.34% <ø> (-4.09%)` | :arrow_down: |
| [...e/operator/LeafStageTransferableBlockOperator.java](https://app.codecov.io/gh/apache/pinot/pull/10831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9vcGVyYXRvci9MZWFmU3RhZ2VUcmFuc2ZlcmFibGVCbG9ja09wZXJhdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
... and [474 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10831/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org