[GitHub] [maven] michael-o commented on a change in pull request #679: MNG-7416 - Simplify conditional expression.

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #679:
URL: https://github.com/apache/maven/pull/679#discussion_r810538110



##########
File path: maven-settings-builder/src/main/java/org/apache/maven/settings/building/SettingsBuildingException.java
##########
@@ -47,10 +47,7 @@ public SettingsBuildingException( List<SettingsProblem> problems )
         super( toMessage( problems ) );
 
         this.problems = new ArrayList<>();
-        if ( problems != null )
-        {
-            this.problems.addAll( problems );
-        }
+        this.problems.addAll( problems );

Review comment:
       The NPE cannot happen here because it will already happen in `toMessage()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org