You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Musachy Barroso <mb...@wfscorp.com> on 2006/10/19 22:34:59 UTC
Re: ajax tags
I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to
start playing with and I have replaced the tabbedpanel implementation
with dojo's implementation, so far I have the static and dynamic tabs
working. I was having so much fun that I didn't stop to ask if this is
what you guys want, although it is suggested by Ian Roughley in the
bug's comments.
musachy
Don Brown wrote:
> The help would be appreciated. Take a look at the tag documentation -
> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide -
> and look at the templates themselves in core/src/main/resources/templates
>
> There are several ajax-related issues in our JIRA right now, so that
> would be a very helpful place to start. :)
>
> Don
>
> Musachy Barroso wrote:
>> Hi all,
>>
>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I found
>> that some of the UI tags(tree, tab panel...) overlap with a project
>> that I'm currently maintaining (ajaxtags at
>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the UI
>> ajax tags, so some pointers on where to start or whom to talk to
>> would be appreciated. Ajaxtags is distributed under an apache 2.0
>> license so we could lift some code if needed.
>>
>> thanks
>>
>> musachy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ian Roughley <ia...@fdar.com>.
I'd like to start a thread on that myself early Nov (after I get back
from vacation).
/Ian
--
>From Down & Around, Inc.
Innovative IT Solutions
Software Architecture * Design * Development
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
web: www.fdar.com
email ian@fdar.com
phone: 617.821.5430
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Don Brown wrote:
> Well, your help is very appreciated. I would still like to rethink
> our concept of tags, themes, and ajax support, but it isn't urgent,
> and anything you can do to help us clean up our ajax tags in the
> meantime would be great. Thanks for joining the fun :)
>
> Don
>
> Musachy Barroso wrote:
>> I'm not sure if that would be a good idea, the thing is that it would
>> add a set of dependencies that I don't think are desirable
>> (scriptaculous, prototype, overlib, etc), I don't see ajaxtags going
>> too far in the future if struts supports these simple ajax tags,
>> because most of its users are using struts anyway. If you guys decide
>> to keep the ajax tags I will work on them despite they are in
>> ajaxtags already. I think keeping thin wrappers over dojo's stuff is
>> a good idea.
>>
>> Don Brown wrote:
>>> Ok, sounds reasonable. I'm all for offloading the maintaining of
>>> code to other projects when possible :)
>>>
>>> Hmm...I wonder...could your work be improved to allow your tags to
>>> be called from velocity and freemarker as well? Currently, IMO,
>>> Struts has only half-hearted support for Ajax widgets and while
>>> we've talked about a compressive strategy to tackle the problem, it
>>> was never enacted upon.
>>>
>>> I wonder if there is any way to link our projects better so that we
>>> can eliminate the overlap.... Some way of delegating the actual
>>> tags to you, but perhaps provide some advanced features that could
>>> only be developed when you have control over the server
>>> framework...I'm thinking of DWR or JSON views of Struts actions here...
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> It doesn't provide anything on top of Dojo right now, it is just a
>>>> wrapper. Even when it is available using dojo, it is really nice
>>>> when you get isolated from the js and just have to use a couple of
>>>> tags on your page. That's what ajaxtags does, wrappers around other
>>>> widgets(scriptaculous and family) and people are using it a lot.
>>>> Considering that we are using dojo anyway, and that it is almost
>>>> done (with not too much effort), I think we should keep it.
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>> Ok, I guess my next question is does the tag provide anything
>>>>> significant on top of Dojo? If we are a simple wrapper for Dojo,
>>>>> it might not be worth continuing to support the tabbed pane tag.
>>>>> What do you think?
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> Well, dojo's has some of nice things out of the box(they are just
>>>>>> hard to figure out given the amount of documentation), tabs can
>>>>>> placed on any of the sides, you can have close buttons on the
>>>>>> tabs, (either on the tab or on a corner, firefox-style), and they
>>>>>> look a lot better by default ;)
>>>>>>
>>>>>> about WW-1371, I will have to check it out.
>>>>>>
>>>>>>
>>>>>> Don Brown wrote:
>>>>>>> Cool! Any chance it fixes other tickets like WW-1371? Do you
>>>>>>> think this should be a new tag or replace the existing? What
>>>>>>> are the advantages of the new implementation?
>>>>>>>
>>>>>>> Don
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> I picked WW-205,
>>>>>>>> (https://issues.apache.org/struts/browse/WW-205) to start
>>>>>>>> playing with and I have replaced the tabbedpanel implementation
>>>>>>>> with dojo's implementation, so far I have the static and
>>>>>>>> dynamic tabs working. I was having so much fun that I didn't
>>>>>>>> stop to ask if this is what you guys want, although it is
>>>>>>>> suggested by Ian Roughley in the bug's comments.
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>> The help would be appreciated. Take a look at the tag
>>>>>>>>> documentation -
>>>>>>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>>>>>>> - and look at the templates themselves in
>>>>>>>>> core/src/main/resources/templates
>>>>>>>>>
>>>>>>>>> There are several ajax-related issues in our JIRA right now,
>>>>>>>>> so that would be a very helpful place to start. :)
>>>>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>> Hi all,
>>>>>>>>>>
>>>>>>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and
>>>>>>>>>> I found that some of the UI tags(tree, tab panel...) overlap
>>>>>>>>>> with a project that I'm currently maintaining (ajaxtags at
>>>>>>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to
>>>>>>>>>> the UI ajax tags, so some pointers on where to start or whom
>>>>>>>>>> to talk to would be appreciated. Ajaxtags is distributed
>>>>>>>>>> under an apache 2.0 license so we could lift some code if
>>>>>>>>>> needed.
>>>>>>>>>>
>>>>>>>>>> thanks
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Well, your help is very appreciated. I would still like to rethink our
concept of tags, themes, and ajax support, but it isn't urgent, and
anything you can do to help us clean up our ajax tags in the meantime
would be great. Thanks for joining the fun :)
Don
Musachy Barroso wrote:
> I'm not sure if that would be a good idea, the thing is that it would
> add a set of dependencies that I don't think are desirable
> (scriptaculous, prototype, overlib, etc), I don't see ajaxtags going
> too far in the future if struts supports these simple ajax tags,
> because most of its users are using struts anyway. If you guys decide
> to keep the ajax tags I will work on them despite they are in ajaxtags
> already. I think keeping thin wrappers over dojo's stuff is a good idea.
>
> Don Brown wrote:
>> Ok, sounds reasonable. I'm all for offloading the maintaining of
>> code to other projects when possible :)
>>
>> Hmm...I wonder...could your work be improved to allow your tags to be
>> called from velocity and freemarker as well? Currently, IMO, Struts
>> has only half-hearted support for Ajax widgets and while we've talked
>> about a compressive strategy to tackle the problem, it was never
>> enacted upon.
>>
>> I wonder if there is any way to link our projects better so that we
>> can eliminate the overlap.... Some way of delegating the actual tags
>> to you, but perhaps provide some advanced features that could only be
>> developed when you have control over the server framework...I'm
>> thinking of DWR or JSON views of Struts actions here...
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> It doesn't provide anything on top of Dojo right now, it is just a
>>> wrapper. Even when it is available using dojo, it is really nice
>>> when you get isolated from the js and just have to use a couple of
>>> tags on your page. That's what ajaxtags does, wrappers around other
>>> widgets(scriptaculous and family) and people are using it a lot.
>>> Considering that we are using dojo anyway, and that it is almost
>>> done (with not too much effort), I think we should keep it.
>>>
>>> musachy
>>>
>>> Don Brown wrote:
>>>> Ok, I guess my next question is does the tag provide anything
>>>> significant on top of Dojo? If we are a simple wrapper for Dojo,
>>>> it might not be worth continuing to support the tabbed pane tag.
>>>> What do you think?
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> Well, dojo's has some of nice things out of the box(they are just
>>>>> hard to figure out given the amount of documentation), tabs can
>>>>> placed on any of the sides, you can have close buttons on the
>>>>> tabs, (either on the tab or on a corner, firefox-style), and they
>>>>> look a lot better by default ;)
>>>>>
>>>>> about WW-1371, I will have to check it out.
>>>>>
>>>>>
>>>>> Don Brown wrote:
>>>>>> Cool! Any chance it fixes other tickets like WW-1371? Do you
>>>>>> think this should be a new tag or replace the existing? What are
>>>>>> the advantages of the new implementation?
>>>>>>
>>>>>> Don
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> I picked WW-205,
>>>>>>> (https://issues.apache.org/struts/browse/WW-205) to start
>>>>>>> playing with and I have replaced the tabbedpanel implementation
>>>>>>> with dojo's implementation, so far I have the static and dynamic
>>>>>>> tabs working. I was having so much fun that I didn't stop to ask
>>>>>>> if this is what you guys want, although it is suggested by Ian
>>>>>>> Roughley in the bug's comments.
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> Don Brown wrote:
>>>>>>>> The help would be appreciated. Take a look at the tag
>>>>>>>> documentation -
>>>>>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>>>>>> - and look at the templates themselves in
>>>>>>>> core/src/main/resources/templates
>>>>>>>>
>>>>>>>> There are several ajax-related issues in our JIRA right now, so
>>>>>>>> that would be a very helpful place to start. :)
>>>>>>>>
>>>>>>>> Don
>>>>>>>>
>>>>>>>> Musachy Barroso wrote:
>>>>>>>>> Hi all,
>>>>>>>>>
>>>>>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>>>>>>> found that some of the UI tags(tree, tab panel...) overlap
>>>>>>>>> with a project that I'm currently maintaining (ajaxtags at
>>>>>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to
>>>>>>>>> the UI ajax tags, so some pointers on where to start or whom
>>>>>>>>> to talk to would be appreciated. Ajaxtags is distributed under
>>>>>>>>> an apache 2.0 license so we could lift some code if needed.
>>>>>>>>>
>>>>>>>>> thanks
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I'm not sure if that would be a good idea, the thing is that it would
add a set of dependencies that I don't think are desirable
(scriptaculous, prototype, overlib, etc), I don't see ajaxtags going too
far in the future if struts supports these simple ajax tags, because
most of its users are using struts anyway. If you guys decide to keep
the ajax tags I will work on them despite they are in ajaxtags already.
I think keeping thin wrappers over dojo's stuff is a good idea.
Don Brown wrote:
> Ok, sounds reasonable. I'm all for offloading the maintaining of code
> to other projects when possible :)
>
> Hmm...I wonder...could your work be improved to allow your tags to be
> called from velocity and freemarker as well? Currently, IMO, Struts
> has only half-hearted support for Ajax widgets and while we've talked
> about a compressive strategy to tackle the problem, it was never
> enacted upon.
>
> I wonder if there is any way to link our projects better so that we
> can eliminate the overlap.... Some way of delegating the actual tags
> to you, but perhaps provide some advanced features that could only be
> developed when you have control over the server framework...I'm
> thinking of DWR or JSON views of Struts actions here...
>
> Don
>
> Musachy Barroso wrote:
>> It doesn't provide anything on top of Dojo right now, it is just a
>> wrapper. Even when it is available using dojo, it is really nice
>> when you get isolated from the js and just have to use a couple of
>> tags on your page. That's what ajaxtags does, wrappers around other
>> widgets(scriptaculous and family) and people are using it a lot.
>> Considering that we are using dojo anyway, and that it is almost done
>> (with not too much effort), I think we should keep it.
>>
>> musachy
>>
>> Don Brown wrote:
>>> Ok, I guess my next question is does the tag provide anything
>>> significant on top of Dojo? If we are a simple wrapper for Dojo, it
>>> might not be worth continuing to support the tabbed pane tag. What
>>> do you think?
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> Well, dojo's has some of nice things out of the box(they are just
>>>> hard to figure out given the amount of documentation), tabs can
>>>> placed on any of the sides, you can have close buttons on the tabs,
>>>> (either on the tab or on a corner, firefox-style), and they look a
>>>> lot better by default ;)
>>>>
>>>> about WW-1371, I will have to check it out.
>>>>
>>>>
>>>> Don Brown wrote:
>>>>> Cool! Any chance it fixes other tickets like WW-1371? Do you
>>>>> think this should be a new tag or replace the existing? What are
>>>>> the advantages of the new implementation?
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205)
>>>>>> to start playing with and I have replaced the tabbedpanel
>>>>>> implementation with dojo's implementation, so far I have the
>>>>>> static and dynamic tabs working. I was having so much fun that I
>>>>>> didn't stop to ask if this is what you guys want, although it is
>>>>>> suggested by Ian Roughley in the bug's comments.
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> Don Brown wrote:
>>>>>>> The help would be appreciated. Take a look at the tag
>>>>>>> documentation -
>>>>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>>>>> - and look at the templates themselves in
>>>>>>> core/src/main/resources/templates
>>>>>>>
>>>>>>> There are several ajax-related issues in our JIRA right now, so
>>>>>>> that would be a very helpful place to start. :)
>>>>>>>
>>>>>>> Don
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>>>>>> found that some of the UI tags(tree, tab panel...) overlap with
>>>>>>>> a project that I'm currently maintaining (ajaxtags at
>>>>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to
>>>>>>>> the UI ajax tags, so some pointers on where to start or whom to
>>>>>>>> talk to would be appreciated. Ajaxtags is distributed under an
>>>>>>>> apache 2.0 license so we could lift some code if needed.
>>>>>>>>
>>>>>>>> thanks
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Ok, sounds reasonable. I'm all for offloading the maintaining of code
to other projects when possible :)
Hmm...I wonder...could your work be improved to allow your tags to be
called from velocity and freemarker as well? Currently, IMO, Struts has
only half-hearted support for Ajax widgets and while we've talked about
a compressive strategy to tackle the problem, it was never enacted upon.
I wonder if there is any way to link our projects better so that we can
eliminate the overlap.... Some way of delegating the actual tags to
you, but perhaps provide some advanced features that could only be
developed when you have control over the server framework...I'm thinking
of DWR or JSON views of Struts actions here...
Don
Musachy Barroso wrote:
> It doesn't provide anything on top of Dojo right now, it is just a
> wrapper. Even when it is available using dojo, it is really nice when
> you get isolated from the js and just have to use a couple of tags on
> your page. That's what ajaxtags does, wrappers around other
> widgets(scriptaculous and family) and people are using it a lot.
> Considering that we are using dojo anyway, and that it is almost done
> (with not too much effort), I think we should keep it.
>
> musachy
>
> Don Brown wrote:
>> Ok, I guess my next question is does the tag provide anything
>> significant on top of Dojo? If we are a simple wrapper for Dojo, it
>> might not be worth continuing to support the tabbed pane tag. What
>> do you think?
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> Well, dojo's has some of nice things out of the box(they are just
>>> hard to figure out given the amount of documentation), tabs can
>>> placed on any of the sides, you can have close buttons on the tabs,
>>> (either on the tab or on a corner, firefox-style), and they look a
>>> lot better by default ;)
>>>
>>> about WW-1371, I will have to check it out.
>>>
>>>
>>> Don Brown wrote:
>>>> Cool! Any chance it fixes other tickets like WW-1371? Do you
>>>> think this should be a new tag or replace the existing? What are
>>>> the advantages of the new implementation?
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205)
>>>>> to start playing with and I have replaced the tabbedpanel
>>>>> implementation with dojo's implementation, so far I have the
>>>>> static and dynamic tabs working. I was having so much fun that I
>>>>> didn't stop to ask if this is what you guys want, although it is
>>>>> suggested by Ian Roughley in the bug's comments.
>>>>>
>>>>> musachy
>>>>>
>>>>> Don Brown wrote:
>>>>>> The help would be appreciated. Take a look at the tag
>>>>>> documentation -
>>>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>>>> - and look at the templates themselves in
>>>>>> core/src/main/resources/templates
>>>>>>
>>>>>> There are several ajax-related issues in our JIRA right now, so
>>>>>> that would be a very helpful place to start. :)
>>>>>>
>>>>>> Don
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>>>>> found that some of the UI tags(tree, tab panel...) overlap with
>>>>>>> a project that I'm currently maintaining (ajaxtags at
>>>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the
>>>>>>> UI ajax tags, so some pointers on where to start or whom to talk
>>>>>>> to would be appreciated. Ajaxtags is distributed under an apache
>>>>>>> 2.0 license so we could lift some code if needed.
>>>>>>>
>>>>>>> thanks
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
It doesn't provide anything on top of Dojo right now, it is just a
wrapper. Even when it is available using dojo, it is really nice when
you get isolated from the js and just have to use a couple of tags on
your page. That's what ajaxtags does, wrappers around other
widgets(scriptaculous and family) and people are using it a lot.
Considering that we are using dojo anyway, and that it is almost done
(with not too much effort), I think we should keep it.
musachy
Don Brown wrote:
> Ok, I guess my next question is does the tag provide anything
> significant on top of Dojo? If we are a simple wrapper for Dojo, it
> might not be worth continuing to support the tabbed pane tag. What do
> you think?
>
> Don
>
> Musachy Barroso wrote:
>> Well, dojo's has some of nice things out of the box(they are just
>> hard to figure out given the amount of documentation), tabs can
>> placed on any of the sides, you can have close buttons on the tabs,
>> (either on the tab or on a corner, firefox-style), and they look a
>> lot better by default ;)
>>
>> about WW-1371, I will have to check it out.
>>
>>
>> Don Brown wrote:
>>> Cool! Any chance it fixes other tickets like WW-1371? Do you think
>>> this should be a new tag or replace the existing? What are the
>>> advantages of the new implementation?
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205)
>>>> to start playing with and I have replaced the tabbedpanel
>>>> implementation with dojo's implementation, so far I have the static
>>>> and dynamic tabs working. I was having so much fun that I didn't
>>>> stop to ask if this is what you guys want, although it is suggested
>>>> by Ian Roughley in the bug's comments.
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>> The help would be appreciated. Take a look at the tag
>>>>> documentation -
>>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>>> - and look at the templates themselves in
>>>>> core/src/main/resources/templates
>>>>>
>>>>> There are several ajax-related issues in our JIRA right now, so
>>>>> that would be a very helpful place to start. :)
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> Hi all,
>>>>>>
>>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>>>> found that some of the UI tags(tree, tab panel...) overlap with a
>>>>>> project that I'm currently maintaining (ajaxtags at
>>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the
>>>>>> UI ajax tags, so some pointers on where to start or whom to talk
>>>>>> to would be appreciated. Ajaxtags is distributed under an apache
>>>>>> 2.0 license so we could lift some code if needed.
>>>>>>
>>>>>> thanks
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Ok, I guess my next question is does the tag provide anything
significant on top of Dojo? If we are a simple wrapper for Dojo, it
might not be worth continuing to support the tabbed pane tag. What do
you think?
Don
Musachy Barroso wrote:
> Well, dojo's has some of nice things out of the box(they are just hard
> to figure out given the amount of documentation), tabs can placed on
> any of the sides, you can have close buttons on the tabs, (either on
> the tab or on a corner, firefox-style), and they look a lot better by
> default ;)
>
> about WW-1371, I will have to check it out.
>
>
> Don Brown wrote:
>> Cool! Any chance it fixes other tickets like WW-1371? Do you think
>> this should be a new tag or replace the existing? What are the
>> advantages of the new implementation?
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to
>>> start playing with and I have replaced the tabbedpanel
>>> implementation with dojo's implementation, so far I have the static
>>> and dynamic tabs working. I was having so much fun that I didn't
>>> stop to ask if this is what you guys want, although it is suggested
>>> by Ian Roughley in the bug's comments.
>>>
>>> musachy
>>>
>>> Don Brown wrote:
>>>> The help would be appreciated. Take a look at the tag
>>>> documentation -
>>>> http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>>> - and look at the templates themselves in
>>>> core/src/main/resources/templates
>>>>
>>>> There are several ajax-related issues in our JIRA right now, so
>>>> that would be a very helpful place to start. :)
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> Hi all,
>>>>>
>>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>>> found that some of the UI tags(tree, tab panel...) overlap with a
>>>>> project that I'm currently maintaining (ajaxtags at
>>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the
>>>>> UI ajax tags, so some pointers on where to start or whom to talk
>>>>> to would be appreciated. Ajaxtags is distributed under an apache
>>>>> 2.0 license so we could lift some code if needed.
>>>>>
>>>>> thanks
>>>>>
>>>>> musachy
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Well, dojo's has some of nice things out of the box(they are just hard
to figure out given the amount of documentation), tabs can placed on any
of the sides, you can have close buttons on the tabs, (either on the tab
or on a corner, firefox-style), and they look a lot better by default ;)
about WW-1371, I will have to check it out.
Don Brown wrote:
> Cool! Any chance it fixes other tickets like WW-1371? Do you think
> this should be a new tag or replace the existing? What are the
> advantages of the new implementation?
>
> Don
>
> Musachy Barroso wrote:
>> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to
>> start playing with and I have replaced the tabbedpanel implementation
>> with dojo's implementation, so far I have the static and dynamic tabs
>> working. I was having so much fun that I didn't stop to ask if this
>> is what you guys want, although it is suggested by Ian Roughley in
>> the bug's comments.
>>
>> musachy
>>
>> Don Brown wrote:
>>> The help would be appreciated. Take a look at the tag documentation
>>> - http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>>> - and look at the templates themselves in
>>> core/src/main/resources/templates
>>>
>>> There are several ajax-related issues in our JIRA right now, so that
>>> would be a very helpful place to start. :)
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> Hi all,
>>>>
>>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I
>>>> found that some of the UI tags(tree, tab panel...) overlap with a
>>>> project that I'm currently maintaining (ajaxtags at
>>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the UI
>>>> ajax tags, so some pointers on where to start or whom to talk to
>>>> would be appreciated. Ajaxtags is distributed under an apache 2.0
>>>> license so we could lift some code if needed.
>>>>
>>>> thanks
>>>>
>>>> musachy
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Cool! Any chance it fixes other tickets like WW-1371? Do you think
this should be a new tag or replace the existing? What are the
advantages of the new implementation?
Don
Musachy Barroso wrote:
> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to
> start playing with and I have replaced the tabbedpanel implementation
> with dojo's implementation, so far I have the static and dynamic tabs
> working. I was having so much fun that I didn't stop to ask if this is
> what you guys want, although it is suggested by Ian Roughley in the
> bug's comments.
>
> musachy
>
> Don Brown wrote:
>> The help would be appreciated. Take a look at the tag documentation
>> - http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>> - and look at the templates themselves in
>> core/src/main/resources/templates
>>
>> There are several ajax-related issues in our JIRA right now, so that
>> would be a very helpful place to start. :)
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> Hi all,
>>>
>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I found
>>> that some of the UI tags(tree, tab panel...) overlap with a project
>>> that I'm currently maintaining (ajaxtags at
>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the UI
>>> ajax tags, so some pointers on where to start or whom to talk to
>>> would be appreciated. Ajaxtags is distributed under an apache 2.0
>>> license so we could lift some code if needed.
>>>
>>> thanks
>>>
>>> musachy
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
"The one feature that we had that you should check that has been
implemented in dojo is the pub/sub events - so there should be events
that each tabs listens to to refresh itself. "
I haven't seen this in dojo (I haven't seen much anyway), I will check
it out and implement it if isn't available.
Ian Roughley wrote:
> Yes - this was the direction that we wanted to go in. Try to do as
> much as possible in dojo and provide light wrappers in Struts. When
> we first implemented the tabs, there was no such dojo implementation.
> The one feature that we had that you should check that has been
> implemented in dojo is the pub/sub events - so there should be events
> that each tabs listens to to refresh itself.
>
> I think as Don pointed out, we want to keep a very lightweight wrapper
> in struts and have all the work being done in dojo.
>
> The other big thing that would be a great help is converting the code
> from dojo 0.2 to 0.3 :)
>
> Ian
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Martin Cooper <ma...@apache.org>.
On 10/23/06, Don Brown <mr...@twdata.org> wrote:
>
> Have you tried this with the Dojo 0.4 release? Any reason we shouldn't
> upgrade to it?
Nope, not that I know of. In fact, I would think we'd want to upgrade
to 0.4directly, and bypass
0.3.1. If we have any problems, they're much more likely to be fixed if
we're on the latest release.
--
Martin Cooper
Don
>
> Musachy Barroso wrote:
> > Would something like this include all the current functionality in
> > BindDiv? (events for stop/start timer, refresh, start after a delay,
> > advisor via dojo's "handler" property). This way BindDiv will be
> > easier to maintain (dojo's ContentPane + timer) and the Tab widget can
> > be deleted (doesn't add anything to this one). By the way this doesn't
> > work on AMD 64/firefox/linux due to a dojo's bug.
> >
> > dojo.provide("struts.widgets.BindDiv");
> >
> > dojo.require("dojo.widget.*");
> > dojo.require("dojo.io.*");
> > dojo.require("dojo.widget.Container");
> > dojo.require("dojo.widget.ContentPane");
> > dojo.require("dojo.animation.Timer");
> >
> > struts.widgets.BindDiv = function() {
> > dojo.widget.html.ContentPane.call(this);
> > var self = this;
> >
> > this.widgetType = "BindDiv";
> >
> > this.href = "";
> > this.extractContent = false;
> > this.parseContent = false;
> > this.cacheContent = false;
> >
> > this.frequency = 0;
> > this.delay = 0;
> > this.startTimer = false;
> > this.timer = null;
> >
> > //pub/sub events
> > this.refreshListenTopics = "";
> > this.stopTimerListenTopics = "";
> > this.startTimerListenTopics = "";
> >
> > this.postCreate = function() {
> > if(self.frequency > 0) {
> > self.timer = new dojo.animation.Timer(self.frequency);
> > self.timer.onTick = self.reloadContents;
> >
> > //start the timer
> > if(self.startTimer) {
> > //start after delay
> > dojo.debug("starting timer after " + self.delay);
> > dojo.lang.setTimeout(self.delay, self.startTimer);
> > }
> > }
> >
> > //attach listeners
> > if(!dojo.string.isBlank(self.refreshListenTopics)) {
> > dojo.debug("Listening to " + self.refreshListenTopics);
> > dojo.event.topic.subscribe(self.refreshListenTopics, self,
> > "reloadContents");
> > }
> > if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
> > dojo.debug("Listening to " + self.stopTimerListenTopics);
> > dojo.event.topic.subscribe(self.stopTimerListenTopics, self,
> > "stopTimer");
> > }
> > if(!dojo.string.isBlank(self.startTimerListenTopics)) {
> > dojo.debug("Listening to " + self.startTimerListenTopics);
> > dojo.event.topic.subscribe(self.startTimerListenTopics, self,
> > "startTimer");
> > }
> > };
> >
> > this.reloadContents = function() {
> > //refresh is not visible in ContentPane
> > self.isLoaded = false;
> > self.loadContents();
> > };
> >
> > this.stopTimer = function() {
> > dojo.debug("stopping timer");
> > self.timer.stop();
> > };
> >
> > this.startTimer = function() {
> > dojo.debug("starting timer with frequency " + self.frequency);
> > self.timer.start();
> > };
> > };
> >
> > dojo.inherits(struts.widgets.BindDiv, dojo.widget.html.ContentPane);
> >
> > dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
> >
> >
> >
> > Musachy Barroso wrote:
> >> I was looking at the Div/Panel classes and I think we need to do some
> >> changes, right now Panel extends Div and PanelTag exteds DivTag. The
> >> problem is that the new PanelTag wraps dojo's ContentPane, while
> >> DivTag wraps HTMLBindDiv(from struts), and they are quite different.
> >> I think we should replace HTMLBindDiv with an implementation that
> >> extends dojo's ContentPane and add a timer to it for the auto refresh.
> >>
> >> what do you guys think?
> >>
> >> musachy
> >>
> >> Ian Roughley wrote:
> >>> Yes - this was the direction that we wanted to go in. Try to do as
> >>> much as possible in dojo and provide light wrappers in Struts. When
> >>> we first implemented the tabs, there was no such dojo
> >>> implementation. The one feature that we had that you should check
> >>> that has been implemented in dojo is the pub/sub events - so there
> >>> should be events that each tabs listens to to refresh itself.
> >>>
> >>> I think as Don pointed out, we want to keep a very lightweight
> >>> wrapper in struts and have all the work being done in dojo.
> >>>
> >>> The other big thing that would be a great help is converting the
> >>> code from dojo 0.2 to 0.3 :)
> >>>
> >>> Ian
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Ok, in that case you can delete my attachment to WW-205.
musachy
Don Brown wrote:
> Ok, then put those two under one ticket. You know best :)
>
> Don
>
> Musachy Barroso wrote:
>> That's ok, the only problem is that this one by itself would break
>> anchor and tabbed panel.
>>
>> musachy
>>
>> Don Brown wrote:
>>> I'd prefer separate issues, with attached patches. As for testing,
>>> we started to use Patrick's hostedqa stuff, but we need to use it more.
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> I have everything (I think :)) for the ajax Div Tag, do you want me
>>>> to create a patch for it, or wait and create a big one when I'm
>>>> done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>
>>>> musachy
>>>>
>>>> //Have you guys consider anything to test this ajax stuff?
>>>> (Selenium maybe?)
>>>>
>>>> Musachy Barroso wrote:
>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>> message on their mailing list.
>>>>>
>>>>> musachy
>>>>>
>>>>> Don Brown wrote:
>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>> shouldn't upgrade to it?
>>>>>>
>>>>>> Don
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> Would something like this include all the current functionality
>>>>>>> in BindDiv? (events for stop/start timer, refresh, start after a
>>>>>>> delay, advisor via dojo's "handler" property). This way BindDiv
>>>>>>> will be easier to maintain (dojo's ContentPane + timer) and the
>>>>>>> Tab widget can be deleted (doesn't add anything to this one). By
>>>>>>> the way this doesn't work on AMD 64/firefox/linux due to a
>>>>>>> dojo's bug.
>>>>>>>
>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>
>>>>>>> dojo.require("dojo.widget.*");
>>>>>>> dojo.require("dojo.io.*");
>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>
>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>> var self = this;
>>>>>>>
>>>>>>> this.widgetType = "BindDiv";
>>>>>>>
>>>>>>> this.href = "";
>>>>>>> this.extractContent = false;
>>>>>>> this.parseContent = false;
>>>>>>> this.cacheContent = false;
>>>>>>>
>>>>>>> this.frequency = 0;
>>>>>>> this.delay = 0;
>>>>>>> this.startTimer = false;
>>>>>>> this.timer = null;
>>>>>>>
>>>>>>> //pub/sub events
>>>>>>> this.refreshListenTopics = "";
>>>>>>> this.stopTimerListenTopics = "";
>>>>>>> this.startTimerListenTopics = "";
>>>>>>>
>>>>>>> this.postCreate = function() {
>>>>>>> if(self.frequency > 0) {
>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>
>>>>>>> //start the timer
>>>>>>> if(self.startTimer) {
>>>>>>> //start after delay
>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>> }
>>>>>>> }
>>>>>>>
>>>>>>> //attach listeners
>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>>>>> "reloadContents");
>>>>>>> }
>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>> self, "stopTimer");
>>>>>>> }
>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>> self, "startTimer");
>>>>>>> }
>>>>>>> };
>>>>>>>
>>>>>>> this.reloadContents = function() {
>>>>>>> //refresh is not visible in ContentPane
>>>>>>> self.isLoaded = false;
>>>>>>> self.loadContents();
>>>>>>> };
>>>>>>>
>>>>>>> this.stopTimer = function() {
>>>>>>> dojo.debug("stopping timer");
>>>>>>> self.timer.stop();
>>>>>>> };
>>>>>>>
>>>>>>> this.startTimer = function() {
>>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>>> self.timer.start();
>>>>>>> };
>>>>>>> };
>>>>>>>
>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>
>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>> replace HTMLBindDiv with an implementation that extends dojo's
>>>>>>>> ContentPane and add a timer to it for the auto refresh.
>>>>>>>>
>>>>>>>> what do you guys think?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Ian Roughley wrote:
>>>>>>>>> Yes - this was the direction that we wanted to go in. Try to
>>>>>>>>> do as much as possible in dojo and provide light wrappers in
>>>>>>>>> Struts. When we first implemented the tabs, there was no such
>>>>>>>>> dojo implementation. The one feature that we had that you
>>>>>>>>> should check that has been implemented in dojo is the pub/sub
>>>>>>>>> events - so there should be events that each tabs listens to
>>>>>>>>> to refresh itself.
>>>>>>>>>
>>>>>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>>>>>
>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>
>>>>>>>>> Ian
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
> I'm using defineWidget, and it is cool.
Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
> I will be looking into hostedqa
You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
Cheers.
Musachy Barroso <mu...@gmail.com> wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
given that it is being used in struts already, as per Don's comment
somewhere on this thread.
musachy
tm jee wrote:
> Hi guys,
>
> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>
> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>
> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>
> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>
> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>
> What you guys think? :-)
>
> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> As soon as I get it, I'll update Dojo first and commit your patches for
> the tags separately.
>
> just let me know, when you are done :)
> tia,
> Rainer
>
>
>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>
>> musachy
>>
>> Martin Cooper wrote:
>>
>>> On 10/30/06, Musachy Barroso wrote:
>>>
>>>> Oh, ok. Then just don't apply the patch.
>>>>
>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>> should be
>>> a separate commit.
>>>
>>> By the way, do we have a Jira
>>>
>>>> issue for the dojo upgrade?
>>>>
>>> Not that I can see. Feel free to add one, and one with your patch, if
>>> there
>>> isn't one already.
>>>
>>> --
>>> Martin.
>>>
>>>
>>> musachy
>>>
>>>> Martin Cooper wrote:
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>> Hi Rainer
>>>>>>
>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>
>>>> patch
>>>>
>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>
>>>> new
>>>>
>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>
>>>> 0.4. If
>>>>
>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>
>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>
>>>> commits, so
>>>>
>>>>> that we can track the changes separately, and so that we can revert
>>>>> one or
>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>> prospective committer to determine timing. ;-)
>>>>>
>>>>> --
>>>>> Martin Cooper
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>> Rainer Hermanns wrote:
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>
>>>> during the
>>>>
>>>>>> week.
>>>>>>
>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>
>>>>>> 0.4release,
>>>>>>
>>>>>>> I could apply those as well.
>>>>>>>
>>>>>>> What do you (and others of course) think?
>>>>>>>
>>>>>>> regards,
>>>>>>> Rainer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>
>>>> patches to
>>>>
>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>
>>>>>> Dojo?
>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>
>>>> you
>>>>
>>>>>> want
>>>>>>
>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>
>>>>>> replace
>>>>>>
>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>
>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>
>>>> know
>>>>
>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>
>>>> patch
>>>> :)
>>>>
>>>>>> ).
>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>
>>>>>> break
>>>>>>
>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>
>>>> need
>>>>
>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>
>>>>>> want
>>>>>>
>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>
>>>> when
>>>>
>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>
>>>>>> 0.3)?
>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>
>>>> posted a
>>>>
>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>
>>>> reason
>>>> we
>>>>
>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>
>>>> "handler"
>>>>
>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>
>>>>>> (dojo's
>>>>>>
>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>
>>>> doesn't
>>>>
>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>
>>>> dojo.animation.Timer(self.frequency);
>>>>
>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>
>>>> self.startTimer);
>>>>
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>> self.refreshListenTopics
>>>> );
>>>>
>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>
>>>> {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.stopTimerListenTopics);
>>>>>>
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>
>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.startTimerListenTopics
>>>>>> );
>>>>>>
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>> ,
>>>>
>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>
>>>>>> need to
>>>>>>
>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>
>>>> PanelTag
>>>>
>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>
>>>> wraps
>>>>
>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>
>>>> should
>>>>
>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>
>>>>>> refresh.
>>>>>>
>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>
>>>> in. Try
>>>>
>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>
>>>>>> wrappers
>>>>>>
>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>
>>>>>> was no
>>>>>>
>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>
>>>>>> that
>>>>>>
>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>
>>>> is the
>>>>
>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>
>>>> tabs
>>>>
>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>
>>>> being
>>>>
>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>
>>>>>> converting
>>>>>>
>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
=== message truncated ===
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi guys,
I've go ahead and added a jira issue for struts2 dojo migration, Its at http://issues.apache.org/struts/browse/WW-1484
rgds
Musachy Barroso <mu...@gmail.com> wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
given that it is being used in struts already, as per Don's comment
somewhere on this thread.
musachy
tm jee wrote:
> Hi guys,
>
> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>
> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>
> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>
> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>
> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>
> What you guys think? :-)
>
> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> As soon as I get it, I'll update Dojo first and commit your patches for
> the tags separately.
>
> just let me know, when you are done :)
> tia,
> Rainer
>
>
>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>
>> musachy
>>
>> Martin Cooper wrote:
>>
>>> On 10/30/06, Musachy Barroso wrote:
>>>
>>>> Oh, ok. Then just don't apply the patch.
>>>>
>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>> should be
>>> a separate commit.
>>>
>>> By the way, do we have a Jira
>>>
>>>> issue for the dojo upgrade?
>>>>
>>> Not that I can see. Feel free to add one, and one with your patch, if
>>> there
>>> isn't one already.
>>>
>>> --
>>> Martin.
>>>
>>>
>>> musachy
>>>
>>>> Martin Cooper wrote:
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>> Hi Rainer
>>>>>>
>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>
>>>> patch
>>>>
>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>
>>>> new
>>>>
>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>
>>>> 0.4. If
>>>>
>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>
>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>
>>>> commits, so
>>>>
>>>>> that we can track the changes separately, and so that we can revert
>>>>> one or
>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>> prospective committer to determine timing. ;-)
>>>>>
>>>>> --
>>>>> Martin Cooper
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>> Rainer Hermanns wrote:
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>
>>>> during the
>>>>
>>>>>> week.
>>>>>>
>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>
>>>>>> 0.4release,
>>>>>>
>>>>>>> I could apply those as well.
>>>>>>>
>>>>>>> What do you (and others of course) think?
>>>>>>>
>>>>>>> regards,
>>>>>>> Rainer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>
>>>> patches to
>>>>
>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>
>>>>>> Dojo?
>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>
>>>> you
>>>>
>>>>>> want
>>>>>>
>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>
>>>>>> replace
>>>>>>
>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>
>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>
>>>> know
>>>>
>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>
>>>> patch
>>>> :)
>>>>
>>>>>> ).
>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>
>>>>>> break
>>>>>>
>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>
>>>> need
>>>>
>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>
>>>>>> want
>>>>>>
>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>
>>>> when
>>>>
>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>
>>>>>> 0.3)?
>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>
>>>> posted a
>>>>
>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>
>>>> reason
>>>> we
>>>>
>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>
>>>> "handler"
>>>>
>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>
>>>>>> (dojo's
>>>>>>
>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>
>>>> doesn't
>>>>
>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>
>>>> dojo.animation.Timer(self.frequency);
>>>>
>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>
>>>> self.startTimer);
>>>>
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>> self.refreshListenTopics
>>>> );
>>>>
>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>
>>>> {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.stopTimerListenTopics);
>>>>>>
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>
>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.startTimerListenTopics
>>>>>> );
>>>>>>
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>> ,
>>>>
>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>
>>>>>> need to
>>>>>>
>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>
>>>> PanelTag
>>>>
>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>
>>>> wraps
>>>>
>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>
>>>> should
>>>>
>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>
>>>>>> refresh.
>>>>>>
>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>
>>>> in. Try
>>>>
>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>
>>>>>> wrappers
>>>>>>
>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>
>>>>>> was no
>>>>>>
>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>
>>>>>> that
>>>>>>
>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>
>>>> is the
>>>>
>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>
>>>> tabs
>>>>
>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>
>>>> being
>>>>
>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>
>>>>>> converting
>>>>>>
>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
=== message truncated ===
---------------------------------
All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine
Re: ajax tags
Posted by Ted Husted <hu...@apache.org>.
On 11/6/06, Musachy Barroso <mb...@wfscorp.com> wrote:
> Does this list accept attachments? It got rejected as spam :)
No, you would need to attach it to the ticket.
-Ted.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
As long as the form had a unique ID, yes. For now I just made the submit
button behave like the old one by default, but I like this approach better.
musachy
Ian Roughley wrote:
> It's been a while since I've been in dojo code. Will this approach
> accommodate multiple forms with multiple submits per form?
>
> /Ian
>
>
>
> Musachy Barroso wrote:
>> I wish it would work, I could get rid of my cell phone :).
>>
>> What I was trying to say is, that I think it would be better(less
>> code, easier to use) if the submit were a regular submit, with no
>> javascript attached, and no ajax theme, then we would use FormBind if
>> the form is using the ajax theme, like
>>
>> <s:form .... theme="ajax" id="bla">
>> <s:submit/>
>> </s:form>
>>
>> would be translated into something like:
>>
>> <form ... id="bla">
>> <input type="submit"/>
>> </form>
>>
>> <script ...> new dojo.io.FormBind({formNode: dojo.byId("bla")});
>> </script>
>>
>> What do you think?
>>
>> musachy
>>
>> Ian Roughley wrote:
>>> The submit works hand-in-hand with the form in the ajax theme.
>>> After all, you need a button to press to remotely submit a form... I
>>> tried mental telepathy a couple of times but it just didn't work ;)
>>>
>>> /Ian
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ian Roughley <ia...@fdar.com>.
It's been a while since I've been in dojo code. Will this approach
accommodate multiple forms with multiple submits per form?
/Ian
Musachy Barroso wrote:
> I wish it would work, I could get rid of my cell phone :).
>
> What I was trying to say is, that I think it would be better(less
> code, easier to use) if the submit were a regular submit, with no
> javascript attached, and no ajax theme, then we would use FormBind if
> the form is using the ajax theme, like
>
> <s:form .... theme="ajax" id="bla">
> <s:submit/>
> </s:form>
>
> would be translated into something like:
>
> <form ... id="bla">
> <input type="submit"/>
> </form>
>
> <script ...> new dojo.io.FormBind({formNode: dojo.byId("bla")});
> </script>
>
> What do you think?
>
> musachy
>
> Ian Roughley wrote:
>> The submit works hand-in-hand with the form in the ajax theme. After
>> all, you need a button to press to remotely submit a form... I tried
>> mental telepathy a couple of times but it just didn't work ;)
>>
>> /Ian
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I wish it would work, I could get rid of my cell phone :).
What I was trying to say is, that I think it would be better(less code,
easier to use) if the submit were a regular submit, with no javascript
attached, and no ajax theme, then we would use FormBind if the form is
using the ajax theme, like
<s:form .... theme="ajax" id="bla">
<s:submit/>
</s:form>
would be translated into something like:
<form ... id="bla">
<input type="submit"/>
</form>
<script ...>
new dojo.io.FormBind({formNode: dojo.byId("bla")});
</script>
What do you think?
musachy
Ian Roughley wrote:
> The submit works hand-in-hand with the form in the ajax theme. After
> all, you need a button to press to remotely submit a form... I tried
> mental telepathy a couple of times but it just didn't work ;)
>
> /Ian
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ian Roughley <ia...@fdar.com>.
The submit works hand-in-hand with the form in the ajax theme. After
all, you need a button to press to remotely submit a form... I tried
mental telepathy a couple of times but it just didn't work ;)
/Ian
--
>From Down & Around, Inc.
Innovative IT Solutions
Software Architecture * Design * Development
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
web: www.fdar.com
email ian@fdar.com
phone: 617.821.5430
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Musachy Barroso wrote:
> I attached an small patch to ww-1484 which will restore the "action"
> attribute(it was missing only on the tld), fix the div problem and add
> the 2 missing jsps. I'm still trying to figure out if we really need
> an ajax submit at all, given that we have an ajax form, any ideas?
>
> musachy
>
> // by the way what does the /s mean? :)
> Ted Husted wrote:
>> /s/not broken/now broken
>>
>> On 11/15/06, Ted Husted <hu...@apache.org> wrote:
>>> Please immediately restore the action attribute, since I expect 80-90%
>>> of all Struts 2 applications are not broken against the nightly build.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy,
thanks again, I applied your latest patch some minutes ago.
The AJAX samples are working again and are now completely based on Dojo 0.4.
Thanks for all your efforts and help :)
-Rainer
> I attached an small patch to ww-1484 which will restore the "action"
> attribute(it was missing only on the tld), fix the div problem and add
> the 2 missing jsps. I'm still trying to figure out if we really need an
> ajax submit at all, given that we have an ajax form, any ideas?
>
> musachy
>
> // by the way what does the /s mean? :)
> Ted Husted wrote:
>> /s/not broken/now broken
>>
>> On 11/15/06, Ted Husted <hu...@apache.org> wrote:
>>> Please immediately restore the action attribute, since I expect 80-90%
>>> of all Struts 2 applications are not broken against the nightly build.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
> I attached an small patch to ww-1484 which will restore the "action"
> attribute(it was missing only on the tld), fix the div problem and add
> the 2 missing jsps. I'm still trying to figure out if we really need an
> ajax submit at all, given that we have an ajax form, any ideas?
>
Thanks, I'll apply the patch as soon as I come back home today...
> // by the way what does the /s mean? :)
/s: replace occurance of pattern
-Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I attached an small patch to ww-1484 which will restore the "action"
attribute(it was missing only on the tld), fix the div problem and add
the 2 missing jsps. I'm still trying to figure out if we really need an
ajax submit at all, given that we have an ajax form, any ideas?
musachy
// by the way what does the /s mean? :)
Ted Husted wrote:
> /s/not broken/now broken
>
> On 11/15/06, Ted Husted <hu...@apache.org> wrote:
>> Please immediately restore the action attribute, since I expect 80-90%
>> of all Struts 2 applications are not broken against the nightly build.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ted Husted <hu...@apache.org>.
/s/not broken/now broken
On 11/15/06, Ted Husted <hu...@apache.org> wrote:
> Please immediately restore the action attribute, since I expect 80-90%
> of all Struts 2 applications are not broken against the nightly build.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I forgot to mention that the ajax behavior for the submit is not working
as before, if "formId" is specified for the "submit" then everything
works as expected. I'm playing with the idea that I mentioned before to
Ian.
musachy
Rainer Hermanns wrote:
> Ted,
> just commited back the action attribute. It was missing in the tld file
> only, as Musachy pointed out. All submit tags should now work again as
> expected.
>
> Could you please verify this with your apps?
>
> thanks,
> Rainer
>
>
>> The submit tag is used outside the scope of the Ajax theme.
>>
>> The submit tag *MUST* have an action attribute to solve the use case
>> of having one form handle various operations -- especially Cancel.
>>
>> Please immediately restore the action attribute, since I expect 80-90%
>> of all Struts 2 applications are not broken against the nightly build.
>>
>> -Ted.
>>
>>
>> On 11/14/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>
>>> Rainer
>>>
>>> I fixed the div problem. and the missing links (it seems I forgot to
>>> send you a couple of files). My problem is with the Submit tag, the
>>> submit tag used to take an "action" and a "method", but the anchor, and
>>> the div tag used to take an "href", I'm trying to make them have the
>>> same attributes for the ajax stuff (maybe this is the problem on the
>>> first place), using just an "href". If we addthe "action" and "method"
>>> attributes in the submit tag, should we add them in the others also?
>>>
>>> musachy
>>>
>>> Rainer Hermanns wrote:
>>>
>>>> Musachy,
>>>>
>>>> Dojo upgrade and patches/fixes are committed.
>>>> Could you please check the showcase ajax samples for the mentioned
>>>>
>>> issues
>>>
>>>> with remotediv stuff.
>>>>
>>>> Feel free to contact me, if you need more input.
>>>>
>>>> tia,
>>>> Rainer
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Rainer,
I posted the last(hopefully) patch, this fixes the javadoc and makes the
submit button behave like before when used on the ajax theme. Is there
any documentation/tutorial for these tags that I should update?
musachy
Rainer Hermanns wrote:
> Ted,
> just commited back the action attribute. It was missing in the tld file
> only, as Musachy pointed out. All submit tags should now work again as
> expected.
>
> Could you please verify this with your apps?
>
> thanks,
> Rainer
>
>
>> The submit tag is used outside the scope of the Ajax theme.
>>
>> The submit tag *MUST* have an action attribute to solve the use case
>> of having one form handle various operations -- especially Cancel.
>>
>> Please immediately restore the action attribute, since I expect 80-90%
>> of all Struts 2 applications are not broken against the nightly build.
>>
>> -Ted.
>>
>>
>> On 11/14/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>
>>> Rainer
>>>
>>> I fixed the div problem. and the missing links (it seems I forgot to
>>> send you a couple of files). My problem is with the Submit tag, the
>>> submit tag used to take an "action" and a "method", but the anchor, and
>>> the div tag used to take an "href", I'm trying to make them have the
>>> same attributes for the ajax stuff (maybe this is the problem on the
>>> first place), using just an "href". If we addthe "action" and "method"
>>> attributes in the submit tag, should we add them in the others also?
>>>
>>> musachy
>>>
>>> Rainer Hermanns wrote:
>>>
>>>> Musachy,
>>>>
>>>> Dojo upgrade and patches/fixes are committed.
>>>> Could you please check the showcase ajax samples for the mentioned
>>>>
>>> issues
>>>
>>>> with remotediv stuff.
>>>>
>>>> Feel free to contact me, if you need more input.
>>>>
>>>> tia,
>>>> Rainer
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Ted,
just commited back the action attribute. It was missing in the tld file
only, as Musachy pointed out. All submit tags should now work again as
expected.
Could you please verify this with your apps?
thanks,
Rainer
> The submit tag is used outside the scope of the Ajax theme.
>
> The submit tag *MUST* have an action attribute to solve the use case
> of having one form handle various operations -- especially Cancel.
>
> Please immediately restore the action attribute, since I expect 80-90%
> of all Struts 2 applications are not broken against the nightly build.
>
> -Ted.
>
>
> On 11/14/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>> Rainer
>>
>> I fixed the div problem. and the missing links (it seems I forgot to
>> send you a couple of files). My problem is with the Submit tag, the
>> submit tag used to take an "action" and a "method", but the anchor, and
>> the div tag used to take an "href", I'm trying to make them have the
>> same attributes for the ajax stuff (maybe this is the problem on the
>> first place), using just an "href". If we addthe "action" and "method"
>> attributes in the submit tag, should we add them in the others also?
>>
>> musachy
>>
>> Rainer Hermanns wrote:
>> > Musachy,
>> >
>> > Dojo upgrade and patches/fixes are committed.
>> > Could you please check the showcase ajax samples for the mentioned
>> issues
>> > with remotediv stuff.
>> >
>> > Feel free to contact me, if you need more input.
>> >
>> > tia,
>> > Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ted Husted <hu...@apache.org>.
The submit tag is used outside the scope of the Ajax theme.
The submit tag *MUST* have an action attribute to solve the use case
of having one form handle various operations -- especially Cancel.
Please immediately restore the action attribute, since I expect 80-90%
of all Struts 2 applications are not broken against the nightly build.
-Ted.
On 11/14/06, Musachy Barroso <mb...@wfscorp.com> wrote:
> Rainer
>
> I fixed the div problem. and the missing links (it seems I forgot to
> send you a couple of files). My problem is with the Submit tag, the
> submit tag used to take an "action" and a "method", but the anchor, and
> the div tag used to take an "href", I'm trying to make them have the
> same attributes for the ajax stuff (maybe this is the problem on the
> first place), using just an "href". If we addthe "action" and "method"
> attributes in the submit tag, should we add them in the others also?
>
> musachy
>
> Rainer Hermanns wrote:
> > Musachy,
> >
> > Dojo upgrade and patches/fixes are committed.
> > Could you please check the showcase ajax samples for the mentioned issues
> > with remotediv stuff.
> >
> > Feel free to contact me, if you need more input.
> >
> > tia,
> > Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Rainer
I fixed the div problem. and the missing links (it seems I forgot to
send you a couple of files). My problem is with the Submit tag, the
submit tag used to take an "action" and a "method", but the anchor, and
the div tag used to take an "href", I'm trying to make them have the
same attributes for the ajax stuff (maybe this is the problem on the
first place), using just an "href". If we addthe "action" and "method"
attributes in the submit tag, should we add them in the others also?
musachy
Rainer Hermanns wrote:
> Musachy,
>
> Dojo upgrade and patches/fixes are committed.
> Could you please check the showcase ajax samples for the mentioned issues
> with remotediv stuff.
>
> Feel free to contact me, if you need more input.
>
> tia,
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy,
Dojo upgrade and patches/fixes are committed.
Could you please check the showcase ajax samples for the mentioned issues
with remotediv stuff.
Feel free to contact me, if you need more input.
tia,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Thanks,
I am committing the Dojo 0.4 upgrade now and your changes as well.
So you can check against the most current sources.
Still takes some minutes :)
Rainer
> Don't worry about the remote Div and the submit tag, I will check them out
> and fix them. About the broken links, are they in the pages that I
> changed?
> I'm not sure which ones you are talking about. I have to update the
> javadoc
> comments also.
>
> musachy
>
> On 11/13/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>
>> Musachy, others,
>>
>> I applied all of your patches and fixed some minor things I found
>> myself.
>> However, there seems to be still a problem with the remotediv and
>> remoteform samples in showcase.
>> It seems to me, that the initial and refresh loading is not working as
>> expected.
>>
>> I am not yet sure where to look for the error exactly, still hunting for
>> it... If you got an idea or this is still an open issue, please let me
>> know :)
>>
>> Another problem seems to appear with the changed submit tag logic.
>> IIRC you removed the action attribute and replaced it with an href
>> attribute. But the reworked href attribute does not take care of the
>> action:actionName notation.
>>
>> Another issue is open with the showcase samples. A lot of pages are not
>> working or linked files are missing. Also, the navigation within
>> showcase
>> seems to be broken.
>>
>> Tomorrow, after daytime work, I'll try to tackle most of these issues.
>>
>> later,
>> Rainer
>>
>> > Let me know if you find any problem, I don't have much to do this
>> weekend
>> > :)
>> >
>> > musachy
>> >
>> > Rainer Hermanns wrote:
>> >> Musachy send me the required files via email.
>> >>
>> >> I am currently in progress of incorporating the patches into the
>> locally
>> >> updated repo. I'll work further on these over the weekend, so that
>> dojo
>> >> 0.4 with (hopefully) working ajax tags should be in place until
>> monday.
>> >>
>> >> regards,
>> >> Rainer
>> >>
>> >>
>> >>> Does this list accept attachments? It got rejected as spam :)
>> >>>
>> >>> Rainer Hermanns wrote:
>> >>>
>> >>>> No idea, just zip together the newly created dir and I'll add the
>> >>>> files
>> >>>> individually :)
>> >>>>
>> >>>> tia,
>> >>>> Rainer
>> >>>>
>> >>>>
>> >>>>
>> >>>>> You are right, the patch doesn't include the new files inside the
>> >>>>> added
>> >>>>> folder, I can't figure out how to make svn create a patch with the
>> >>>>> added
>> >>>>> folder, it keeps complaining:
>> >>>>>
>> >>>>> "Files inside the added folder won't be included ...."
>> >>>>>
>> >>>>> Am I doing something wrong or this is a svn/patch limitation?
>> >>>>>
>> >>>>> musachy
>> >>>>>
>> >>>>> Rainer Hermanns wrote:
>> >>>>>
>> >>>>>
>> >>>>>> Ah, okay... So it looks like the complete folder with all moved
>> >>>>>> widget
>> >>>>>> files
>> >>>>>> is missing. The patch does not create the folder, nor does it
>> create
>> >>>>>> the
>> >>>>>> "new/moved" template files.
>> >>>>>>
>> >>>>>> thanks for your help,
>> >>>>>> Rainer
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>> I will take a look tomorrow (not on my box right now), but I do
>> >>>>>>> remember
>> >>>>>>> that I changed the widgets to struts.widget from struts.widgets,
>> >>>>>>> for
>> >>>>>>> 2
>> >>>>>>> reasons, 1. Keep consistency with Dojo (not that we had to
>> anyway)
>> >>>>>>> and
>> >>>>>>> 2.
>> >>>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir
>> "widget"
>> >>>>>>> which
>> >>>>>>> requires less configuration. I will let you know tomorrow.
>> >>>>>>>
>> >>>>>>> thanks
>> >>>>>>>
>> >>>>>>> musachy
>> >>>>>>>
>> >>>>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>> Musachy,
>> >>>>>>>>
>> >>>>>>>> after applying your patch, all custom widget files do no longer
>> >>>>>>>> have
>> >>>>>>>> content.
>> >>>>>>>> Is it correct, that all files under
>> core/src/main/resources/org/
>> >>>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>> >>>>>>>>
>> >>>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>> >>>>>>>> dojoRequire.js should be changed like this (remove all lines
>> with
>> >>>>>>>> '-'
>> >>>>>>>> ):
>> >>>>>>>>
>> >>>>>>>> dojo.require("dojo.io.BrowserIO");
>> >>>>>>>> dojo.require("dojo.event.topic");
>> >>>>>>>>
>> >>>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>> >>>>>>>> dojo.require('dojo.widget.*');
>> >>>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>> >>>>>>>>
>> >>>>>>>> - dojo.require("struts.widget.Bind");
>> >>>>>>>> - dojo.require("struts.widget.BindDiv");
>> >>>>>>>> - dojo.require("struts.widget.BindAnchor");
>> >>>>>>>> dojo.require("dojo.widget.Editor");
>> >>>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the
>> >>>>>>>> Venkman
>> >>>>>>>> debugger to work with the includes
>> >>>>>>>>
>> >>>>>>>> It looks to me, that either the patch is not complete, or that
>> I
>> >>>>>>>> am
>> >>>>>>>> missing the part replacing the above widget requirements.
>> >>>>>>>>
>> >>>>>>>> Could you please have a look at this?
>> >>>>>>>>
>> >>>>>>>> Thanks,
>> >>>>>>>> Rainer
>> >>>>>>>>
>> >>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>> --
>> >>>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> ---------------------------------------------------------------------
>> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>
>> ---------------------------------------------------------------------
>> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>> ---------------------------------------------------------------------
>> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>
>> >>>>
>> >>>>
>> >>>>
>> >>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>
>> >>>
>> >>>
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >>
>> >>
>> >>
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > For additional commands, e-mail: dev-help@struts.apache.org
>> >
>> >
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
Don't worry about the remote Div and the submit tag, I will check them out
and fix them. About the broken links, are they in the pages that I changed?
I'm not sure which ones you are talking about. I have to update the javadoc
comments also.
musachy
On 11/13/06, Rainer Hermanns <he...@aixcept.de> wrote:
>
> Musachy, others,
>
> I applied all of your patches and fixed some minor things I found myself.
> However, there seems to be still a problem with the remotediv and
> remoteform samples in showcase.
> It seems to me, that the initial and refresh loading is not working as
> expected.
>
> I am not yet sure where to look for the error exactly, still hunting for
> it... If you got an idea or this is still an open issue, please let me
> know :)
>
> Another problem seems to appear with the changed submit tag logic.
> IIRC you removed the action attribute and replaced it with an href
> attribute. But the reworked href attribute does not take care of the
> action:actionName notation.
>
> Another issue is open with the showcase samples. A lot of pages are not
> working or linked files are missing. Also, the navigation within showcase
> seems to be broken.
>
> Tomorrow, after daytime work, I'll try to tackle most of these issues.
>
> later,
> Rainer
>
> > Let me know if you find any problem, I don't have much to do this
> weekend
> > :)
> >
> > musachy
> >
> > Rainer Hermanns wrote:
> >> Musachy send me the required files via email.
> >>
> >> I am currently in progress of incorporating the patches into the
> locally
> >> updated repo. I'll work further on these over the weekend, so that dojo
> >> 0.4 with (hopefully) working ajax tags should be in place until monday.
> >>
> >> regards,
> >> Rainer
> >>
> >>
> >>> Does this list accept attachments? It got rejected as spam :)
> >>>
> >>> Rainer Hermanns wrote:
> >>>
> >>>> No idea, just zip together the newly created dir and I'll add the
> >>>> files
> >>>> individually :)
> >>>>
> >>>> tia,
> >>>> Rainer
> >>>>
> >>>>
> >>>>
> >>>>> You are right, the patch doesn't include the new files inside the
> >>>>> added
> >>>>> folder, I can't figure out how to make svn create a patch with the
> >>>>> added
> >>>>> folder, it keeps complaining:
> >>>>>
> >>>>> "Files inside the added folder won't be included ...."
> >>>>>
> >>>>> Am I doing something wrong or this is a svn/patch limitation?
> >>>>>
> >>>>> musachy
> >>>>>
> >>>>> Rainer Hermanns wrote:
> >>>>>
> >>>>>
> >>>>>> Ah, okay... So it looks like the complete folder with all moved
> >>>>>> widget
> >>>>>> files
> >>>>>> is missing. The patch does not create the folder, nor does it
> create
> >>>>>> the
> >>>>>> "new/moved" template files.
> >>>>>>
> >>>>>> thanks for your help,
> >>>>>> Rainer
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> I will take a look tomorrow (not on my box right now), but I do
> >>>>>>> remember
> >>>>>>> that I changed the widgets to struts.widget from struts.widgets,
> >>>>>>> for
> >>>>>>> 2
> >>>>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway)
> >>>>>>> and
> >>>>>>> 2.
> >>>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
> >>>>>>> which
> >>>>>>> requires less configuration. I will let you know tomorrow.
> >>>>>>>
> >>>>>>> thanks
> >>>>>>>
> >>>>>>> musachy
> >>>>>>>
> >>>>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Musachy,
> >>>>>>>>
> >>>>>>>> after applying your patch, all custom widget files do no longer
> >>>>>>>> have
> >>>>>>>> content.
> >>>>>>>> Is it correct, that all files under core/src/main/resources/org/
> >>>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
> >>>>>>>>
> >>>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
> >>>>>>>> dojoRequire.js should be changed like this (remove all lines with
> >>>>>>>> '-'
> >>>>>>>> ):
> >>>>>>>>
> >>>>>>>> dojo.require("dojo.io.BrowserIO");
> >>>>>>>> dojo.require("dojo.event.topic");
> >>>>>>>>
> >>>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
> >>>>>>>> dojo.require('dojo.widget.*');
> >>>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
> >>>>>>>>
> >>>>>>>> - dojo.require("struts.widget.Bind");
> >>>>>>>> - dojo.require("struts.widget.BindDiv");
> >>>>>>>> - dojo.require("struts.widget.BindAnchor");
> >>>>>>>> dojo.require("dojo.widget.Editor");
> >>>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the
> >>>>>>>> Venkman
> >>>>>>>> debugger to work with the includes
> >>>>>>>>
> >>>>>>>> It looks to me, that either the patch is not complete, or that I
> >>>>>>>> am
> >>>>>>>> missing the part replacing the above widget requirements.
> >>>>>>>>
> >>>>>>>> Could you please have a look at this?
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>> Rainer
> >>>>>>>>
> >>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> --
> >>>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>
> >>>
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy, others,
I applied all of your patches and fixed some minor things I found myself.
However, there seems to be still a problem with the remotediv and
remoteform samples in showcase.
It seems to me, that the initial and refresh loading is not working as
expected.
I am not yet sure where to look for the error exactly, still hunting for
it... If you got an idea or this is still an open issue, please let me
know :)
Another problem seems to appear with the changed submit tag logic.
IIRC you removed the action attribute and replaced it with an href
attribute. But the reworked href attribute does not take care of the
action:actionName notation.
Another issue is open with the showcase samples. A lot of pages are not
working or linked files are missing. Also, the navigation within showcase
seems to be broken.
Tomorrow, after daytime work, I'll try to tackle most of these issues.
later,
Rainer
> Let me know if you find any problem, I don't have much to do this weekend
> :)
>
> musachy
>
> Rainer Hermanns wrote:
>> Musachy send me the required files via email.
>>
>> I am currently in progress of incorporating the patches into the locally
>> updated repo. I'll work further on these over the weekend, so that dojo
>> 0.4 with (hopefully) working ajax tags should be in place until monday.
>>
>> regards,
>> Rainer
>>
>>
>>> Does this list accept attachments? It got rejected as spam :)
>>>
>>> Rainer Hermanns wrote:
>>>
>>>> No idea, just zip together the newly created dir and I'll add the
>>>> files
>>>> individually :)
>>>>
>>>> tia,
>>>> Rainer
>>>>
>>>>
>>>>
>>>>> You are right, the patch doesn't include the new files inside the
>>>>> added
>>>>> folder, I can't figure out how to make svn create a patch with the
>>>>> added
>>>>> folder, it keeps complaining:
>>>>>
>>>>> "Files inside the added folder won't be included ...."
>>>>>
>>>>> Am I doing something wrong or this is a svn/patch limitation?
>>>>>
>>>>> musachy
>>>>>
>>>>> Rainer Hermanns wrote:
>>>>>
>>>>>
>>>>>> Ah, okay... So it looks like the complete folder with all moved
>>>>>> widget
>>>>>> files
>>>>>> is missing. The patch does not create the folder, nor does it create
>>>>>> the
>>>>>> "new/moved" template files.
>>>>>>
>>>>>> thanks for your help,
>>>>>> Rainer
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> I will take a look tomorrow (not on my box right now), but I do
>>>>>>> remember
>>>>>>> that I changed the widgets to struts.widget from struts.widgets,
>>>>>>> for
>>>>>>> 2
>>>>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway)
>>>>>>> and
>>>>>>> 2.
>>>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
>>>>>>> which
>>>>>>> requires less configuration. I will let you know tomorrow.
>>>>>>>
>>>>>>> thanks
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Musachy,
>>>>>>>>
>>>>>>>> after applying your patch, all custom widget files do no longer
>>>>>>>> have
>>>>>>>> content.
>>>>>>>> Is it correct, that all files under core/src/main/resources/org/
>>>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>>>>>>
>>>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>>>>>>> dojoRequire.js should be changed like this (remove all lines with
>>>>>>>> '-'
>>>>>>>> ):
>>>>>>>>
>>>>>>>> dojo.require("dojo.io.BrowserIO");
>>>>>>>> dojo.require("dojo.event.topic");
>>>>>>>>
>>>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>>>>>>> dojo.require('dojo.widget.*');
>>>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>>>>>>
>>>>>>>> - dojo.require("struts.widget.Bind");
>>>>>>>> - dojo.require("struts.widget.BindDiv");
>>>>>>>> - dojo.require("struts.widget.BindAnchor");
>>>>>>>> dojo.require("dojo.widget.Editor");
>>>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the
>>>>>>>> Venkman
>>>>>>>> debugger to work with the includes
>>>>>>>>
>>>>>>>> It looks to me, that either the patch is not complete, or that I
>>>>>>>> am
>>>>>>>> missing the part replacing the above widget requirements.
>>>>>>>>
>>>>>>>> Could you please have a look at this?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Rainer
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> --
>>>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Let me know if you find any problem, I don't have much to do this weekend :)
musachy
Rainer Hermanns wrote:
> Musachy send me the required files via email.
>
> I am currently in progress of incorporating the patches into the locally
> updated repo. I'll work further on these over the weekend, so that dojo
> 0.4 with (hopefully) working ajax tags should be in place until monday.
>
> regards,
> Rainer
>
>
>> Does this list accept attachments? It got rejected as spam :)
>>
>> Rainer Hermanns wrote:
>>
>>> No idea, just zip together the newly created dir and I'll add the files
>>> individually :)
>>>
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>> You are right, the patch doesn't include the new files inside the added
>>>> folder, I can't figure out how to make svn create a patch with the
>>>> added
>>>> folder, it keeps complaining:
>>>>
>>>> "Files inside the added folder won't be included ...."
>>>>
>>>> Am I doing something wrong or this is a svn/patch limitation?
>>>>
>>>> musachy
>>>>
>>>> Rainer Hermanns wrote:
>>>>
>>>>
>>>>> Ah, okay... So it looks like the complete folder with all moved widget
>>>>> files
>>>>> is missing. The patch does not create the folder, nor does it create
>>>>> the
>>>>> "new/moved" template files.
>>>>>
>>>>> thanks for your help,
>>>>> Rainer
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> I will take a look tomorrow (not on my box right now), but I do
>>>>>> remember
>>>>>> that I changed the widgets to struts.widget from struts.widgets, for
>>>>>> 2
>>>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway)
>>>>>> and
>>>>>> 2.
>>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
>>>>>> which
>>>>>> requires less configuration. I will let you know tomorrow.
>>>>>>
>>>>>> thanks
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> after applying your patch, all custom widget files do no longer have
>>>>>>> content.
>>>>>>> Is it correct, that all files under core/src/main/resources/org/
>>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>>>>>
>>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>>>>>> dojoRequire.js should be changed like this (remove all lines with
>>>>>>> '-'
>>>>>>> ):
>>>>>>>
>>>>>>> dojo.require("dojo.io.BrowserIO");
>>>>>>> dojo.require("dojo.event.topic");
>>>>>>>
>>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>>>>>> dojo.require('dojo.widget.*');
>>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>>>>>
>>>>>>> - dojo.require("struts.widget.Bind");
>>>>>>> - dojo.require("struts.widget.BindDiv");
>>>>>>> - dojo.require("struts.widget.BindAnchor");
>>>>>>> dojo.require("dojo.widget.Editor");
>>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>>>>>>> debugger to work with the includes
>>>>>>>
>>>>>>> It looks to me, that either the patch is not complete, or that I am
>>>>>>> missing the part replacing the above widget requirements.
>>>>>>>
>>>>>>> Could you please have a look at this?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Rainer
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> --
>>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy send me the required files via email.
I am currently in progress of incorporating the patches into the locally
updated repo. I'll work further on these over the weekend, so that dojo
0.4 with (hopefully) working ajax tags should be in place until monday.
regards,
Rainer
> Does this list accept attachments? It got rejected as spam :)
>
> Rainer Hermanns wrote:
>> No idea, just zip together the newly created dir and I'll add the files
>> individually :)
>>
>> tia,
>> Rainer
>>
>>
>>> You are right, the patch doesn't include the new files inside the added
>>> folder, I can't figure out how to make svn create a patch with the
>>> added
>>> folder, it keeps complaining:
>>>
>>> "Files inside the added folder won't be included ...."
>>>
>>> Am I doing something wrong or this is a svn/patch limitation?
>>>
>>> musachy
>>>
>>> Rainer Hermanns wrote:
>>>
>>>> Ah, okay... So it looks like the complete folder with all moved widget
>>>> files
>>>> is missing. The patch does not create the folder, nor does it create
>>>> the
>>>> "new/moved" template files.
>>>>
>>>> thanks for your help,
>>>> Rainer
>>>>
>>>>
>>>>
>>>>> I will take a look tomorrow (not on my box right now), but I do
>>>>> remember
>>>>> that I changed the widgets to struts.widget from struts.widgets, for
>>>>> 2
>>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway)
>>>>> and
>>>>> 2.
>>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
>>>>> which
>>>>> requires less configuration. I will let you know tomorrow.
>>>>>
>>>>> thanks
>>>>>
>>>>> musachy
>>>>>
>>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>>>>
>>>>>
>>>>>> Musachy,
>>>>>>
>>>>>> after applying your patch, all custom widget files do no longer have
>>>>>> content.
>>>>>> Is it correct, that all files under core/src/main/resources/org/
>>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>>>>
>>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>>>>> dojoRequire.js should be changed like this (remove all lines with
>>>>>> '-'
>>>>>> ):
>>>>>>
>>>>>> dojo.require("dojo.io.BrowserIO");
>>>>>> dojo.require("dojo.event.topic");
>>>>>>
>>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>>>>> dojo.require('dojo.widget.*');
>>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>>>>
>>>>>> - dojo.require("struts.widget.Bind");
>>>>>> - dojo.require("struts.widget.BindDiv");
>>>>>> - dojo.require("struts.widget.BindAnchor");
>>>>>> dojo.require("dojo.widget.Editor");
>>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>>>>>> debugger to work with the includes
>>>>>>
>>>>>> It looks to me, that either the patch is not complete, or that I am
>>>>>> missing the part replacing the above widget requirements.
>>>>>>
>>>>>> Could you please have a look at this?
>>>>>>
>>>>>> Thanks,
>>>>>> Rainer
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Konstantin Priblouda <kp...@yahoo.com>.
--- Musachy Barroso <mb...@wfscorp.com> wrote:
> Does this list accept attachments? It got rejected
> as spam :)
>
file jira issue and attach it there.
regards,
----[ Konstantin Pribluda http://www.pribluda.de ]----------------
Still using XDoclet 1.x? XDoclet 2 is released and of production quality.
check it out: http://xdoclet.codehaus.org
____________________________________________________________________________________
Sponsored Link
Get a free Motorola Razr! Today Only!
Choose Cingular, Sprint, Verizon, Alltel, or T-Mobile.
http://www.letstalk.com/inlink.htm?to=592913
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Does this list accept attachments? It got rejected as spam :)
Rainer Hermanns wrote:
> No idea, just zip together the newly created dir and I'll add the files
> individually :)
>
> tia,
> Rainer
>
>
>> You are right, the patch doesn't include the new files inside the added
>> folder, I can't figure out how to make svn create a patch with the added
>> folder, it keeps complaining:
>>
>> "Files inside the added folder won't be included ...."
>>
>> Am I doing something wrong or this is a svn/patch limitation?
>>
>> musachy
>>
>> Rainer Hermanns wrote:
>>
>>> Ah, okay... So it looks like the complete folder with all moved widget
>>> files
>>> is missing. The patch does not create the folder, nor does it create the
>>> "new/moved" template files.
>>>
>>> thanks for your help,
>>> Rainer
>>>
>>>
>>>
>>>> I will take a look tomorrow (not on my box right now), but I do
>>>> remember
>>>> that I changed the widgets to struts.widget from struts.widgets, for 2
>>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway) and
>>>> 2.
>>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
>>>> which
>>>> requires less configuration. I will let you know tomorrow.
>>>>
>>>> thanks
>>>>
>>>> musachy
>>>>
>>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>>>
>>>>
>>>>> Musachy,
>>>>>
>>>>> after applying your patch, all custom widget files do no longer have
>>>>> content.
>>>>> Is it correct, that all files under core/src/main/resources/org/
>>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>>>
>>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>>>> dojoRequire.js should be changed like this (remove all lines with '-'
>>>>> ):
>>>>>
>>>>> dojo.require("dojo.io.BrowserIO");
>>>>> dojo.require("dojo.event.topic");
>>>>>
>>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>>>> dojo.require('dojo.widget.*');
>>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>>>
>>>>> - dojo.require("struts.widget.Bind");
>>>>> - dojo.require("struts.widget.BindDiv");
>>>>> - dojo.require("struts.widget.BindAnchor");
>>>>> dojo.require("dojo.widget.Editor");
>>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>>>>> debugger to work with the includes
>>>>>
>>>>> It looks to me, that either the patch is not complete, or that I am
>>>>> missing the part replacing the above widget requirements.
>>>>>
>>>>> Could you please have a look at this?
>>>>>
>>>>> Thanks,
>>>>> Rainer
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>> --
>>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
No idea, just zip together the newly created dir and I'll add the files
individually :)
tia,
Rainer
> You are right, the patch doesn't include the new files inside the added
> folder, I can't figure out how to make svn create a patch with the added
> folder, it keeps complaining:
>
> "Files inside the added folder won't be included ...."
>
> Am I doing something wrong or this is a svn/patch limitation?
>
> musachy
>
> Rainer Hermanns wrote:
>> Ah, okay... So it looks like the complete folder with all moved widget
>> files
>> is missing. The patch does not create the folder, nor does it create the
>> "new/moved" template files.
>>
>> thanks for your help,
>> Rainer
>>
>>
>>> I will take a look tomorrow (not on my box right now), but I do
>>> remember
>>> that I changed the widgets to struts.widget from struts.widgets, for 2
>>> reasons, 1. Keep consistency with Dojo (not that we had to anyway) and
>>> 2.
>>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget"
>>> which
>>> requires less configuration. I will let you know tomorrow.
>>>
>>> thanks
>>>
>>> musachy
>>>
>>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>>
>>>> Musachy,
>>>>
>>>> after applying your patch, all custom widget files do no longer have
>>>> content.
>>>> Is it correct, that all files under core/src/main/resources/org/
>>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>>
>>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>>> dojoRequire.js should be changed like this (remove all lines with '-'
>>>> ):
>>>>
>>>> dojo.require("dojo.io.BrowserIO");
>>>> dojo.require("dojo.event.topic");
>>>>
>>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>>> dojo.require('dojo.widget.*');
>>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>>
>>>> - dojo.require("struts.widget.Bind");
>>>> - dojo.require("struts.widget.BindDiv");
>>>> - dojo.require("struts.widget.BindAnchor");
>>>> dojo.require("dojo.widget.Editor");
>>>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>>>> debugger to work with the includes
>>>>
>>>> It looks to me, that either the patch is not complete, or that I am
>>>> missing the part replacing the above widget requirements.
>>>>
>>>> Could you please have a look at this?
>>>>
>>>> Thanks,
>>>> Rainer
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>>> --
>>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
You are right, the patch doesn't include the new files inside the added
folder, I can't figure out how to make svn create a patch with the added
folder, it keeps complaining:
"Files inside the added folder won't be included ...."
Am I doing something wrong or this is a svn/patch limitation?
musachy
Rainer Hermanns wrote:
> Ah, okay... So it looks like the complete folder with all moved widget files
> is missing. The patch does not create the folder, nor does it create the
> "new/moved" template files.
>
> thanks for your help,
> Rainer
>
>
>> I will take a look tomorrow (not on my box right now), but I do remember
>> that I changed the widgets to struts.widget from struts.widgets, for 2
>> reasons, 1. Keep consistency with Dojo (not that we had to anyway) and 2.
>> Dojo 0.4 by default assumes the widgets to be on a subdir "widget" which
>> requires less configuration. I will let you know tomorrow.
>>
>> thanks
>>
>> musachy
>>
>> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>
>>> Musachy,
>>>
>>> after applying your patch, all custom widget files do no longer have
>>> content.
>>> Is it correct, that all files under core/src/main/resources/org/
>>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>>
>>> If yes, shouldn't core/src/main/resources/template/ajax/
>>> dojoRequire.js should be changed like this (remove all lines with '-' ):
>>>
>>> dojo.require("dojo.io.BrowserIO");
>>> dojo.require("dojo.event.topic");
>>>
>>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>>> dojo.require('dojo.widget.*');
>>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>>
>>> - dojo.require("struts.widget.Bind");
>>> - dojo.require("struts.widget.BindDiv");
>>> - dojo.require("struts.widget.BindAnchor");
>>> dojo.require("dojo.widget.Editor");
>>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>>> debugger to work with the includes
>>>
>>> It looks to me, that either the patch is not complete, or that I am
>>> missing the part replacing the above widget requirements.
>>>
>>> Could you please have a look at this?
>>>
>>> Thanks,
>>> Rainer
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>> --
>> "Hey you! Would you help me to carry the stone?" Pink Floyd
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Ah, okay... So it looks like the complete folder with all moved widget files
is missing. The patch does not create the folder, nor does it create the
"new/moved" template files.
thanks for your help,
Rainer
> I will take a look tomorrow (not on my box right now), but I do remember
> that I changed the widgets to struts.widget from struts.widgets, for 2
> reasons, 1. Keep consistency with Dojo (not that we had to anyway) and 2.
> Dojo 0.4 by default assumes the widgets to be on a subdir "widget" which
> requires less configuration. I will let you know tomorrow.
>
> thanks
>
> musachy
>
> On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>>
>> Musachy,
>>
>> after applying your patch, all custom widget files do no longer have
>> content.
>> Is it correct, that all files under core/src/main/resources/org/
>> apache/struts2/static/dojo/struts/widget/ should be removed?
>>
>> If yes, shouldn't core/src/main/resources/template/ajax/
>> dojoRequire.js should be changed like this (remove all lines with '-' ):
>>
>> dojo.require("dojo.io.BrowserIO");
>> dojo.require("dojo.event.topic");
>>
>> - dojo.hostenv.setModulePrefix('struts', 'struts');
>> dojo.require('dojo.widget.*');
>> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>>
>> - dojo.require("struts.widget.Bind");
>> - dojo.require("struts.widget.BindDiv");
>> - dojo.require("struts.widget.BindAnchor");
>> dojo.require("dojo.widget.Editor");
>> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
>> debugger to work with the includes
>>
>> It looks to me, that either the patch is not complete, or that I am
>> missing the part replacing the above widget requirements.
>>
>> Could you please have a look at this?
>>
>> Thanks,
>> Rainer
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> --
> "Hey you! Would you help me to carry the stone?" Pink Floyd
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
I will take a look tomorrow (not on my box right now), but I do remember
that I changed the widgets to struts.widget from struts.widgets, for 2
reasons, 1. Keep consistency with Dojo (not that we had to anyway) and 2.
Dojo 0.4 by default assumes the widgets to be on a subdir "widget" which
requires less configuration. I will let you know tomorrow.
thanks
musachy
On 11/5/06, Rainer Hermanns <he...@aixcept.de> wrote:
>
> Musachy,
>
> after applying your patch, all custom widget files do no longer have
> content.
> Is it correct, that all files under core/src/main/resources/org/
> apache/struts2/static/dojo/struts/widget/ should be removed?
>
> If yes, shouldn't core/src/main/resources/template/ajax/
> dojoRequire.js should be changed like this (remove all lines with '-' ):
>
> dojo.require("dojo.io.BrowserIO");
> dojo.require("dojo.event.topic");
>
> - dojo.hostenv.setModulePrefix('struts', 'struts');
> dojo.require('dojo.widget.*');
> - dojo.widget.manager.registerWidgetPackage('struts.widget');
>
> - dojo.require("struts.widget.Bind");
> - dojo.require("struts.widget.BindDiv");
> - dojo.require("struts.widget.BindAnchor");
> dojo.require("dojo.widget.Editor");
> dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
> debugger to work with the includes
>
> It looks to me, that either the patch is not complete, or that I am
> missing the part replacing the above widget requirements.
>
> Could you please have a look at this?
>
> Thanks,
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy,
after applying your patch, all custom widget files do no longer have
content.
Is it correct, that all files under core/src/main/resources/org/
apache/struts2/static/dojo/struts/widget/ should be removed?
If yes, shouldn't core/src/main/resources/template/ajax/
dojoRequire.js should be changed like this (remove all lines with '-' ):
dojo.require("dojo.io.BrowserIO");
dojo.require("dojo.event.topic");
- dojo.hostenv.setModulePrefix('struts', 'struts');
dojo.require('dojo.widget.*');
- dojo.widget.manager.registerWidgetPackage('struts.widget');
- dojo.require("struts.widget.Bind");
- dojo.require("struts.widget.BindDiv");
- dojo.require("struts.widget.BindAnchor");
dojo.require("dojo.widget.Editor");
dojo.hostenv.writeIncludes(); // not needed, but allows the Venkman
debugger to work with the includes
It looks to me, that either the patch is not complete, or that I am
missing the part replacing the above widget requirements.
Could you please have a look at this?
Thanks,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Sorry for the delay guys.
I see. Thx for the heads up. :-) Haven't tried it on eclipse yet.
Rainer have started playing with dojo 0.4 on his local box, will get it and the patches into svn within these few days. Thx Rainer.
Cheers.
Musachy Barroso <mu...@gmail.com> wrote: I tried also with similar results(using patch), I tried with eclipse and
it worked like a charm. Shame on me :)
tm jee wrote:
> Hi guys,
>
> I've tried to apply Musachy's patch on my local machine and the following is the output. There seems to be some part that failed. Am I patching it wrongly?
>
> tm_jee@linux:~/development/struts2_temp> svn update ./
> At revision 471138.
> tm_jee@linux:~/development/struts2_temp> patch -p0 < WW-1484.patch
> (Stripping trailing CRs from patch.)
> patching file apps/showcase/src/main/webapp/ajax/AjaxResult.jsp
> (Stripping trailing CRs from patch.)
> ....
> patching file core/src/main/java/org/apache/struts2/components/TabbedPanel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/components/TimePicker.java
> Hunk #1 FAILED at 25.
> 1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/struts2/components/TimePicker.java.rej
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/DropdownDateTimePickerModel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 1 out of 1 hunk ignored -- saving rejects to file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java.rej
> (Stripping trailing CRs from patch.)
> ....
>
> rgds
>
>
>
> tm jee wrote: Okie dokie. Thx Musachy. :-)
>
> Musachy Barroso wrote: I have attached the patch to WW-1484, please note that it doesn't
> include some of the things mentioned in the bug (javadoc-like
> documentation for the widgets). This includes
> BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
> DropDownDateTimePicker(kind of a verbose name right? :))
>
> musachy
>
> tm jee wrote:
>
>> Done, 2 jira ticket created
>>
>> http://issues.apache.org/struts/browse/WW-1484
>> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>>
>> http://issues.apache.org/struts/browse/WW-1485
>> - upgrading Struts2 dojo to 0.4
>>
>> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
>> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
>> today I think).
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>>> I'm using defineWidget, and it is cool.
>>>>
>>>>
>>>>
>>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>>
>>>
>>>
>>>
>>>> I will be looking into hostedqa
>>>>
>>>>
>>>>
>>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>>
>>> Cheers.
>>>
>>>
>>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>>> given that it is being used in struts already, as per Don's comment
>>> somewhere on this thread.
>>>
>>> musachy
>>>
>>> tm jee wrote:
>>>
>>>
>>>
>>>> Hi guys,
>>>>
>>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>>
>>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>>
>>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>>
>>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>>
>>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>>
>>>> What you guys think? :-)
>>>>
>>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>>> the tags separately.
>>>>
>>>> just let me know, when you are done :)
>>>> tia,
>>>> Rainer
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>>
>>>>> musachy
>>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>>> should be
>>>>>> a separate commit.
>>>>>>
>>>>>> By the way, do we have a Jira
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> issue for the dojo upgrade?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>>> there
>>>>>> isn't one already.
>>>>>>
>>>>>> --
>>>>>> Martin.
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Martin Cooper wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Hi Rainer
>>>>>>>>>
>>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> patch
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> new
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> 0.4. If
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> commits, so
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>>> one or
>>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>>
>>>>>>>> --
>>>>>>>> Martin Cooper
>>>>>>>>
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Musachy,
>>>>>>>>>>
>>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> during the
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> week.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> 0.4release,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I could apply those as well.
>>>>>>>>>>
>>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>>
>>>>>>>>>> regards,
>>>>>>>>>> Rainer
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>> patches to
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>> Dojo?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> you
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>> replace
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>>
>>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> know
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> patch
>>>>>>> :)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> ).
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>> break
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>> need
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>> when
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> 0.3)?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> posted a
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> reason
>>>>>>> we
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> "handler"
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> (dojo's
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> doesn't
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
=== message truncated ===
---------------------------------
Try the all-new Yahoo! Mail . "The New Version is radically easier to use" – The Wall Street Journal
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
I tried also with similar results(using patch), I tried with eclipse and
it worked like a charm. Shame on me :)
tm jee wrote:
> Hi guys,
>
> I've tried to apply Musachy's patch on my local machine and the following is the output. There seems to be some part that failed. Am I patching it wrongly?
>
> tm_jee@linux:~/development/struts2_temp> svn update ./
> At revision 471138.
> tm_jee@linux:~/development/struts2_temp> patch -p0 < WW-1484.patch
> (Stripping trailing CRs from patch.)
> patching file apps/showcase/src/main/webapp/ajax/AjaxResult.jsp
> (Stripping trailing CRs from patch.)
> ....
> patching file core/src/main/java/org/apache/struts2/components/TabbedPanel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/components/TimePicker.java
> Hunk #1 FAILED at 25.
> 1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/struts2/components/TimePicker.java.rej
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/DropdownDateTimePickerModel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 1 out of 1 hunk ignored -- saving rejects to file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java.rej
> (Stripping trailing CRs from patch.)
> ....
>
> rgds
>
>
>
> tm jee <tm...@yahoo.co.uk> wrote: Okie dokie. Thx Musachy. :-)
>
> Musachy Barroso wrote: I have attached the patch to WW-1484, please note that it doesn't
> include some of the things mentioned in the bug (javadoc-like
> documentation for the widgets). This includes
> BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
> DropDownDateTimePicker(kind of a verbose name right? :))
>
> musachy
>
> tm jee wrote:
>
>> Done, 2 jira ticket created
>>
>> http://issues.apache.org/struts/browse/WW-1484
>> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>>
>> http://issues.apache.org/struts/browse/WW-1485
>> - upgrading Struts2 dojo to 0.4
>>
>> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
>> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
>> today I think).
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>>> I'm using defineWidget, and it is cool.
>>>>
>>>>
>>>>
>>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>>
>>>
>>>
>>>
>>>> I will be looking into hostedqa
>>>>
>>>>
>>>>
>>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>>
>>> Cheers.
>>>
>>>
>>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>>> given that it is being used in struts already, as per Don's comment
>>> somewhere on this thread.
>>>
>>> musachy
>>>
>>> tm jee wrote:
>>>
>>>
>>>
>>>> Hi guys,
>>>>
>>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>>
>>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>>
>>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>>
>>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>>
>>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>>
>>>> What you guys think? :-)
>>>>
>>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>>> the tags separately.
>>>>
>>>> just let me know, when you are done :)
>>>> tia,
>>>> Rainer
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>>
>>>>> musachy
>>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>>> should be
>>>>>> a separate commit.
>>>>>>
>>>>>> By the way, do we have a Jira
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> issue for the dojo upgrade?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>>> there
>>>>>> isn't one already.
>>>>>>
>>>>>> --
>>>>>> Martin.
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Martin Cooper wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Hi Rainer
>>>>>>>>>
>>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> patch
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> new
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> 0.4. If
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> commits, so
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>>> one or
>>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>>
>>>>>>>> --
>>>>>>>> Martin Cooper
>>>>>>>>
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Musachy,
>>>>>>>>>>
>>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> during the
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> week.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> 0.4release,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I could apply those as well.
>>>>>>>>>>
>>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>>
>>>>>>>>>> regards,
>>>>>>>>>> Rainer
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>> patches to
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>> Dojo?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> you
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>> replace
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>>
>>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> know
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> patch
>>>>>>> :)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> ).
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>> break
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>> need
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>> when
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> 0.3)?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> posted a
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> reason
>>>>>>> we
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> "handler"
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> (dojo's
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> doesn't
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> self.startTimer);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> self.refreshListenTopics
>>>>>>> );
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> {
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> self.startTimerListenTopics
>>>>>>>>> );
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>>> ,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> need to
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>
> === message truncated ===
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
What is it saving in
TimePicker.java.rej
PanelModel.java.rej
?
tm jee wrote:
> Hi guys,
>
> I've tried to apply Musachy's patch on my local machine and the following is the output. There seems to be some part that failed. Am I patching it wrongly?
>
> tm_jee@linux:~/development/struts2_temp> svn update ./
> At revision 471138.
> tm_jee@linux:~/development/struts2_temp> patch -p0 < WW-1484.patch
> (Stripping trailing CRs from patch.)
> patching file apps/showcase/src/main/webapp/ajax/AjaxResult.jsp
> (Stripping trailing CRs from patch.)
> ....
> patching file core/src/main/java/org/apache/struts2/components/TabbedPanel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/components/TimePicker.java
> Hunk #1 FAILED at 25.
> 1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/struts2/components/TimePicker.java.rej
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/DropdownDateTimePickerModel.java
> (Stripping trailing CRs from patch.)
> patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 1 out of 1 hunk ignored -- saving rejects to file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java.rej
> (Stripping trailing CRs from patch.)
> ....
>
> rgds
>
>
>
> tm jee <tm...@yahoo.co.uk> wrote: Okie dokie. Thx Musachy. :-)
>
> Musachy Barroso wrote: I have attached the patch to WW-1484, please note that it doesn't
> include some of the things mentioned in the bug (javadoc-like
> documentation for the widgets). This includes
> BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
> DropDownDateTimePicker(kind of a verbose name right? :))
>
> musachy
>
> tm jee wrote:
>
>> Done, 2 jira ticket created
>>
>> http://issues.apache.org/struts/browse/WW-1484
>> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>>
>> http://issues.apache.org/struts/browse/WW-1485
>> - upgrading Struts2 dojo to 0.4
>>
>> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
>> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
>> today I think).
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>>> I'm using defineWidget, and it is cool.
>>>>
>>>>
>>>>
>>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>>
>>>
>>>
>>>
>>>> I will be looking into hostedqa
>>>>
>>>>
>>>>
>>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>>
>>> Cheers.
>>>
>>>
>>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>>> given that it is being used in struts already, as per Don's comment
>>> somewhere on this thread.
>>>
>>> musachy
>>>
>>> tm jee wrote:
>>>
>>>
>>>
>>>> Hi guys,
>>>>
>>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>>
>>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>>
>>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>>
>>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>>
>>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>>
>>>> What you guys think? :-)
>>>>
>>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>>> the tags separately.
>>>>
>>>> just let me know, when you are done :)
>>>> tia,
>>>> Rainer
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>>
>>>>> musachy
>>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>>> should be
>>>>>> a separate commit.
>>>>>>
>>>>>> By the way, do we have a Jira
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> issue for the dojo upgrade?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>>> there
>>>>>> isn't one already.
>>>>>>
>>>>>> --
>>>>>> Martin.
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Martin Cooper wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Hi Rainer
>>>>>>>>>
>>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> patch
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> new
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> 0.4. If
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> commits, so
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>>> one or
>>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>>
>>>>>>>> --
>>>>>>>> Martin Cooper
>>>>>>>>
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Musachy,
>>>>>>>>>>
>>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> during the
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> week.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> 0.4release,
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I could apply those as well.
>>>>>>>>>>
>>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>>
>>>>>>>>>> regards,
>>>>>>>>>> Rainer
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>> patches to
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>> Dojo?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> you
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>> replace
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>>
>>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> know
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> patch
>>>>>>> :)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>> ).
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>> break
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>> need
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> want
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>> when
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>> 0.3)?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> posted a
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> reason
>>>>>>> we
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> "handler"
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> (dojo's
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> doesn't
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> self.startTimer);
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> self.refreshListenTopics
>>>>>>> );
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> {
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> self.startTimerListenTopics
>>>>>>>>> );
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>>> ,
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>> need to
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>
> === message truncated ===
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi guys,
I've tried to apply Musachy's patch on my local machine and the following is the output. There seems to be some part that failed. Am I patching it wrongly?
tm_jee@linux:~/development/struts2_temp> svn update ./
At revision 471138.
tm_jee@linux:~/development/struts2_temp> patch -p0 < WW-1484.patch
(Stripping trailing CRs from patch.)
patching file apps/showcase/src/main/webapp/ajax/AjaxResult.jsp
(Stripping trailing CRs from patch.)
....
patching file core/src/main/java/org/apache/struts2/components/TabbedPanel.java
(Stripping trailing CRs from patch.)
patching file core/src/main/java/org/apache/struts2/components/TimePicker.java
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file core/src/main/java/org/apache/struts2/components/TimePicker.java.rej
(Stripping trailing CRs from patch.)
patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/DropdownDateTimePickerModel.java
(Stripping trailing CRs from patch.)
patching file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file core/src/main/java/org/apache/struts2/views/freemarker/tags/PanelModel.java.rej
(Stripping trailing CRs from patch.)
....
rgds
tm jee <tm...@yahoo.co.uk> wrote: Okie dokie. Thx Musachy. :-)
Musachy Barroso wrote: I have attached the patch to WW-1484, please note that it doesn't
include some of the things mentioned in the bug (javadoc-like
documentation for the widgets). This includes
BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
DropDownDateTimePicker(kind of a verbose name right? :))
musachy
tm jee wrote:
> Done, 2 jira ticket created
>
> http://issues.apache.org/struts/browse/WW-1484
> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>
> http://issues.apache.org/struts/browse/WW-1485
> - upgrading Struts2 dojo to 0.4
>
> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> today I think).
>
> musachy
>
> tm jee wrote:
>
>>> I'm using defineWidget, and it is cool.
>>>
>>>
>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>
>>
>>
>>> I will be looking into hostedqa
>>>
>>>
>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>
>> Cheers.
>>
>>
>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>> given that it is being used in struts already, as per Don's comment
>> somewhere on this thread.
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>> Hi guys,
>>>
>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>
>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>
>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>
>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>
>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>
>>> What you guys think? :-)
>>>
>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>> the tags separately.
>>>
>>> just let me know, when you are done :)
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>
>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>
>>>> musachy
>>>>
>>>> Martin Cooper wrote:
>>>>
>>>>
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>
>>>>>>
>>>>>>
>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>> should be
>>>>> a separate commit.
>>>>>
>>>>> By the way, do we have a Jira
>>>>>
>>>>>
>>>>>
>>>>>> issue for the dojo upgrade?
>>>>>>
>>>>>>
>>>>>>
>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>> there
>>>>> isn't one already.
>>>>>
>>>>> --
>>>>> Martin.
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>
>>>>>
>>>>>> Martin Cooper wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Hi Rainer
>>>>>>>>
>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> patch
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> new
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> 0.4. If
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> commits, so
>>>>>>
>>>>>>
>>>>>>
>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>> one or
>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>
>>>>>>> --
>>>>>>> Martin Cooper
>>>>>>>
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Musachy,
>>>>>>>>>
>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> during the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> week.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> 0.4release,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> I could apply those as well.
>>>>>>>>>
>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Rainer
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> patches to
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>> Dojo?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> you
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>> replace
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>
>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> know
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> patch
>>>>>> :)
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> ).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>> break
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> need
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> when
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> 0.3)?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> posted a
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> reason
>>>>>> we
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> "handler"
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> (dojo's
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> doesn't
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.startTimer);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.refreshListenTopics
>>>>>> );
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.startTimerListenTopics
>>>>>>>> );
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>> ,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> need to
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
=== message truncated ===
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Okie dokie. Thx Musachy. :-)
Musachy Barroso <mb...@wfscorp.com> wrote: I have attached the patch to WW-1484, please note that it doesn't
include some of the things mentioned in the bug (javadoc-like
documentation for the widgets). This includes
BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
DropDownDateTimePicker(kind of a verbose name right? :))
musachy
tm jee wrote:
> Done, 2 jira ticket created
>
> http://issues.apache.org/struts/browse/WW-1484
> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>
> http://issues.apache.org/struts/browse/WW-1485
> - upgrading Struts2 dojo to 0.4
>
> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> today I think).
>
> musachy
>
> tm jee wrote:
>
>>> I'm using defineWidget, and it is cool.
>>>
>>>
>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>
>>
>>
>>> I will be looking into hostedqa
>>>
>>>
>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>
>> Cheers.
>>
>>
>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>> given that it is being used in struts already, as per Don's comment
>> somewhere on this thread.
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>> Hi guys,
>>>
>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>
>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>
>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>
>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>
>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>
>>> What you guys think? :-)
>>>
>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>> the tags separately.
>>>
>>> just let me know, when you are done :)
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>
>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>
>>>> musachy
>>>>
>>>> Martin Cooper wrote:
>>>>
>>>>
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>
>>>>>>
>>>>>>
>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>> should be
>>>>> a separate commit.
>>>>>
>>>>> By the way, do we have a Jira
>>>>>
>>>>>
>>>>>
>>>>>> issue for the dojo upgrade?
>>>>>>
>>>>>>
>>>>>>
>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>> there
>>>>> isn't one already.
>>>>>
>>>>> --
>>>>> Martin.
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>
>>>>>
>>>>>> Martin Cooper wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Hi Rainer
>>>>>>>>
>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> patch
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> new
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> 0.4. If
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> commits, so
>>>>>>
>>>>>>
>>>>>>
>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>> one or
>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>
>>>>>>> --
>>>>>>> Martin Cooper
>>>>>>>
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Musachy,
>>>>>>>>>
>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> during the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> week.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> 0.4release,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> I could apply those as well.
>>>>>>>>>
>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Rainer
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> patches to
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>> Dojo?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> you
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>> replace
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>
>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> know
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> patch
>>>>>> :)
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> ).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>> break
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> need
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> when
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> 0.3)?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> posted a
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> reason
>>>>>> we
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> "handler"
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> (dojo's
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> doesn't
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.startTimer);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.refreshListenTopics
>>>>>> );
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.startTimerListenTopics
>>>>>>>> );
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>> ,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> need to
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
=== message truncated ===
---------------------------------
Try the all-new Yahoo! Mail . "The New Version is radically easier to use" – The Wall Street Journal
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I have attached the patch to WW-1484, please note that it doesn't
include some of the things mentioned in the bug (javadoc-like
documentation for the widgets). This includes
BindDiv, BindAnchor, BindButton, TabbedPannel, DatePicker, TimePicker,
DropDownDateTimePicker(kind of a verbose name right? :))
musachy
tm jee wrote:
> Done, 2 jira ticket created
>
> http://issues.apache.org/struts/browse/WW-1484
> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>
> http://issues.apache.org/struts/browse/WW-1485
> - upgrading Struts2 dojo to 0.4
>
> Musachy Barroso <mb...@wfscorp.com> wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> today I think).
>
> musachy
>
> tm jee wrote:
>
>>> I'm using defineWidget, and it is cool.
>>>
>>>
>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>
>>
>>
>>> I will be looking into hostedqa
>>>
>>>
>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>
>> Cheers.
>>
>>
>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>> given that it is being used in struts already, as per Don's comment
>> somewhere on this thread.
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>> Hi guys,
>>>
>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>
>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>
>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>
>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>
>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>
>>> What you guys think? :-)
>>>
>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>> the tags separately.
>>>
>>> just let me know, when you are done :)
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>
>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>
>>>> musachy
>>>>
>>>> Martin Cooper wrote:
>>>>
>>>>
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>
>>>>>>
>>>>>>
>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>> should be
>>>>> a separate commit.
>>>>>
>>>>> By the way, do we have a Jira
>>>>>
>>>>>
>>>>>
>>>>>> issue for the dojo upgrade?
>>>>>>
>>>>>>
>>>>>>
>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>> there
>>>>> isn't one already.
>>>>>
>>>>> --
>>>>> Martin.
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>
>>>>>
>>>>>> Martin Cooper wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Hi Rainer
>>>>>>>>
>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> patch
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> new
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> 0.4. If
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> commits, so
>>>>>>
>>>>>>
>>>>>>
>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>> one or
>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>
>>>>>>> --
>>>>>>> Martin Cooper
>>>>>>>
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Musachy,
>>>>>>>>>
>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> during the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> week.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> 0.4release,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> I could apply those as well.
>>>>>>>>>
>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Rainer
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> patches to
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>> Dojo?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> you
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>> replace
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>
>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> know
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> patch
>>>>>> :)
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> ).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>> break
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> need
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> when
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> 0.3)?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> posted a
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> reason
>>>>>> we
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> "handler"
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> (dojo's
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> doesn't
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.startTimer);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.refreshListenTopics
>>>>>> );
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.startTimerListenTopics
>>>>>>>> );
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>> ,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> need to
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> PanelTag
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> wraps
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> should
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> refresh.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> in. Try
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> wrappers
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> was no
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> that
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> is the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> tabs
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> being
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> converting
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> dev-unsubscribe@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>>>
>
> === message truncated ===
>
>
> ---------------------------------
> All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
I think ToggleBindDiv.js and DynArchCalendar.js are not used. We could update them if we wish later once we got the main ones in (eg. BindDiv which ToggleBindDiv extends from)
Musachy Barroso <mu...@gmail.com> wrote: I just finished with DatePicker and DropdownDatePicker. The ones missing are
ToggleBindDiv.js, DynArchCalendar.js, and TimePicker, I think only
TimerPicker is important(I need to add DropDownTimePicker), which I could
get done by Wednesday or Thursday.
musachy
On 10/31/06, tm jee wrote:
>
> Hi Ian,
>
> > Have we cut the 2.0.1 beta yet?
> I think we have the 2.0.1 release, its now open for quality voting. If we
> do another release it would be 2.0.2. So i guess the answer would be
> "yes". Do correct me if I am wrong, Ted, Don :-)
>
> > My preference would also be to have the dojo 0.4
> > update, together with all the existing tags working with 0.4 available,
> > but to commit them separately. This way we only need to fix bugs,
> > rather than convert failing UI widgets that the user community may be
> > relying on.
>
> I think Musachy have converted all of them, just that they are not
> commited yet. If we are to do it this way, i guess we'll need Musachy to
> have all the patches ready. Then we could upgrade dojo to 0.4 in one
> commit, and one commit for each widget/component etc.
>
> Thoughts?
>
>
>
>
> Ian Roughley wrote: Sorry for the late reply - vacation.
>
> Have we cut the 2.0.1 beta yet? If not, we should wait until then
> before this update. My preference would also be to have the dojo 0.4
> update, together with all the existing tags working with 0.4 available,
> but to commit them separately. This way we only need to fix bugs,
> rather than convert failing UI widgets that the user community may be
> relying on.
>
> /Ian
>
> --
> From Down & Around, Inc.
> Innovative IT Solutions
> Software Architecture * Design * Development
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> web: www.fdar.com
> email ian@fdar.com
> phone: 617.821.5430
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>
> tm jee wrote:
> > Hi guys,
> >
> > If its ok with everyone, I'd like to upgrade Struts2 dojo js to 0.4,
> sometime today or tomorrow. (WW-1845). This will most likely breaks some
> existing struts2 components. We will patch them up individually (WW-1844)
> >
> > Cheers
> >
> >
> > tm jee wrote: Done, 2 jira ticket created
> >
> > http://issues.apache.org/struts/browse/WW-1484
> > - upgrading Struts2 dojo widget that might failed due to upgrading dojo
> to 0.4
> >
> > http://issues.apache.org/struts/browse/WW-1485
> > - upgrading Struts2 dojo to 0.4
> >
> > Musachy Barroso wrote: yes, I overwrote those bindXs with
> defineWidget. We are going to need
> > another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> > today I think).
> >
> > musachy
> >
> > tm jee wrote:
> >
> >>> I'm using defineWidget, and it is cool.
> >>>
> >>>
> >> Yup. Is it that the bind, binddiv, bindanchor etc have been written
> with dojo.widget.defineWidget? If so, this would be great. :-) I've
> converter the bind component using defineWidget... but looks like it could
> be deleted now.... :-)
> >>
> >>
> >>
> >>> I will be looking into hostedqa
> >>>
> >>>
> >> You could get a free account from Pat at [ plightbo at friendly gmail
> dot com ]
> >>
> >> Cheers.
> >>
> >>
> >> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will
> be looking into hostedqa
> >> given that it is being used in struts already, as per Don's comment
> >> somewhere on this thread.
> >>
> >> musachy
> >>
> >> tm jee wrote:
> >>
> >>
> >>> Hi guys,
> >>>
> >>> sorry for jumping into this late. I think we should do the followings
> for struts2 dojo widgets.
> >>>
> >>> - use dojo.widget.defineWidget instead of the old-way of using
> dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten
> using this way.
> >>>
> >>> - have struts2 widgets/utils as a separate module and add them in
> using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4and the concept of module is namespace in
> 0.4
> >>>
> >>> - have javadoc comments in our widget, hopefully it would be easier to
> follow and maybe if possible able to generate docs like
> http://dojotoolkit.org/api But I am not sure about how to do this yet.
> Definitely interested in finding out more.
> >>>
> >>> - have a test folder, like dojo's where we could have pages that test
> the widget, we could use Pat's product to do test the pages (something like
> HostedQA or Selenium)
> >>>
> >>> What you guys think? :-)
> >>>
> >>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> >>> As soon as I get it, I'll update Dojo first and commit your patches
> for
> >>> the tags separately.
> >>>
> >>> just let me know, when you are done :)
> >>> tia,
> >>> Rainer
> >>>
> >>>
> >>>
> >>>
> >>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
> >>>> made it using 0.3 and I haven't tried it on 0.4 yet.
> >>>>
> >>>> musachy
> >>>>
> >>>> Martin Cooper wrote:
> >>>>
> >>>>
> >>>>
> >>>>> On 10/30/06, Musachy Barroso wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Oh, ok. Then just don't apply the patch.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> No, no - I'm not saying that it shouldn't be applied, only that it
> >>>>> should be
> >>>>> a separate commit.
> >>>>>
> >>>>> By the way, do we have a Jira
> >>>>>
> >>>>>
> >>>>>
> >>>>>> issue for the dojo upgrade?
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> Not that I can see. Feel free to add one, and one with your patch,
> if
> >>>>> there
> >>>>> isn't one already.
> >>>>>
> >>>>> --
> >>>>> Martin.
> >>>>>
> >>>>>
> >>>>> musachy
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Martin Cooper wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> On 10/30/06, Musachy Barroso wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Hi Rainer
> >>>>>>>>
> >>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> patch
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> using 0.3) and finish some changes(for BindButton) that I have
> for a
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> new
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> patch. I will give you a new patch soon with the changes for
> Bind,
> >>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> 0.4. If
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch
> later,
> >>>>>>>> that's fine. (I will just be bothering with another patch soon :)
> )
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Well, the upgrade and the patch should certainly be separate
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> commits, so
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> that we can track the changes separately, and so that we can
> revert
> >>>>>>> one or
> >>>>>>> the other if that ever becomes necessary. Beyond that, it's up to
> the
> >>>>>>> prospective committer to determine timing. ;-)
> >>>>>>>
> >>>>>>> --
> >>>>>>> Martin Cooper
> >>>>>>>
> >>>>>>>
> >>>>>>> musachy
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Rainer Hermanns wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Musachy,
> >>>>>>>>>
> >>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>> during the
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> week.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> If your patches for the s2 ajax tags already are against the
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> 0.4release,
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> I could apply those as well.
> >>>>>>>>>
> >>>>>>>>> What do you (and others of course) think?
> >>>>>>>>>
> >>>>>>>>> regards,
> >>>>>>>>> Rainer
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
> >>>>>>>>>>
> >>>>>>>>>> musachy
> >>>>>>>>>>
> >>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>> patches to
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>> update the tags. How much work do you think it'll be to
> upgrade
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>> Dojo?
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>> Don
> >>>>>>>>>>>
> >>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
> >>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> you
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> want
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>> replace
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> dojo distribution under static/dojo.)
> >>>>>>>>>>>>
> >>>>>>>>>>>> I modified the examples in showcase and the test cases. Let
> me
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> know
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>> if something is missing or wrong (bear with me on my first
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> patch
> >>>>>> :)
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> ).
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> musachy
> >>>>>>>>>>>>
> >>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Don
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> That's ok, the only problem is that this one by itself
> would
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>> break
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>> anchor and tabbed panel.
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
> >>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but
> we
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>> need
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>> to use it more.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Don
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do
> you
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>> want
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>> when
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2->
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>> 0.3)?
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax
> stuff?
> >>>>>>>>>>>>>>>> (Selenium maybe?)
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>> posted a
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>> message on their mailing list.
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>> reason
> >>>>>> we
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Don
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> Would something like this include all the current
> >>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start
> timer,
> >>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> "handler"
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> (dojo's
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
> >>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> doesn't
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
> >>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
> >>>>>>>>>>>>>>>>>>> var self = this;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.href = "";
> >>>>>>>>>>>>>>>>>>> this.extractContent = false;
> >>>>>>>>>>>>>>>>>>> this.parseContent = false;
> >>>>>>>>>>>>>>>>>>> this.cacheContent = false;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.frequency = 0;
> >>>>>>>>>>>>>>>>>>> this.delay = 0;
> >>>>>>>>>>>>>>>>>>> this.startTimer = false;
> >>>>>>>>>>>>>>>>>>> this.timer = null;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //pub/sub events
> >>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
> >>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
> >>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.postCreate = function() {
> >>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
> >>>>>>>>>>>>>>>>>>> self.timer = new
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> dojo.animation.Timer(self.frequency);
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //start the timer
> >>>>>>>>>>>>>>>>>>> if(self.startTimer) {
> >>>>>>>>>>>>>>>>>>> //start after delay
> >>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay
> );
> >>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> self.startTimer);
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //attach listeners
> >>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics))
> {
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> self.refreshListenTopics
> >>>>>> );
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(
> self.refreshListenTopics,
> >>>>>>>>>>>>>>>>>>> self, "reloadContents");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics
> ))
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> {
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> self.stopTimerListenTopics);
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self, "stopTimer");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> self.startTimerListenTopics
> >>>>>>>> );
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
> >>>>>> ,
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self, "startTimer");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
> >>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
> >>>>>>>>>>>>>>>>>>> self.isLoaded = false;
> >>>>>>>>>>>>>>>>>>> self.loadContents();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
> >>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
> >>>>>>>>>>>>>>>>>>> self.timer.stop();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.startTimer = function() {
> >>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
> >>>>>>>>>>>>>>>>>>> self.frequency);
> >>>>>>>>>>>>>>>>>>> self.timer.start();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
> >>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
>
> === message truncated ===
>
>
> ---------------------------------
> Copy addresses and emails from any email account to Yahoo! Mail - quick,
> easy and free. Do it now...
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
I just finished with DatePicker and DropdownDatePicker. The ones missing are
ToggleBindDiv.js, DynArchCalendar.js, and TimePicker, I think only
TimerPicker is important(I need to add DropDownTimePicker), which I could
get done by Wednesday or Thursday.
musachy
On 10/31/06, tm jee <tm...@yahoo.co.uk> wrote:
>
> Hi Ian,
>
> > Have we cut the 2.0.1 beta yet?
> I think we have the 2.0.1 release, its now open for quality voting. If we
> do another release it would be 2.0.2. So i guess the answer would be
> "yes". Do correct me if I am wrong, Ted, Don :-)
>
> > My preference would also be to have the dojo 0.4
> > update, together with all the existing tags working with 0.4 available,
> > but to commit them separately. This way we only need to fix bugs,
> > rather than convert failing UI widgets that the user community may be
> > relying on.
>
> I think Musachy have converted all of them, just that they are not
> commited yet. If we are to do it this way, i guess we'll need Musachy to
> have all the patches ready. Then we could upgrade dojo to 0.4 in one
> commit, and one commit for each widget/component etc.
>
> Thoughts?
>
>
>
>
> Ian Roughley <ia...@fdar.com> wrote: Sorry for the late reply - vacation.
>
> Have we cut the 2.0.1 beta yet? If not, we should wait until then
> before this update. My preference would also be to have the dojo 0.4
> update, together with all the existing tags working with 0.4 available,
> but to commit them separately. This way we only need to fix bugs,
> rather than convert failing UI widgets that the user community may be
> relying on.
>
> /Ian
>
> --
> From Down & Around, Inc.
> Innovative IT Solutions
> Software Architecture * Design * Development
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> web: www.fdar.com
> email ian@fdar.com
> phone: 617.821.5430
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
>
> tm jee wrote:
> > Hi guys,
> >
> > If its ok with everyone, I'd like to upgrade Struts2 dojo js to 0.4,
> sometime today or tomorrow. (WW-1845). This will most likely breaks some
> existing struts2 components. We will patch them up individually (WW-1844)
> >
> > Cheers
> >
> >
> > tm jee wrote: Done, 2 jira ticket created
> >
> > http://issues.apache.org/struts/browse/WW-1484
> > - upgrading Struts2 dojo widget that might failed due to upgrading dojo
> to 0.4
> >
> > http://issues.apache.org/struts/browse/WW-1485
> > - upgrading Struts2 dojo to 0.4
> >
> > Musachy Barroso wrote: yes, I overwrote those bindXs with
> defineWidget. We are going to need
> > another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> > today I think).
> >
> > musachy
> >
> > tm jee wrote:
> >
> >>> I'm using defineWidget, and it is cool.
> >>>
> >>>
> >> Yup. Is it that the bind, binddiv, bindanchor etc have been written
> with dojo.widget.defineWidget? If so, this would be great. :-) I've
> converter the bind component using defineWidget... but looks like it could
> be deleted now.... :-)
> >>
> >>
> >>
> >>> I will be looking into hostedqa
> >>>
> >>>
> >> You could get a free account from Pat at [ plightbo at friendly gmail
> dot com ]
> >>
> >> Cheers.
> >>
> >>
> >> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will
> be looking into hostedqa
> >> given that it is being used in struts already, as per Don's comment
> >> somewhere on this thread.
> >>
> >> musachy
> >>
> >> tm jee wrote:
> >>
> >>
> >>> Hi guys,
> >>>
> >>> sorry for jumping into this late. I think we should do the followings
> for struts2 dojo widgets.
> >>>
> >>> - use dojo.widget.defineWidget instead of the old-way of using
> dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten
> using this way.
> >>>
> >>> - have struts2 widgets/utils as a separate module and add them in
> using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4and the concept of module is namespace in
> 0.4
> >>>
> >>> - have javadoc comments in our widget, hopefully it would be easier to
> follow and maybe if possible able to generate docs like
> http://dojotoolkit.org/api But I am not sure about how to do this yet.
> Definitely interested in finding out more.
> >>>
> >>> - have a test folder, like dojo's where we could have pages that test
> the widget, we could use Pat's product to do test the pages (something like
> HostedQA or Selenium)
> >>>
> >>> What you guys think? :-)
> >>>
> >>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> >>> As soon as I get it, I'll update Dojo first and commit your patches
> for
> >>> the tags separately.
> >>>
> >>> just let me know, when you are done :)
> >>> tia,
> >>> Rainer
> >>>
> >>>
> >>>
> >>>
> >>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
> >>>> made it using 0.3 and I haven't tried it on 0.4 yet.
> >>>>
> >>>> musachy
> >>>>
> >>>> Martin Cooper wrote:
> >>>>
> >>>>
> >>>>
> >>>>> On 10/30/06, Musachy Barroso wrote:
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Oh, ok. Then just don't apply the patch.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> No, no - I'm not saying that it shouldn't be applied, only that it
> >>>>> should be
> >>>>> a separate commit.
> >>>>>
> >>>>> By the way, do we have a Jira
> >>>>>
> >>>>>
> >>>>>
> >>>>>> issue for the dojo upgrade?
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> Not that I can see. Feel free to add one, and one with your patch,
> if
> >>>>> there
> >>>>> isn't one already.
> >>>>>
> >>>>> --
> >>>>> Martin.
> >>>>>
> >>>>>
> >>>>> musachy
> >>>>>
> >>>>>
> >>>>>
> >>>>>> Martin Cooper wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> On 10/30/06, Musachy Barroso wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Hi Rainer
> >>>>>>>>
> >>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> patch
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> using 0.3) and finish some changes(for BindButton) that I have
> for a
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> new
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> patch. I will give you a new patch soon with the changes for
> Bind,
> >>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> 0.4. If
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch
> later,
> >>>>>>>> that's fine. (I will just be bothering with another patch soon :)
> )
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Well, the upgrade and the patch should certainly be separate
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> commits, so
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> that we can track the changes separately, and so that we can
> revert
> >>>>>>> one or
> >>>>>>> the other if that ever becomes necessary. Beyond that, it's up to
> the
> >>>>>>> prospective committer to determine timing. ;-)
> >>>>>>>
> >>>>>>> --
> >>>>>>> Martin Cooper
> >>>>>>>
> >>>>>>>
> >>>>>>> musachy
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Rainer Hermanns wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Musachy,
> >>>>>>>>>
> >>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>> during the
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> week.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> If your patches for the s2 ajax tags already are against the
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> 0.4release,
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> I could apply those as well.
> >>>>>>>>>
> >>>>>>>>> What do you (and others of course) think?
> >>>>>>>>>
> >>>>>>>>> regards,
> >>>>>>>>> Rainer
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
> >>>>>>>>>>
> >>>>>>>>>> musachy
> >>>>>>>>>>
> >>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>> patches to
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>> update the tags. How much work do you think it'll be to
> upgrade
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>> Dojo?
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>> Don
> >>>>>>>>>>>
> >>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
> >>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> you
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> want
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>> replace
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> dojo distribution under static/dojo.)
> >>>>>>>>>>>>
> >>>>>>>>>>>> I modified the examples in showcase and the test cases. Let
> me
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> know
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>> if something is missing or wrong (bear with me on my first
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>> patch
> >>>>>> :)
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>> ).
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>> musachy
> >>>>>>>>>>>>
> >>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Don
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>> That's ok, the only problem is that this one by itself
> would
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>> break
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>> anchor and tabbed panel.
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
> >>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but
> we
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>> need
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>> to use it more.
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Don
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do
> you
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>> want
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>> when
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2->
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>> 0.3)?
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax
> stuff?
> >>>>>>>>>>>>>>>> (Selenium maybe?)
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>> posted a
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>> message on their mailing list.
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> musachy
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>> Don Brown wrote:
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>> reason
> >>>>>> we
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Don
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> Would something like this include all the current
> >>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start
> timer,
> >>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> "handler"
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> (dojo's
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
> >>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> doesn't
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
> >>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
> >>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
> >>>>>>>>>>>>>>>>>>> var self = this;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.href = "";
> >>>>>>>>>>>>>>>>>>> this.extractContent = false;
> >>>>>>>>>>>>>>>>>>> this.parseContent = false;
> >>>>>>>>>>>>>>>>>>> this.cacheContent = false;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.frequency = 0;
> >>>>>>>>>>>>>>>>>>> this.delay = 0;
> >>>>>>>>>>>>>>>>>>> this.startTimer = false;
> >>>>>>>>>>>>>>>>>>> this.timer = null;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //pub/sub events
> >>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
> >>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
> >>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.postCreate = function() {
> >>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
> >>>>>>>>>>>>>>>>>>> self.timer = new
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> dojo.animation.Timer(self.frequency);
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //start the timer
> >>>>>>>>>>>>>>>>>>> if(self.startTimer) {
> >>>>>>>>>>>>>>>>>>> //start after delay
> >>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay
> );
> >>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> self.startTimer);
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> //attach listeners
> >>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics))
> {
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> self.refreshListenTopics
> >>>>>> );
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(
> self.refreshListenTopics,
> >>>>>>>>>>>>>>>>>>> self, "reloadContents");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics
> ))
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> {
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> self.stopTimerListenTopics);
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self, "stopTimer");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>> self.startTimerListenTopics
> >>>>>>>> );
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
> >>>>>> ,
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>>>>>>>>>>>>>> self, "startTimer");
> >>>>>>>>>>>>>>>>>>> }
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
> >>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
> >>>>>>>>>>>>>>>>>>> self.isLoaded = false;
> >>>>>>>>>>>>>>>>>>> self.loadContents();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
> >>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
> >>>>>>>>>>>>>>>>>>> self.timer.stop();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> this.startTimer = function() {
> >>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
> >>>>>>>>>>>>>>>>>>> self.frequency);
> >>>>>>>>>>>>>>>>>>> self.timer.start();
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>> };
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
> >>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
> >>>>>>>>>>>>>>>>>>>
>
> === message truncated ===
>
>
> ---------------------------------
> Copy addresses and emails from any email account to Yahoo! Mail - quick,
> easy and free. Do it now...
>
--
"Hey you! Would you help me to carry the stone?" Pink Floyd
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi Ian,
> Have we cut the 2.0.1 beta yet?
I think we have the 2.0.1 release, its now open for quality voting. If we do another release it would be 2.0.2. So i guess the answer would be "yes". Do correct me if I am wrong, Ted, Don :-)
> My preference would also be to have the dojo 0.4
> update, together with all the existing tags working with 0.4 available,
> but to commit them separately. This way we only need to fix bugs,
> rather than convert failing UI widgets that the user community may be
> relying on.
I think Musachy have converted all of them, just that they are not commited yet. If we are to do it this way, i guess we'll need Musachy to have all the patches ready. Then we could upgrade dojo to 0.4 in one commit, and one commit for each widget/component etc.
Thoughts?
Ian Roughley <ia...@fdar.com> wrote: Sorry for the late reply - vacation.
Have we cut the 2.0.1 beta yet? If not, we should wait until then
before this update. My preference would also be to have the dojo 0.4
update, together with all the existing tags working with 0.4 available,
but to commit them separately. This way we only need to fix bugs,
rather than convert failing UI widgets that the user community may be
relying on.
/Ian
--
>From Down & Around, Inc.
Innovative IT Solutions
Software Architecture * Design * Development
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
web: www.fdar.com
email ian@fdar.com
phone: 617.821.5430
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tm jee wrote:
> Hi guys,
>
> If its ok with everyone, I'd like to upgrade Struts2 dojo js to 0.4, sometime today or tomorrow. (WW-1845). This will most likely breaks some existing struts2 components. We will patch them up individually (WW-1844)
>
> Cheers
>
>
> tm jee wrote: Done, 2 jira ticket created
>
> http://issues.apache.org/struts/browse/WW-1484
> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>
> http://issues.apache.org/struts/browse/WW-1485
> - upgrading Struts2 dojo to 0.4
>
> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> today I think).
>
> musachy
>
> tm jee wrote:
>
>>> I'm using defineWidget, and it is cool.
>>>
>>>
>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>
>>
>>
>>> I will be looking into hostedqa
>>>
>>>
>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>
>> Cheers.
>>
>>
>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>> given that it is being used in struts already, as per Don's comment
>> somewhere on this thread.
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>> Hi guys,
>>>
>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>
>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>
>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>
>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>
>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>
>>> What you guys think? :-)
>>>
>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>> the tags separately.
>>>
>>> just let me know, when you are done :)
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>
>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>
>>>> musachy
>>>>
>>>> Martin Cooper wrote:
>>>>
>>>>
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>
>>>>>>
>>>>>>
>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>> should be
>>>>> a separate commit.
>>>>>
>>>>> By the way, do we have a Jira
>>>>>
>>>>>
>>>>>
>>>>>> issue for the dojo upgrade?
>>>>>>
>>>>>>
>>>>>>
>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>> there
>>>>> isn't one already.
>>>>>
>>>>> --
>>>>> Martin.
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>
>>>>>
>>>>>> Martin Cooper wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Hi Rainer
>>>>>>>>
>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> patch
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> new
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> 0.4. If
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> commits, so
>>>>>>
>>>>>>
>>>>>>
>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>> one or
>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>
>>>>>>> --
>>>>>>> Martin Cooper
>>>>>>>
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Musachy,
>>>>>>>>>
>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> during the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> week.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> 0.4release,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> I could apply those as well.
>>>>>>>>>
>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Rainer
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> patches to
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>> Dojo?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> you
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>> replace
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>
>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> know
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> patch
>>>>>> :)
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> ).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>> break
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> need
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> when
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> 0.3)?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> posted a
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> reason
>>>>>> we
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> "handler"
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> (dojo's
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> doesn't
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.startTimer);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.refreshListenTopics
>>>>>> );
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.startTimerListenTopics
>>>>>>>> );
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>> ,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
=== message truncated ===
---------------------------------
Copy addresses and emails from any email account to Yahoo! Mail - quick, easy and free. Do it now...
Re: ajax tags
Posted by Ian Roughley <ia...@fdar.com>.
Sorry for the late reply - vacation.
Have we cut the 2.0.1 beta yet? If not, we should wait until then
before this update. My preference would also be to have the dojo 0.4
update, together with all the existing tags working with 0.4 available,
but to commit them separately. This way we only need to fix bugs,
rather than convert failing UI widgets that the user community may be
relying on.
/Ian
--
>From Down & Around, Inc.
Innovative IT Solutions
Software Architecture * Design * Development
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
web: www.fdar.com
email ian@fdar.com
phone: 617.821.5430
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tm jee wrote:
> Hi guys,
>
> If its ok with everyone, I'd like to upgrade Struts2 dojo js to 0.4, sometime today or tomorrow. (WW-1845). This will most likely breaks some existing struts2 components. We will patch them up individually (WW-1844)
>
> Cheers
>
>
> tm jee <tm...@yahoo.co.uk> wrote: Done, 2 jira ticket created
>
> http://issues.apache.org/struts/browse/WW-1484
> - upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
>
> http://issues.apache.org/struts/browse/WW-1485
> - upgrading Struts2 dojo to 0.4
>
> Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
> another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
> today I think).
>
> musachy
>
> tm jee wrote:
>
>>> I'm using defineWidget, and it is cool.
>>>
>>>
>> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>>
>>
>>
>>> I will be looking into hostedqa
>>>
>>>
>> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>>
>> Cheers.
>>
>>
>> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
>> given that it is being used in struts already, as per Don's comment
>> somewhere on this thread.
>>
>> musachy
>>
>> tm jee wrote:
>>
>>
>>> Hi guys,
>>>
>>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>>
>>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>>
>>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>>
>>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>>
>>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>>
>>> What you guys think? :-)
>>>
>>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>>> As soon as I get it, I'll update Dojo first and commit your patches for
>>> the tags separately.
>>>
>>> just let me know, when you are done :)
>>> tia,
>>> Rainer
>>>
>>>
>>>
>>>
>>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>>
>>>> musachy
>>>>
>>>> Martin Cooper wrote:
>>>>
>>>>
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Oh, ok. Then just don't apply the patch.
>>>>>>
>>>>>>
>>>>>>
>>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>>> should be
>>>>> a separate commit.
>>>>>
>>>>> By the way, do we have a Jira
>>>>>
>>>>>
>>>>>
>>>>>> issue for the dojo upgrade?
>>>>>>
>>>>>>
>>>>>>
>>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>>> there
>>>>> isn't one already.
>>>>>
>>>>> --
>>>>> Martin.
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>
>>>>>
>>>>>> Martin Cooper wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Hi Rainer
>>>>>>>>
>>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> patch
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> new
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> 0.4. If
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> commits, so
>>>>>>
>>>>>>
>>>>>>
>>>>>>> that we can track the changes separately, and so that we can revert
>>>>>>> one or
>>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>>> prospective committer to determine timing. ;-)
>>>>>>>
>>>>>>> --
>>>>>>> Martin Cooper
>>>>>>>
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Rainer Hermanns wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Musachy,
>>>>>>>>>
>>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> during the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> week.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> 0.4release,
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> I could apply those as well.
>>>>>>>>>
>>>>>>>>> What do you (and others of course) think?
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Rainer
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> patches to
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>> Dojo?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> you
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>> replace
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>>
>>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> know
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> patch
>>>>>> :)
>>>>>>
>>>>>>
>>>>>>
>>>>>>>> ).
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>> break
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> need
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> want
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> when
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>> 0.3)?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> posted a
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> reason
>>>>>> we
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> "handler"
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> (dojo's
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> doesn't
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> dojo.animation.Timer(self.frequency);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.startTimer);
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> self.refreshListenTopics
>>>>>> );
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.stopTimerListenTopics);
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>> self.startTimerListenTopics
>>>>>>>> );
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>>> ,
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> need to
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> PanelTag
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> wraps
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>> should
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>> refresh.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> in. Try
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> wrappers
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> was no
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> that
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> is the
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> tabs
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>> being
>>>>>>
>>>>>>
>>>>>>
>>>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> converting
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>>
>>>>>>>>
>
> === message truncated ===
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi guys,
If its ok with everyone, I'd like to upgrade Struts2 dojo js to 0.4, sometime today or tomorrow. (WW-1845). This will most likely breaks some existing struts2 components. We will patch them up individually (WW-1844)
Cheers
tm jee <tm...@yahoo.co.uk> wrote: Done, 2 jira ticket created
http://issues.apache.org/struts/browse/WW-1484
- upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
http://issues.apache.org/struts/browse/WW-1485
- upgrading Struts2 dojo to 0.4
Musachy Barroso wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
today I think).
musachy
tm jee wrote:
>> I'm using defineWidget, and it is cool.
>>
> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>
>
>> I will be looking into hostedqa
>>
> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>
> Cheers.
>
>
> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
> given that it is being used in struts already, as per Don's comment
> somewhere on this thread.
>
> musachy
>
> tm jee wrote:
>
>> Hi guys,
>>
>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>
>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>
>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>
>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>
>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>
>> What you guys think? :-)
>>
>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>> As soon as I get it, I'll update Dojo first and commit your patches for
>> the tags separately.
>>
>> just let me know, when you are done :)
>> tia,
>> Rainer
>>
>>
>>
>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>
>>> musachy
>>>
>>> Martin Cooper wrote:
>>>
>>>
>>>> On 10/30/06, Musachy Barroso wrote:
>>>>
>>>>
>>>>> Oh, ok. Then just don't apply the patch.
>>>>>
>>>>>
>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>> should be
>>>> a separate commit.
>>>>
>>>> By the way, do we have a Jira
>>>>
>>>>
>>>>> issue for the dojo upgrade?
>>>>>
>>>>>
>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>> there
>>>> isn't one already.
>>>>
>>>> --
>>>> Martin.
>>>>
>>>>
>>>> musachy
>>>>
>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>> Hi Rainer
>>>>>>>
>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>
>>>>>>>
>>>>> patch
>>>>>
>>>>>
>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>
>>>>>>>
>>>>> new
>>>>>
>>>>>
>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>
>>>>>>>
>>>>> 0.4. If
>>>>>
>>>>>
>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>
>>>>>>>
>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>
>>>>>>
>>>>> commits, so
>>>>>
>>>>>
>>>>>> that we can track the changes separately, and so that we can revert
>>>>>> one or
>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>> prospective committer to determine timing. ;-)
>>>>>>
>>>>>> --
>>>>>> Martin Cooper
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>> Rainer Hermanns wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Musachy,
>>>>>>>>
>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>
>>>>>>>>
>>>>> during the
>>>>>
>>>>>
>>>>>>> week.
>>>>>>>
>>>>>>>
>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>
>>>>>>>>
>>>>>>> 0.4release,
>>>>>>>
>>>>>>>
>>>>>>>> I could apply those as well.
>>>>>>>>
>>>>>>>> What do you (and others of course) think?
>>>>>>>>
>>>>>>>> regards,
>>>>>>>> Rainer
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> Don Brown wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>
>>>>>>>>>>
>>>>> patches to
>>>>>
>>>>>
>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> Dojo?
>>>>>>>
>>>>>>>
>>>>>>>>>> Don
>>>>>>>>>>
>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> you
>>>>>
>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>> replace
>>>>>>>
>>>>>>>
>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>
>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> know
>>>>>
>>>>>
>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> patch
>>>>> :)
>>>>>
>>>>>
>>>>>>> ).
>>>>>>>
>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> break
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>> need
>>>>>
>>>>>
>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>> when
>>>>>
>>>>>
>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> 0.3)?
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>> posted a
>>>>>
>>>>>
>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>> reason
>>>>> we
>>>>>
>>>>>
>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> "handler"
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> (dojo's
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> doesn't
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> dojo.animation.Timer(self.frequency);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.startTimer);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.refreshListenTopics
>>>>> );
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.stopTimerListenTopics);
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.startTimerListenTopics
>>>>>>> );
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>> ,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> need to
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> PanelTag
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> wraps
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> should
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> refresh.
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> in. Try
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> wrappers
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> was no
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> that
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> is the
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> tabs
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> being
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> converting
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
=== message truncated ===
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Done, 2 jira ticket created
http://issues.apache.org/struts/browse/WW-1484
- upgrading Struts2 dojo widget that might failed due to upgrading dojo to 0.4
http://issues.apache.org/struts/browse/WW-1485
- upgrading Struts2 dojo to 0.4
Musachy Barroso <mb...@wfscorp.com> wrote: yes, I overwrote those bindXs with defineWidget. We are going to need
another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
today I think).
musachy
tm jee wrote:
>> I'm using defineWidget, and it is cool.
>>
> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>
>
>> I will be looking into hostedqa
>>
> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>
> Cheers.
>
>
> Musachy Barroso wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
> given that it is being used in struts already, as per Don's comment
> somewhere on this thread.
>
> musachy
>
> tm jee wrote:
>
>> Hi guys,
>>
>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>
>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>
>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>
>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>
>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>
>> What you guys think? :-)
>>
>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>> As soon as I get it, I'll update Dojo first and commit your patches for
>> the tags separately.
>>
>> just let me know, when you are done :)
>> tia,
>> Rainer
>>
>>
>>
>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>
>>> musachy
>>>
>>> Martin Cooper wrote:
>>>
>>>
>>>> On 10/30/06, Musachy Barroso wrote:
>>>>
>>>>
>>>>> Oh, ok. Then just don't apply the patch.
>>>>>
>>>>>
>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>> should be
>>>> a separate commit.
>>>>
>>>> By the way, do we have a Jira
>>>>
>>>>
>>>>> issue for the dojo upgrade?
>>>>>
>>>>>
>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>> there
>>>> isn't one already.
>>>>
>>>> --
>>>> Martin.
>>>>
>>>>
>>>> musachy
>>>>
>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>> Hi Rainer
>>>>>>>
>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>
>>>>>>>
>>>>> patch
>>>>>
>>>>>
>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>
>>>>>>>
>>>>> new
>>>>>
>>>>>
>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>
>>>>>>>
>>>>> 0.4. If
>>>>>
>>>>>
>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>
>>>>>>>
>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>
>>>>>>
>>>>> commits, so
>>>>>
>>>>>
>>>>>> that we can track the changes separately, and so that we can revert
>>>>>> one or
>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>> prospective committer to determine timing. ;-)
>>>>>>
>>>>>> --
>>>>>> Martin Cooper
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>> Rainer Hermanns wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Musachy,
>>>>>>>>
>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>
>>>>>>>>
>>>>> during the
>>>>>
>>>>>
>>>>>>> week.
>>>>>>>
>>>>>>>
>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>
>>>>>>>>
>>>>>>> 0.4release,
>>>>>>>
>>>>>>>
>>>>>>>> I could apply those as well.
>>>>>>>>
>>>>>>>> What do you (and others of course) think?
>>>>>>>>
>>>>>>>> regards,
>>>>>>>> Rainer
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> Don Brown wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>
>>>>>>>>>>
>>>>> patches to
>>>>>
>>>>>
>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> Dojo?
>>>>>>>
>>>>>>>
>>>>>>>>>> Don
>>>>>>>>>>
>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> you
>>>>>
>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>> replace
>>>>>>>
>>>>>>>
>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>
>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> know
>>>>>
>>>>>
>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> patch
>>>>> :)
>>>>>
>>>>>
>>>>>>> ).
>>>>>>>
>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> break
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>> need
>>>>>
>>>>>
>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>> when
>>>>>
>>>>>
>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> 0.3)?
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>> posted a
>>>>>
>>>>>
>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>> reason
>>>>> we
>>>>>
>>>>>
>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> "handler"
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> (dojo's
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> doesn't
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> dojo.animation.Timer(self.frequency);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.startTimer);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.refreshListenTopics
>>>>> );
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.stopTimerListenTopics);
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.startTimerListenTopics
>>>>>>> );
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>> ,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> need to
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> PanelTag
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> wraps
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> should
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> refresh.
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> in. Try
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> wrappers
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> was no
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> that
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> is the
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> tabs
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> being
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> converting
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> dev-unsubscribe@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
=== message truncated ===
---------------------------------
All new Yahoo! Mail "The new Interface is stunning in its simplicity and ease of use." - PC Magazine
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
yes, I overwrote those bindXs with defineWidget. We are going to need
another bug for the actual upgrade from dojo 0.3 to 0.4(0.4 was released
today I think).
musachy
tm jee wrote:
>> I'm using defineWidget, and it is cool.
>>
> Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
>
>
>> I will be looking into hostedqa
>>
> You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
>
> Cheers.
>
>
> Musachy Barroso <mu...@gmail.com> wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
> given that it is being used in struts already, as per Don's comment
> somewhere on this thread.
>
> musachy
>
> tm jee wrote:
>
>> Hi guys,
>>
>> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>>
>> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>>
>> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>>
>> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>>
>> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>>
>> What you guys think? :-)
>>
>> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
>> As soon as I get it, I'll update Dojo first and commit your patches for
>> the tags separately.
>>
>> just let me know, when you are done :)
>> tia,
>> Rainer
>>
>>
>>
>>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>>
>>> musachy
>>>
>>> Martin Cooper wrote:
>>>
>>>
>>>> On 10/30/06, Musachy Barroso wrote:
>>>>
>>>>
>>>>> Oh, ok. Then just don't apply the patch.
>>>>>
>>>>>
>>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>>> should be
>>>> a separate commit.
>>>>
>>>> By the way, do we have a Jira
>>>>
>>>>
>>>>> issue for the dojo upgrade?
>>>>>
>>>>>
>>>> Not that I can see. Feel free to add one, and one with your patch, if
>>>> there
>>>> isn't one already.
>>>>
>>>> --
>>>> Martin.
>>>>
>>>>
>>>> musachy
>>>>
>>>>
>>>>> Martin Cooper wrote:
>>>>>
>>>>>
>>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>>
>>>>>>
>>>>>>> Hi Rainer
>>>>>>>
>>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>>
>>>>>>>
>>>>> patch
>>>>>
>>>>>
>>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>>
>>>>>>>
>>>>> new
>>>>>
>>>>>
>>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>>
>>>>>>>
>>>>> 0.4. If
>>>>>
>>>>>
>>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>>
>>>>>>>
>>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>>
>>>>>>
>>>>> commits, so
>>>>>
>>>>>
>>>>>> that we can track the changes separately, and so that we can revert
>>>>>> one or
>>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>>> prospective committer to determine timing. ;-)
>>>>>>
>>>>>> --
>>>>>> Martin Cooper
>>>>>>
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>>
>>>>>>> Rainer Hermanns wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Musachy,
>>>>>>>>
>>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>>
>>>>>>>>
>>>>> during the
>>>>>
>>>>>
>>>>>>> week.
>>>>>>>
>>>>>>>
>>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>>
>>>>>>>>
>>>>>>> 0.4release,
>>>>>>>
>>>>>>>
>>>>>>>> I could apply those as well.
>>>>>>>>
>>>>>>>> What do you (and others of course) think?
>>>>>>>>
>>>>>>>> regards,
>>>>>>>> Rainer
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> Don Brown wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>>
>>>>>>>>>>
>>>>> patches to
>>>>>
>>>>>
>>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>>
>>>>>>>>>>
>>>>>>> Dojo?
>>>>>>>
>>>>>>>
>>>>>>>>>> Don
>>>>>>>>>>
>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> you
>>>>>
>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>> replace
>>>>>>>
>>>>>>>
>>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>>
>>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> know
>>>>>
>>>>>
>>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>>
>>>>>>>>>>>
>>>>> patch
>>>>> :)
>>>>>
>>>>>
>>>>>>> ).
>>>>>>>
>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>>
>>>>>>>>>>>> Don
>>>>>>>>>>>>
>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> break
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>>
>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>> need
>>>>>
>>>>>
>>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> want
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>> when
>>>>>
>>>>>
>>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> 0.3)?
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>> posted a
>>>>>
>>>>>
>>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>> reason
>>>>> we
>>>>>
>>>>>
>>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> "handler"
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> (dojo's
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> doesn't
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> dojo.animation.Timer(self.frequency);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.startTimer);
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> self.refreshListenTopics
>>>>> );
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.stopTimerListenTopics);
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> self.startTimerListenTopics
>>>>>>> );
>>>>>>>
>>>>>>>
>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>>> ,
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> need to
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> PanelTag
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> wraps
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> should
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> refresh.
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> in. Try
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> wrappers
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> was no
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> that
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> is the
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> tabs
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>> being
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> converting
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> dev-unsubscribe@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>> dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> dev-unsubscribe@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>> dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>> dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>> dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>
>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>
>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>> Send instant messages to your online friends http://uk.messenger.yahoo.com
>>
>>
>
> ---------------------------------------------------------------------
>
> === message truncated ===
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
> I'm using defineWidget, and it is cool.
Yup. Is it that the bind, binddiv, bindanchor etc have been written with dojo.widget.defineWidget? If so, this would be great. :-) I've converter the bind component using defineWidget... but looks like it could be deleted now.... :-)
> I will be looking into hostedqa
You could get a free account from Pat at [ plightbo at friendly gmail dot com ]
Cheers.
Musachy Barroso <mu...@gmail.com> wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
given that it is being used in struts already, as per Don's comment
somewhere on this thread.
musachy
tm jee wrote:
> Hi guys,
>
> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>
> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>
> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>
> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>
> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>
> What you guys think? :-)
>
> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> As soon as I get it, I'll update Dojo first and commit your patches for
> the tags separately.
>
> just let me know, when you are done :)
> tia,
> Rainer
>
>
>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>
>> musachy
>>
>> Martin Cooper wrote:
>>
>>> On 10/30/06, Musachy Barroso wrote:
>>>
>>>> Oh, ok. Then just don't apply the patch.
>>>>
>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>> should be
>>> a separate commit.
>>>
>>> By the way, do we have a Jira
>>>
>>>> issue for the dojo upgrade?
>>>>
>>> Not that I can see. Feel free to add one, and one with your patch, if
>>> there
>>> isn't one already.
>>>
>>> --
>>> Martin.
>>>
>>>
>>> musachy
>>>
>>>> Martin Cooper wrote:
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>> Hi Rainer
>>>>>>
>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>
>>>> patch
>>>>
>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>
>>>> new
>>>>
>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>
>>>> 0.4. If
>>>>
>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>
>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>
>>>> commits, so
>>>>
>>>>> that we can track the changes separately, and so that we can revert
>>>>> one or
>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>> prospective committer to determine timing. ;-)
>>>>>
>>>>> --
>>>>> Martin Cooper
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>> Rainer Hermanns wrote:
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>
>>>> during the
>>>>
>>>>>> week.
>>>>>>
>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>
>>>>>> 0.4release,
>>>>>>
>>>>>>> I could apply those as well.
>>>>>>>
>>>>>>> What do you (and others of course) think?
>>>>>>>
>>>>>>> regards,
>>>>>>> Rainer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>
>>>> patches to
>>>>
>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>
>>>>>> Dojo?
>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>
>>>> you
>>>>
>>>>>> want
>>>>>>
>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>
>>>>>> replace
>>>>>>
>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>
>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>
>>>> know
>>>>
>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>
>>>> patch
>>>> :)
>>>>
>>>>>> ).
>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>
>>>>>> break
>>>>>>
>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>
>>>> need
>>>>
>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>
>>>>>> want
>>>>>>
>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>
>>>> when
>>>>
>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>
>>>>>> 0.3)?
>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>
>>>> posted a
>>>>
>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>
>>>> reason
>>>> we
>>>>
>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>
>>>> "handler"
>>>>
>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>
>>>>>> (dojo's
>>>>>>
>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>
>>>> doesn't
>>>>
>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>
>>>> dojo.animation.Timer(self.frequency);
>>>>
>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>
>>>> self.startTimer);
>>>>
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>> self.refreshListenTopics
>>>> );
>>>>
>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>
>>>> {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.stopTimerListenTopics);
>>>>>>
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>
>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.startTimerListenTopics
>>>>>> );
>>>>>>
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>> ,
>>>>
>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>
>>>>>> need to
>>>>>>
>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>
>>>> PanelTag
>>>>
>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>
>>>> wraps
>>>>
>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>
>>>> should
>>>>
>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>
>>>>>> refresh.
>>>>>>
>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>
>>>> in. Try
>>>>
>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>
>>>>>> wrappers
>>>>>>
>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>
>>>>>> was no
>>>>>>
>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>
>>>>>> that
>>>>>>
>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>
>>>> is the
>>>>
>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>
>>>> tabs
>>>>
>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>
>>>> being
>>>>
>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>
>>>>>> converting
>>>>>>
>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
=== message truncated ===
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi guys,
I've go ahead and added a jira issue for struts2 dojo migration, Its at http://issues.apache.org/struts/browse/WW-1484
rgds
Musachy Barroso <mu...@gmail.com> wrote: I'm using defineWidget, and it is cool. I will be looking into hostedqa
given that it is being used in struts already, as per Don's comment
somewhere on this thread.
musachy
tm jee wrote:
> Hi guys,
>
> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>
> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>
> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>
> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>
> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>
> What you guys think? :-)
>
> Rainer Hermanns wrote: I'll wait for your patch against 0.4 then.
> As soon as I get it, I'll update Dojo first and commit your patches for
> the tags separately.
>
> just let me know, when you are done :)
> tia,
> Rainer
>
>
>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>
>> musachy
>>
>> Martin Cooper wrote:
>>
>>> On 10/30/06, Musachy Barroso wrote:
>>>
>>>> Oh, ok. Then just don't apply the patch.
>>>>
>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>> should be
>>> a separate commit.
>>>
>>> By the way, do we have a Jira
>>>
>>>> issue for the dojo upgrade?
>>>>
>>> Not that I can see. Feel free to add one, and one with your patch, if
>>> there
>>> isn't one already.
>>>
>>> --
>>> Martin.
>>>
>>>
>>> musachy
>>>
>>>> Martin Cooper wrote:
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>> Hi Rainer
>>>>>>
>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>
>>>> patch
>>>>
>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>
>>>> new
>>>>
>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>
>>>> 0.4. If
>>>>
>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>
>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>
>>>> commits, so
>>>>
>>>>> that we can track the changes separately, and so that we can revert
>>>>> one or
>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>> prospective committer to determine timing. ;-)
>>>>>
>>>>> --
>>>>> Martin Cooper
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>> Rainer Hermanns wrote:
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>
>>>> during the
>>>>
>>>>>> week.
>>>>>>
>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>
>>>>>> 0.4release,
>>>>>>
>>>>>>> I could apply those as well.
>>>>>>>
>>>>>>> What do you (and others of course) think?
>>>>>>>
>>>>>>> regards,
>>>>>>> Rainer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>
>>>> patches to
>>>>
>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>
>>>>>> Dojo?
>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>
>>>> you
>>>>
>>>>>> want
>>>>>>
>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>
>>>>>> replace
>>>>>>
>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>
>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>
>>>> know
>>>>
>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>
>>>> patch
>>>> :)
>>>>
>>>>>> ).
>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>
>>>>>> break
>>>>>>
>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>
>>>> need
>>>>
>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>
>>>>>> want
>>>>>>
>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>
>>>> when
>>>>
>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>
>>>>>> 0.3)?
>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>
>>>> posted a
>>>>
>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>
>>>> reason
>>>> we
>>>>
>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>
>>>> "handler"
>>>>
>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>
>>>>>> (dojo's
>>>>>>
>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>
>>>> doesn't
>>>>
>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>
>>>> dojo.animation.Timer(self.frequency);
>>>>
>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>
>>>> self.startTimer);
>>>>
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>> self.refreshListenTopics
>>>> );
>>>>
>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>
>>>> {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.stopTimerListenTopics);
>>>>>>
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>
>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.startTimerListenTopics
>>>>>> );
>>>>>>
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>> ,
>>>>
>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>
>>>>>> need to
>>>>>>
>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>
>>>> PanelTag
>>>>
>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>
>>>> wraps
>>>>
>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>
>>>> should
>>>>
>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>
>>>>>> refresh.
>>>>>>
>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>
>>>> in. Try
>>>>
>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>
>>>>>> wrappers
>>>>>>
>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>
>>>>>> was no
>>>>>>
>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>
>>>>>> that
>>>>>>
>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>
>>>> is the
>>>>
>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>
>>>> tabs
>>>>
>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>
>>>> being
>>>>
>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>
>>>>>> converting
>>>>>>
>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
=== message truncated ===
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
I'm using defineWidget, and it is cool. I will be looking into hostedqa
given that it is being used in struts already, as per Don's comment
somewhere on this thread.
musachy
tm jee wrote:
> Hi guys,
>
> sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
>
> - use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
>
> - have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
>
> - have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
>
> - have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
>
> What you guys think? :-)
>
> Rainer Hermanns <he...@aixcept.de> wrote: I'll wait for your patch against 0.4 then.
> As soon as I get it, I'll update Dojo first and commit your patches for
> the tags separately.
>
> just let me know, when you are done :)
> tia,
> Rainer
>
>
>> :) I know. What I meant is that it shouldn't be applied yet 'cause I
>> made it using 0.3 and I haven't tried it on 0.4 yet.
>>
>> musachy
>>
>> Martin Cooper wrote:
>>
>>> On 10/30/06, Musachy Barroso wrote:
>>>
>>>> Oh, ok. Then just don't apply the patch.
>>>>
>>> No, no - I'm not saying that it shouldn't be applied, only that it
>>> should be
>>> a separate commit.
>>>
>>> By the way, do we have a Jira
>>>
>>>> issue for the dojo upgrade?
>>>>
>>> Not that I can see. Feel free to add one, and one with your patch, if
>>> there
>>> isn't one already.
>>>
>>> --
>>> Martin.
>>>
>>>
>>> musachy
>>>
>>>> Martin Cooper wrote:
>>>>
>>>>> On 10/30/06, Musachy Barroso wrote:
>>>>>
>>>>>> Hi Rainer
>>>>>>
>>>>>> Give me a couple of days so I can test it against 0.4 (I made the
>>>>>>
>>>> patch
>>>>
>>>>>> using 0.3) and finish some changes(for BindButton) that I have for a
>>>>>>
>>>> new
>>>>
>>>>>> patch. I will give you a new patch soon with the changes for Bind,
>>>>>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>>>>>
>>>> 0.4. If
>>>>
>>>>>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>>>>> that's fine. (I will just be bothering with another patch soon :) )
>>>>>>
>>>>> Well, the upgrade and the patch should certainly be separate
>>>>>
>>>> commits, so
>>>>
>>>>> that we can track the changes separately, and so that we can revert
>>>>> one or
>>>>> the other if that ever becomes necessary. Beyond that, it's up to the
>>>>> prospective committer to determine timing. ;-)
>>>>>
>>>>> --
>>>>> Martin Cooper
>>>>>
>>>>>
>>>>> musachy
>>>>>
>>>>>> Rainer Hermanns wrote:
>>>>>>
>>>>>>> Musachy,
>>>>>>>
>>>>>>> I could upgrade the embedded Dojo files to the 0.4 release
>>>>>>>
>>>> during the
>>>>
>>>>>> week.
>>>>>>
>>>>>>> If your patches for the s2 ajax tags already are against the
>>>>>>>
>>>>>> 0.4release,
>>>>>>
>>>>>>> I could apply those as well.
>>>>>>>
>>>>>>> What do you (and others of course) think?
>>>>>>>
>>>>>>> regards,
>>>>>>> Rainer
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Any idea on when is Dojo going to be bumped up to 0.4?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>>>>>>>>
>>>> patches to
>>>>
>>>>>>>>> update the tags. How much work do you think it'll be to upgrade
>>>>>>>>>
>>>>>> Dojo?
>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> I attached a new patch to WW-205, this one includes the new
>>>>>>>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>>>>>>>>>
>>>> you
>>>>
>>>>>> want
>>>>>>
>>>>>>>>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>>>>>>>>>
>>>>>> replace
>>>>>>
>>>>>>>>>> dojo distribution under static/dojo.)
>>>>>>>>>>
>>>>>>>>>> I modified the examples in showcase and the test cases. Let me
>>>>>>>>>>
>>>> know
>>>>
>>>>>>>>>> if something is missing or wrong (bear with me on my first
>>>>>>>>>>
>>>> patch
>>>> :)
>>>>
>>>>>> ).
>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>>>>>>>
>>>>>>>>>>> Don
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> That's ok, the only problem is that this one by itself would
>>>>>>>>>>>>
>>>>>> break
>>>>>>
>>>>>>>>>>>> anchor and tabbed panel.
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>>>>>>>>>>>>
>>>> need
>>>>
>>>>>>>>>>>>> to use it more.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Don
>>>>>>>>>>>>>
>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>>>>>>>>>>>>>
>>>>>> want
>>>>>>
>>>>>>>>>>>>>> me to create a patch for it, or wait and create a big one
>>>>>>>>>>>>>>
>>>> when
>>>>
>>>>>>>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>>>>>>>>>>>>>
>>>>>> 0.3)?
>>>>>>
>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>>>>>>>> (Selenium maybe?)
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> This was with 0.3.1 which is the current release. I
>>>>>>>>>>>>>>>
>>>> posted a
>>>>
>>>>>>>>>>>>>>> message on their mailing list.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Don Brown wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>>>>>>>>>>>>>>>
>>>> reason
>>>> we
>>>>
>>>>>>>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Don
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>>>>>>>>>>>>>>>>
>>>> "handler"
>>>>
>>>>>>>>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>>>>>>>>>>>>>>>>
>>>>>> (dojo's
>>>>>>
>>>>>>>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>>>>>>>> (doesn't add anything to this one). By the way this
>>>>>>>>>>>>>>>>>
>>>> doesn't
>>>>
>>>>>>>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>>>>>>>> var self = this;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.href = "";
>>>>>>>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //pub/sub events
>>>>>>>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>>>>>>>> self.timer = new
>>>>>>>>>>>>>>>>>
>>>> dojo.animation.Timer(self.frequency);
>>>>
>>>>>>>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //start the timer
>>>>>>>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>>>>>>>> //start after delay
>>>>>>>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>>>>>>>>>>>>>>>>
>>>> self.startTimer);
>>>>
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> //attach listeners
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>> self.refreshListenTopics
>>>> );
>>>>
>>>>>>>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>>>>>>>>>>>>>>>>
>>>> {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.stopTimerListenTopics);
>>>>>>
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>
>>>>>>>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>
>>>>>>>>>>>>>>>>> dojo.debug("Listening to " +
>>>>>>>>>>>>>>>>>
>>>>>> self.startTimerListenTopics
>>>>>> );
>>>>>>
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>>> ,
>>>>
>>>>>>>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>>>>>>>> }
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>>>>>>>> self.loadContents();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>>>>>>>> self.frequency);
>>>>>>>>>>>>>>>>> self.timer.start();
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>> };
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>>>>>>>>>>>>>>>>>
>>>>>> need to
>>>>>>
>>>>>>>>>>>>>>>>>> do some changes, right now Panel extends Div and
>>>>>>>>>>>>>>>>>>
>>>> PanelTag
>>>>
>>>>>>>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>>>>>>>>>>>>>>>>>
>>>> wraps
>>>>
>>>>>>>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>>>>>>>> struts), and they are quite different. I think we
>>>>>>>>>>>>>>>>>>
>>>> should
>>>>
>>>>>>>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>>>>>>>>>>>>>>>>>
>>>>>> refresh.
>>>>>>
>>>>>>>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> musachy
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>>>>>>>>>>>>>>>>>>
>>>> in. Try
>>>>
>>>>>>>>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>>>>>>>>>>>>>>>>>>
>>>>>> wrappers
>>>>>>
>>>>>>>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>>>>>>>>>>>>>>>>>>
>>>>>> was no
>>>>>>
>>>>>>>>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>>>>>>>>>>>>>>>>>>
>>>>>> that
>>>>>>
>>>>>>>>>>>>>>>>>>> you should check that has been implemented in dojo
>>>>>>>>>>>>>>>>>>>
>>>> is the
>>>>
>>>>>>>>>>>>>>>>>>> pub/sub events - so there should be events that each
>>>>>>>>>>>>>>>>>>>
>>>> tabs
>>>>
>>>>>>>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>>>>>>>>>>>>>>>>>>
>>>> being
>>>>
>>>>>>>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> The other big thing that would be a great help is
>>>>>>>>>>>>>>>>>>>
>>>>>> converting
>>>>>>
>>>>>>>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-unsubscribe@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>>>>>>>
>>>> dev-help@struts.apache.org
>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by tm jee <tm...@yahoo.co.uk>.
Hi guys,
sorry for jumping into this late. I think we should do the followings for struts2 dojo widgets.
- use dojo.widget.defineWidget instead of the old-way of using dojo.provide, dojo.extends etc. Dojo got most of its widget rewritten using this way.
- have struts2 widgets/utils as a separate module and add them in using dojo.setModulePrefix(...) (0.3) I think the method is renamed in 0.4 and the concept of module is namespace in 0.4
- have javadoc comments in our widget, hopefully it would be easier to follow and maybe if possible able to generate docs like http://dojotoolkit.org/api But I am not sure about how to do this yet. Definitely interested in finding out more.
- have a test folder, like dojo's where we could have pages that test the widget, we could use Pat's product to do test the pages (something like HostedQA or Selenium)
What you guys think? :-)
Rainer Hermanns <he...@aixcept.de> wrote: I'll wait for your patch against 0.4 then.
As soon as I get it, I'll update Dojo first and commit your patches for
the tags separately.
just let me know, when you are done :)
tia,
Rainer
> :) I know. What I meant is that it shouldn't be applied yet 'cause I
> made it using 0.3 and I haven't tried it on 0.4 yet.
>
> musachy
>
> Martin Cooper wrote:
>> On 10/30/06, Musachy Barroso wrote:
>>>
>>> Oh, ok. Then just don't apply the patch.
>>
>>
>> No, no - I'm not saying that it shouldn't be applied, only that it
>> should be
>> a separate commit.
>>
>> By the way, do we have a Jira
>>> issue for the dojo upgrade?
>>
>>
>> Not that I can see. Feel free to add one, and one with your patch, if
>> there
>> isn't one already.
>>
>> --
>> Martin.
>>
>>
>> musachy
>>>
>>> Martin Cooper wrote:
>>> > On 10/30/06, Musachy Barroso wrote:
>>> >>
>>> >> Hi Rainer
>>> >>
>>> >> Give me a couple of days so I can test it against 0.4 (I made the
>>> patch
>>> >> using 0.3) and finish some changes(for BindButton) that I have for a
>>> new
>>> >> patch. I will give you a new patch soon with the changes for Bind,
>>> >> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>> 0.4. If
>>> >> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>> >> that's fine. (I will just be bothering with another patch soon :) )
>>> >
>>> >
>>> > Well, the upgrade and the patch should certainly be separate
>>> commits, so
>>> > that we can track the changes separately, and so that we can revert
>>> > one or
>>> > the other if that ever becomes necessary. Beyond that, it's up to the
>>> > prospective committer to determine timing. ;-)
>>> >
>>> > --
>>> > Martin Cooper
>>> >
>>> >
>>> > musachy
>>> >>
>>> >> Rainer Hermanns wrote:
>>> >> > Musachy,
>>> >> >
>>> >> > I could upgrade the embedded Dojo files to the 0.4 release
>>> during the
>>> >> week.
>>> >> > If your patches for the s2 ajax tags already are against the
>>> >> 0.4release,
>>> >> > I could apply those as well.
>>> >> >
>>> >> > What do you (and others of course) think?
>>> >> >
>>> >> > regards,
>>> >> > Rainer
>>> >> >
>>> >> >
>>> >> >> Any idea on when is Dojo going to be bumped up to 0.4?
>>> >> >>
>>> >> >> musachy
>>> >> >>
>>> >> >> Don Brown wrote:
>>> >> >>
>>> >> >>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>> patches to
>>> >> >>> update the tags. How much work do you think it'll be to upgrade
>>> >> Dojo?
>>> >> >>>
>>> >> >>> Don
>>> >> >>>
>>> >> >>> Musachy Barroso wrote:
>>> >> >>>
>>> >> >>>> I attached a new patch to WW-205, this one includes the new
>>> >> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>> you
>>> >> want
>>> >> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>> >> replace
>>> >> >>>> dojo distribution under static/dojo.)
>>> >> >>>>
>>> >> >>>> I modified the examples in showcase and the test cases. Let me
>>> know
>>> >> >>>> if something is missing or wrong (bear with me on my first
>>> patch
>>> :)
>>> >> ).
>>> >> >>>>
>>> >> >>>> musachy
>>> >> >>>>
>>> >> >>>> Don Brown wrote:
>>> >> >>>>
>>> >> >>>>> Ok, then put those two under one ticket. You know best :)
>>> >> >>>>>
>>> >> >>>>> Don
>>> >> >>>>>
>>> >> >>>>> Musachy Barroso wrote:
>>> >> >>>>>
>>> >> >>>>>> That's ok, the only problem is that this one by itself would
>>> >> break
>>> >> >>>>>> anchor and tabbed panel.
>>> >> >>>>>>
>>> >> >>>>>> musachy
>>> >> >>>>>>
>>> >> >>>>>> Don Brown wrote:
>>> >> >>>>>>
>>> >> >>>>>>> I'd prefer separate issues, with attached patches. As for
>>> >> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>> need
>>> >> >>>>>>> to use it more.
>>> >> >>>>>>>
>>> >> >>>>>>> Don
>>> >> >>>>>>>
>>> >> >>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>
>>> >> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>> >> want
>>> >> >>>>>>>> me to create a patch for it, or wait and create a big one
>>> when
>>> >> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>> >> 0.3)?
>>> >> >>>>>>>>
>>> >> >>>>>>>> musachy
>>> >> >>>>>>>>
>>> >> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>> >> >>>>>>>> (Selenium maybe?)
>>> >> >>>>>>>>
>>> >> >>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>
>>> >> >>>>>>>>> This was with 0.3.1 which is the current release. I
>>> posted a
>>> >> >>>>>>>>> message on their mailing list.
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> musachy
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> Don Brown wrote:
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>> reason
>>> we
>>> >> >>>>>>>>>> shouldn't upgrade to it?
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> Don
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>> Would something like this include all the current
>>> >> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>> >> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>> "handler"
>>> >> >>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>> >> (dojo's
>>> >> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>> >> >>>>>>>>>>> (doesn't add anything to this one). By the way this
>>> doesn't
>>> >> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.*");
>>> >> >>>>>>>>>>> dojo.require("dojo.io.*");
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.Container");
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>> >> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> struts.widgets.BindDiv = function() {
>>> >> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>> >> >>>>>>>>>>> var self = this;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.widgetType = "BindDiv";
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.href = "";
>>> >> >>>>>>>>>>> this.extractContent = false;
>>> >> >>>>>>>>>>> this.parseContent = false;
>>> >> >>>>>>>>>>> this.cacheContent = false;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.frequency = 0;
>>> >> >>>>>>>>>>> this.delay = 0;
>>> >> >>>>>>>>>>> this.startTimer = false;
>>> >> >>>>>>>>>>> this.timer = null;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //pub/sub events
>>> >> >>>>>>>>>>> this.refreshListenTopics = "";
>>> >> >>>>>>>>>>> this.stopTimerListenTopics = "";
>>> >> >>>>>>>>>>> this.startTimerListenTopics = "";
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.postCreate = function() {
>>> >> >>>>>>>>>>> if(self.frequency > 0) {
>>> >> >>>>>>>>>>> self.timer = new
>>> dojo.animation.Timer(self.frequency);
>>> >> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //start the timer
>>> >> >>>>>>>>>>> if(self.startTimer) {
>>> >> >>>>>>>>>>> //start after delay
>>> >> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>> >> >>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>> self.startTimer);
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //attach listeners
>>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> self.refreshListenTopics
>>> );
>>> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>> >> >>>>>>>>>>> self, "reloadContents");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>> {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> >> self.stopTimerListenTopics);
>>> >> >>>>>>>>>>>
>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>> >> >>>>>>>>>>> self, "stopTimer");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>>
>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> >> self.startTimerListenTopics
>>> >> );
>>> >> >>>>>>>>>>>
>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>> ,
>>> >> >>>>>>>>>>> self, "startTimer");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.reloadContents = function() {
>>> >> >>>>>>>>>>> //refresh is not visible in ContentPane
>>> >> >>>>>>>>>>> self.isLoaded = false;
>>> >> >>>>>>>>>>> self.loadContents();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.stopTimer = function() {
>>> >> >>>>>>>>>>> dojo.debug("stopping timer");
>>> >> >>>>>>>>>>> self.timer.stop();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.startTimer = function() {
>>> >> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>> >> >>>>>>>>>>> self.frequency);
>>> >> >>>>>>>>>>> self.timer.start();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>> >> >>>>>>>>>>> dojo.widget.html.ContentPane);
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>> >> need to
>>> >> >>>>>>>>>>>> do some changes, right now Panel extends Div and
>>> PanelTag
>>> >> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>> wraps
>>> >> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>> >> >>>>>>>>>>>> struts), and they are quite different. I think we
>>> should
>>> >> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>> >> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>> >> refresh.
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> what do you guys think?
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> musachy
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> Ian Roughley wrote:
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>> in. Try
>>> >> >>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>> >> wrappers
>>> >> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>> >> was no
>>> >> >>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>> >> that
>>> >> >>>>>>>>>>>>> you should check that has been implemented in dojo
>>> is the
>>> >> >>>>>>>>>>>>> pub/sub events - so there should be events that each
>>> tabs
>>> >> >>>>>>>>>>>>> listens to to refresh itself.
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>> >> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>> being
>>> >> >>>>>>>>>>>>> done in dojo.
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> The other big thing that would be a great help is
>>> >> converting
>>> >> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Ian
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>
>>> >> >>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>
>>> >> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>>>
>>> >> >>>>>>>>
>>> >> >>>>>>>>
>>> >> >>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>
>>> >> >>>>>
>>> >> >>>>>
>>> >> >>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>
>>> >> >>>>
>>> >> >>>>
>>> >> >>>
>>> >> ---------------------------------------------------------------------
>>> >> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >> >>
>>> ---------------------------------------------------------------------
>>> >> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >
>>> >> >
>>> >> >
>>> ---------------------------------------------------------------------
>>> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> > For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >
>>> >> >
>>> >> >
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> For additional commands, e-mail: dev-help@struts.apache.org
>>> >>
>>> >>
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Send instant messages to your online friends http://uk.messenger.yahoo.com
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
I'll wait for your patch against 0.4 then.
As soon as I get it, I'll update Dojo first and commit your patches for
the tags separately.
just let me know, when you are done :)
tia,
Rainer
> :) I know. What I meant is that it shouldn't be applied yet 'cause I
> made it using 0.3 and I haven't tried it on 0.4 yet.
>
> musachy
>
> Martin Cooper wrote:
>> On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>>
>>> Oh, ok. Then just don't apply the patch.
>>
>>
>> No, no - I'm not saying that it shouldn't be applied, only that it
>> should be
>> a separate commit.
>>
>> By the way, do we have a Jira
>>> issue for the dojo upgrade?
>>
>>
>> Not that I can see. Feel free to add one, and one with your patch, if
>> there
>> isn't one already.
>>
>> --
>> Martin.
>>
>>
>> musachy
>>>
>>> Martin Cooper wrote:
>>> > On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>> >>
>>> >> Hi Rainer
>>> >>
>>> >> Give me a couple of days so I can test it against 0.4 (I made the
>>> patch
>>> >> using 0.3) and finish some changes(for BindButton) that I have for a
>>> new
>>> >> patch. I will give you a new patch soon with the changes for Bind,
>>> >> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>>> 0.4. If
>>> >> you want to go ahead and upgrade to 0.4 and apply the patch later,
>>> >> that's fine. (I will just be bothering with another patch soon :) )
>>> >
>>> >
>>> > Well, the upgrade and the patch should certainly be separate
>>> commits, so
>>> > that we can track the changes separately, and so that we can revert
>>> > one or
>>> > the other if that ever becomes necessary. Beyond that, it's up to the
>>> > prospective committer to determine timing. ;-)
>>> >
>>> > --
>>> > Martin Cooper
>>> >
>>> >
>>> > musachy
>>> >>
>>> >> Rainer Hermanns wrote:
>>> >> > Musachy,
>>> >> >
>>> >> > I could upgrade the embedded Dojo files to the 0.4 release
>>> during the
>>> >> week.
>>> >> > If your patches for the s2 ajax tags already are against the
>>> >> 0.4release,
>>> >> > I could apply those as well.
>>> >> >
>>> >> > What do you (and others of course) think?
>>> >> >
>>> >> > regards,
>>> >> > Rainer
>>> >> >
>>> >> >
>>> >> >> Any idea on when is Dojo going to be bumped up to 0.4?
>>> >> >>
>>> >> >> musachy
>>> >> >>
>>> >> >> Don Brown wrote:
>>> >> >>
>>> >> >>> Yes, let's start with bumping up Dojo to 0.4, then apply
>>> patches to
>>> >> >>> update the tags. How much work do you think it'll be to upgrade
>>> >> Dojo?
>>> >> >>>
>>> >> >>> Don
>>> >> >>>
>>> >> >>> Musachy Barroso wrote:
>>> >> >>>
>>> >> >>>> I attached a new patch to WW-205, this one includes the new
>>> >> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do
>>> you
>>> >> want
>>> >> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>>> >> replace
>>> >> >>>> dojo distribution under static/dojo.)
>>> >> >>>>
>>> >> >>>> I modified the examples in showcase and the test cases. Let me
>>> know
>>> >> >>>> if something is missing or wrong (bear with me on my first
>>> patch
>>> :)
>>> >> ).
>>> >> >>>>
>>> >> >>>> musachy
>>> >> >>>>
>>> >> >>>> Don Brown wrote:
>>> >> >>>>
>>> >> >>>>> Ok, then put those two under one ticket. You know best :)
>>> >> >>>>>
>>> >> >>>>> Don
>>> >> >>>>>
>>> >> >>>>> Musachy Barroso wrote:
>>> >> >>>>>
>>> >> >>>>>> That's ok, the only problem is that this one by itself would
>>> >> break
>>> >> >>>>>> anchor and tabbed panel.
>>> >> >>>>>>
>>> >> >>>>>> musachy
>>> >> >>>>>>
>>> >> >>>>>> Don Brown wrote:
>>> >> >>>>>>
>>> >> >>>>>>> I'd prefer separate issues, with attached patches. As for
>>> >> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>>> need
>>> >> >>>>>>> to use it more.
>>> >> >>>>>>>
>>> >> >>>>>>> Don
>>> >> >>>>>>>
>>> >> >>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>
>>> >> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>>> >> want
>>> >> >>>>>>>> me to create a patch for it, or wait and create a big one
>>> when
>>> >> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>>> >> 0.3)?
>>> >> >>>>>>>>
>>> >> >>>>>>>> musachy
>>> >> >>>>>>>>
>>> >> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>> >> >>>>>>>> (Selenium maybe?)
>>> >> >>>>>>>>
>>> >> >>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>
>>> >> >>>>>>>>> This was with 0.3.1 which is the current release. I
>>> posted a
>>> >> >>>>>>>>> message on their mailing list.
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> musachy
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> Don Brown wrote:
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any
>>> reason
>>> we
>>> >> >>>>>>>>>> shouldn't upgrade to it?
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> Don
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>> Would something like this include all the current
>>> >> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>> >> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>>> "handler"
>>> >> >>>>>>>>>>> property). This way BindDiv will be easier to maintain
>>> >> (dojo's
>>> >> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>> >> >>>>>>>>>>> (doesn't add anything to this one). By the way this
>>> doesn't
>>> >> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.*");
>>> >> >>>>>>>>>>> dojo.require("dojo.io.*");
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.Container");
>>> >> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>> >> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> struts.widgets.BindDiv = function() {
>>> >> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>> >> >>>>>>>>>>> var self = this;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.widgetType = "BindDiv";
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.href = "";
>>> >> >>>>>>>>>>> this.extractContent = false;
>>> >> >>>>>>>>>>> this.parseContent = false;
>>> >> >>>>>>>>>>> this.cacheContent = false;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.frequency = 0;
>>> >> >>>>>>>>>>> this.delay = 0;
>>> >> >>>>>>>>>>> this.startTimer = false;
>>> >> >>>>>>>>>>> this.timer = null;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //pub/sub events
>>> >> >>>>>>>>>>> this.refreshListenTopics = "";
>>> >> >>>>>>>>>>> this.stopTimerListenTopics = "";
>>> >> >>>>>>>>>>> this.startTimerListenTopics = "";
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.postCreate = function() {
>>> >> >>>>>>>>>>> if(self.frequency > 0) {
>>> >> >>>>>>>>>>> self.timer = new
>>> dojo.animation.Timer(self.frequency);
>>> >> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //start the timer
>>> >> >>>>>>>>>>> if(self.startTimer) {
>>> >> >>>>>>>>>>> //start after delay
>>> >> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>> >> >>>>>>>>>>> dojo.lang.setTimeout(self.delay,
>>> self.startTimer);
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> //attach listeners
>>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> self.refreshListenTopics
>>> );
>>> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>> >> >>>>>>>>>>> self, "reloadContents");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics))
>>> {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> >> self.stopTimerListenTopics);
>>> >> >>>>>>>>>>>
>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>> >> >>>>>>>>>>> self, "stopTimer");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>>
>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>>> >> self.startTimerListenTopics
>>> >> );
>>> >> >>>>>>>>>>>
>>> dojo.event.topic.subscribe(self.startTimerListenTopics
>>> ,
>>> >> >>>>>>>>>>> self, "startTimer");
>>> >> >>>>>>>>>>> }
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.reloadContents = function() {
>>> >> >>>>>>>>>>> //refresh is not visible in ContentPane
>>> >> >>>>>>>>>>> self.isLoaded = false;
>>> >> >>>>>>>>>>> self.loadContents();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.stopTimer = function() {
>>> >> >>>>>>>>>>> dojo.debug("stopping timer");
>>> >> >>>>>>>>>>> self.timer.stop();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> this.startTimer = function() {
>>> >> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>> >> >>>>>>>>>>> self.frequency);
>>> >> >>>>>>>>>>> self.timer.start();
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>> };
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>> >> >>>>>>>>>>> dojo.widget.html.ContentPane);
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> Musachy Barroso wrote:
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>>> >> need to
>>> >> >>>>>>>>>>>> do some changes, right now Panel extends Div and
>>> PanelTag
>>> >> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>>> wraps
>>> >> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>> >> >>>>>>>>>>>> struts), and they are quite different. I think we
>>> should
>>> >> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>> >> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>>> >> refresh.
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> what do you guys think?
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> musachy
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> Ian Roughley wrote:
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>>> in. Try
>>> >> >>>>>>>>>>>>> to do as much as possible in dojo and provide light
>>> >> wrappers
>>> >> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>>> >> was no
>>> >> >>>>>>>>>>>>> such dojo implementation. The one feature that we had
>>> >> that
>>> >> >>>>>>>>>>>>> you should check that has been implemented in dojo
>>> is the
>>> >> >>>>>>>>>>>>> pub/sub events - so there should be events that each
>>> tabs
>>> >> >>>>>>>>>>>>> listens to to refresh itself.
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>> >> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>>> being
>>> >> >>>>>>>>>>>>> done in dojo.
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> The other big thing that would be a great help is
>>> >> converting
>>> >> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>> Ian
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>> To unsubscribe, e-mail:
>>> dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>>
>>> >> >>>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>>
>>> >> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>>> For additional commands, e-mail:
>>> dev-help@struts.apache.org
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>
>>> >> >>>>>>>>>
>>> >> >>>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>>>
>>> >> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>>>
>>> >> >>>>>>>>
>>> >> >>>>>>>>
>>> >> >>>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>>
>>> >> >>>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>>
>>> >> >>>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>>
>>> >> >>>>>
>>> >> >>>>>
>>> >> >>>>
>>> >> ---------------------------------------------------------------------
>>> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>>
>>> >> >>>>
>>> >> >>>>
>>> >> >>>
>>> >> ---------------------------------------------------------------------
>>> >> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >>> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>>
>>> >> >>>
>>> >> >>>
>>> >> >>
>>> ---------------------------------------------------------------------
>>> >> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> >> For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >
>>> >> >
>>> >> >
>>> ---------------------------------------------------------------------
>>> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> > For additional commands, e-mail: dev-help@struts.apache.org
>>> >> >
>>> >> >
>>> >> >
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> >> For additional commands, e-mail: dev-help@struts.apache.org
>>> >>
>>> >>
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
:) I know. What I meant is that it shouldn't be applied yet 'cause I
made it using 0.3 and I haven't tried it on 0.4 yet.
musachy
Martin Cooper wrote:
> On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>
>> Oh, ok. Then just don't apply the patch.
>
>
> No, no - I'm not saying that it shouldn't be applied, only that it
> should be
> a separate commit.
>
> By the way, do we have a Jira
>> issue for the dojo upgrade?
>
>
> Not that I can see. Feel free to add one, and one with your patch, if
> there
> isn't one already.
>
> --
> Martin.
>
>
> musachy
>>
>> Martin Cooper wrote:
>> > On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>> >>
>> >> Hi Rainer
>> >>
>> >> Give me a couple of days so I can test it against 0.4 (I made the
>> patch
>> >> using 0.3) and finish some changes(for BindButton) that I have for a
>> new
>> >> patch. I will give you a new patch soon with the changes for Bind,
>> >> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo
>> 0.4. If
>> >> you want to go ahead and upgrade to 0.4 and apply the patch later,
>> >> that's fine. (I will just be bothering with another patch soon :) )
>> >
>> >
>> > Well, the upgrade and the patch should certainly be separate
>> commits, so
>> > that we can track the changes separately, and so that we can revert
>> > one or
>> > the other if that ever becomes necessary. Beyond that, it's up to the
>> > prospective committer to determine timing. ;-)
>> >
>> > --
>> > Martin Cooper
>> >
>> >
>> > musachy
>> >>
>> >> Rainer Hermanns wrote:
>> >> > Musachy,
>> >> >
>> >> > I could upgrade the embedded Dojo files to the 0.4 release
>> during the
>> >> week.
>> >> > If your patches for the s2 ajax tags already are against the
>> >> 0.4release,
>> >> > I could apply those as well.
>> >> >
>> >> > What do you (and others of course) think?
>> >> >
>> >> > regards,
>> >> > Rainer
>> >> >
>> >> >
>> >> >> Any idea on when is Dojo going to be bumped up to 0.4?
>> >> >>
>> >> >> musachy
>> >> >>
>> >> >> Don Brown wrote:
>> >> >>
>> >> >>> Yes, let's start with bumping up Dojo to 0.4, then apply
>> patches to
>> >> >>> update the tags. How much work do you think it'll be to upgrade
>> >> Dojo?
>> >> >>>
>> >> >>> Don
>> >> >>>
>> >> >>> Musachy Barroso wrote:
>> >> >>>
>> >> >>>> I attached a new patch to WW-205, this one includes the new
>> >> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you
>> >> want
>> >> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>> >> replace
>> >> >>>> dojo distribution under static/dojo.)
>> >> >>>>
>> >> >>>> I modified the examples in showcase and the test cases. Let me
>> know
>> >> >>>> if something is missing or wrong (bear with me on my first patch
>> :)
>> >> ).
>> >> >>>>
>> >> >>>> musachy
>> >> >>>>
>> >> >>>> Don Brown wrote:
>> >> >>>>
>> >> >>>>> Ok, then put those two under one ticket. You know best :)
>> >> >>>>>
>> >> >>>>> Don
>> >> >>>>>
>> >> >>>>> Musachy Barroso wrote:
>> >> >>>>>
>> >> >>>>>> That's ok, the only problem is that this one by itself would
>> >> break
>> >> >>>>>> anchor and tabbed panel.
>> >> >>>>>>
>> >> >>>>>> musachy
>> >> >>>>>>
>> >> >>>>>> Don Brown wrote:
>> >> >>>>>>
>> >> >>>>>>> I'd prefer separate issues, with attached patches. As for
>> >> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
>> need
>> >> >>>>>>> to use it more.
>> >> >>>>>>>
>> >> >>>>>>> Don
>> >> >>>>>>>
>> >> >>>>>>> Musachy Barroso wrote:
>> >> >>>>>>>
>> >> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>> >> want
>> >> >>>>>>>> me to create a patch for it, or wait and create a big one
>> when
>> >> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>> >> 0.3)?
>> >> >>>>>>>>
>> >> >>>>>>>> musachy
>> >> >>>>>>>>
>> >> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
>> >> >>>>>>>> (Selenium maybe?)
>> >> >>>>>>>>
>> >> >>>>>>>> Musachy Barroso wrote:
>> >> >>>>>>>>
>> >> >>>>>>>>> This was with 0.3.1 which is the current release. I
>> posted a
>> >> >>>>>>>>> message on their mailing list.
>> >> >>>>>>>>>
>> >> >>>>>>>>> musachy
>> >> >>>>>>>>>
>> >> >>>>>>>>> Don Brown wrote:
>> >> >>>>>>>>>
>> >> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason
>> we
>> >> >>>>>>>>>> shouldn't upgrade to it?
>> >> >>>>>>>>>>
>> >> >>>>>>>>>> Don
>> >> >>>>>>>>>>
>> >> >>>>>>>>>> Musachy Barroso wrote:
>> >> >>>>>>>>>>
>> >> >>>>>>>>>>> Would something like this include all the current
>> >> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>> >> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's
>> "handler"
>> >> >>>>>>>>>>> property). This way BindDiv will be easier to maintain
>> >> (dojo's
>> >> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>> >> >>>>>>>>>>> (doesn't add anything to this one). By the way this
>> doesn't
>> >> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> dojo.require("dojo.widget.*");
>> >> >>>>>>>>>>> dojo.require("dojo.io.*");
>> >> >>>>>>>>>>> dojo.require("dojo.widget.Container");
>> >> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>> >> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> struts.widgets.BindDiv = function() {
>> >> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>> >> >>>>>>>>>>> var self = this;
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.widgetType = "BindDiv";
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.href = "";
>> >> >>>>>>>>>>> this.extractContent = false;
>> >> >>>>>>>>>>> this.parseContent = false;
>> >> >>>>>>>>>>> this.cacheContent = false;
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.frequency = 0;
>> >> >>>>>>>>>>> this.delay = 0;
>> >> >>>>>>>>>>> this.startTimer = false;
>> >> >>>>>>>>>>> this.timer = null;
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> //pub/sub events
>> >> >>>>>>>>>>> this.refreshListenTopics = "";
>> >> >>>>>>>>>>> this.stopTimerListenTopics = "";
>> >> >>>>>>>>>>> this.startTimerListenTopics = "";
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.postCreate = function() {
>> >> >>>>>>>>>>> if(self.frequency > 0) {
>> >> >>>>>>>>>>> self.timer = new
>> dojo.animation.Timer(self.frequency);
>> >> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> //start the timer
>> >> >>>>>>>>>>> if(self.startTimer) {
>> >> >>>>>>>>>>> //start after delay
>> >> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>> >> >>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>> >> >>>>>>>>>>> }
>> >> >>>>>>>>>>> }
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> //attach listeners
>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>> self.refreshListenTopics
>> );
>> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>> >> >>>>>>>>>>> self, "reloadContents");
>> >> >>>>>>>>>>> }
>> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>> >> self.stopTimerListenTopics);
>> >> >>>>>>>>>>>
>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>> >> >>>>>>>>>>> self, "stopTimer");
>> >> >>>>>>>>>>> }
>> >> >>>>>>>>>>>
>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>> >> >>>>>>>>>>> dojo.debug("Listening to " +
>> >> self.startTimerListenTopics
>> >> );
>> >> >>>>>>>>>>>
>> dojo.event.topic.subscribe(self.startTimerListenTopics
>> ,
>> >> >>>>>>>>>>> self, "startTimer");
>> >> >>>>>>>>>>> }
>> >> >>>>>>>>>>> };
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.reloadContents = function() {
>> >> >>>>>>>>>>> //refresh is not visible in ContentPane
>> >> >>>>>>>>>>> self.isLoaded = false;
>> >> >>>>>>>>>>> self.loadContents();
>> >> >>>>>>>>>>> };
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.stopTimer = function() {
>> >> >>>>>>>>>>> dojo.debug("stopping timer");
>> >> >>>>>>>>>>> self.timer.stop();
>> >> >>>>>>>>>>> };
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> this.startTimer = function() {
>> >> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
>> >> >>>>>>>>>>> self.frequency);
>> >> >>>>>>>>>>> self.timer.start();
>> >> >>>>>>>>>>> };
>> >> >>>>>>>>>>> };
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>> >> >>>>>>>>>>> dojo.widget.html.ContentPane);
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> Musachy Barroso wrote:
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>> >> need to
>> >> >>>>>>>>>>>> do some changes, right now Panel extends Div and
>> PanelTag
>> >> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag
>> wraps
>> >> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>> >> >>>>>>>>>>>> struts), and they are quite different. I think we should
>> >> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>> >> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>> >> refresh.
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>> what do you guys think?
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>> musachy
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>> Ian Roughley wrote:
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go
>> in. Try
>> >> >>>>>>>>>>>>> to do as much as possible in dojo and provide light
>> >> wrappers
>> >> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>> >> was no
>> >> >>>>>>>>>>>>> such dojo implementation. The one feature that we had
>> >> that
>> >> >>>>>>>>>>>>> you should check that has been implemented in dojo
>> is the
>> >> >>>>>>>>>>>>> pub/sub events - so there should be events that each
>> tabs
>> >> >>>>>>>>>>>>> listens to to refresh itself.
>> >> >>>>>>>>>>>>>
>> >> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>> >> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work
>> being
>> >> >>>>>>>>>>>>> done in dojo.
>> >> >>>>>>>>>>>>>
>> >> >>>>>>>>>>>>> The other big thing that would be a great help is
>> >> converting
>> >> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>> >> >>>>>>>>>>>>>
>> >> >>>>>>>>>>>>> Ian
>> >> >>>>>>>>>>>>>
>> >> >>>>>>>>>>>>>
>> >> >>>>>>>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>> To unsubscribe, e-mail:
>> dev-unsubscribe@struts.apache.org
>> >> >>>>>>>>>>>> For additional commands, e-mail:
>> dev-help@struts.apache.org
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>>
>> >> >>>>>>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>>>>>>> For additional commands, e-mail:
>> dev-help@struts.apache.org
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>>
>> >> >>>>>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>>>>>
>> >> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>>>>>> For additional commands, e-mail:
>> dev-help@struts.apache.org
>> >> >>>>>>>>>>
>> >> >>>>>>>>>>
>> >> >>>>>>>>>>
>> >> >>>>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>>>>
>> >> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>>>>>>
>> >> >>>>>>>>>
>> >> >>>>>>>>>
>> >> >>>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>>>
>> >> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>>>>>
>> >> >>>>>>>>
>> >> >>>>>>>>
>> >> >>>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>
>> >> ---------------------------------------------------------------------
>> >> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>>
>> >> >>>>>
>> >> >>>>>
>> >> >>>>
>> >> ---------------------------------------------------------------------
>> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>>
>> >> >>>>
>> >> >>>>
>> >> >>>
>> >> ---------------------------------------------------------------------
>> >> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >>> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>
>> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >> >>
>> >> >>
>> >> >>
>> >> >
>> >> >
>> >> >
>> ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> > For additional commands, e-mail: dev-help@struts.apache.org
>> >> >
>> >> >
>> >> >
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >>
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Martin Cooper <ma...@apache.org>.
On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>
> Oh, ok. Then just don't apply the patch.
No, no - I'm not saying that it shouldn't be applied, only that it should be
a separate commit.
By the way, do we have a Jira
> issue for the dojo upgrade?
Not that I can see. Feel free to add one, and one with your patch, if there
isn't one already.
--
Martin.
musachy
>
> Martin Cooper wrote:
> > On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
> >>
> >> Hi Rainer
> >>
> >> Give me a couple of days so I can test it against 0.4 (I made the patch
> >> using 0.3) and finish some changes(for BindButton) that I have for a
> new
> >> patch. I will give you a new patch soon with the changes for Bind,
> >> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo 0.4. If
> >> you want to go ahead and upgrade to 0.4 and apply the patch later,
> >> that's fine. (I will just be bothering with another patch soon :) )
> >
> >
> > Well, the upgrade and the patch should certainly be separate commits, so
> > that we can track the changes separately, and so that we can revert
> > one or
> > the other if that ever becomes necessary. Beyond that, it's up to the
> > prospective committer to determine timing. ;-)
> >
> > --
> > Martin Cooper
> >
> >
> > musachy
> >>
> >> Rainer Hermanns wrote:
> >> > Musachy,
> >> >
> >> > I could upgrade the embedded Dojo files to the 0.4 release during the
> >> week.
> >> > If your patches for the s2 ajax tags already are against the
> >> 0.4release,
> >> > I could apply those as well.
> >> >
> >> > What do you (and others of course) think?
> >> >
> >> > regards,
> >> > Rainer
> >> >
> >> >
> >> >> Any idea on when is Dojo going to be bumped up to 0.4?
> >> >>
> >> >> musachy
> >> >>
> >> >> Don Brown wrote:
> >> >>
> >> >>> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
> >> >>> update the tags. How much work do you think it'll be to upgrade
> >> Dojo?
> >> >>>
> >> >>> Don
> >> >>>
> >> >>> Musachy Barroso wrote:
> >> >>>
> >> >>>> I attached a new patch to WW-205, this one includes the new
> >> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you
> >> want
> >> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to
> >> replace
> >> >>>> dojo distribution under static/dojo.)
> >> >>>>
> >> >>>> I modified the examples in showcase and the test cases. Let me
> know
> >> >>>> if something is missing or wrong (bear with me on my first patch
> :)
> >> ).
> >> >>>>
> >> >>>> musachy
> >> >>>>
> >> >>>> Don Brown wrote:
> >> >>>>
> >> >>>>> Ok, then put those two under one ticket. You know best :)
> >> >>>>>
> >> >>>>> Don
> >> >>>>>
> >> >>>>> Musachy Barroso wrote:
> >> >>>>>
> >> >>>>>> That's ok, the only problem is that this one by itself would
> >> break
> >> >>>>>> anchor and tabbed panel.
> >> >>>>>>
> >> >>>>>> musachy
> >> >>>>>>
> >> >>>>>> Don Brown wrote:
> >> >>>>>>
> >> >>>>>>> I'd prefer separate issues, with attached patches. As for
> >> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we
> need
> >> >>>>>>> to use it more.
> >> >>>>>>>
> >> >>>>>>> Don
> >> >>>>>>>
> >> >>>>>>> Musachy Barroso wrote:
> >> >>>>>>>
> >> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
> >> want
> >> >>>>>>>> me to create a patch for it, or wait and create a big one when
> >> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
> >> 0.3)?
> >> >>>>>>>>
> >> >>>>>>>> musachy
> >> >>>>>>>>
> >> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
> >> >>>>>>>> (Selenium maybe?)
> >> >>>>>>>>
> >> >>>>>>>> Musachy Barroso wrote:
> >> >>>>>>>>
> >> >>>>>>>>> This was with 0.3.1 which is the current release. I posted a
> >> >>>>>>>>> message on their mailing list.
> >> >>>>>>>>>
> >> >>>>>>>>> musachy
> >> >>>>>>>>>
> >> >>>>>>>>> Don Brown wrote:
> >> >>>>>>>>>
> >> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason
> we
> >> >>>>>>>>>> shouldn't upgrade to it?
> >> >>>>>>>>>>
> >> >>>>>>>>>> Don
> >> >>>>>>>>>>
> >> >>>>>>>>>> Musachy Barroso wrote:
> >> >>>>>>>>>>
> >> >>>>>>>>>>> Would something like this include all the current
> >> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
> >> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
> >> >>>>>>>>>>> property). This way BindDiv will be easier to maintain
> >> (dojo's
> >> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
> >> >>>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
> >> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> dojo.require("dojo.widget.*");
> >> >>>>>>>>>>> dojo.require("dojo.io.*");
> >> >>>>>>>>>>> dojo.require("dojo.widget.Container");
> >> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
> >> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> struts.widgets.BindDiv = function() {
> >> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
> >> >>>>>>>>>>> var self = this;
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.widgetType = "BindDiv";
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.href = "";
> >> >>>>>>>>>>> this.extractContent = false;
> >> >>>>>>>>>>> this.parseContent = false;
> >> >>>>>>>>>>> this.cacheContent = false;
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.frequency = 0;
> >> >>>>>>>>>>> this.delay = 0;
> >> >>>>>>>>>>> this.startTimer = false;
> >> >>>>>>>>>>> this.timer = null;
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> //pub/sub events
> >> >>>>>>>>>>> this.refreshListenTopics = "";
> >> >>>>>>>>>>> this.stopTimerListenTopics = "";
> >> >>>>>>>>>>> this.startTimerListenTopics = "";
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.postCreate = function() {
> >> >>>>>>>>>>> if(self.frequency > 0) {
> >> >>>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
> >> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> //start the timer
> >> >>>>>>>>>>> if(self.startTimer) {
> >> >>>>>>>>>>> //start after delay
> >> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
> >> >>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
> >> >>>>>>>>>>> }
> >> >>>>>>>>>>> }
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> //attach listeners
> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
> >> >>>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics
> );
> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
> >> >>>>>>>>>>> self, "reloadContents");
> >> >>>>>>>>>>> }
> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
> >> >>>>>>>>>>> dojo.debug("Listening to " +
> >> self.stopTimerListenTopics);
> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
> >> >>>>>>>>>>> self, "stopTimer");
> >> >>>>>>>>>>> }
> >> >>>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
> >> >>>>>>>>>>> dojo.debug("Listening to " +
> >> self.startTimerListenTopics
> >> );
> >> >>>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics
> ,
> >> >>>>>>>>>>> self, "startTimer");
> >> >>>>>>>>>>> }
> >> >>>>>>>>>>> };
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.reloadContents = function() {
> >> >>>>>>>>>>> //refresh is not visible in ContentPane
> >> >>>>>>>>>>> self.isLoaded = false;
> >> >>>>>>>>>>> self.loadContents();
> >> >>>>>>>>>>> };
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.stopTimer = function() {
> >> >>>>>>>>>>> dojo.debug("stopping timer");
> >> >>>>>>>>>>> self.timer.stop();
> >> >>>>>>>>>>> };
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> this.startTimer = function() {
> >> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
> >> >>>>>>>>>>> self.frequency);
> >> >>>>>>>>>>> self.timer.start();
> >> >>>>>>>>>>> };
> >> >>>>>>>>>>> };
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
> >> >>>>>>>>>>> dojo.widget.html.ContentPane);
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
> >> >>>>>>>>>>>
> >> >>>>>>>>>>>
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> Musachy Barroso wrote:
> >> >>>>>>>>>>>
> >> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
> >> need to
> >> >>>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
> >> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
> >> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
> >> >>>>>>>>>>>> struts), and they are quite different. I think we should
> >> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
> >> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
> >> refresh.
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>> what do you guys think?
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>> musachy
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>> Ian Roughley wrote:
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go
> in. Try
> >> >>>>>>>>>>>>> to do as much as possible in dojo and provide light
> >> wrappers
> >> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
> >> was no
> >> >>>>>>>>>>>>> such dojo implementation. The one feature that we had
> >> that
> >> >>>>>>>>>>>>> you should check that has been implemented in dojo is the
> >> >>>>>>>>>>>>> pub/sub events - so there should be events that each tabs
> >> >>>>>>>>>>>>> listens to to refresh itself.
> >> >>>>>>>>>>>>>
> >> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
> >> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work being
> >> >>>>>>>>>>>>> done in dojo.
> >> >>>>>>>>>>>>>
> >> >>>>>>>>>>>>> The other big thing that would be a great help is
> >> converting
> >> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
> >> >>>>>>>>>>>>>
> >> >>>>>>>>>>>>> Ian
> >> >>>>>>>>>>>>>
> >> >>>>>>>>>>>>>
> >> >>>>>>>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>>>>>>> For additional commands, e-mail:
> dev-help@struts.apache.org
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>>
> >> >>>>>>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>>>>>>
> >> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>>>>>>
> >> >>>>>>>>>>>
> >> >>>>>>>>>>>
> >> >>>>>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>>>>>
> >> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>>>>>
> >> >>>>>>>>>>
> >> >>>>>>>>>>
> >> >>>>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>>>>
> >> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>>>>
> >> >>>>>>>>>
> >> >>>>>>>>>
> >> >>>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>>>
> >> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>>>>>>>
> >> >>>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>
> >> ---------------------------------------------------------------------
> >> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>>
> >> >>>>>>
> >> >>>>>>
> >> >>>>>
> >> ---------------------------------------------------------------------
> >> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>>
> >> >>>>>
> >> >>>>>
> >> >>>>
> >> ---------------------------------------------------------------------
> >> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>
> >> ---------------------------------------------------------------------
> >> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >>> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>>
> >> >>>
> >> >>>
> >> >>
> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> >> For additional commands, e-mail: dev-help@struts.apache.org
> >> >>
> >> >>
> >> >>
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> > For additional commands, e-mail: dev-help@struts.apache.org
> >> >
> >> >
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Oh, ok. Then just don't apply the patch. By the way, do we have a Jira
issue for the dojo upgrade?
musachy
Martin Cooper wrote:
> On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>>
>> Hi Rainer
>>
>> Give me a couple of days so I can test it against 0.4 (I made the patch
>> using 0.3) and finish some changes(for BindButton) that I have for a new
>> patch. I will give you a new patch soon with the changes for Bind,
>> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo 0.4. If
>> you want to go ahead and upgrade to 0.4 and apply the patch later,
>> that's fine. (I will just be bothering with another patch soon :) )
>
>
> Well, the upgrade and the patch should certainly be separate commits, so
> that we can track the changes separately, and so that we can revert
> one or
> the other if that ever becomes necessary. Beyond that, it's up to the
> prospective committer to determine timing. ;-)
>
> --
> Martin Cooper
>
>
> musachy
>>
>> Rainer Hermanns wrote:
>> > Musachy,
>> >
>> > I could upgrade the embedded Dojo files to the 0.4 release during the
>> week.
>> > If your patches for the s2 ajax tags already are against the
>> 0.4release,
>> > I could apply those as well.
>> >
>> > What do you (and others of course) think?
>> >
>> > regards,
>> > Rainer
>> >
>> >
>> >> Any idea on when is Dojo going to be bumped up to 0.4?
>> >>
>> >> musachy
>> >>
>> >> Don Brown wrote:
>> >>
>> >>> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
>> >>> update the tags. How much work do you think it'll be to upgrade
>> Dojo?
>> >>>
>> >>> Don
>> >>>
>> >>> Musachy Barroso wrote:
>> >>>
>> >>>> I attached a new patch to WW-205, this one includes the new
>> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you
>> want
>> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to
>> replace
>> >>>> dojo distribution under static/dojo.)
>> >>>>
>> >>>> I modified the examples in showcase and the test cases. Let me know
>> >>>> if something is missing or wrong (bear with me on my first patch :)
>> ).
>> >>>>
>> >>>> musachy
>> >>>>
>> >>>> Don Brown wrote:
>> >>>>
>> >>>>> Ok, then put those two under one ticket. You know best :)
>> >>>>>
>> >>>>> Don
>> >>>>>
>> >>>>> Musachy Barroso wrote:
>> >>>>>
>> >>>>>> That's ok, the only problem is that this one by itself would
>> break
>> >>>>>> anchor and tabbed panel.
>> >>>>>>
>> >>>>>> musachy
>> >>>>>>
>> >>>>>> Don Brown wrote:
>> >>>>>>
>> >>>>>>> I'd prefer separate issues, with attached patches. As for
>> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
>> >>>>>>> to use it more.
>> >>>>>>>
>> >>>>>>> Don
>> >>>>>>>
>> >>>>>>> Musachy Barroso wrote:
>> >>>>>>>
>> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you
>> want
>> >>>>>>>> me to create a patch for it, or wait and create a big one when
>> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 ->
>> 0.3)?
>> >>>>>>>>
>> >>>>>>>> musachy
>> >>>>>>>>
>> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
>> >>>>>>>> (Selenium maybe?)
>> >>>>>>>>
>> >>>>>>>> Musachy Barroso wrote:
>> >>>>>>>>
>> >>>>>>>>> This was with 0.3.1 which is the current release. I posted a
>> >>>>>>>>> message on their mailing list.
>> >>>>>>>>>
>> >>>>>>>>> musachy
>> >>>>>>>>>
>> >>>>>>>>> Don Brown wrote:
>> >>>>>>>>>
>> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>> >>>>>>>>>> shouldn't upgrade to it?
>> >>>>>>>>>>
>> >>>>>>>>>> Don
>> >>>>>>>>>>
>> >>>>>>>>>> Musachy Barroso wrote:
>> >>>>>>>>>>
>> >>>>>>>>>>> Would something like this include all the current
>> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
>> >>>>>>>>>>> property). This way BindDiv will be easier to maintain
>> (dojo's
>> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>> >>>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
>> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>> >>>>>>>>>>>
>> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>> >>>>>>>>>>>
>> >>>>>>>>>>> dojo.require("dojo.widget.*");
>> >>>>>>>>>>> dojo.require("dojo.io.*");
>> >>>>>>>>>>> dojo.require("dojo.widget.Container");
>> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
>> >>>>>>>>>>>
>> >>>>>>>>>>> struts.widgets.BindDiv = function() {
>> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>> >>>>>>>>>>> var self = this;
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.widgetType = "BindDiv";
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.href = "";
>> >>>>>>>>>>> this.extractContent = false;
>> >>>>>>>>>>> this.parseContent = false;
>> >>>>>>>>>>> this.cacheContent = false;
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.frequency = 0;
>> >>>>>>>>>>> this.delay = 0;
>> >>>>>>>>>>> this.startTimer = false;
>> >>>>>>>>>>> this.timer = null;
>> >>>>>>>>>>>
>> >>>>>>>>>>> //pub/sub events
>> >>>>>>>>>>> this.refreshListenTopics = "";
>> >>>>>>>>>>> this.stopTimerListenTopics = "";
>> >>>>>>>>>>> this.startTimerListenTopics = "";
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.postCreate = function() {
>> >>>>>>>>>>> if(self.frequency > 0) {
>> >>>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
>> >>>>>>>>>>>
>> >>>>>>>>>>> //start the timer
>> >>>>>>>>>>> if(self.startTimer) {
>> >>>>>>>>>>> //start after delay
>> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>> >>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>> >>>>>>>>>>> }
>> >>>>>>>>>>> }
>> >>>>>>>>>>>
>> >>>>>>>>>>> //attach listeners
>> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>> >>>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>> >>>>>>>>>>> self, "reloadContents");
>> >>>>>>>>>>> }
>> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>> >>>>>>>>>>> dojo.debug("Listening to " +
>> self.stopTimerListenTopics);
>> >>>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>> >>>>>>>>>>> self, "stopTimer");
>> >>>>>>>>>>> }
>> >>>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>> >>>>>>>>>>> dojo.debug("Listening to " +
>> self.startTimerListenTopics
>> );
>> >>>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>> >>>>>>>>>>> self, "startTimer");
>> >>>>>>>>>>> }
>> >>>>>>>>>>> };
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.reloadContents = function() {
>> >>>>>>>>>>> //refresh is not visible in ContentPane
>> >>>>>>>>>>> self.isLoaded = false;
>> >>>>>>>>>>> self.loadContents();
>> >>>>>>>>>>> };
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.stopTimer = function() {
>> >>>>>>>>>>> dojo.debug("stopping timer");
>> >>>>>>>>>>> self.timer.stop();
>> >>>>>>>>>>> };
>> >>>>>>>>>>>
>> >>>>>>>>>>> this.startTimer = function() {
>> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
>> >>>>>>>>>>> self.frequency);
>> >>>>>>>>>>> self.timer.start();
>> >>>>>>>>>>> };
>> >>>>>>>>>>> };
>> >>>>>>>>>>>
>> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>> >>>>>>>>>>> dojo.widget.html.ContentPane);
>> >>>>>>>>>>>
>> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>> Musachy Barroso wrote:
>> >>>>>>>>>>>
>> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we
>> need to
>> >>>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>> >>>>>>>>>>>> struts), and they are quite different. I think we should
>> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
>> refresh.
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> what do you guys think?
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> musachy
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> Ian Roughley wrote:
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
>> >>>>>>>>>>>>> to do as much as possible in dojo and provide light
>> wrappers
>> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there
>> was no
>> >>>>>>>>>>>>> such dojo implementation. The one feature that we had
>> that
>> >>>>>>>>>>>>> you should check that has been implemented in dojo is the
>> >>>>>>>>>>>>> pub/sub events - so there should be events that each tabs
>> >>>>>>>>>>>>> listens to to refresh itself.
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work being
>> >>>>>>>>>>>>> done in dojo.
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> The other big thing that would be a great help is
>> converting
>> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> Ian
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>
>> >>>>>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>>>>>
>> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> >>>>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>>>>
>> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>>>
>> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>>
>> >>>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>>>
>> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>>
>> >>>>>>>
>> ---------------------------------------------------------------------
>> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>>
>> >>>>>>>
>> >>>>>>>
>> >>>>>>
>> ---------------------------------------------------------------------
>> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>>
>> >>>>>>
>> >>>>>>
>> >>>>>
>> ---------------------------------------------------------------------
>> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>
>> ---------------------------------------------------------------------
>> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>>
>> >>>>
>> >>>>
>> >>>
>> ---------------------------------------------------------------------
>> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >>> For additional commands, e-mail: dev-help@struts.apache.org
>> >>>
>> >>>
>> >>>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> >> For additional commands, e-mail: dev-help@struts.apache.org
>> >>
>> >>
>> >>
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> > For additional commands, e-mail: dev-help@struts.apache.org
>> >
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Martin Cooper <ma...@apache.org>.
On 10/30/06, Musachy Barroso <mb...@wfscorp.com> wrote:
>
> Hi Rainer
>
> Give me a couple of days so I can test it against 0.4 (I made the patch
> using 0.3) and finish some changes(for BindButton) that I have for a new
> patch. I will give you a new patch soon with the changes for Bind,
> BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo 0.4. If
> you want to go ahead and upgrade to 0.4 and apply the patch later,
> that's fine. (I will just be bothering with another patch soon :) )
Well, the upgrade and the patch should certainly be separate commits, so
that we can track the changes separately, and so that we can revert one or
the other if that ever becomes necessary. Beyond that, it's up to the
prospective committer to determine timing. ;-)
--
Martin Cooper
musachy
>
> Rainer Hermanns wrote:
> > Musachy,
> >
> > I could upgrade the embedded Dojo files to the 0.4 release during the
> week.
> > If your patches for the s2 ajax tags already are against the 0.4release,
> > I could apply those as well.
> >
> > What do you (and others of course) think?
> >
> > regards,
> > Rainer
> >
> >
> >> Any idea on when is Dojo going to be bumped up to 0.4?
> >>
> >> musachy
> >>
> >> Don Brown wrote:
> >>
> >>> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
> >>> update the tags. How much work do you think it'll be to upgrade Dojo?
> >>>
> >>> Don
> >>>
> >>> Musachy Barroso wrote:
> >>>
> >>>> I attached a new patch to WW-205, this one includes the new
> >>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
> >>>> me to create a patch to update to Dojo 0.3.1?(We just need to replace
> >>>> dojo distribution under static/dojo.)
> >>>>
> >>>> I modified the examples in showcase and the test cases. Let me know
> >>>> if something is missing or wrong (bear with me on my first patch :)
> ).
> >>>>
> >>>> musachy
> >>>>
> >>>> Don Brown wrote:
> >>>>
> >>>>> Ok, then put those two under one ticket. You know best :)
> >>>>>
> >>>>> Don
> >>>>>
> >>>>> Musachy Barroso wrote:
> >>>>>
> >>>>>> That's ok, the only problem is that this one by itself would break
> >>>>>> anchor and tabbed panel.
> >>>>>>
> >>>>>> musachy
> >>>>>>
> >>>>>> Don Brown wrote:
> >>>>>>
> >>>>>>> I'd prefer separate issues, with attached patches. As for
> >>>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
> >>>>>>> to use it more.
> >>>>>>>
> >>>>>>> Don
> >>>>>>>
> >>>>>>> Musachy Barroso wrote:
> >>>>>>>
> >>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
> >>>>>>>> me to create a patch for it, or wait and create a big one when
> >>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
> >>>>>>>>
> >>>>>>>> musachy
> >>>>>>>>
> >>>>>>>> //Have you guys consider anything to test this ajax stuff?
> >>>>>>>> (Selenium maybe?)
> >>>>>>>>
> >>>>>>>> Musachy Barroso wrote:
> >>>>>>>>
> >>>>>>>>> This was with 0.3.1 which is the current release. I posted a
> >>>>>>>>> message on their mailing list.
> >>>>>>>>>
> >>>>>>>>> musachy
> >>>>>>>>>
> >>>>>>>>> Don Brown wrote:
> >>>>>>>>>
> >>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
> >>>>>>>>>> shouldn't upgrade to it?
> >>>>>>>>>>
> >>>>>>>>>> Don
> >>>>>>>>>>
> >>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>
> >>>>>>>>>>> Would something like this include all the current
> >>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
> >>>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
> >>>>>>>>>>> property). This way BindDiv will be easier to maintain (dojo's
> >>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
> >>>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
> >>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
> >>>>>>>>>>>
> >>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
> >>>>>>>>>>>
> >>>>>>>>>>> dojo.require("dojo.widget.*");
> >>>>>>>>>>> dojo.require("dojo.io.*");
> >>>>>>>>>>> dojo.require("dojo.widget.Container");
> >>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
> >>>>>>>>>>> dojo.require("dojo.animation.Timer");
> >>>>>>>>>>>
> >>>>>>>>>>> struts.widgets.BindDiv = function() {
> >>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
> >>>>>>>>>>> var self = this;
> >>>>>>>>>>>
> >>>>>>>>>>> this.widgetType = "BindDiv";
> >>>>>>>>>>>
> >>>>>>>>>>> this.href = "";
> >>>>>>>>>>> this.extractContent = false;
> >>>>>>>>>>> this.parseContent = false;
> >>>>>>>>>>> this.cacheContent = false;
> >>>>>>>>>>>
> >>>>>>>>>>> this.frequency = 0;
> >>>>>>>>>>> this.delay = 0;
> >>>>>>>>>>> this.startTimer = false;
> >>>>>>>>>>> this.timer = null;
> >>>>>>>>>>>
> >>>>>>>>>>> //pub/sub events
> >>>>>>>>>>> this.refreshListenTopics = "";
> >>>>>>>>>>> this.stopTimerListenTopics = "";
> >>>>>>>>>>> this.startTimerListenTopics = "";
> >>>>>>>>>>>
> >>>>>>>>>>> this.postCreate = function() {
> >>>>>>>>>>> if(self.frequency > 0) {
> >>>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
> >>>>>>>>>>> self.timer.onTick = self.reloadContents;
> >>>>>>>>>>>
> >>>>>>>>>>> //start the timer
> >>>>>>>>>>> if(self.startTimer) {
> >>>>>>>>>>> //start after delay
> >>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
> >>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
> >>>>>>>>>>> }
> >>>>>>>>>>> }
> >>>>>>>>>>>
> >>>>>>>>>>> //attach listeners
> >>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
> >>>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
> >>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
> >>>>>>>>>>> self, "reloadContents");
> >>>>>>>>>>> }
> >>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
> >>>>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
> >>>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
> >>>>>>>>>>> self, "stopTimer");
> >>>>>>>>>>> }
> >>>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
> >>>>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics
> );
> >>>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
> >>>>>>>>>>> self, "startTimer");
> >>>>>>>>>>> }
> >>>>>>>>>>> };
> >>>>>>>>>>>
> >>>>>>>>>>> this.reloadContents = function() {
> >>>>>>>>>>> //refresh is not visible in ContentPane
> >>>>>>>>>>> self.isLoaded = false;
> >>>>>>>>>>> self.loadContents();
> >>>>>>>>>>> };
> >>>>>>>>>>>
> >>>>>>>>>>> this.stopTimer = function() {
> >>>>>>>>>>> dojo.debug("stopping timer");
> >>>>>>>>>>> self.timer.stop();
> >>>>>>>>>>> };
> >>>>>>>>>>>
> >>>>>>>>>>> this.startTimer = function() {
> >>>>>>>>>>> dojo.debug("starting timer with frequency " +
> >>>>>>>>>>> self.frequency);
> >>>>>>>>>>> self.timer.start();
> >>>>>>>>>>> };
> >>>>>>>>>>> };
> >>>>>>>>>>>
> >>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
> >>>>>>>>>>> dojo.widget.html.ContentPane);
> >>>>>>>>>>>
> >>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> Musachy Barroso wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
> >>>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
> >>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
> >>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
> >>>>>>>>>>>> struts), and they are quite different. I think we should
> >>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
> >>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto
> refresh.
> >>>>>>>>>>>>
> >>>>>>>>>>>> what do you guys think?
> >>>>>>>>>>>>
> >>>>>>>>>>>> musachy
> >>>>>>>>>>>>
> >>>>>>>>>>>> Ian Roughley wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
> >>>>>>>>>>>>> to do as much as possible in dojo and provide light wrappers
> >>>>>>>>>>>>> in Struts. When we first implemented the tabs, there was no
> >>>>>>>>>>>>> such dojo implementation. The one feature that we had that
> >>>>>>>>>>>>> you should check that has been implemented in dojo is the
> >>>>>>>>>>>>> pub/sub events - so there should be events that each tabs
> >>>>>>>>>>>>> listens to to refresh itself.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
> >>>>>>>>>>>>> lightweight wrapper in struts and have all the work being
> >>>>>>>>>>>>> done in dojo.
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> The other big thing that would be a great help is converting
> >>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Ian
> >>>>>>>>>>>>>
> >>>>>>>>>>>>>
> >>>>>>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>>>>>
> >>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>>>>
> >>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>>>
> >>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>>
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> ---------------------------------------------------------------------
> >>>>>>>>
> >>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>>
> >>>>>
> >>>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >>> For additional commands, e-mail: dev-help@struts.apache.org
> >>>
> >>>
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
Re: ajax tags
Posted by Musachy Barroso <mu...@gmail.com>.
I don't think it will be that bad, the new tags should work ok, and the
others are just a few. I know for sure we will have to rewrite the Tree
tag, because they have released a brand new tree.
musachy
Don Brown wrote:
> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
> update the tags. How much work do you think it'll be to upgrade Dojo?
>
> Don
>
> Musachy Barroso wrote:
>> I attached a new patch to WW-205, this one includes the new
>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
>> me to create a patch to update to Dojo 0.3.1?(We just need to replace
>> dojo distribution under static/dojo.)
>>
>> I modified the examples in showcase and the test cases. Let me know
>> if something is missing or wrong (bear with me on my first patch :) ).
>>
>> musachy
>>
>> Don Brown wrote:
>>> Ok, then put those two under one ticket. You know best :)
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> That's ok, the only problem is that this one by itself would break
>>>> anchor and tabbed panel.
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>> I'd prefer separate issues, with attached patches. As for
>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
>>>>> to use it more.
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
>>>>>> me to create a patch for it, or wait and create a big one when
>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>> (Selenium maybe?)
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>>>> message on their mailing list.
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> Don Brown wrote:
>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>>>> shouldn't upgrade to it?
>>>>>>>>
>>>>>>>> Don
>>>>>>>>
>>>>>>>> Musachy Barroso wrote:
>>>>>>>>> Would something like this include all the current
>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
>>>>>>>>> property). This way BindDiv will be easier to maintain (dojo's
>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>
>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>
>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>
>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>> var self = this;
>>>>>>>>>
>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>
>>>>>>>>> this.href = "";
>>>>>>>>> this.extractContent = false;
>>>>>>>>> this.parseContent = false;
>>>>>>>>> this.cacheContent = false;
>>>>>>>>>
>>>>>>>>> this.frequency = 0;
>>>>>>>>> this.delay = 0;
>>>>>>>>> this.startTimer = false;
>>>>>>>>> this.timer = null;
>>>>>>>>>
>>>>>>>>> //pub/sub events
>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>
>>>>>>>>> this.postCreate = function() {
>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>
>>>>>>>>> //start the timer
>>>>>>>>> if(self.startTimer) {
>>>>>>>>> //start after delay
>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>>>> }
>>>>>>>>> }
>>>>>>>>>
>>>>>>>>> //attach listeners
>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>> self, "reloadContents");
>>>>>>>>> }
>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>>> self, "stopTimer");
>>>>>>>>> }
>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>>>> self, "startTimer");
>>>>>>>>> }
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.reloadContents = function() {
>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>> self.isLoaded = false;
>>>>>>>>> self.loadContents();
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.stopTimer = function() {
>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>> self.timer.stop();
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.startTimer = function() {
>>>>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>>>>> self.timer.start();
>>>>>>>>> };
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>
>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto refresh.
>>>>>>>>>>
>>>>>>>>>> what do you guys think?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
>>>>>>>>>>> to do as much as possible in dojo and provide light wrappers
>>>>>>>>>>> in Struts. When we first implemented the tabs, there was no
>>>>>>>>>>> such dojo implementation. The one feature that we had that
>>>>>>>>>>> you should check that has been implemented in dojo is the
>>>>>>>>>>> pub/sub events - so there should be events that each tabs
>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>
>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>> lightweight wrapper in struts and have all the work being
>>>>>>>>>>> done in dojo.
>>>>>>>>>>>
>>>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>
>>>>>>>>>>> Ian
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Hi Rainer
Give me a couple of days so I can test it against 0.4 (I made the patch
using 0.3) and finish some changes(for BindButton) that I have for a new
patch. I will give you a new patch soon with the changes for Bind,
BindDiv, BindAnchor, BindButton and TabbedPanel tested on dojo 0.4. If
you want to go ahead and upgrade to 0.4 and apply the patch later,
that's fine. (I will just be bothering with another patch soon :) )
musachy
Rainer Hermanns wrote:
> Musachy,
>
> I could upgrade the embedded Dojo files to the 0.4 release during the week.
> If your patches for the s2 ajax tags already are against the 0.4 release,
> I could apply those as well.
>
> What do you (and others of course) think?
>
> regards,
> Rainer
>
>
>> Any idea on when is Dojo going to be bumped up to 0.4?
>>
>> musachy
>>
>> Don Brown wrote:
>>
>>> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
>>> update the tags. How much work do you think it'll be to upgrade Dojo?
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>
>>>> I attached a new patch to WW-205, this one includes the new
>>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
>>>> me to create a patch to update to Dojo 0.3.1?(We just need to replace
>>>> dojo distribution under static/dojo.)
>>>>
>>>> I modified the examples in showcase and the test cases. Let me know
>>>> if something is missing or wrong (bear with me on my first patch :) ).
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>
>>>>> Ok, then put those two under one ticket. You know best :)
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>
>>>>>> That's ok, the only problem is that this one by itself would break
>>>>>> anchor and tabbed panel.
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> Don Brown wrote:
>>>>>>
>>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
>>>>>>> to use it more.
>>>>>>>
>>>>>>> Don
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>
>>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
>>>>>>>> me to create a patch for it, or wait and create a big one when
>>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>>> (Selenium maybe?)
>>>>>>>>
>>>>>>>> Musachy Barroso wrote:
>>>>>>>>
>>>>>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>>>>>> message on their mailing list.
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> Don Brown wrote:
>>>>>>>>>
>>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>>
>>>>>>>>>> Don
>>>>>>>>>>
>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>
>>>>>>>>>>> Would something like this include all the current
>>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
>>>>>>>>>>> property). This way BindDiv will be easier to maintain (dojo's
>>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
>>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>>
>>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>>
>>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>>
>>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>>> var self = this;
>>>>>>>>>>>
>>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>>
>>>>>>>>>>> this.href = "";
>>>>>>>>>>> this.extractContent = false;
>>>>>>>>>>> this.parseContent = false;
>>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>>
>>>>>>>>>>> this.frequency = 0;
>>>>>>>>>>> this.delay = 0;
>>>>>>>>>>> this.startTimer = false;
>>>>>>>>>>> this.timer = null;
>>>>>>>>>>>
>>>>>>>>>>> //pub/sub events
>>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>>
>>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>>
>>>>>>>>>>> //start the timer
>>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>>> //start after delay
>>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>>>>>> }
>>>>>>>>>>> }
>>>>>>>>>>>
>>>>>>>>>>> //attach listeners
>>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>>> self, "reloadContents");
>>>>>>>>>>> }
>>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>>>>> self, "stopTimer");
>>>>>>>>>>> }
>>>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>>>>>> self, "startTimer");
>>>>>>>>>>> }
>>>>>>>>>>> };
>>>>>>>>>>>
>>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>>> self.loadContents();
>>>>>>>>>>> };
>>>>>>>>>>>
>>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>>> self.timer.stop();
>>>>>>>>>>> };
>>>>>>>>>>>
>>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>>> self.frequency);
>>>>>>>>>>> self.timer.start();
>>>>>>>>>>> };
>>>>>>>>>>> };
>>>>>>>>>>>
>>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>>
>>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto refresh.
>>>>>>>>>>>>
>>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>>
>>>>>>>>>>>> musachy
>>>>>>>>>>>>
>>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
>>>>>>>>>>>>> to do as much as possible in dojo and provide light wrappers
>>>>>>>>>>>>> in Struts. When we first implemented the tabs, there was no
>>>>>>>>>>>>> such dojo implementation. The one feature that we had that
>>>>>>>>>>>>> you should check that has been implemented in dojo is the
>>>>>>>>>>>>> pub/sub events - so there should be events that each tabs
>>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>>> lightweight wrapper in struts and have all the work being
>>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>>
>>>>>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Ian
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>>
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Rainer Hermanns <he...@aixcept.de>.
Musachy,
I could upgrade the embedded Dojo files to the 0.4 release during the week.
If your patches for the s2 ajax tags already are against the 0.4 release,
I could apply those as well.
What do you (and others of course) think?
regards,
Rainer
> Any idea on when is Dojo going to be bumped up to 0.4?
>
> musachy
>
> Don Brown wrote:
>> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
>> update the tags. How much work do you think it'll be to upgrade Dojo?
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> I attached a new patch to WW-205, this one includes the new
>>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
>>> me to create a patch to update to Dojo 0.3.1?(We just need to replace
>>> dojo distribution under static/dojo.)
>>>
>>> I modified the examples in showcase and the test cases. Let me know
>>> if something is missing or wrong (bear with me on my first patch :) ).
>>>
>>> musachy
>>>
>>> Don Brown wrote:
>>>> Ok, then put those two under one ticket. You know best :)
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> That's ok, the only problem is that this one by itself would break
>>>>> anchor and tabbed panel.
>>>>>
>>>>> musachy
>>>>>
>>>>> Don Brown wrote:
>>>>>> I'd prefer separate issues, with attached patches. As for
>>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
>>>>>> to use it more.
>>>>>>
>>>>>> Don
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
>>>>>>> me to create a patch for it, or wait and create a big one when
>>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>>> (Selenium maybe?)
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>>>>> message on their mailing list.
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Don Brown wrote:
>>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>>>>> shouldn't upgrade to it?
>>>>>>>>>
>>>>>>>>> Don
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>> Would something like this include all the current
>>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
>>>>>>>>>> property). This way BindDiv will be easier to maintain (dojo's
>>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
>>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>>
>>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>>
>>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>>
>>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>>> var self = this;
>>>>>>>>>>
>>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>>
>>>>>>>>>> this.href = "";
>>>>>>>>>> this.extractContent = false;
>>>>>>>>>> this.parseContent = false;
>>>>>>>>>> this.cacheContent = false;
>>>>>>>>>>
>>>>>>>>>> this.frequency = 0;
>>>>>>>>>> this.delay = 0;
>>>>>>>>>> this.startTimer = false;
>>>>>>>>>> this.timer = null;
>>>>>>>>>>
>>>>>>>>>> //pub/sub events
>>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>>
>>>>>>>>>> this.postCreate = function() {
>>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>>
>>>>>>>>>> //start the timer
>>>>>>>>>> if(self.startTimer) {
>>>>>>>>>> //start after delay
>>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>>>>> }
>>>>>>>>>> }
>>>>>>>>>>
>>>>>>>>>> //attach listeners
>>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>>> self, "reloadContents");
>>>>>>>>>> }
>>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>>>> self, "stopTimer");
>>>>>>>>>> }
>>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>>>>> self, "startTimer");
>>>>>>>>>> }
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>> this.reloadContents = function() {
>>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>>> self.isLoaded = false;
>>>>>>>>>> self.loadContents();
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>> this.stopTimer = function() {
>>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>>> self.timer.stop();
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>> this.startTimer = function() {
>>>>>>>>>> dojo.debug("starting timer with frequency " +
>>>>>>>>>> self.frequency);
>>>>>>>>>> self.timer.start();
>>>>>>>>>> };
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>>
>>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto refresh.
>>>>>>>>>>>
>>>>>>>>>>> what do you guys think?
>>>>>>>>>>>
>>>>>>>>>>> musachy
>>>>>>>>>>>
>>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
>>>>>>>>>>>> to do as much as possible in dojo and provide light wrappers
>>>>>>>>>>>> in Struts. When we first implemented the tabs, there was no
>>>>>>>>>>>> such dojo implementation. The one feature that we had that
>>>>>>>>>>>> you should check that has been implemented in dojo is the
>>>>>>>>>>>> pub/sub events - so there should be events that each tabs
>>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>>
>>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>>> lightweight wrapper in struts and have all the work being
>>>>>>>>>>>> done in dojo.
>>>>>>>>>>>>
>>>>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>>
>>>>>>>>>>>> Ian
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
Any idea on when is Dojo going to be bumped up to 0.4?
musachy
Don Brown wrote:
> Yes, let's start with bumping up Dojo to 0.4, then apply patches to
> update the tags. How much work do you think it'll be to upgrade Dojo?
>
> Don
>
> Musachy Barroso wrote:
>> I attached a new patch to WW-205, this one includes the new
>> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
>> me to create a patch to update to Dojo 0.3.1?(We just need to replace
>> dojo distribution under static/dojo.)
>>
>> I modified the examples in showcase and the test cases. Let me know
>> if something is missing or wrong (bear with me on my first patch :) ).
>>
>> musachy
>>
>> Don Brown wrote:
>>> Ok, then put those two under one ticket. You know best :)
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> That's ok, the only problem is that this one by itself would break
>>>> anchor and tabbed panel.
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>> I'd prefer separate issues, with attached patches. As for
>>>>> testing, we started to use Patrick's hostedqa stuff, but we need
>>>>> to use it more.
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
>>>>>> me to create a patch for it, or wait and create a big one when
>>>>>> I'm done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>>> (Selenium maybe?)
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>>>> message on their mailing list.
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> Don Brown wrote:
>>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>>>> shouldn't upgrade to it?
>>>>>>>>
>>>>>>>> Don
>>>>>>>>
>>>>>>>> Musachy Barroso wrote:
>>>>>>>>> Would something like this include all the current
>>>>>>>>> functionality in BindDiv? (events for stop/start timer,
>>>>>>>>> refresh, start after a delay, advisor via dojo's "handler"
>>>>>>>>> property). This way BindDiv will be easier to maintain (dojo's
>>>>>>>>> ContentPane + timer) and the Tab widget can be deleted
>>>>>>>>> (doesn't add anything to this one). By the way this doesn't
>>>>>>>>> work on AMD 64/firefox/linux due to a dojo's bug.
>>>>>>>>>
>>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>>
>>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>>
>>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>>> var self = this;
>>>>>>>>>
>>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>>
>>>>>>>>> this.href = "";
>>>>>>>>> this.extractContent = false;
>>>>>>>>> this.parseContent = false;
>>>>>>>>> this.cacheContent = false;
>>>>>>>>>
>>>>>>>>> this.frequency = 0;
>>>>>>>>> this.delay = 0;
>>>>>>>>> this.startTimer = false;
>>>>>>>>> this.timer = null;
>>>>>>>>>
>>>>>>>>> //pub/sub events
>>>>>>>>> this.refreshListenTopics = "";
>>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>>
>>>>>>>>> this.postCreate = function() {
>>>>>>>>> if(self.frequency > 0) {
>>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>>
>>>>>>>>> //start the timer
>>>>>>>>> if(self.startTimer) {
>>>>>>>>> //start after delay
>>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>>>> }
>>>>>>>>> }
>>>>>>>>>
>>>>>>>>> //attach listeners
>>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics,
>>>>>>>>> self, "reloadContents");
>>>>>>>>> }
>>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>>> self, "stopTimer");
>>>>>>>>> }
>>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>>>> self, "startTimer");
>>>>>>>>> }
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.reloadContents = function() {
>>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>>> self.isLoaded = false;
>>>>>>>>> self.loadContents();
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.stopTimer = function() {
>>>>>>>>> dojo.debug("stopping timer");
>>>>>>>>> self.timer.stop();
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> this.startTimer = function() {
>>>>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>>>>> self.timer.start();
>>>>>>>>> };
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>>
>>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Musachy Barroso wrote:
>>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>>>> replace HTMLBindDiv with an implementation that extends
>>>>>>>>>> dojo's ContentPane and add a timer to it for the auto refresh.
>>>>>>>>>>
>>>>>>>>>> what do you guys think?
>>>>>>>>>>
>>>>>>>>>> musachy
>>>>>>>>>>
>>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try
>>>>>>>>>>> to do as much as possible in dojo and provide light wrappers
>>>>>>>>>>> in Struts. When we first implemented the tabs, there was no
>>>>>>>>>>> such dojo implementation. The one feature that we had that
>>>>>>>>>>> you should check that has been implemented in dojo is the
>>>>>>>>>>> pub/sub events - so there should be events that each tabs
>>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>>
>>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>>> lightweight wrapper in struts and have all the work being
>>>>>>>>>>> done in dojo.
>>>>>>>>>>>
>>>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>>
>>>>>>>>>>> Ian
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Yes, let's start with bumping up Dojo to 0.4, then apply patches to
update the tags. How much work do you think it'll be to upgrade Dojo?
Don
Musachy Barroso wrote:
> I attached a new patch to WW-205, this one includes the new
> TabbedPanel, BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want
> me to create a patch to update to Dojo 0.3.1?(We just need to replace
> dojo distribution under static/dojo.)
>
> I modified the examples in showcase and the test cases. Let me know if
> something is missing or wrong (bear with me on my first patch :) ).
>
> musachy
>
> Don Brown wrote:
>> Ok, then put those two under one ticket. You know best :)
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> That's ok, the only problem is that this one by itself would break
>>> anchor and tabbed panel.
>>>
>>> musachy
>>>
>>> Don Brown wrote:
>>>> I'd prefer separate issues, with attached patches. As for testing,
>>>> we started to use Patrick's hostedqa stuff, but we need to use it
>>>> more.
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> I have everything (I think :)) for the ajax Div Tag, do you want
>>>>> me to create a patch for it, or wait and create a big one when I'm
>>>>> done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>>
>>>>> musachy
>>>>>
>>>>> //Have you guys consider anything to test this ajax stuff?
>>>>> (Selenium maybe?)
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>>> message on their mailing list.
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> Don Brown wrote:
>>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>>> shouldn't upgrade to it?
>>>>>>>
>>>>>>> Don
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> Would something like this include all the current functionality
>>>>>>>> in BindDiv? (events for stop/start timer, refresh, start after
>>>>>>>> a delay, advisor via dojo's "handler" property). This way
>>>>>>>> BindDiv will be easier to maintain (dojo's ContentPane + timer)
>>>>>>>> and the Tab widget can be deleted (doesn't add anything to this
>>>>>>>> one). By the way this doesn't work on AMD 64/firefox/linux due
>>>>>>>> to a dojo's bug.
>>>>>>>>
>>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>>
>>>>>>>> dojo.require("dojo.widget.*");
>>>>>>>> dojo.require("dojo.io.*");
>>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>>
>>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>>> var self = this;
>>>>>>>>
>>>>>>>> this.widgetType = "BindDiv";
>>>>>>>>
>>>>>>>> this.href = "";
>>>>>>>> this.extractContent = false;
>>>>>>>> this.parseContent = false;
>>>>>>>> this.cacheContent = false;
>>>>>>>>
>>>>>>>> this.frequency = 0;
>>>>>>>> this.delay = 0;
>>>>>>>> this.startTimer = false;
>>>>>>>> this.timer = null;
>>>>>>>>
>>>>>>>> //pub/sub events
>>>>>>>> this.refreshListenTopics = "";
>>>>>>>> this.stopTimerListenTopics = "";
>>>>>>>> this.startTimerListenTopics = "";
>>>>>>>>
>>>>>>>> this.postCreate = function() {
>>>>>>>> if(self.frequency > 0) {
>>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>>
>>>>>>>> //start the timer
>>>>>>>> if(self.startTimer) {
>>>>>>>> //start after delay
>>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>>> }
>>>>>>>> }
>>>>>>>>
>>>>>>>> //attach listeners
>>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>>>>>> "reloadContents");
>>>>>>>> }
>>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>>> self, "stopTimer");
>>>>>>>> }
>>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>>> self, "startTimer");
>>>>>>>> }
>>>>>>>> };
>>>>>>>>
>>>>>>>> this.reloadContents = function() {
>>>>>>>> //refresh is not visible in ContentPane
>>>>>>>> self.isLoaded = false;
>>>>>>>> self.loadContents();
>>>>>>>> };
>>>>>>>>
>>>>>>>> this.stopTimer = function() {
>>>>>>>> dojo.debug("stopping timer");
>>>>>>>> self.timer.stop();
>>>>>>>> };
>>>>>>>>
>>>>>>>> this.startTimer = function() {
>>>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>>>> self.timer.start();
>>>>>>>> };
>>>>>>>> };
>>>>>>>>
>>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>>
>>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Musachy Barroso wrote:
>>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>>> replace HTMLBindDiv with an implementation that extends dojo's
>>>>>>>>> ContentPane and add a timer to it for the auto refresh.
>>>>>>>>>
>>>>>>>>> what do you guys think?
>>>>>>>>>
>>>>>>>>> musachy
>>>>>>>>>
>>>>>>>>> Ian Roughley wrote:
>>>>>>>>>> Yes - this was the direction that we wanted to go in. Try to
>>>>>>>>>> do as much as possible in dojo and provide light wrappers in
>>>>>>>>>> Struts. When we first implemented the tabs, there was no
>>>>>>>>>> such dojo implementation. The one feature that we had that
>>>>>>>>>> you should check that has been implemented in dojo is the
>>>>>>>>>> pub/sub events - so there should be events that each tabs
>>>>>>>>>> listens to to refresh itself.
>>>>>>>>>>
>>>>>>>>>> I think as Don pointed out, we want to keep a very
>>>>>>>>>> lightweight wrapper in struts and have all the work being
>>>>>>>>>> done in dojo.
>>>>>>>>>>
>>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>>
>>>>>>>>>> Ian
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>>
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I attached a new patch to WW-205, this one includes the new TabbedPanel,
BindDiv and BindAnchor. It needs Dojo 0.3.1.Do you want me to create a
patch to update to Dojo 0.3.1?(We just need to replace dojo distribution
under static/dojo.)
I modified the examples in showcase and the test cases. Let me know if
something is missing or wrong (bear with me on my first patch :) ).
musachy
Don Brown wrote:
> Ok, then put those two under one ticket. You know best :)
>
> Don
>
> Musachy Barroso wrote:
>> That's ok, the only problem is that this one by itself would break
>> anchor and tabbed panel.
>>
>> musachy
>>
>> Don Brown wrote:
>>> I'd prefer separate issues, with attached patches. As for testing,
>>> we started to use Patrick's hostedqa stuff, but we need to use it more.
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> I have everything (I think :)) for the ajax Div Tag, do you want me
>>>> to create a patch for it, or wait and create a big one when I'm
>>>> done with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>>
>>>> musachy
>>>>
>>>> //Have you guys consider anything to test this ajax stuff?
>>>> (Selenium maybe?)
>>>>
>>>> Musachy Barroso wrote:
>>>>> This was with 0.3.1 which is the current release. I posted a
>>>>> message on their mailing list.
>>>>>
>>>>> musachy
>>>>>
>>>>> Don Brown wrote:
>>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>>> shouldn't upgrade to it?
>>>>>>
>>>>>> Don
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> Would something like this include all the current functionality
>>>>>>> in BindDiv? (events for stop/start timer, refresh, start after a
>>>>>>> delay, advisor via dojo's "handler" property). This way BindDiv
>>>>>>> will be easier to maintain (dojo's ContentPane + timer) and the
>>>>>>> Tab widget can be deleted (doesn't add anything to this one). By
>>>>>>> the way this doesn't work on AMD 64/firefox/linux due to a
>>>>>>> dojo's bug.
>>>>>>>
>>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>>
>>>>>>> dojo.require("dojo.widget.*");
>>>>>>> dojo.require("dojo.io.*");
>>>>>>> dojo.require("dojo.widget.Container");
>>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>>
>>>>>>> struts.widgets.BindDiv = function() {
>>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>>> var self = this;
>>>>>>>
>>>>>>> this.widgetType = "BindDiv";
>>>>>>>
>>>>>>> this.href = "";
>>>>>>> this.extractContent = false;
>>>>>>> this.parseContent = false;
>>>>>>> this.cacheContent = false;
>>>>>>>
>>>>>>> this.frequency = 0;
>>>>>>> this.delay = 0;
>>>>>>> this.startTimer = false;
>>>>>>> this.timer = null;
>>>>>>>
>>>>>>> //pub/sub events
>>>>>>> this.refreshListenTopics = "";
>>>>>>> this.stopTimerListenTopics = "";
>>>>>>> this.startTimerListenTopics = "";
>>>>>>>
>>>>>>> this.postCreate = function() {
>>>>>>> if(self.frequency > 0) {
>>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>>
>>>>>>> //start the timer
>>>>>>> if(self.startTimer) {
>>>>>>> //start after delay
>>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>>> }
>>>>>>> }
>>>>>>>
>>>>>>> //attach listeners
>>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>>>>> "reloadContents");
>>>>>>> }
>>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics,
>>>>>>> self, "stopTimer");
>>>>>>> }
>>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>>> self, "startTimer");
>>>>>>> }
>>>>>>> };
>>>>>>>
>>>>>>> this.reloadContents = function() {
>>>>>>> //refresh is not visible in ContentPane
>>>>>>> self.isLoaded = false;
>>>>>>> self.loadContents();
>>>>>>> };
>>>>>>>
>>>>>>> this.stopTimer = function() {
>>>>>>> dojo.debug("stopping timer");
>>>>>>> self.timer.stop();
>>>>>>> };
>>>>>>>
>>>>>>> this.startTimer = function() {
>>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>>> self.timer.start();
>>>>>>> };
>>>>>>> };
>>>>>>>
>>>>>>> dojo.inherits(struts.widgets.BindDiv,
>>>>>>> dojo.widget.html.ContentPane);
>>>>>>>
>>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Musachy Barroso wrote:
>>>>>>>> I was looking at the Div/Panel classes and I think we need to
>>>>>>>> do some changes, right now Panel extends Div and PanelTag
>>>>>>>> exteds DivTag. The problem is that the new PanelTag wraps
>>>>>>>> dojo's ContentPane, while DivTag wraps HTMLBindDiv(from
>>>>>>>> struts), and they are quite different. I think we should
>>>>>>>> replace HTMLBindDiv with an implementation that extends dojo's
>>>>>>>> ContentPane and add a timer to it for the auto refresh.
>>>>>>>>
>>>>>>>> what do you guys think?
>>>>>>>>
>>>>>>>> musachy
>>>>>>>>
>>>>>>>> Ian Roughley wrote:
>>>>>>>>> Yes - this was the direction that we wanted to go in. Try to
>>>>>>>>> do as much as possible in dojo and provide light wrappers in
>>>>>>>>> Struts. When we first implemented the tabs, there was no such
>>>>>>>>> dojo implementation. The one feature that we had that you
>>>>>>>>> should check that has been implemented in dojo is the pub/sub
>>>>>>>>> events - so there should be events that each tabs listens to
>>>>>>>>> to refresh itself.
>>>>>>>>>
>>>>>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>>>>>
>>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>>
>>>>>>>>> Ian
>>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
Ok, then put those two under one ticket. You know best :)
Don
Musachy Barroso wrote:
> That's ok, the only problem is that this one by itself would break
> anchor and tabbed panel.
>
> musachy
>
> Don Brown wrote:
>> I'd prefer separate issues, with attached patches. As for testing,
>> we started to use Patrick's hostedqa stuff, but we need to use it more.
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> I have everything (I think :)) for the ajax Div Tag, do you want me
>>> to create a patch for it, or wait and create a big one when I'm done
>>> with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>>
>>> musachy
>>>
>>> //Have you guys consider anything to test this ajax stuff? (Selenium
>>> maybe?)
>>>
>>> Musachy Barroso wrote:
>>>> This was with 0.3.1 which is the current release. I posted a
>>>> message on their mailing list.
>>>>
>>>> musachy
>>>>
>>>> Don Brown wrote:
>>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>>> shouldn't upgrade to it?
>>>>>
>>>>> Don
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> Would something like this include all the current functionality
>>>>>> in BindDiv? (events for stop/start timer, refresh, start after a
>>>>>> delay, advisor via dojo's "handler" property). This way BindDiv
>>>>>> will be easier to maintain (dojo's ContentPane + timer) and the
>>>>>> Tab widget can be deleted (doesn't add anything to this one). By
>>>>>> the way this doesn't work on AMD 64/firefox/linux due to a dojo's
>>>>>> bug.
>>>>>>
>>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>>
>>>>>> dojo.require("dojo.widget.*");
>>>>>> dojo.require("dojo.io.*");
>>>>>> dojo.require("dojo.widget.Container");
>>>>>> dojo.require("dojo.widget.ContentPane");
>>>>>> dojo.require("dojo.animation.Timer");
>>>>>>
>>>>>> struts.widgets.BindDiv = function() {
>>>>>> dojo.widget.html.ContentPane.call(this);
>>>>>> var self = this;
>>>>>>
>>>>>> this.widgetType = "BindDiv";
>>>>>>
>>>>>> this.href = "";
>>>>>> this.extractContent = false;
>>>>>> this.parseContent = false;
>>>>>> this.cacheContent = false;
>>>>>>
>>>>>> this.frequency = 0;
>>>>>> this.delay = 0;
>>>>>> this.startTimer = false;
>>>>>> this.timer = null;
>>>>>>
>>>>>> //pub/sub events
>>>>>> this.refreshListenTopics = "";
>>>>>> this.stopTimerListenTopics = "";
>>>>>> this.startTimerListenTopics = "";
>>>>>>
>>>>>> this.postCreate = function() {
>>>>>> if(self.frequency > 0) {
>>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>>> self.timer.onTick = self.reloadContents;
>>>>>>
>>>>>> //start the timer
>>>>>> if(self.startTimer) {
>>>>>> //start after delay
>>>>>> dojo.debug("starting timer after " + self.delay);
>>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>>> }
>>>>>> }
>>>>>>
>>>>>> //attach listeners
>>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>>>> "reloadContents");
>>>>>> }
>>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics, self,
>>>>>> "stopTimer");
>>>>>> }
>>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics,
>>>>>> self, "startTimer");
>>>>>> }
>>>>>> };
>>>>>>
>>>>>> this.reloadContents = function() {
>>>>>> //refresh is not visible in ContentPane
>>>>>> self.isLoaded = false;
>>>>>> self.loadContents();
>>>>>> };
>>>>>>
>>>>>> this.stopTimer = function() {
>>>>>> dojo.debug("stopping timer");
>>>>>> self.timer.stop();
>>>>>> };
>>>>>>
>>>>>> this.startTimer = function() {
>>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>>> self.timer.start();
>>>>>> };
>>>>>> };
>>>>>>
>>>>>> dojo.inherits(struts.widgets.BindDiv, dojo.widget.html.ContentPane);
>>>>>>
>>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>>
>>>>>>
>>>>>>
>>>>>> Musachy Barroso wrote:
>>>>>>> I was looking at the Div/Panel classes and I think we need to do
>>>>>>> some changes, right now Panel extends Div and PanelTag exteds
>>>>>>> DivTag. The problem is that the new PanelTag wraps dojo's
>>>>>>> ContentPane, while DivTag wraps HTMLBindDiv(from struts), and
>>>>>>> they are quite different. I think we should replace HTMLBindDiv
>>>>>>> with an implementation that extends dojo's ContentPane and add a
>>>>>>> timer to it for the auto refresh.
>>>>>>>
>>>>>>> what do you guys think?
>>>>>>>
>>>>>>> musachy
>>>>>>>
>>>>>>> Ian Roughley wrote:
>>>>>>>> Yes - this was the direction that we wanted to go in. Try to
>>>>>>>> do as much as possible in dojo and provide light wrappers in
>>>>>>>> Struts. When we first implemented the tabs, there was no such
>>>>>>>> dojo implementation. The one feature that we had that you
>>>>>>>> should check that has been implemented in dojo is the pub/sub
>>>>>>>> events - so there should be events that each tabs listens to to
>>>>>>>> refresh itself.
>>>>>>>>
>>>>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>>>>
>>>>>>>> The other big thing that would be a great help is converting
>>>>>>>> the code from dojo 0.2 to 0.3 :)
>>>>>>>>
>>>>>>>> Ian
>>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
That's ok, the only problem is that this one by itself would break
anchor and tabbed panel.
musachy
Don Brown wrote:
> I'd prefer separate issues, with attached patches. As for testing, we
> started to use Patrick's hostedqa stuff, but we need to use it more.
>
> Don
>
> Musachy Barroso wrote:
>> I have everything (I think :)) for the ajax Div Tag, do you want me
>> to create a patch for it, or wait and create a big one when I'm done
>> with the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>>
>> musachy
>>
>> //Have you guys consider anything to test this ajax stuff? (Selenium
>> maybe?)
>>
>> Musachy Barroso wrote:
>>> This was with 0.3.1 which is the current release. I posted a message
>>> on their mailing list.
>>>
>>> musachy
>>>
>>> Don Brown wrote:
>>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>>> shouldn't upgrade to it?
>>>>
>>>> Don
>>>>
>>>> Musachy Barroso wrote:
>>>>> Would something like this include all the current functionality in
>>>>> BindDiv? (events for stop/start timer, refresh, start after a
>>>>> delay, advisor via dojo's "handler" property). This way BindDiv
>>>>> will be easier to maintain (dojo's ContentPane + timer) and the
>>>>> Tab widget can be deleted (doesn't add anything to this one). By
>>>>> the way this doesn't work on AMD 64/firefox/linux due to a dojo's
>>>>> bug.
>>>>>
>>>>> dojo.provide("struts.widgets.BindDiv");
>>>>>
>>>>> dojo.require("dojo.widget.*");
>>>>> dojo.require("dojo.io.*");
>>>>> dojo.require("dojo.widget.Container");
>>>>> dojo.require("dojo.widget.ContentPane");
>>>>> dojo.require("dojo.animation.Timer");
>>>>>
>>>>> struts.widgets.BindDiv = function() {
>>>>> dojo.widget.html.ContentPane.call(this);
>>>>> var self = this;
>>>>>
>>>>> this.widgetType = "BindDiv";
>>>>>
>>>>> this.href = "";
>>>>> this.extractContent = false;
>>>>> this.parseContent = false;
>>>>> this.cacheContent = false;
>>>>>
>>>>> this.frequency = 0;
>>>>> this.delay = 0;
>>>>> this.startTimer = false;
>>>>> this.timer = null;
>>>>>
>>>>> //pub/sub events
>>>>> this.refreshListenTopics = "";
>>>>> this.stopTimerListenTopics = "";
>>>>> this.startTimerListenTopics = "";
>>>>>
>>>>> this.postCreate = function() {
>>>>> if(self.frequency > 0) {
>>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>>> self.timer.onTick = self.reloadContents;
>>>>>
>>>>> //start the timer
>>>>> if(self.startTimer) {
>>>>> //start after delay
>>>>> dojo.debug("starting timer after " + self.delay);
>>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>>> }
>>>>> }
>>>>>
>>>>> //attach listeners
>>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>>> "reloadContents");
>>>>> }
>>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics, self,
>>>>> "stopTimer");
>>>>> }
>>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>>> dojo.event.topic.subscribe(self.startTimerListenTopics, self,
>>>>> "startTimer");
>>>>> }
>>>>> };
>>>>>
>>>>> this.reloadContents = function() {
>>>>> //refresh is not visible in ContentPane
>>>>> self.isLoaded = false;
>>>>> self.loadContents();
>>>>> };
>>>>>
>>>>> this.stopTimer = function() {
>>>>> dojo.debug("stopping timer");
>>>>> self.timer.stop();
>>>>> };
>>>>>
>>>>> this.startTimer = function() {
>>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>>> self.timer.start();
>>>>> };
>>>>> };
>>>>>
>>>>> dojo.inherits(struts.widgets.BindDiv, dojo.widget.html.ContentPane);
>>>>>
>>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>>
>>>>>
>>>>>
>>>>> Musachy Barroso wrote:
>>>>>> I was looking at the Div/Panel classes and I think we need to do
>>>>>> some changes, right now Panel extends Div and PanelTag exteds
>>>>>> DivTag. The problem is that the new PanelTag wraps dojo's
>>>>>> ContentPane, while DivTag wraps HTMLBindDiv(from struts), and
>>>>>> they are quite different. I think we should replace HTMLBindDiv
>>>>>> with an implementation that extends dojo's ContentPane and add a
>>>>>> timer to it for the auto refresh.
>>>>>>
>>>>>> what do you guys think?
>>>>>>
>>>>>> musachy
>>>>>>
>>>>>> Ian Roughley wrote:
>>>>>>> Yes - this was the direction that we wanted to go in. Try to do
>>>>>>> as much as possible in dojo and provide light wrappers in
>>>>>>> Struts. When we first implemented the tabs, there was no such
>>>>>>> dojo implementation. The one feature that we had that you
>>>>>>> should check that has been implemented in dojo is the pub/sub
>>>>>>> events - so there should be events that each tabs listens to to
>>>>>>> refresh itself.
>>>>>>>
>>>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>>>
>>>>>>> The other big thing that would be a great help is converting the
>>>>>>> code from dojo 0.2 to 0.3 :)
>>>>>>>
>>>>>>> Ian
>>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Don Brown <mr...@twdata.org>.
I'd prefer separate issues, with attached patches. As for testing, we
started to use Patrick's hostedqa stuff, but we need to use it more.
Don
Musachy Barroso wrote:
> I have everything (I think :)) for the ajax Div Tag, do you want me to
> create a patch for it, or wait and create a big one when I'm done with
> the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
>
> musachy
>
> //Have you guys consider anything to test this ajax stuff? (Selenium
> maybe?)
>
> Musachy Barroso wrote:
>> This was with 0.3.1 which is the current release. I posted a message
>> on their mailing list.
>>
>> musachy
>>
>> Don Brown wrote:
>>> Have you tried this with the Dojo 0.4 release? Any reason we
>>> shouldn't upgrade to it?
>>>
>>> Don
>>>
>>> Musachy Barroso wrote:
>>>> Would something like this include all the current functionality in
>>>> BindDiv? (events for stop/start timer, refresh, start after a
>>>> delay, advisor via dojo's "handler" property). This way BindDiv
>>>> will be easier to maintain (dojo's ContentPane + timer) and the Tab
>>>> widget can be deleted (doesn't add anything to this one). By the
>>>> way this doesn't work on AMD 64/firefox/linux due to a dojo's bug.
>>>>
>>>> dojo.provide("struts.widgets.BindDiv");
>>>>
>>>> dojo.require("dojo.widget.*");
>>>> dojo.require("dojo.io.*");
>>>> dojo.require("dojo.widget.Container");
>>>> dojo.require("dojo.widget.ContentPane");
>>>> dojo.require("dojo.animation.Timer");
>>>>
>>>> struts.widgets.BindDiv = function() {
>>>> dojo.widget.html.ContentPane.call(this);
>>>> var self = this;
>>>>
>>>> this.widgetType = "BindDiv";
>>>>
>>>> this.href = "";
>>>> this.extractContent = false;
>>>> this.parseContent = false;
>>>> this.cacheContent = false;
>>>>
>>>> this.frequency = 0;
>>>> this.delay = 0;
>>>> this.startTimer = false;
>>>> this.timer = null;
>>>>
>>>> //pub/sub events
>>>> this.refreshListenTopics = "";
>>>> this.stopTimerListenTopics = "";
>>>> this.startTimerListenTopics = "";
>>>>
>>>> this.postCreate = function() {
>>>> if(self.frequency > 0) {
>>>> self.timer = new dojo.animation.Timer(self.frequency);
>>>> self.timer.onTick = self.reloadContents;
>>>>
>>>> //start the timer
>>>> if(self.startTimer) {
>>>> //start after delay
>>>> dojo.debug("starting timer after " + self.delay);
>>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>>> }
>>>> }
>>>>
>>>> //attach listeners
>>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>>> "reloadContents");
>>>> }
>>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>>> dojo.event.topic.subscribe(self.stopTimerListenTopics, self,
>>>> "stopTimer");
>>>> }
>>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>>> dojo.event.topic.subscribe(self.startTimerListenTopics, self,
>>>> "startTimer");
>>>> }
>>>> };
>>>>
>>>> this.reloadContents = function() {
>>>> //refresh is not visible in ContentPane
>>>> self.isLoaded = false;
>>>> self.loadContents();
>>>> };
>>>>
>>>> this.stopTimer = function() {
>>>> dojo.debug("stopping timer");
>>>> self.timer.stop();
>>>> };
>>>>
>>>> this.startTimer = function() {
>>>> dojo.debug("starting timer with frequency " + self.frequency);
>>>> self.timer.start();
>>>> };
>>>> };
>>>>
>>>> dojo.inherits(struts.widgets.BindDiv, dojo.widget.html.ContentPane);
>>>>
>>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>>
>>>>
>>>>
>>>> Musachy Barroso wrote:
>>>>> I was looking at the Div/Panel classes and I think we need to do
>>>>> some changes, right now Panel extends Div and PanelTag exteds
>>>>> DivTag. The problem is that the new PanelTag wraps dojo's
>>>>> ContentPane, while DivTag wraps HTMLBindDiv(from struts), and they
>>>>> are quite different. I think we should replace HTMLBindDiv with an
>>>>> implementation that extends dojo's ContentPane and add a timer to
>>>>> it for the auto refresh.
>>>>>
>>>>> what do you guys think?
>>>>>
>>>>> musachy
>>>>>
>>>>> Ian Roughley wrote:
>>>>>> Yes - this was the direction that we wanted to go in. Try to do
>>>>>> as much as possible in dojo and provide light wrappers in
>>>>>> Struts. When we first implemented the tabs, there was no such
>>>>>> dojo implementation. The one feature that we had that you should
>>>>>> check that has been implemented in dojo is the pub/sub events -
>>>>>> so there should be events that each tabs listens to to refresh
>>>>>> itself.
>>>>>>
>>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>>
>>>>>> The other big thing that would be a great help is converting the
>>>>>> code from dojo 0.2 to 0.3 :)
>>>>>>
>>>>>> Ian
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Musachy Barroso <mb...@wfscorp.com>.
I have everything (I think :)) for the ajax Div Tag, do you want me to
create a patch for it, or wait and create a big one when I'm done with
the other widgets (anchor, tree...dojo 0.2 -> 0.3)?
musachy
//Have you guys consider anything to test this ajax stuff? (Selenium maybe?)
Musachy Barroso wrote:
> This was with 0.3.1 which is the current release. I posted a message
> on their mailing list.
>
> musachy
>
> Don Brown wrote:
>> Have you tried this with the Dojo 0.4 release? Any reason we
>> shouldn't upgrade to it?
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> Would something like this include all the current functionality in
>>> BindDiv? (events for stop/start timer, refresh, start after a delay,
>>> advisor via dojo's "handler" property). This way BindDiv will be
>>> easier to maintain (dojo's ContentPane + timer) and the Tab widget
>>> can be deleted (doesn't add anything to this one). By the way this
>>> doesn't work on AMD 64/firefox/linux due to a dojo's bug.
>>>
>>> dojo.provide("struts.widgets.BindDiv");
>>>
>>> dojo.require("dojo.widget.*");
>>> dojo.require("dojo.io.*");
>>> dojo.require("dojo.widget.Container");
>>> dojo.require("dojo.widget.ContentPane");
>>> dojo.require("dojo.animation.Timer");
>>>
>>> struts.widgets.BindDiv = function() {
>>> dojo.widget.html.ContentPane.call(this);
>>> var self = this;
>>>
>>> this.widgetType = "BindDiv";
>>>
>>> this.href = "";
>>> this.extractContent = false;
>>> this.parseContent = false;
>>> this.cacheContent = false;
>>>
>>> this.frequency = 0;
>>> this.delay = 0;
>>> this.startTimer = false;
>>> this.timer = null;
>>>
>>> //pub/sub events
>>> this.refreshListenTopics = "";
>>> this.stopTimerListenTopics = "";
>>> this.startTimerListenTopics = "";
>>>
>>> this.postCreate = function() {
>>> if(self.frequency > 0) {
>>> self.timer = new dojo.animation.Timer(self.frequency);
>>> self.timer.onTick = self.reloadContents;
>>>
>>> //start the timer
>>> if(self.startTimer) {
>>> //start after delay
>>> dojo.debug("starting timer after " + self.delay);
>>> dojo.lang.setTimeout(self.delay, self.startTimer);
>>> }
>>> }
>>>
>>> //attach listeners
>>> if(!dojo.string.isBlank(self.refreshListenTopics)) {
>>> dojo.debug("Listening to " + self.refreshListenTopics);
>>> dojo.event.topic.subscribe(self.refreshListenTopics, self,
>>> "reloadContents");
>>> }
>>> if(!dojo.string.isBlank(self.stopTimerListenTopics)) {
>>> dojo.debug("Listening to " + self.stopTimerListenTopics);
>>> dojo.event.topic.subscribe(self.stopTimerListenTopics, self,
>>> "stopTimer");
>>> }
>>> if(!dojo.string.isBlank(self.startTimerListenTopics)) {
>>> dojo.debug("Listening to " + self.startTimerListenTopics);
>>> dojo.event.topic.subscribe(self.startTimerListenTopics, self,
>>> "startTimer");
>>> }
>>> };
>>>
>>> this.reloadContents = function() {
>>> //refresh is not visible in ContentPane
>>> self.isLoaded = false;
>>> self.loadContents();
>>> };
>>>
>>> this.stopTimer = function() {
>>> dojo.debug("stopping timer");
>>> self.timer.stop();
>>> };
>>>
>>> this.startTimer = function() {
>>> dojo.debug("starting timer with frequency " + self.frequency);
>>> self.timer.start();
>>> };
>>> };
>>>
>>> dojo.inherits(struts.widgets.BindDiv, dojo.widget.html.ContentPane);
>>>
>>> dojo.widget.tags.addParseTreeHandler("dojo:BindDiv");
>>>
>>>
>>>
>>> Musachy Barroso wrote:
>>>> I was looking at the Div/Panel classes and I think we need to do
>>>> some changes, right now Panel extends Div and PanelTag exteds
>>>> DivTag. The problem is that the new PanelTag wraps dojo's
>>>> ContentPane, while DivTag wraps HTMLBindDiv(from struts), and they
>>>> are quite different. I think we should replace HTMLBindDiv with an
>>>> implementation that extends dojo's ContentPane and add a timer to
>>>> it for the auto refresh.
>>>>
>>>> what do you guys think?
>>>>
>>>> musachy
>>>>
>>>> Ian Roughley wrote:
>>>>> Yes - this was the direction that we wanted to go in. Try to do
>>>>> as much as possible in dojo and provide light wrappers in Struts.
>>>>> When we first implemented the tabs, there was no such dojo
>>>>> implementation. The one feature that we had that you should check
>>>>> that has been implemented in dojo is the pub/sub events - so there
>>>>> should be events that each tabs listens to to refresh itself.
>>>>>
>>>>> I think as Don pointed out, we want to keep a very lightweight
>>>>> wrapper in struts and have all the work being done in dojo.
>>>>>
>>>>> The other big thing that would be a great help is converting the
>>>>> code from dojo 0.2 to 0.3 :)
>>>>>
>>>>> Ian
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: ajax tags
Posted by Ian Roughley <ia...@fdar.com>.
Yes - this was the direction that we wanted to go in. Try to do as much
as possible in dojo and provide light wrappers in Struts. When we first
implemented the tabs, there was no such dojo implementation. The one
feature that we had that you should check that has been implemented in
dojo is the pub/sub events - so there should be events that each tabs
listens to to refresh itself.
I think as Don pointed out, we want to keep a very lightweight wrapper
in struts and have all the work being done in dojo.
The other big thing that would be a great help is converting the code
from dojo 0.2 to 0.3 :)
Ian
--
>From Down & Around, Inc.
Innovative IT Solutions
Software Architecture * Design * Development
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
web: www.fdar.com
email ian@fdar.com
phone: 617.821.5430
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Musachy Barroso wrote:
> I picked WW-205, (https://issues.apache.org/struts/browse/WW-205) to
> start playing with and I have replaced the tabbedpanel implementation
> with dojo's implementation, so far I have the static and dynamic tabs
> working. I was having so much fun that I didn't stop to ask if this is
> what you guys want, although it is suggested by Ian Roughley in the
> bug's comments.
>
> musachy
>
> Don Brown wrote:
>> The help would be appreciated. Take a look at the tag documentation
>> - http://cwiki.apache.org/confluence/display/WW/Tag+Developers+Guide
>> - and look at the templates themselves in
>> core/src/main/resources/templates
>>
>> There are several ajax-related issues in our JIRA right now, so that
>> would be a very helpful place to start. :)
>>
>> Don
>>
>> Musachy Barroso wrote:
>>> Hi all,
>>>
>>> I was checking out struts 2 yesterday (I'm a 1.2.7 user) and I found
>>> that some of the UI tags(tree, tab panel...) overlap with a project
>>> that I'm currently maintaining (ajaxtags at
>>> http://ajaxtags.sourceforge.net/). I'd like to contribute to the UI
>>> ajax tags, so some pointers on where to start or whom to talk to
>>> would be appreciated. Ajaxtags is distributed under an apache 2.0
>>> license so we could lift some code if needed.
>>>
>>> thanks
>>>
>>> musachy
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org