[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #206: Add option to load column stats with data files.

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #206: Add option to load column stats with data files.
URL: https://github.com/apache/incubator-iceberg/pull/206#discussion_r291280947
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/GenericDataFile.java
 ##########
 @@ -174,12 +174,20 @@ private GenericDataFile(GenericDataFile toCopy) {
     this.fileSizeInBytes = toCopy.fileSizeInBytes;
     this.fileOrdinal = toCopy.fileOrdinal;
     this.sortColumns = copy(toCopy.sortColumns);
-    // TODO: support lazy conversion to/from map
-    this.columnSizes = copy(toCopy.columnSizes);
-    this.valueCounts = copy(toCopy.valueCounts);
-    this.nullValueCounts = copy(toCopy.nullValueCounts);
-    this.lowerBounds = SerializableByteBufferMap.wrap(copy(toCopy.lowerBounds));
-    this.upperBounds = SerializableByteBufferMap.wrap(copy(toCopy.upperBounds));
+    if (fullCopy) {
+      // TODO: support lazy conversion to/from map
+      this.columnSizes = copy(toCopy.columnSizes);
 
 Review comment:
   columnSizes was not part of the STATS_COLUMN field in FilteredManifest class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org