You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by rahulforallp <gi...@git.apache.org> on 2018/02/25 11:32:20 UTC
[GitHub] carbondata pull request #1997: [CARBONDATA-2201] NPE fixed for Streaming eve...
GitHub user rahulforallp opened a pull request:
https://github.com/apache/carbondata/pull/1997
[CARBONDATA-2201] NPE fixed for Streaming event
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rahulforallp/incubator-carbondata stream_npe
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1997.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1997
----
commit b94ae7c86f67b6d4eedfc9ed56ca2f7bde2a2ea9
Author: rahulforallp <ra...@...>
Date: 2018-02-25T09:55:26Z
NPE fixed for Streaming event
----
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/1997
LGTM
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed for Streaming event
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1997
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2634/
---
[GitHub] carbondata pull request #1997: [CARBONDATA-2201] NPE fixed while triggering ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1997
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1997
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3658/
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1997
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3886/
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1997
LGTM
---
[GitHub] carbondata pull request #1997: [CARBONDATA-2201] NPE fixed for Streaming eve...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1997#discussion_r170451389
--- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
@@ -67,7 +67,7 @@ object StreamSinkFactory {
carbonLoadModel.getFactFilePath,
false,
parameters.asJava,
- null,
+ parameters.asJava,
--- End diff --
add comment why we need to pass same parameters twice
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed for Streaming event
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1997
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3879/
---
[GitHub] carbondata pull request #1997: [CARBONDATA-2201] NPE fixed while triggering ...
Posted by rahulforallp <gi...@git.apache.org>.
Github user rahulforallp commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1997#discussion_r170452321
--- Diff: streaming/src/main/scala/org/apache/carbondata/streaming/StreamSinkFactory.scala ---
@@ -67,7 +67,7 @@ object StreamSinkFactory {
carbonLoadModel.getFactFilePath,
false,
parameters.asJava,
- null,
+ parameters.asJava,
--- End diff --
while triggering the LoadTablePreExecutionEvent we reuire options provided by user and the finalOptions . In case of streaming both are same
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1997
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3665/
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed while triggering the Loa...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1997
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2641/
---
[GitHub] carbondata pull request #1997: [CARBONDATA-2201] NPE fixed for Streaming eve...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1997#discussion_r170451392
--- Diff: streaming/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonAppendableStreamSink.scala ---
@@ -102,7 +102,7 @@ class CarbonAppendableStreamSink(
carbonLoadModel.getFactFilePath,
false,
parameters.asJava,
- null,
+ parameters.asJava,
--- End diff --
add comment why we need to pass same parameters twice
---
[GitHub] carbondata issue #1997: [CARBONDATA-2201] NPE fixed for Streaming event
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on the issue:
https://github.com/apache/carbondata/pull/1997
update PR description
---