[GitHub] [ignite-3] Berkof commented on a change in pull request #326: IGNITE-15212 Add SQL API

[GitBox <gi...@apache.org>]

Berkof commented on a change in pull request #326:
URL: https://github.com/apache/ignite-3/pull/326#discussion_r753049462



##########
File path: modules/api/src/main/java/org/apache/ignite/sql/ResultSet.java
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.sql;
+
+/**
+ * SQL result set provides methods to access SQL query result represented as collection of {@link
+ * SqlRow}.
+ *
+ * <p>All the rows in result set have the same structure described in {@link ResultSetMetadata}.
+ * ResultSet must be closed after usage to free resources.
+ */
+public interface ResultSet extends Iterable<SqlRow>, AutoCloseable {
+    /**
+     * Returns metadata for the results.
+     *
+     * @return ResultSet metadata.
+     */
+    ResultSetMetadata metadata();
+    
+    /**
+     * Returns whether the result set contains rows (SELECT query result), or not (for query of DML, DDL or other kind).
+     *
+     * @return {@code True} if result set contains rows, {@code false} otherwise.
+     */
+    boolean hasRowSet();
+    
+    /**
+     * Returns number of row affected by DML query.
+     *
+     * @return Number of rows or {@code -1} if unapplicable.
+     */
+    int updateCount();
+    
+    /**
+     * Returns result for the conditional query.
+     *
+     * @return {@code True} if conditional query applied, {@code false} otherwise.
+     */
+    boolean wasApplied();

Review comment:
       But it can be useful for DDL operations like "create if not exists".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org