[GitHub] [celix] PengZheng commented on a diff in pull request #505: Feature/parse filter attribute types

["PengZheng (via GitHub)" <gi...@apache.org>]

PengZheng commented on code in PR #505:
URL: https://github.com/apache/celix/pull/505#discussion_r1160499103


##########
libs/utils/src/filter.c:
##########
@@ -554,14 +652,15 @@ celix_filter_t* celix_filter_create(const char *filterString) {
         free(filterStr);
     } else {
         filter->filterStr = filterStr;
+        celix_filter_compile(filter);

Review Comment:
   Return value is not checked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org