You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/10 11:59:20 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #4140: Adding showunique parameter to list templates and isos
davidjumani opened a new pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140
## Description
Adds a new parameter `showunique` to listTemplate and listIsos to return only unique templates / isos across all zones
Fixes #4041
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644522925
@RodrigoDLopez can you help review/test after the final changes? Thanks.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645152732
@davidjumani can you merge latest master and try packaging again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643834241
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643809956
<b>Trillian test result (tid-1721)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61023 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1721-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 278.55 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 258.93 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 255.24 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.18 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.34 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.20 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.26 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.59 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.28 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.90 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.16 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.58 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.48 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643098697
Packaging result: ✔centos7 ✔debian. JID-1362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643809956
<b>Trillian test result (tid-1721)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 61023 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1721-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 278.55 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 258.93 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 255.24 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.18 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.34 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.37 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.20 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.26 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.59 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.28 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.90 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.16 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.58 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.48 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644564301
Packaging result: ✔centos7 ✔debian. JID-1389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643084960
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r440521942
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java
##########
@@ -78,6 +78,9 @@
@Parameter(name = ApiConstants.PARENT_TEMPLATE_ID, type = CommandType.UUID, entityType = TemplateResponse.class, description = "list datadisk templates by parent template id", since = "4.4")
private Long parentTemplateId;
+ @Parameter(name = ApiConstants.SHOW_UNIQUE, type = CommandType.BOOLEAN, description = "If set to true, list only unique templates across zones")
Review comment:
@rhtyd this PR is aiming 4.13 branch. Considering the version 4.15, shouldn`t it aim master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161040
Packaging result: ✖centos7 ✖debian. JID-1406
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161070
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez edited a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644119338
Did again those manual test, everything as expected
* Test 01
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List all my templates without duplicate entries.
**Result:** All good, as expected
```
name: T1 id: b94ad7c7-c036-4bd5-a6d6-905355e092a6 zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T2 id: 182600f0-4e4c-4c1c-a8cf-b53f5e985bf6 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: 171768d6-d038-4ed2-9973-2df306edbf31 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T4 id: 1a15384f-a6a8-4858-ba34-db427cb71cd1 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T5 id: a9637fe9-4c4a-40c9-81d6-54243d9b664c zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T6 id: 546d6683-cb18-4f8b-9bf1-0de8b4b8948e zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T7 id: 9597cdfe-4217-419e-a098-3533873cb081 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T8 id: afdd7c70-5900-4de7-9c4b-efd051ced3e1 zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T9 id: 1d1419c8-4dd4-49e0-a804-32a22d4190a4 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T10 id: db97b7a6-61fe-489b-af51-4eaea34377d9 zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T11 id: fa8e60c2-8b8e-47f4-8a19-09f092fbceb7 zoneid: 2db252e4-5416-459a-aa8e-bd8cab23c2c9
name: T12 id: 3a1c2c1a-06cf-40c1-ade5-ad1b38567f87 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
```
* Test 02
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=5 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 5 templates
**Result:** All good, as expected
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
* Test 03
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=9 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 9 templates
**Result:** All good, as expected
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644549118
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643686079
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r439907843
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java
##########
@@ -78,6 +78,9 @@
@Parameter(name = ApiConstants.PARENT_TEMPLATE_ID, type = CommandType.UUID, entityType = TemplateResponse.class, description = "list datadisk templates by parent template id", since = "4.4")
private Long parentTemplateId;
+ @Parameter(name = ApiConstants.SHOW_UNIQUE, type = CommandType.BOOLEAN, description = "If set to true, list only unique templates across zones")
Review comment:
@davidjumani add version `4.15`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643638216
<b>Trillian test result (tid-1697)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 60043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1697-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 191.44 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 184.04 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 257.89 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.35 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.34 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.34 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.31 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.26 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.97 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.26 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.03 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.59 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.54 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez edited a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643383795
@davidjumani I'm already using the last commit.
I will retest. and update you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644211522
@RodrigoDLopez Thanks!
@rhtyd Changes made!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644238386
<b>Trillian test result (tid-1725)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59803 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1725-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 179.07 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 175.01 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 243.43 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.19 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.37 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 66.42 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 66.11 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.64 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.27 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.99 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.18 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.59 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.52 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643504521
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643383795
@davidjumani I'm allready using the last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r441239286
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3423,12 +3432,22 @@ else if (!template.isPublicTemplate() && caller.getType() != Account.ACCOUNT_TYP
return uniqueTmplPair;
}
List<TemplateJoinVO> uniqueTmpls = uniqueTmplPair.first();
- String[] tzIds = new String[uniqueTmpls.size()];
int i = 0;
- for (TemplateJoinVO v : uniqueTmpls) {
- tzIds[i++] = v.getTempZonePair();
+ List<TemplateJoinVO> vrs = null;
+ if (showUnique) {
+ Long[] tzIds = new Long[uniqueTmpls.size()];
Review comment:
@davidjumani nit - let's refactor and use a more modern form of writing code, the current code looks less like Java, more like C/C++; can be written as:
```
Long[] templateIds = uniqueTmpls.stream().map(template -> template.getId()).toArray(Long[]::new);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645157322
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643474068
Hi @davidjumani
I did those tests again.
Everything as expected.
My first test was fail, because those templates was not in the right state, caused by an error into my environment. My misstake.
LGTM based on manual tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-641955817
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643925431
Packaging result: ✔centos7 ✔debian. JID-1376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645146799
@GabrielBrascher @rhtyd comments addressed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643836370
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957500
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644569796
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-642299747
<b>Trillian test result (tid-1669)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1669-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 237.41 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 213.80 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 288.37 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643686168
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645634795
<b>Trillian test result (tid-1754)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36757 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1754-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 252.54 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 240.65 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 310.45 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645170949
Packaging result: ✔centos7 ✔debian. JID-1409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-641956086
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645161483
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643086454
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643358376
@davidjumani
I tested this enhancement with Cloudmonkey and used JQ to parse the output.
My Environment have 2 Zones and some fake templates named T<int> copied into both zones
* Test 01
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List all my templates without duplicate entries.
**Result:** the output brought all templates duplicates too
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T10 id: c3c8e05c-f8b9-44f7-91c8-b9679de95b30 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T11 id: bd552d64-7354-4e51-9c57-b7991f5d3a95 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T12 id: b21ffae9-cf69-4c3e-b204-3ea9202a662a zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T10 id: c3c8e05c-f8b9-44f7-91c8-b9679de95b30 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T11 id: bd552d64-7354-4e51-9c57-b7991f5d3a95 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T12 id: b21ffae9-cf69-4c3e-b204-3ea9202a662a zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
* Test 02
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=5 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 5 templates
**Result:** All good, as expected
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
* Test 03
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=7 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 7 templates
**Result:** All good, as expected
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
* Test 04
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=9 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 9 templates
**Result:** the output brought 16 templates and some duplicate entries
```
name: T1 id: 422b3235-ad7f-49fa-93ec-2c2df9140569 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T2 id: 6d224f3a-057e-4be3-bf27-ea911a77b87d zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: bfa05e73-7948-419f-a47d-29b498bf3ef9
name: T3 id: f302a9f9-50e6-4990-a746-3185be9fa6fb zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T4 id: a10d6bb8-dea5-45a9-8e45-4fec5456c885 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T5 id: 584317d2-009e-46eb-a5b0-ef005231bd14 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T6 id: 07994afd-ec0d-4098-ba86-c5ae1a4198df zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T7 id: 09face5a-f496-47cf-a367-1e872bb1c659 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T8 id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T9 id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
Whithout `showunique` parameter, I receive duplicate entries as well, but the `pagesize` was respected
* Test 05
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=10 \
page=1 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List only 10 templates
**Result:** As the test 04, I received duplicate entries, and the `pagesize` was not respected.
But the second page seems to be okay.
```
cloudmonkey -p acs listtemplates \
templatefilter=self \
pagesize=10 \
page=2 \
showunique=true \
| jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
```
**Expected result:** List the remaining templates, without duplicates.
**Result:** all good, bring the remaining templates, without duplicate entries
```
name: T11 id: bd552d64-7354-4e51-9c57-b7991f5d3a95 zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
name: T12 id: b21ffae9-cf69-4c3e-b204-3ea9202a662a zoneid: 8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644910781
<b>Trillian test result (tid-1740)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36827 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1740-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 214.31 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 247.59 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 268.74 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-641966078
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-641965660
Packaging result: ✔centos7 ✔debian. JID-1332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644523194
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643638216
<b>Trillian test result (tid-1697)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 60043 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1697-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 191.44 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 184.04 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 257.89 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.35 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.34 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.34 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.31 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.26 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.97 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.26 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 74.03 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.59 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.54 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645182875
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643836307
Packaging result: ✔centos7 ✔debian. JID-1372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644238386
<b>Trillian test result (tid-1725)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59803 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4140-t1725-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 55 look OK, 22 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 179.07 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 175.01 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 243.43 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.10 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.19 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.37 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 66.42 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 66.11 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.18 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.24 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 16.64 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.27 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.99 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.18 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.59 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.52 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957014
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643919066
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645183270
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r439908027
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java
##########
@@ -118,6 +121,10 @@ public Boolean getShowRemoved() {
return (showRemoved != null ? showRemoved : false);
}
+ public Boolean getShowUnique() {
+ return (showUnique != null ? showUnique : false);
Review comment:
Can be simplified as `return showUnique != null && showUnique;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-641966829
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643836487
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957323
@RodrigoDLopez could you run a test again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643918650
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643086781
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643504288
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643377134
@RodrigoDLopez could you try it on the latest commit. I ran it and it worked as expected :
**Just the flag**
`cmk listtemplates templatefilter=all showunique=true | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'`
```
name: SystemVM Template (simulator) id: 1e097a9f-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
name: CentOS 5.6 (64-bit) no GUI (Simulator) id: 1e09b0c9-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
```
**With pagination**
`cmk listtemplates templatefilter=all showunique=true page=1 pagesize=1 | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'`
```
name: SystemVM Template (simulator) id: 1e097a9f-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
```
`cmk listtemplates templatefilter=all showunique=true page=2 pagesize=1 | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'`
```
name: CentOS 5.6 (64-bit) no GUI (Simulator) id: 1e09b0c9-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
````
`cmk listtemplates templatefilter=all showunique=true page=1 pagesize=2 | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'`
```
name: SystemVM Template (simulator) id: 1e097a9f-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
name: CentOS 5.6 (64-bit) no GUI (Simulator) id: 1e09b0c9-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
```
**All the templates**
`cmk listtemplates templatefilter=all | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'`
```
name: SystemVM Template (simulator) id: 1e097a9f-aafb-11ea-a5c3-50eb71576f75 zoneid: 7eea393a-2738-46b2-a85e-12c25ccf5913
name: SystemVM Template (simulator) id: 1e097a9f-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
name: CentOS 5.6 (64-bit) no GUI (Simulator) id: 1e09b0c9-aafb-11ea-a5c3-50eb71576f75 zoneid: 7eea393a-2738-46b2-a85e-12c25ccf5913
name: CentOS 5.6 (64-bit) no GUI (Simulator) id: 1e09b0c9-aafb-11ea-a5c3-50eb71576f75 zoneid: a82d7a28-e405-4456-b095-62c635951b0e
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643085591
@davidjumani you need to package before you kick tests, esp after any code changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644548893
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r441234854
##########
File path: server/src/main/java/com/cloud/api/query/dao/TemplateJoinDaoImpl.java
##########
@@ -481,4 +488,14 @@ public TemplateResponse newIsoResponse(TemplateJoinVO iso) {
return new Pair<List<TemplateJoinVO>, Integer>(objects, count);
}
+ @Override
+ public List<TemplateJoinVO> findByDistinctIds(Long... ids) {
+ if (ids.length == 0) {
Review comment:
@davidjumani make it defensive, for example do a null check on ids
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644119338
sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r440835059
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3423,12 +3432,22 @@ else if (!template.isPublicTemplate() && caller.getType() != Account.ACCOUNT_TYP
return uniqueTmplPair;
}
List<TemplateJoinVO> uniqueTmpls = uniqueTmplPair.first();
- String[] tzIds = new String[uniqueTmpls.size()];
int i = 0;
- for (TemplateJoinVO v : uniqueTmpls) {
- tzIds[i++] = v.getTempZonePair();
+ List<TemplateJoinVO> vrs = null;
+ if (showUnique) {
+ Long[] tzIds = new Long[uniqueTmpls.size()];
+ for (TemplateJoinVO v : uniqueTmpls) {
+ tzIds[i++] = v.getId();
+ }
+ vrs = _templateJoinDao.findByDistinctIds(tzIds);
+ } else {
+ String[] tzIds = new String[uniqueTmpls.size()];
+ for (TemplateJoinVO v : uniqueTmpls) {
+ tzIds[i++] = v.getTempZonePair();
+ }
+ vrs = _templateJoinDao.searchByTemplateZonePair(showRemovedTmpl, tzIds);
Review comment:
Unit testing for such a huge/complex method is not easy. However, it would be great to address small pieces.
With that said, lines 3436 - 3448 could be extracted into a method that would allow testing this specific piece of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645152305
Packaging result: ✖centos7 ✖debian. JID-1404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644570030
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-642533932
@davidjumani have you checked if this also addresses the pagination issue?
To test, you can deploy two simulator zones and register some (fake) templates and isos. The expected outcome is listTemplates and listIsos should return unique templates/isos as well as honour pagination (test using `page=1 and pagesize=1`, `page=2`... vary both page and pagesize to see expected returns are seen).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#discussion_r439908149
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3423,12 +3432,32 @@ else if (!template.isPublicTemplate() && caller.getType() != Account.ACCOUNT_TYP
return uniqueTmplPair;
}
List<TemplateJoinVO> uniqueTmpls = uniqueTmplPair.first();
- String[] tzIds = new String[uniqueTmpls.size()];
int i = 0;
- for (TemplateJoinVO v : uniqueTmpls) {
- tzIds[i++] = v.getTempZonePair();
+ List<TemplateJoinVO> vrs = null;
+ if (showUnique) {
+ Long[] tzIds = new Long[uniqueTmpls.size()];
+ for (TemplateJoinVO v : uniqueTmpls) {
+ tzIds[i++] = v.getId();
+ }
+ vrs = _templateJoinDao.findByIds(tzIds);
+
+ // Get only unique id rows
+ Long lastId = null;
+ for(i = vrs.size() - 1; i >= 0; i--) {
+ if (new Long(vrs.get(i).getId()).equals(lastId)) {
+ vrs.remove(i);
Review comment:
Please explore if you can simplify the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643834310
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645146799
@GabrielBrascher @rhtyd comments addressed!
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645147165
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-645157656
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643084617
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644524397
Packaging result: ✖centos7 ✖debian. JID-1379
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org