You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by maitreyak <gi...@git.apache.org> on 2018/07/27 22:37:06 UTC
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
GitHub user maitreyak opened a pull request:
https://github.com/apache/zeppelin/pull/3101
[ZEPPELIN-3667] [Improvement] Large CVS download.
### What is this PR for?
The download CSV feature from the table views fails when the total data accumulated is greater than 2MB on the chrome browser.
encodeURIComponent call has a maxs out for larger sizes of csv, using blob extends csv download size limitations.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-3667](https://issues.apache.org/jira/browse/ZEPPELIN-3667)
### How should this be tested?
set env variable ZEPPELIN_INTERPRETER_OUTPUT_LIMIT to greater than 2 MB.
Test downloading a small to moderate CSV from the table segment on chrome, safari, opera and firefox.
Test downloading a large CSV(2MB or greater) from the table segment on chrome, safari, opera and firefox.
All downloads should pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maitreyak/zeppelin branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3101
----
commit 9e32a5ce4c1acdc07878f98a984bf5ce4760becc
Author: Maitreya <ma...@...>
Date: 2018-07-27T19:11:29Z
Enhancement to download CSV greater than 2 MB
commit 3f882c4352d0869856b339ef4ce11fb238d21ae8
Author: maitreya kundurthy <sl...@...>
Date: 2018-07-27T21:17:20Z
removed encodeComponentURI call
----
---
[GitHub] zeppelin issue #3101: [ZEPPELIN-3667] [Improvement] Large CVS download.
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3101
FYI. That download button will be removed by https://github.com/apache/zeppelin/pull/3013
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
Github user maitreyak closed the pull request at:
https://github.com/apache/zeppelin/pull/3101
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
GitHub user maitreyak reopened a pull request:
https://github.com/apache/zeppelin/pull/3101
[ZEPPELIN-3667] [Improvement] Large CVS download.
### What is this PR for?
The download CSV feature from the table views fails when the total data accumulated is greater than 2MB on the chrome browser.
encodeURIComponent call has a maxs out for larger sizes of csv, using blob extends csv download size limitations.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-3667](https://issues.apache.org/jira/browse/ZEPPELIN-3667)
### How should this be tested?
set env variable ZEPPELIN_INTERPRETER_OUTPUT_LIMIT to greater than 2 MB.
Test downloading a small to moderate CSV from the table segment on chrome, safari, opera and firefox.
Test downloading a large CSV(2MB or greater) from the table segment on chrome, safari, opera and firefox.
All downloads should pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maitreyak/zeppelin branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3101
----
commit 9e32a5ce4c1acdc07878f98a984bf5ce4760becc
Author: Maitreya <ma...@...>
Date: 2018-07-27T19:11:29Z
Enhancement to download CSV greater than 2 MB
commit 3f882c4352d0869856b339ef4ce11fb238d21ae8
Author: maitreya kundurthy <sl...@...>
Date: 2018-07-27T21:17:20Z
removed encodeComponentURI call
----
---
[GitHub] zeppelin issue #3101: [ZEPPELIN-3667] [Improvement] Large CVS download.
Posted by maitreyak <gi...@git.apache.org>.
Github user maitreyak commented on the issue:
https://github.com/apache/zeppelin/pull/3101
@Tagar providing the fix for 0.7x versions. #3013 is meant for 0.8 and up according to the JIRA.
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
GitHub user maitreyak reopened a pull request:
https://github.com/apache/zeppelin/pull/3101
[ZEPPELIN-3667] [Improvement] Large CVS download.
### What is this PR for?
The download CSV feature from the table views fails when the total data accumulated is greater than 2MB on the chrome browser.
encodeURIComponent call has a maxs out for larger sizes of csv, using blob extends csv download size limitations.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-3667](https://issues.apache.org/jira/browse/ZEPPELIN-3667)
### How should this be tested?
set env variable ZEPPELIN_INTERPRETER_OUTPUT_LIMIT to greater than 2 MB.
Test downloading a small to moderate CSV from the table segment on chrome, safari, opera and firefox.
Test downloading a large CSV(2MB or greater) from the table segment on chrome, safari, opera and firefox.
All downloads should pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maitreyak/zeppelin branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3101
----
commit 9e32a5ce4c1acdc07878f98a984bf5ce4760becc
Author: Maitreya <ma...@...>
Date: 2018-07-27T19:11:29Z
Enhancement to download CSV greater than 2 MB
commit 3f882c4352d0869856b339ef4ce11fb238d21ae8
Author: maitreya kundurthy <sl...@...>
Date: 2018-07-27T21:17:20Z
removed encodeComponentURI call
----
---
[GitHub] zeppelin issue #3101: [ZEPPELIN-3667] [Improvement] Large CVS download.
Posted by maitreyak <gi...@git.apache.org>.
Github user maitreyak commented on the issue:
https://github.com/apache/zeppelin/pull/3101
Intended for branch-0.7. We use this version of Zeppelin with the posted fix at our organization.
We don't intend to update to version 0.8+ due to the custom enhancements we have made.
Thought it would be useful for folks on the same branch version or EMR folks.
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
Github user maitreyak closed the pull request at:
https://github.com/apache/zeppelin/pull/3101
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
GitHub user maitreyak reopened a pull request:
https://github.com/apache/zeppelin/pull/3101
[ZEPPELIN-3667] [Improvement] Large CVS download.
### What is this PR for?
The download CSV feature from the table views fails when the total data accumulated is greater than 2MB on the chrome browser.
encodeURIComponent call has a maxs out for larger sizes of csv, using blob extends csv download size limitations.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-3667](https://issues.apache.org/jira/browse/ZEPPELIN-3667)
### How should this be tested?
set env variable ZEPPELIN_INTERPRETER_OUTPUT_LIMIT to greater than 2 MB.
Test downloading a small to moderate CSV from the table segment on chrome, safari, opera and firefox.
Test downloading a large CSV(2MB or greater) from the table segment on chrome, safari, opera and firefox.
All downloads should pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maitreyak/zeppelin branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3101
----
commit 9e32a5ce4c1acdc07878f98a984bf5ce4760becc
Author: Maitreya <ma...@...>
Date: 2018-07-27T19:11:29Z
Enhancement to download CSV greater than 2 MB
commit 3f882c4352d0869856b339ef4ce11fb238d21ae8
Author: maitreya kundurthy <sl...@...>
Date: 2018-07-27T21:17:20Z
removed encodeComponentURI call
----
---
[GitHub] zeppelin pull request #3101: [ZEPPELIN-3667] [Improvement] Large CVS downloa...
Posted by maitreyak <gi...@git.apache.org>.
Github user maitreyak closed the pull request at:
https://github.com/apache/zeppelin/pull/3101
---