You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2013/12/02 19:42:36 UTC

[jira] [Updated] (OAK-1252) Lazy privilege access in AccessControlValidator

     [ https://issues.apache.org/jira/browse/OAK-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated OAK-1252:
-------------------------------

    Attachment: 0001-OAK-1252-Lazy-privilege-access-in-AccessControlValid.patch

The attached patch implements the suggested improvement.

The {{SetPropertyTest}} benchmark shows a 15% improvement on the smallest possible commits (for most normal commits the improvement would be lower):

{noformat}
# SetPropertyTest          C     min     10%     50%     90%     max       N
Oak-Tar (before)           1     188     191     195     199     381     304
Oak-Tar (after)            1     155     157     162     166     369     368
{noformat}


> Lazy privilege access in AccessControlValidator
> -----------------------------------------------
>
>                 Key: OAK-1252
>                 URL: https://issues.apache.org/jira/browse/OAK-1252
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Priority: Minor
>         Attachments: 0001-OAK-1252-Lazy-privilege-access-in-AccessControlValid.patch
>
>
> The {{AccessControlValidatorProvider.getPrivileges()}} method takes a few percent of the time spent processing small commits. It's not that much, but privileges are only really needed for the normally quite rare commits that modify ACEs. Thus it would make sense to defer the loading of privileges to only when they're actually needed.



--
This message was sent by Atlassian JIRA
(v6.1#6144)