[GitHub] [cordova-serve] erisu commented on a change in pull request #40: Add MS Edge Chromium support

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #40:
URL: https://github.com/apache/cordova-serve/pull/40#discussion_r756489444



##########
File path: src/browser.js
##########
@@ -32,7 +32,7 @@ const NOT_SUPPORTED = 'The browser target is not supported: %target%';
  * Launches the specified browser with the given URL.
  * Based on https://github.com/domenic/opener
  * @param {{target: ?string, url: ?string, dataDir: ?string}} opts - parameters:
- *   target - the target browser - ie, chrome, safari, opera, firefox or chromium
+ *   target - the target browser - ie, edge, chrome, safari, opera, firefox or chromium

Review comment:
       I think `ie` in this case was refering to "Internet Explorer" and not "In Example"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org