You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "LiZhenNet (GitHub)" <gi...@apache.org> on 2019/03/14 07:35:22 UTC

[GitHub] [incubator-dubbo] LiZhenNet opened pull request #3654: optimize DefaultTpsLimiter

## What is the purpose of the change

optimize DefaultTpsLimiter

## Brief changelog

1. Replace AtomicInteger with LongAdder,  LongAdder is better than  AtomicInteger When multi-threaded.

2. Fix  when change rate value， it is not effective.

## Verifying this change

UT

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3654: optimize DefaultTpsLimiter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=h1) Report
> Merging [#3654](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e4bfb3d0e78ec903792f34cdd71017819584203b?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `76.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3654      +/-   ##
============================================
+ Coverage     63.91%   63.96%   +0.04%     
  Complexity       71       71              
============================================
  Files           701      701              
  Lines         30750    30756       +6     
  Branches       4979     4980       +1     
============================================
+ Hits          19655    19673      +18     
+ Misses         8827     8819       -8     
+ Partials       2268     2264       -4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/filter/tps/DefaultTPSLimiter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL0RlZmF1bHRUUFNMaW1pdGVyLmphdmE=) | `55.55% <0%> (-11.12%)` | `0 <0> (ø)` | |
| [...java/org/apache/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL1N0YXRJdGVtLmphdmE=) | `81.48% <100%> (+2.31%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.64% <0%> (+2.02%)` | `0% <0%> (ø)` | :arrow_down: |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `58.13% <0%> (+2.32%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `65.88% <0%> (+4.7%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `21.05% <0%> (+5.26%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `78.94% <0%> (+5.26%)` | `0% <0%> (ø)` | :arrow_down: |
| [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `57.14% <0%> (+5.71%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=footer). Last update [e4bfb3d...0de91a0](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3654: optimize DefaultTpsLimiter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=h1) Report
> Merging [#3654](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/e4bfb3d0e78ec903792f34cdd71017819584203b?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3654      +/-   ##
============================================
+ Coverage     63.91%   63.94%   +0.02%     
  Complexity       71       71              
============================================
  Files           701      701              
  Lines         30750    30756       +6     
  Branches       4979     4980       +1     
============================================
+ Hits          19655    19666      +11     
+ Misses         8827     8823       -4     
+ Partials       2268     2267       -1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/filter/tps/DefaultTPSLimiter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL0RlZmF1bHRUUFNMaW1pdGVyLmphdmE=) | `55.55% <0%> (-11.12%)` | `0 <0> (ø)` | |
| [...java/org/apache/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL1N0YXRJdGVtLmphdmE=) | `81.48% <100%> (+2.31%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.94% <0%> (-0.68%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `60% <0%> (+0.35%)` | `0% <0%> (ø)` | :arrow_down: |
| [...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==) | `58.13% <0%> (+2.32%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (+4.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `65.88% <0%> (+4.7%)` | `0% <0%> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `21.05% <0%> (+5.26%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=footer). Last update [e4bfb3d...0de91a0](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] CrazyHZM commented on pull request #3654: optimize DefaultTpsLimiter

Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
  `token.sum()` can be replaced with `getToken()`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] LiZhenNet commented on issue #3654: optimize DefaultTpsLimiter

Posted by "LiZhenNet (GitHub)" <gi...@apache.org>.
> > Fix when change rate value， it is not effective.
> 
> Could you please add a unit test to cover this?

I have added it.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3654: optimize DefaultTpsLimiter

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
There is no need to use while any more, since the loop body will only be executed once.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 closed pull request #3654: optimize DefaultTpsLimiter

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3654: optimize DefaultTpsLimiter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=h1) Report
> Merging [#3654](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b2bfbc76d13106a3211f5af1713ba50848560060?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `94.44%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3654      +/-   ##
============================================
- Coverage     63.44%   63.44%   -0.01%     
  Complexity       71       71              
============================================
  Files           703      703              
  Lines         31000    31002       +2     
  Branches       5024     5023       -1     
============================================
  Hits          19669    19669              
- Misses         9066     9067       +1     
- Partials       2265     2266       +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...java/org/apache/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL1N0YXRJdGVtLmphdmE=) | `81.48% <100%> (+2.31%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/filter/tps/DefaultTPSLimiter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL0RlZmF1bHRUUFNMaW1pdGVyLmphdmE=) | `66.66% <83.33%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...mmon/threadpool/support/AbortPolicyWithReport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L0Fib3J0UG9saWN5V2l0aFJlcG9ydC5qYXZh) | `83.33% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `67.39% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `82.75% <0%> (-3.45%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L2V0Y2QvRXRjZFJlZ2lzdHJ5LmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `50% <0%> (+0.83%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=footer). Last update [b2bfbc7...c3f2f19](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3654: optimize DefaultTpsLimiter

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=h1) Report
> Merging [#3654](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b2bfbc76d13106a3211f5af1713ba50848560060?src=pr&el=desc) will **increase** coverage by `0.51%`.
> The diff coverage is `76.92%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3654      +/-   ##
============================================
+ Coverage     63.44%   63.96%   +0.51%     
  Complexity       71       71              
============================================
  Files           703      701       -2     
  Lines         31000    30756     -244     
  Branches       5024     4980      -44     
============================================
+ Hits          19669    19673       +4     
+ Misses         9066     8819     -247     
+ Partials       2265     2264       -1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/dubbo/rpc/filter/tps/DefaultTPSLimiter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL0RlZmF1bHRUUFNMaW1pdGVyLmphdmE=) | `55.55% <0%> (-11.12%)` | `0 <0> (ø)` | |
| [...java/org/apache/dubbo/rpc/filter/tps/StatItem.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvdHBzL1N0YXRJdGVtLmphdmE=) | `81.48% <100%> (+2.31%)` | `0 <0> (ø)` | :arrow_down: |
| [...pport/zookeeper/ZookeeperDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `72.72% <0%> (-10.61%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...mmon/threadpool/support/AbortPolicyWithReport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L0Fib3J0UG9saWN5V2l0aFJlcG9ydC5qYXZh) | `83.33% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...g/apache/dubbo/configcenter/ConfigChangeEvent.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9Db25maWdDaGFuZ2VFdmVudC5qYXZh) | `70% <0%> (-2.73%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `73.64% <0%> (-2.03%)` | `0% <0%> (ø)` | |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `59.64% <0%> (-1.45%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `88.57% <0%> (-0.96%)` | `0% <0%> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/StringUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `86.11% <0%> (-0.8%)` | `0% <0%> (ø)` | |
| ... and [25 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3654/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=footer). Last update [b2bfbc7...0de91a0](https://codecov.io/gh/apache/incubator-dubbo/pull/3654?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3654 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org