You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "devinjdangelo (via GitHub)" <gi...@apache.org> on 2023/10/05 00:13:21 UTC
[PR] Mark OnCloseRowGroup Send [arrow-rs]
devinjdangelo opened a new pull request, #4893:
URL: https://github.com/apache/arrow-rs/pull/4893
# Which issue does this PR close?
Enables https://github.com/apache/arrow-datafusion/pull/7655
# Rationale for this change
#4871 rolled back this change, but without it https://github.com/apache/arrow-datafusion/pull/7655 encounters a compile time error since `OnCloseRowGroup` is used across an `await`.
Apart from this change, https://github.com/apache/arrow-datafusion/pull/7655 is working great against the current master branch of `arrow-rs`.
The compile error can be viewed here: https://github.com/apache/arrow-datafusion/actions/runs/6412903672/job/17410973730?pr=7655
# What changes are included in this PR?
OnCloseRowGroup is marked Send.
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark OnCloseRowGroup Send [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4893:
URL: https://github.com/apache/arrow-rs/pull/4893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark OnCloseRowGroup Send [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4893:
URL: https://github.com/apache/arrow-rs/pull/4893#issuecomment-1748605704
Aah, it is because you want to hold the row group writer across a call to AsyncWrite to ObjectStorage... I guess that makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org