You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@systemml.apache.org by "Deron Eriksson (JIRA)" <ji...@apache.org> on 2016/05/09 18:56:13 UTC
[jira] [Comment Edited] (SYSTEMML-665) Fix license, notice, and
disclaimer for in-memory jar artifact
[ https://issues.apache.org/jira/browse/SYSTEMML-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276813#comment-15276813 ]
Deron Eriksson edited comment on SYSTEMML-665 at 5/9/16 6:56 PM:
-----------------------------------------------------------------
[~luciano resende]
#1) DISCLAIMER looks good. Thank you!
#2) NOTICE has SystemML and says contains Apache software. Also mentions ANTLR and SLF4J. Does something need to be there for org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 (BSD license), the classes of which are included in the SystemML jar file (via compile scope)? Or is it fine just referencing this library in the LICENSE file.
#3) I think LICENSE of standalone can't be used here and that the in-memory artifact needs its own LICENSE. For example, the following need to be included (these are compile-scope dependencies in in-memory jar artifact):
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
com.google.guava:guava:bundle:14.0.1
org.apache.wink:wink-json4j:jar:1.4
Also, the libraries included in the in-memory jar are different from the libraries included in the standalone jars. See inmemory.xml:
{code}
<includes>
<include>*:commons-collections*</include>
<include>*:commons-configuration*</include>
<include>*:commons-lang*</include>
<include>*:commons-logging*</include>
<include>*:hadoop-auth*</include>
<include>*:hadoop-common*</include>
<include>*:hadoop-mapreduce-client-core*</include>
<include>*:log4j*</include>
<include>*:slf4j-api*</include>
<include>*:slf4j-log4j*</include>
<include>*:systemml*</include>
</includes>
{code}
was (Author: deron):
[~luciano resende]
#1) DISCLAIMER looks good. Thank you!
#2) NOTICE has SystemML and says contains Apache software. Also mentions ANTLR and SLF4J. Does something need to be there for org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1 (BSD license), the classes of which are included in the SystemML jar file (via compile scope)? Or is it fine just referencing this library in the LICENSE file.
#3) I think LICENSE of standalone can't be used here and that the in-memory artifact needs its own LICENSE. For example, the following need to be included (these are compile-scope dependencies in in-memory jar artifact):
org.abego.treelayout:org.abego.treelayout.core:jar:1.0.1
com.google.guava:guava:bundle:14.0.1
org.apache.wink:wink-json4j:jar:1.4
Also, the libraries included in the in-memory jar are different from the libraries included in the standalone jars. See inmemory.xml:
<includes>
<include>*:commons-collections*</include>
<include>*:commons-configuration*</include>
<include>*:commons-lang*</include>
<include>*:commons-logging*</include>
<include>*:hadoop-auth*</include>
<include>*:hadoop-common*</include>
<include>*:hadoop-mapreduce-client-core*</include>
<include>*:log4j*</include>
<include>*:slf4j-api*</include>
<include>*:slf4j-log4j*</include>
<include>*:systemml*</include>
</includes>
> Fix license, notice, and disclaimer for in-memory jar artifact
> --------------------------------------------------------------
>
> Key: SYSTEMML-665
> URL: https://issues.apache.org/jira/browse/SYSTEMML-665
> Project: SystemML
> Issue Type: Task
> Components: Build
> Reporter: Deron Eriksson
> Assignee: Luciano Resende
> Fix For: SystemML 0.10
>
>
> The in-memory jar artifact (see "create-inmemory-jar" in pom.xml, which delegates to "src/assembly/inmemory.xml") has issues with its license, notice, and disclaimer files.
> #1) The DISCLAIMER file "should" be included (probably best located at base level).
> #2) It contains a META-INF/NOTICE file for commons logging and a META-INF/NOTICE.txt file for commons lang. However there is no NOTICE file for SystemML (probably best located at base level).
> #3) It contains a META-INF/LICENSE file which is the general Apache license and a META-INF/LICENSE.txt file which is also the general Apache license. However, the LICENSE file most likely should include a listing of the license information for all the projects contained in the artifact (similar to src/assembly/standalone/LICENSE). Also, see SYSTEMML-659 and SYSTEMML-662. This LICENSE for SystemML is probably best located at the base level of the artifact.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)