You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/14 11:13:59 UTC

[GitHub] [superset] ravsha2 opened a new issue, #19717: Dashboard shouldn't load on CLEAR ALL button action if you have already set required fields in filter section.

ravsha2 opened a new issue, #19717:
URL: https://github.com/apache/superset/issues/19717

   I have created a report dashboard for sales transaction using table chart and a required date filter field.
   Also set default date range filter for one month and marked as required, dashboard is working fine for selected date range filter.
   when i click on CLEAR ALL button dashboard are not working as result dataset has huge data.
   
   **Expected Result**
   CLEAR ALL button should not work if you have required fields in filter section.
   
   **Actual Result**
   Dashboard is not working.
   
   ![image](https://user-images.githubusercontent.com/103640004/163379732-167f9e46-c8f9-4e46-8925-b7f1223bef1d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] itziarmj commented on issue #19717: Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section.

Posted by "itziarmj (via GitHub)" <gi...@apache.org>.
itziarmj commented on issue #19717:
URL: https://github.com/apache/superset/issues/19717#issuecomment-1514651909

   IMO "Clear all" button should return the filters to the default state, specially if a value is required.
   At least, it is what my users are expecting to happen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mathieudruart commented on issue #19717: Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section.

Posted by GitBox <gi...@apache.org>.
mathieudruart commented on issue #19717:
URL: https://github.com/apache/superset/issues/19717#issuecomment-1215124644

   We experience the same issue, period filter is required but "Clear all" button clear the period field as well and try to load the dashboard (that will fail due to data size).
   
   I agree that if fields are required, "Clear all" button shouldn't load the dashboard with empty required fields.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section. [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #19717:
URL: https://github.com/apache/superset/issues/19717#issuecomment-1962028441

   In recent versions of Superset, Clear All does not trigger any action automatically. You need to click on Apply filters to refresh the charts and that button won't be enabled if a required field is empty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ravsha2 commented on issue #19717: Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section.

Posted by GitBox <gi...@apache.org>.
ravsha2 commented on issue #19717:
URL: https://github.com/apache/superset/issues/19717#issuecomment-1106476692

   Dear Team,
   Can you please look into this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section. [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #19717: Dashboard shouldn't get load on CLEAR ALL button action if you have already set required fields in filter section.
URL: https://github.com/apache/superset/issues/19717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org