You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/02/08 08:23:50 UTC

[kudu-CR] WIP [common] try to examine Schema::Reset(cols, ...)

Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18213


Change subject: WIP [common] try to examine Schema::Reset(cols, ...)
......................................................................

WIP [common] try to examine Schema::Reset(cols, ...)

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@319
PS6, Line 319:                           ColumnSchema("col4", STRING),
Align to 'ColumnSchema' of the row above.



-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 03:33:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] WIP [common] try to examine Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#2).

Change subject: WIP [common] try to examine Schema::Reset(cols, ...)
......................................................................

WIP [common] try to examine Schema::Reset(cols, ...)

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 2
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#9).

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................

[common] fix a bug in Schema::Reset(cols, ...)

Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.

A new test scenario is added to cover the corresponding regressions in future.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#8).

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................

[common] fix a bug in Schema::Reset(cols, ...)

Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.

A new test scenario is added to cover the corresponding regressions in future.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................


Patch Set 9: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 16:02:41 +0000
Gerrit-HasComments: No

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#4).

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................

[common] fix function Schema::Reset(cols, ...)

When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
I find Schema::Reset(cols, ...) seems not what we expect,
and in my opinion, it's a bug.

The fixing is no confluence to all unit tests.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 4
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#5).

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................

[common] fix function Schema::Reset(cols, ...)

When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
I find Schema::Reset(cols, ...) seems not what we expect,
and in my opinion, it's a bug.

The fixing is no confluence to all unit tests.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 5
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] WIP [common] try to examine Schema::Reset(cols, ...)

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: WIP [common] try to examine Schema::Reset(cols, ...)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18213/3/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:

http://gerrit.cloudera.org:8080/#/c/18213/3/src/kudu/common/schema.cc@285
PS3, Line 285:   col_offsets_.clear();
Better to add some unit tests



-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 02:58:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................


Patch Set 8:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@7
PS6, Line 7: fix a bug in Schema::Reset(cols, ...)
> How about:
Done


http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@9
PS6, Line 9: Prior to this patch, Schema::col_offsets_ was not cleared
           : upon calling Schema::Reset(). This patch addresses the issue.
           : 
           : A new test scenario is added to cover the corresponding regressions in future.
           : 
> How about updating this a bit to describe the essence of the problem.  For 
You are very kind.  I would change it.


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@319
PS6, Line 319:                             ColumnSchema("col4", STRING),
> Align to 'ColumnSchema' of the row above.
Done


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@322
PS6, Line 322: ASSERT_OK(schema.Reset(schema1.colu
> Wrap into ASSERT_OK()?
Done


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@327
PS6, Line 327:   ASSERT_EQ(schema.key_byte_size(), schema1.key_byte_size());
> Could you also add an extra check below?
Done


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc@284
PS6, Line 284:   col_offsets_.clear();
             :   col_offsets_.reserve(
> nit: consider changing the order to call vector::clear() before calling vec
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 8
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 12:04:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#6).

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................

[common] fix function Schema::Reset(cols, ...)

When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
I find Schema::Reset(cols, ...) seems not what we expect,
and in my opinion, it's a bug.

The fixing is no confluence to all unit tests.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................


Patch Set 6:

> Patch Set 3:
> 
> (1 comment)
done


-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Sat, 12 Feb 2022 10:39:02 +0000
Gerrit-HasComments: No

[kudu-CR] WIP [common] try to examine Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#3).

Change subject: WIP [common] try to examine Schema::Reset(cols, ...)
......................................................................

WIP [common] try to examine Schema::Reset(cols, ...)

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 3
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................


Patch Set 6:

(5 comments)

Thank you for the patch!

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@7
PS6, Line 7: fix function Schema::Reset(cols, ...)
How about:

fix bug in Schema::Reset(cols, ...)


http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@9
PS6, Line 9: When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
           : I find Schema::Reset(cols, ...) seems not what we expect,
           : and in my opinion, it's a bug.
           : 
           : The fixing is no confluence to all unit tests.
How about updating this a bit to describe the essence of the problem.  For example, something like below:

Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset().  This patch addresses the issue.

A new test scenario is added to cover the corresponding regressions in future.


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc
File src/kudu/common/schema-test.cc:

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@322
PS6, Line 322: schema.Reset(schema1.columns(), 2);
Wrap into ASSERT_OK()?


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema-test.cc@327
PS6, Line 327: 
Could you also add an extra check below?

  ASSERT_EQ(schema.key_byte_size(), schema1.key_byte_size());


http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:

http://gerrit.cloudera.org:8080/#/c/18213/6/src/kudu/common/schema.cc@284
PS6, Line 284:   col_offsets_.reserve(cols_.size() + 1);  // Include space for total byte size at the end.
             :   col_offsets_.clear();
nit: consider changing the order to call vector::clear() before calling vector::reserve()

Even if vector::clear() should not change the capacity by the C++ standard (see https://en.cppreference.com/w/cpp/container/vector/clear), I think the code would be more straightforward if calling vector::clear() before vector::reserve() above.



-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 6
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 21:36:36 +0000
Gerrit-HasComments: Yes

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................


Patch Set 9: Code-Review+2

(1 comment)

Thank you for the contribution!

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18213/6//COMMIT_MSG@9
PS6, Line 9: Prior to this patch, Schema::col_offsets_ was not cleared
           : upon calling Schema::Reset(). This patch addresses the issue.
           : 
           : A new test scenario is added to cover the corresponding regressions in future.
           : 
> You are very kind.  I would change it.
Thank you for updating the summary and the description!  Now it's a bit easier to understand what this patch is about just after reading the commit description.



-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 9
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 16:28:57 +0000
Gerrit-HasComments: Yes

[kudu-CR] [common] fix function Schema::Reset(cols, ...)

Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18213

to look at the new patch set (#7).

Change subject: [common] fix function Schema::Reset(cols, ...)
......................................................................

[common] fix function Schema::Reset(cols, ...)

When I fix a tool bug (https://gerrit.cloudera.org/c/18169/),
I find Schema::Reset(cols, ...) seems not what we expect,
and in my opinion, it's a bug.

The fixing is no confluence to all unit tests.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/18213/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 7
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>

[kudu-CR] [common] fix a bug in Schema::Reset(cols, ...)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18213 )

Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................

[common] fix a bug in Schema::Reset(cols, ...)

Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.

A new test scenario is added to cover the corresponding regressions in future.

Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Reviewed-on: http://gerrit.cloudera.org:8080/18213
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, but someone else must approve
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18213
Gerrit-PatchSet: 10
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>