You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Rampelberg <th...@saunter.org> on 2014/01/10 20:54:16 UTC
Review Request 16787: Implemented a table directive that allows for sorting
and pagination.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Diffs
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31564
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16787/#comment60084>
This is much better than seeing this all in the DOM being copied/pasted.
- Ross Allen
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31577
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16787/#comment60092>
I gave that a try and had problems making it work. Take a look at the comment I added.
- Thomas Rampelberg
On Jan. 11, 2014, 1:07 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 1:07 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> docs/powered-by-mesos.md 35f2dde949f2cf9a51303a0a0c8183035b29684f
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31630
-----------------------------------------------------------
docs/powered-by-mesos.md
<https://reviews.apache.org/r/16787/#comment60317>
Looks like this diff needs a rebase since this change doesn't belong to this commit.
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/16787/#comment60319>
Awesome. So close to killing jQuery...
- Ross Allen
On Jan. 11, 2014, 1:07 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 1:07 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> docs/powered-by-mesos.md 35f2dde949f2cf9a51303a0a0c8183035b29684f
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31686
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Jan. 14, 2014, 12:22 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 12:22 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
> src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
> src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
> src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
> src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
> src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
> src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
> src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Header Sorting
> https://reviews.apache.org/media/uploaded/files/2014/01/14/e2a2cc9f-de3d-4c3e-977b-35dd28394212__Screenshot_2014-01-13_16.18.30.png
> Pagination
> https://reviews.apache.org/media/uploaded/files/2014/01/14/3165c796-cd25-47cf-ae78-051d828571e7__Screenshot_2014-01-13_16.22.09.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31687
-----------------------------------------------------------
This has been submitted.
- Ross Allen
On Jan. 14, 2014, 12:22 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 12:22 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
> src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
> src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
> src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
> src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
> src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
> src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
> src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Header Sorting
> https://reviews.apache.org/media/uploaded/files/2014/01/14/e2a2cc9f-de3d-4c3e-977b-35dd28394212__Screenshot_2014-01-13_16.18.30.png
> Pagination
> https://reviews.apache.org/media/uploaded/files/2014/01/14/3165c796-cd25-47cf-ae78-051d828571e7__Screenshot_2014-01-13_16.22.09.png
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 12:22 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
File Attachments (updated)
----------------
Header Sorting
https://reviews.apache.org/media/uploaded/files/2014/01/14/e2a2cc9f-de3d-4c3e-977b-35dd28394212__Screenshot_2014-01-13_16.18.30.png
Pagination
https://reviews.apache.org/media/uploaded/files/2014/01/14/3165c796-cd25-47cf-ae78-051d828571e7__Screenshot_2014-01-13_16.22.09.png
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 12:21 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
File Attachments (updated)
----------------
Header Sorting
https://reviews.apache.org/media/uploaded/files/2014/01/14/e2a2cc9f-de3d-4c3e-977b-35dd28394212__Screenshot_2014-01-13_16.18.30.png
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 11:56 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 11:51 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 11:42 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Joe Smith <ya...@gmail.com>.
> On Jan. 13, 2014, 2:56 p.m., Joe Smith wrote:
> > src/webui/master/static/home.html, line 119
> > <https://reviews.apache.org/r/16787/diff/6/?file=421979#file421979line119>
> >
> > looks like a merge issue?
>
> Thomas Rampelberg wrote:
> Yup, that's what I get for being dismissive. Thanks for catching that!
No worries, I've done it a few times too :) Any chance you can link a screenshot or two of how this looks?
I'll let someone with a bit more context on this code take it from here though
- Joe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31666
-----------------------------------------------------------
On Jan. 13, 2014, 3:56 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 3:56 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
> src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
> src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
> src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
> src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
> src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
> src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
> src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 13, 2014, 10:56 p.m., Joe Smith wrote:
> > src/webui/master/static/home.html, line 119
> > <https://reviews.apache.org/r/16787/diff/6/?file=421979#file421979line119>
> >
> > looks like a merge issue?
Yup, that's what I get for being dismissive. Thanks for catching that!
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31666
-----------------------------------------------------------
On Jan. 13, 2014, 11:42 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 11:42 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
> src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
> src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
> src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
> src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
> src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
> src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
> src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31666
-----------------------------------------------------------
Sweet, looking forward to this!
src/webui/master/static/home.html
<https://reviews.apache.org/r/16787/#comment60365>
looks like a merge issue?
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/16787/#comment60366>
sweet, good call
- Joe Smith
On Jan. 13, 2014, 2 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 2 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
> src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
> src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
> src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
> src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
> src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
> src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
> src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 10 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am 21df397318fd43f8eab1f0f90f4c1ab5ab873718
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 8:42 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am 576023d37540067a4e020c0fe9e2668f41810757
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html f0aff0d12f6f873a72b0e1057a7702d260a7c70c
src/webui/master/static/frameworks.html 1cdd39fdcfbb44070c8bafd49d484423ffeea04f
src/webui/master/static/home.html 336d1188809885317e2e04ebcf306efd4be7c3c5
src/webui/master/static/js/app.js 67e9a3af03783c5c2cd72a1a83b7f0a9cc20c46c
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 121fd93b8b93171449932c69f7be6c1a48e58e7f
src/webui/master/static/slave.html 60dc3089f9bcd8d4c3462ebb120d94c733d3e587
src/webui/master/static/slave_executor.html e5501e3038027855523ec95a2abefd1640f668dd
src/webui/master/static/slave_framework.html b597ac59517846b677aa1da5ef6cbb2e1b3a7cd2
src/webui/master/static/slaves.html c729fadd977b551a30484f0765c57432165a3bc0
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31642
-----------------------------------------------------------
Can you rebase this commit onto the Bootstrap change?
- Ross Allen
On Jan. 13, 2014, 7:09 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:09 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 7:09 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 1:07 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
docs/powered-by-mesos.md 35f2dde949f2cf9a51303a0a0c8183035b29684f
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Jan. 11, 2014, 12:46 a.m., Ross Allen wrote:
> > src/webui/master/static/js/app.js, line 307
> > <https://reviews.apache.org/r/16787/diff/2/?file=420293#file420293line307>
> >
> > Can this move to the directive's template? DOM manipulation should be left up to Angular.
>
> Thomas Rampelberg wrote:
> There isn't a template for the directive. I couldn't figure out a way to instantiate directives programatically.
Would a template like this work?:
<div data-ng-transclude></div>
<div m-pagination></div>
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31553
-----------------------------------------------------------
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 11, 2014, 12:46 a.m., Ross Allen wrote:
> > src/webui/master/static/js/app.js, line 307
> > <https://reviews.apache.org/r/16787/diff/2/?file=420293#file420293line307>
> >
> > Can this move to the directive's template? DOM manipulation should be left up to Angular.
There isn't a template for the directive. I couldn't figure out a way to instantiate directives programatically.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31553
-----------------------------------------------------------
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31553
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16787/#comment60081>
Can this move to the directive's template? DOM manipulation should be left up to Angular.
- Ross Allen
On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2014, 12:18 a.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 12:18 a.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
> On Jan. 10, 2014, 10:49 p.m., Ross Allen wrote:
> >
It *could*. There isn't really a template here though. It would require me to add those attrs inside the code (see line 254 and ng-click).
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31552
-----------------------------------------------------------
On Jan. 10, 2014, 9:52 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2014, 9:52 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/#review31552
-----------------------------------------------------------
src/webui/master/static/js/app.js
<https://reviews.apache.org/r/16787/#comment60080>
Can DOM manipulation be moved to the template?
- Ross Allen
On Jan. 10, 2014, 9:52 p.m., Thomas Rampelberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16787/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2014, 9:52 p.m.)
>
>
> Review request for mesos and Ross Allen.
>
>
> Bugs: mesos-900
> https://issues.apache.org/jira/browse/mesos-900
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Implemented a table directive that allows for sorting and pagination.
>
> Review: http://reviews.apache.org/r/16787
>
>
> Diffs
> -----
>
> src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
> src/webui/master/static/directives/pagination.html PRE-CREATION
> src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
> src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
> src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
> src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
> src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
> src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
> src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
> src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
> src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
> src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
>
> Diff: https://reviews.apache.org/r/16787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas Rampelberg
>
>
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 9:52 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description (updated)
-------
Implemented a table directive that allows for sorting and pagination.
Review: http://reviews.apache.org/r/16787
Diffs (updated)
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 7:55 p.m.)
Review request for mesos and Ross Allen.
Bugs: mesos-900
https://issues.apache.org/jira/browse/mesos-900
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Diffs
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg
Re: Review Request 16787: Implemented a table directive that allows for
sorting and pagination.
Posted by Thomas Rampelberg <th...@saunter.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16787/
-----------------------------------------------------------
(Updated Jan. 10, 2014, 7:54 p.m.)
Review request for mesos and Ross Allen.
Repository: mesos-git
Description
-------
Implemented a table directive that allows for sorting and pagination.
Diffs
-----
src/Makefile.am ef707706315911c73e12c024b8bb38bbf5487621
src/webui/master/static/directives/pagination.html PRE-CREATION
src/webui/master/static/framework.html 72e14dfb58895e43a10f10c139a983a78b3e8878
src/webui/master/static/frameworks.html 39e7883ffe001ff33ed1b35108c893fa8ff1f92d
src/webui/master/static/home.html fb3a38e94c30487c9b7e50c65c73b7af29999c3f
src/webui/master/static/js/app.js 5569d1143ab353a31515a77113fa742df4ec25ab
src/webui/master/static/js/controllers.js 064f9ec425538e1a9b32e0b119c9d3178d2bcfb7
src/webui/master/static/offers.html 215d65e1ad30fb0df06bcf05cec797d60672ec66
src/webui/master/static/slave.html f30d914e4b43b5d4579c52053f9c0e04089a3adf
src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246
src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203
Diff: https://reviews.apache.org/r/16787/diff/
Testing
-------
Thanks,
Thomas Rampelberg