You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/10/02 00:38:44 UTC
[jira] Created: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
ChecksumFileSystem does not override all create(...) methods
------------------------------------------------------------
Key: HADOOP-4326
URL: https://issues.apache.org/jira/browse/HADOOP-4326
Project: Hadoop Core
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
Priority: Blocker
Fix For: 0.18.2
ChecksumFileSystem does not override the following method
{code}
public FSDataOutputStream create(Path f, FsPermission permission,
boolean overwrite, int bufferSize, short replication, long blockSize,
Progressable progress) throws IOException
{code}
As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: 4326_20081001b_0.18.patch
4326_20081001b_0.18.patch: for 0.18
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636256#action_12636256 ]
Raghu Angadi commented on HADOOP-4326:
--------------------------------------
+1 patch looks good.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-4326:
--------------------------------
Fix Version/s: 0.19.0
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636357#action_12636357 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4326:
------------------------------------------------
The failed TestLeaseRecovery2 is addressed in HADOOP-4257.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: 4326_20081001.patch
4326_20081001.patch: fixed ChecksumFileSystem.create
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Component/s: fs
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.3, 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.17.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636330#action_12636330 ]
Hadoop QA commented on HADOOP-4326:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391341/4326_20081001b.patch
against trunk revision 700997.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3422/console
This message is automatically generated.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Fix Version/s: 0.17.3
This one should also be committed to 0.17
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.3, 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Release Note: Fixed a problem that ChecksumFileSystem did not override all create(...) methods.
Is this an incompatible change?
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636824#action_12636824 ]
Hudson commented on HADOOP-4326:
--------------------------------
Integrated in Hadoop-trunk #623 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/623/])
. ChecksumFileSystem does not override create(...) correctly. (szetszwo)
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.3, 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.17.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636246#action_12636246 ]
Raghu Angadi commented on HADOOP-4326:
--------------------------------------
To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: 4326_20081001b.patch
4326_20081001b.patch: upload the same patch again, so that hudson will pick up the correct file.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: 4326_20081001b_0.17.patch
4326_20081001b_0.17.patch: for 0.17
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.3, 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.17.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: 4326_20081001b.patch
4326_20081001b.patch: updated the test.
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636258#action_12636258 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4326:
------------------------------------------------
"ant test-patch" results:
{noformat}
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4326:
------------------------------------
Release Note: (was: Fixed a problem that ChecksumFileSystem did not override all create(...) methods.)
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.3, 0.18.2, 0.19.0
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.17.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4326) ChecksumFileSystem does not
override all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636253#action_12636253 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4326:
------------------------------------------------
> To avoid such a mistake again, should we make rest of the create methods in FileSystem class final?
+1 Created HADOOP-4328
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4326) ChecksumFileSystem does not override
all create(...) methods
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4326:
-------------------------------------------
Attachment: (was: 4326_20081001b.patch)
> ChecksumFileSystem does not override all create(...) methods
> ------------------------------------------------------------
>
> Key: HADOOP-4326
> URL: https://issues.apache.org/jira/browse/HADOOP-4326
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: 4326_20081001.patch, 4326_20081001b.patch, 4326_20081001b_0.18.patch
>
>
> ChecksumFileSystem does not override the following method
> {code}
> public FSDataOutputStream create(Path f, FsPermission permission,
> boolean overwrite, int bufferSize, short replication, long blockSize,
> Progressable progress) throws IOException
> {code}
> As a consequence, when creating a file with LocalFileSystem and the create method above, no checksum will be created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.