You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "AnonHxy (via GitHub)" <gi...@apache.org> on 2023/04/28 10:59:44 UTC

[GitHub] [pulsar] AnonHxy commented on pull request #20196: [improve][broker] Improve knownBrokers update in ModularLoadManagerImpl

AnonHxy commented on PR #20196:
URL: https://github.com/apache/pulsar/pull/20196#issuecomment-1527388524

   > @AnonHxy hi i found some previous fix on the ConcurrentModificationException when on `knownBrokers` field. and in my opinion this method will have a chance to execute concurrently. So if thread1 is try to figure out which is newAddBroker and which is deadBroker. thread2 clear the Collection will there an missing update？maybe an synchronized is need WDYT？
   
   Make sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org