You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/07/02 15:17:54 UTC
[Bug 4453] New: whitelist_from_rcvd sending host field is case sensitive (patch avail)
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
Summary: whitelist_from_rcvd sending host field is case sensitive
(patch avail)
Product: Spamassassin
Version: unspecified
Platform: Other
OS/Version: other
Status: NEW
Severity: minor
Priority: P5
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: nj@leverton.org
Found in 3.1.0-pre2 but I don't know how long it's been like that. In a
whitelist_from_rcvd rule, e.g. for Crypto-Gram:
whitelist_from_rcvd schneier@counterpane.com MODWEST.COM
the third field with the rDNS domain name, here modwest.com, is case
sensitive. The rule given above will never fire. Not a big deal perhaps, but
while testing my 3.1.0 upgrade I cut and pasted the hostnames from the
Received headers, and puzzled over my trusted_betworks for ages until I
realised the problem is actually this. ISTR upppercase hostnames is some
sort of sendmail-ism. Anyway, patch attached.
If you wonder why I use Bruce's personal address (as in the From: ) instead of
the Crypto-gram Return-Path, it's because Return-Path is no longer queried
since the slightly bodgy fix for bug 1064 in SA 2.42 :-( I'm sure it could be
done better, and I'll look at that one separately.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
Bob@Menschel.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.0
Version|unspecified |SVN Trunk (Latest Devel
| |Version)
------- Additional Comments From Bob@Menschel.net 2005-07-02 22:50 -------
Triage: simple enough, one line patch supplied that looks good to me, I would
hope this could be dropped into 3.1.0 even at this late date.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] [review] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
------- Additional Comments From jm@jmason.org 2005-07-05 18:25 -------
+1 agreed
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] [review] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
------- Additional Comments From parkerm@pobox.com 2005-07-07 05:34 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
------- Additional Comments From nj@leverton.org 2005-07-02 06:19 -------
Created an attachment (id=2973)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2973&action=view)
Test mail
Sorry about the complex path in the local net! Received: should be trusted up
to and including xcalibre.co.uk.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] [review] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2005-07-07 16:03 -------
Committed revision 209672.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
------- Additional Comments From nj@leverton.org 2005-07-02 06:21 -------
Created an attachment (id=2974)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2974&action=view)
Against 3.1.0-pre2
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4453] [review] whitelist_from_rcvd sending host field is case sensitive (patch avail)
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4453
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|whitelist_from_rcvd sending |[review] whitelist_from_rcvd
|host field is case sensitive|sending host field is case
|(patch avail) |sensitive (patch avail)
------- Additional Comments From spamassassin@dostech.ca 2005-07-05 18:10 -------
+1 host names shouldn't be case sensitive.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.