You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/15 12:05:07 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #101: test: add e2e test scaffold
tokers opened a new pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543836431
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=h1) Report
> Merging [#101](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=desc) (b2a9ba4) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/90f6638a9e785cce0a020ae8da20fe506bd4945b?el=desc) (90f6638) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 58.20% 58.20%
=======================================
Files 15 15
Lines 500 500
=======================================
Hits 291 291
Misses 185 185
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=footer). Last update [90f6638...b2a9ba4](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=h1) Report
> Merging [#101](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=desc) (f7b4c80) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/d7cd3e25822270817cee9a8cfe82ab10ac264cb9?el=desc) (d7cd3e2) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 60.53% 60.53%
=======================================
Files 16 16
Lines 527 527
=======================================
Hits 319 319
Misses 184 184
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=footer). Last update [d7cd3e2...f7b4c80](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r544076003
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
Resolve.
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
Resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543369360
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
seems wrong. only test cases need this library
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=h1) Report
> Merging [#101](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=desc) (0b07ca5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/983dbb02105d450ac74cf8da48f7c457f2c78d26?el=desc) (983dbb0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 59.73% 59.73%
=======================================
Files 16 16
Lines 524 524
=======================================
Hits 313 313
Misses 187 187
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=footer). Last update [983dbb0...da7e785](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=h1) Report
> Merging [#101](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=desc) (da7e785) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/983dbb02105d450ac74cf8da48f7c457f2c78d26?el=desc) (983dbb0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 59.73% 59.73%
=======================================
Files 16 16
Lines 524 524
=======================================
Hits 313 313
Misses 187 187
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=footer). Last update [983dbb0...da7e785](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543806297
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
Since we only use on go module in this project, all dependencies include the tests will be recorded in go.mod.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#discussion_r543816381
##########
File path: go.mod
##########
@@ -10,6 +10,7 @@ require (
github.com/gxthrj/apisix-types v0.1.0
github.com/gxthrj/seven v0.1.9
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
+ github.com/onsi/ginkgo v1.11.0
Review comment:
The `go.sum` and `go.mod` in the test can be maintained separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101#issuecomment-745247281
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=h1) Report
> Merging [#101](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=desc) (fb9dfea) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/90f6638a9e785cce0a020ae8da20fe506bd4945b?el=desc) (90f6638) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 58.20% 58.20%
=======================================
Files 15 15
Lines 500 500
=======================================
Hits 291 291
Misses 185 185
Partials 24 24
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=footer). Last update [90f6638...b2a9ba4](https://codecov.io/gh/apache/apisix-ingress-controller/pull/101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #101: test: add e2e test scaffold
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #101:
URL: https://github.com/apache/apisix-ingress-controller/pull/101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org