[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2802: ARTEMIS-2457 implement ring queue

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r315888950
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueuePendingMessageMetrics.java
 ##########
 @@ -49,14 +52,18 @@
 
    private final Queue queue;
 
-   public QueuePendingMessageMetrics(final Queue queue) {
+   private final String name;
+
+   public QueuePendingMessageMetrics(final Queue queue, final String name) {
       Preconditions.checkNotNull(queue);
       this.queue = queue;
+      this.name = name;
    }
 
    public void incrementMetrics(final MessageReference reference) {
       long size = getPersistentSize(reference);
       COUNT_UPDATER.incrementAndGet(this);
+      logger.debugf("%s increment messageCount to %d: %s", this, messageCount, reference);
 
 Review comment:
   can we wrap this in a isDebugEnabled

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services