You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/26 00:57:23 UTC

[GitHub] [druid] suneet-s commented on a change in pull request #11631: DataSchema: improve rollup WARN message

suneet-s commented on a change in pull request #11631:
URL: https://github.com/apache/druid/pull/11631#discussion_r696210133



##########
File path: server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java
##########
@@ -116,8 +116,7 @@ public DataSchema(
 
     if (this.granularitySpec.isRollup()) {

Review comment:
       It seems like another option is to only warn if isRollup is true and aggregators is empty. This way the current warning message would make more sense.
   
   ```suggestion
       if (this.granularitySpec.isRollup() &&  && this.aggregators.length == 0) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org