You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/04/19 12:48:29 UTC
[GitHub] [spark] pan3793 opened a new pull request, #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
pan3793 opened a new pull request, #40850:
URL: https://github.com/apache/spark/pull/40850
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Replace reflection w/ direct calling for `org.apache.hadoop.ipc.CallerContext`
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
`org.apache.hadoop.ipc.CallerContext` was added in [HDFS-9184](https://issues.apache.org/jira/browse/HDFS-9184) (Hadoop 2.8.0/3.0.0), previously, Spark uses reflection to invoke it for compatible w/ Hadoop 2.7, since SPARK-42452 removed support for Hadoop2, we can call the Hadoop class directly instead of using reflection.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao closed pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao closed pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
URL: https://github.com/apache/spark/pull/40850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #40850:
URL: https://github.com/apache/spark/pull/40850#issuecomment-1514681056
cc @sunchao @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on code in PR #40850:
URL: https://github.com/apache/spark/pull/40850#discussion_r1172865732
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -3371,22 +3358,11 @@ private[spark] class CallerContext(
/**
* Set up the caller context [[context]] by invoking Hadoop CallerContext API of
- * [[org.apache.hadoop.ipc.CallerContext]], which was added in hadoop 2.8.
+ * [[org.apache.hadoop.ipc.CallerContext]].
*/
- def setCurrentContext(): Unit = {
- if (CallerContext.callerContextSupported) {
- try {
- val callerContext = Utils.classForName("org.apache.hadoop.ipc.CallerContext")
- val builder: Class[AnyRef] =
- Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
- val builderInst = builder.getConstructor(classOf[String]).newInstance(context)
- val hdfsContext = builder.getMethod("build").invoke(builderInst)
- callerContext.getMethod("setCurrent", callerContext).invoke(null, hdfsContext)
- } catch {
- case NonFatal(e) =>
- logWarning("Fail to set Spark caller context", e)
- }
- }
+ def setCurrentContext(): Unit = if (CallerContext.callerContextEnabled) {
+ val hdfsContext = new org.apache.hadoop.ipc.CallerContext.Builder(context).build()
+ org.apache.hadoop.ipc.CallerContext.setCurrent(hdfsContext)
Review Comment:
nit: Instead of using the fully qualified name (which made sense in reflection code earlier), we should have used a renamed import statement.
Something like:
import org.apache.hadoop.ipc.{CallerContext => HadoopCallerContext}
import org.apache.hadoop.ipc.CallerContext.{Builder => HadoopCallerContextBuilder}
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -3371,22 +3358,11 @@ private[spark] class CallerContext(
/**
* Set up the caller context [[context]] by invoking Hadoop CallerContext API of
- * [[org.apache.hadoop.ipc.CallerContext]], which was added in hadoop 2.8.
+ * [[org.apache.hadoop.ipc.CallerContext]].
*/
- def setCurrentContext(): Unit = {
- if (CallerContext.callerContextSupported) {
- try {
- val callerContext = Utils.classForName("org.apache.hadoop.ipc.CallerContext")
- val builder: Class[AnyRef] =
- Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
- val builderInst = builder.getConstructor(classOf[String]).newInstance(context)
- val hdfsContext = builder.getMethod("build").invoke(builderInst)
- callerContext.getMethod("setCurrent", callerContext).invoke(null, hdfsContext)
- } catch {
- case NonFatal(e) =>
- logWarning("Fail to set Spark caller context", e)
- }
- }
+ def setCurrentContext(): Unit = if (CallerContext.callerContextEnabled) {
+ val hdfsContext = new org.apache.hadoop.ipc.CallerContext.Builder(context).build()
+ org.apache.hadoop.ipc.CallerContext.setCurrent(hdfsContext)
Review Comment:
nit: Instead of using the fully qualified name (which made sense in reflection code earlier), we should have used a renamed import statement.
Something like:
```
import org.apache.hadoop.ipc.{CallerContext => HadoopCallerContext}
import org.apache.hadoop.ipc.CallerContext.{Builder => HadoopCallerContextBuilder}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #40850:
URL: https://github.com/apache/spark/pull/40850#discussion_r1173234909
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -3371,22 +3358,11 @@ private[spark] class CallerContext(
/**
* Set up the caller context [[context]] by invoking Hadoop CallerContext API of
- * [[org.apache.hadoop.ipc.CallerContext]], which was added in hadoop 2.8.
+ * [[org.apache.hadoop.ipc.CallerContext]].
*/
- def setCurrentContext(): Unit = {
- if (CallerContext.callerContextSupported) {
- try {
- val callerContext = Utils.classForName("org.apache.hadoop.ipc.CallerContext")
- val builder: Class[AnyRef] =
- Utils.classForName("org.apache.hadoop.ipc.CallerContext$Builder")
- val builderInst = builder.getConstructor(classOf[String]).newInstance(context)
- val hdfsContext = builder.getMethod("build").invoke(builderInst)
- callerContext.getMethod("setCurrent", callerContext).invoke(null, hdfsContext)
- } catch {
- case NonFatal(e) =>
- logWarning("Fail to set Spark caller context", e)
- }
- }
+ def setCurrentContext(): Unit = if (CallerContext.callerContextEnabled) {
+ val hdfsContext = new org.apache.hadoop.ipc.CallerContext.Builder(context).build()
+ org.apache.hadoop.ipc.CallerContext.setCurrent(hdfsContext)
Review Comment:
Thanks @mridulm, opened https://github.com/apache/spark/pull/40891 to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #40850: [SPARK-43191][CORE] Replace reflection w/ direct calling for Hadoop CallerContext
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao commented on PR #40850:
URL: https://github.com/apache/spark/pull/40850#issuecomment-1515685347
Merged to master, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org