You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/20 01:45:42 UTC
[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19939: [wip] Attemp to fix cd by changing gpu node to g4 which has newer nvidia drivers
Zha0q1 opened a new pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939
https://github.com/apache/incubator-mxnet/issues/19917
This pr tries to fix ^ this issue. Joe helped update g4 instance to use the new nvidia-460 driver, which should be higher than the minimum requirement of the cu112 docker
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939#discussion_r581454004
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1307,13 +1307,14 @@ cd_pypi_publish() {
cd_s3_publish() {
set -ex
- pip3 install --user awscli
+ pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
+ export PATH=/usr/local/bin:$PATH
Review comment:
We recently changed the ami used by restricted-mxnetlinux-gpu to update the nvidia driver
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939#discussion_r581615238
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1307,13 +1307,14 @@ cd_pypi_publish() {
cd_s3_publish() {
set -ex
- pip3 install --user awscli
+ pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
+ export PATH=/usr/local/bin:$PATH
Review comment:
@leezu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939#discussion_r581454260
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1307,13 +1307,14 @@ cd_pypi_publish() {
cd_s3_publish() {
set -ex
- pip3 install --user awscli
+ pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
+ export PATH=/usr/local/bin:$PATH
Review comment:
Do you think if there is a better place to set PATH?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939#discussion_r581452814
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1307,13 +1307,14 @@ cd_pypi_publish() {
cd_s3_publish() {
set -ex
- pip3 install --user awscli
+ pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
+ export PATH=/usr/local/bin:$PATH
Review comment:
Do you mean that `/usr/local/bin` wasn't on the PATH before? Do you know why it worked at all before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 closed pull request #19939: [wip] Attemp to fix cd by changing gpu node to g4 which has newer nvidia drivers
Posted by GitBox <gi...@apache.org>.
Zha0q1 closed pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19939: Fix cd by adding to $PATH
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19939:
URL: https://github.com/apache/incubator-mxnet/pull/19939#discussion_r582164915
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1307,13 +1307,14 @@ cd_pypi_publish() {
cd_s3_publish() {
set -ex
- pip3 install --user awscli
+ pip3 install --upgrade --user awscli
filepath=$(readlink -f wheel_build/dist/*.whl)
filename=$(basename $filepath)
variant=$(echo $filename | cut -d'-' -f1 | cut -d'_' -f2 -s)
if [ -z "${variant}" ]; then
variant="cpu"
fi
+ export PATH=/usr/local/bin:$PATH
Review comment:
It's fine to add it here, I'm just trying to understand the reasoning. Can you explain how it's related to AMI? Wouldn't `cd_s3_publish` run in a docker container and be independent from the AMI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org