[GitHub] [geode] mkevo commented on a diff in pull request #6225: GEODE-9101: fix VisibleNode attribute in MemberMXBean

[GitBox <gi...@apache.org>]

mkevo commented on code in PR #6225:
URL: https://github.com/apache/geode/pull/6225#discussion_r869103403


##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -1793,9 +1793,7 @@ private String prettifyReason(String r) {
    */
   private void handleManagerStartup(InternalDistributedMember theId) {
     // Note test is under membersLock
-    if (theId.getVmKind() != ClusterDistributionManager.LOCATOR_DM_TYPE) {
-      stats.incNodes(1);
-    }
+    stats.incNodes(1);

Review Comment:
   The stats should count both locators and servers, as both of them are nodes. With if-condition locators wouldn't count.



##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -350,13 +350,13 @@ static ClusterDistributionManager create(InternalDistributedSystem system,
               }
             }
           }
+        } else {
+          distributionManager.addNewMember(id); // add ourselves

Review Comment:
   Hi @kirklund ,
   I send a mail to the dev list to discuss what is the right way to fix this. No response.
   I wrote an RFC with adding a new attribute. The only one response, to fix this ticket instead of adding a new attribute.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org