You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/06 18:43:22 UTC
[GitHub] [incubator-mxnet] TristonC opened a new pull request #20493: [License] Remove the "copyright by contributors" line in source files
TristonC opened a new pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493
## Description ##
This PR is the action item 5, for the issue [20475](https://github.com/apache/incubator-mxnet/issues/20475). It removes the "Copyright by Contributors" line in the ./src and ./include directory and their sub-directories.
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [x] Remove the "Copyright by Contributors" line in the ./src direcotry and its sub-directories.
- [x] Remove the "Copyright by Contributors" line in the ./include direcotry and its sub-directories.
## Comments ##
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on a change in pull request #20493: [v1.9.x] Remove the "copyright by contributors" line in source files
Posted by GitBox <gi...@apache.org>.
TristonC commented on a change in pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493#discussion_r684506876
##########
File path: src/kvstore/comm.h
##########
@@ -18,7 +18,6 @@
*/
/**
Review comment:
Done.
##########
File path: src/kvstore/gpu_topology.h
##########
@@ -18,7 +18,6 @@
*/
/**
Review comment:
Done.
##########
File path: src/operator/numpy/np_einsum_op.cc
##########
@@ -34,7 +34,6 @@
* with the distribution.
*
* * Neither the name of the NumPy Developers nor the names of any
- * contributors may be used to endorse or promote products derived
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20493: [v1.9.x] Remove the "copyright by contributors" line in source files
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] TristonC commented on a change in pull request #20493: [v1.9.x] Remove the "copyright by contributors" line in source files
Posted by GitBox <gi...@apache.org>.
TristonC commented on a change in pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493#discussion_r684504914
##########
File path: src/operator/numpy/np_einsum_op.cc
##########
@@ -34,7 +34,6 @@
* with the distribution.
*
* * Neither the name of the NumPy Developers nor the names of any
- * contributors may be used to endorse or promote products derived
Review comment:
Not sure about this. Should we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20493: [License] Remove the "copyright by contributors" line in source files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493#issuecomment-894449862
Hey @TristonC , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [edge, sanity, centos-cpu, unix-gpu, clang, windows-gpu, website, unix-cpu, miscellaneous, windows-cpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #20493: [v1.9.x] Remove the "copyright by contributors" line in source files
Posted by GitBox <gi...@apache.org>.
josephevans commented on a change in pull request #20493:
URL: https://github.com/apache/incubator-mxnet/pull/20493#discussion_r684499605
##########
File path: src/kvstore/comm.h
##########
@@ -18,7 +18,6 @@
*/
/**
Review comment:
remove empty comment lines here too?
##########
File path: src/kvstore/gpu_topology.h
##########
@@ -18,7 +18,6 @@
*/
/**
Review comment:
Empty comment.
##########
File path: src/operator/numpy/np_einsum_op.cc
##########
@@ -34,7 +34,6 @@
* with the distribution.
*
* * Neither the name of the NumPy Developers nor the names of any
- * contributors may be used to endorse or promote products derived
Review comment:
This line shouldn't be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org