You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "JackDrogon (via GitHub)" <gi...@apache.org> on 2024/01/29 09:13:09 UTC
[PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
JackDrogon opened a new pull request, #30509:
URL: https://github.com/apache/doris/pull/30509
## Proposed changes
Refactor be/CMakeLists some add_compile_options to add_definitions && set to option
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #30509:
URL: https://github.com/apache/doris/pull/30509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "JackDrogon (via GitHub)" <gi...@apache.org>.
JackDrogon commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914266550
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914337452
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit b9de322111f6fccb14ed1903838fff5461510f4a with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 13.4 seconds inserted 10000000 Rows, about 746K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914409153
TeamCity be ut coverage result:
Function Coverage: 36.19% (8621/23823)
Line Coverage: 28.25% (70512/249579)
Region Coverage: 27.25% (36379/133522)
Branch Coverage: 24.04% (18643/77536)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b9de322111f6fccb14ed1903838fff5461510f4a_b9de322111f6fccb14ed1903838fff5461510f4a/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914268498
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914268428
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914322590
<details>
<summary>TPC-DS: <b>Total hot run time: 172828 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b9de322111f6fccb14ed1903838fff5461510f4a, data reload: false
query1 933 335 329 329
query2 6560 1953 1850 1850
query3 6691 203 197 197
query4 32372 22289 22134 22134
query5 4447 429 359 359
query6 244 148 152 148
query7 4613 257 258 257
query8 242 169 169 169
query9 8611 2267 2243 2243
query10 412 216 195 195
query11 17875 15505 15390 15390
query12 117 69 62 62
query13 1674 374 382 374
query14 9187 6440 6351 6351
query15 200 180 188 180
query16 5698 265 245 245
query17 944 479 471 471
query18 1800 262 253 253
query19 175 130 128 128
query20 71 71 68 68
query21 193 129 131 129
query22 4919 4665 4630 4630
query23 31220 30346 30395 30346
query24 12409 2773 2783 2773
query25 583 311 301 301
query26 2045 138 140 138
query27 3173 283 288 283
query28 7719 1829 1813 1813
query29 2229 622 619 619
query30 286 139 129 129
query31 897 705 713 705
query32 77 48 46 46
query33 705 211 206 206
query34 1159 465 469 465
query35 855 765 791 765
query36 1327 1216 1104 1104
query37 96 58 61 58
query38 3270 3172 3147 3147
query39 1289 1266 1232 1232
query40 345 87 82 82
query41 36 37 35 35
query42 87 82 79 79
query43 513 490 482 482
query44 1115 699 698 698
query45 194 176 177 176
query46 1024 660 647 647
query47 1611 1523 1440 1440
query48 388 319 308 308
query49 1218 280 281 280
query50 682 305 308 305
query51 5265 5126 5096 5096
query52 89 80 78 78
query53 310 257 261 257
query54 253 190 179 179
query55 84 73 71 71
query56 173 154 160 154
query57 954 916 889 889
query58 176 153 152 152
query59 2639 2515 2571 2515
query60 202 176 186 176
query61 83 80 83 80
query62 616 376 342 342
query63 281 264 262 262
query64 5990 1765 1756 1756
query65 3289 3237 3240 3237
query66 1450 317 309 309
query67 14576 14087 14293 14087
query68 3920 507 500 500
query69 414 305 312 305
query70 1559 1461 1545 1461
query71 253 217 203 203
query72 3745 2856 2848 2848
query73 699 308 309 308
query74 6704 6166 6234 6166
query75 2748 2272 2250 2250
query76 2605 1060 957 957
query77 350 241 219 219
query78 9105 8818 8777 8777
query79 2176 488 487 487
query80 1211 317 309 309
query81 521 197 195 195
query82 680 88 75 75
query83 215 113 113 113
query84 292 72 72 72
query85 2144 345 324 324
query86 506 395 378 378
query87 3422 3279 3271 3271
query88 3767 2155 2165 2155
query89 427 346 348 346
query90 1851 187 182 182
query91 152 115 118 115
query92 51 44 41 41
query93 2140 450 412 412
query94 1352 155 158 155
query95 503 460 445 445
query96 630 313 310 310
query97 4272 4114 4199 4114
query98 202 193 179 179
query99 1042 692 734 692
Total cold run time: 280618 ms
Total hot run time: 172828 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914281845
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914332044
<details>
<summary>ClickBench: <b>Total hot run time: 30.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b9de322111f6fccb14ed1903838fff5461510f4a, data reload: false
query1 0.03 0.04 0.03
query2 0.06 0.02 0.03
query3 0.23 0.06 0.06
query4 1.68 0.10 0.09
query5 0.53 0.51 0.52
query6 1.36 0.65 0.65
query7 0.02 0.02 0.01
query8 0.04 0.03 0.03
query9 0.52 0.50 0.50
query10 0.56 0.54 0.55
query11 0.12 0.08 0.09
query12 0.12 0.09 0.10
query13 0.61 0.60 0.61
query14 0.80 0.80 0.80
query15 0.80 0.78 0.78
query16 0.38 0.40 0.38
query17 1.01 1.02 1.04
query18 0.23 0.26 0.25
query19 1.87 1.78 1.78
query20 0.01 0.01 0.01
query21 15.42 0.59 0.61
query22 2.68 2.72 1.49
query23 17.53 0.78 0.71
query24 2.41 1.11 1.37
query25 0.42 0.14 0.16
query26 0.55 0.15 0.14
query27 0.04 0.05 0.05
query28 11.30 0.84 0.86
query29 12.56 3.26 3.13
query30 0.65 0.50 0.53
query31 2.79 0.33 0.35
query32 3.38 0.49 0.47
query33 3.25 3.19 3.20
query34 15.97 4.32 4.30
query35 4.41 4.32 4.32
query36 1.08 1.06 1.09
query37 0.07 0.05 0.05
query38 0.04 0.03 0.03
query39 0.02 0.01 0.01
query40 0.16 0.12 0.12
query41 0.07 0.02 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.83 s
Total hot run time: 30.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](cmake) Refactor be/CMakeLists some add_compile_options to add_definitions && set to option [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30509:
URL: https://github.com/apache/doris/pull/30509#issuecomment-1914302325
<details>
<summary>TPC-H: <b>Total hot run time: 37932 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b9de322111f6fccb14ed1903838fff5461510f4a, data reload: false
------ Round 1 ----------------------------------
q1 17622 5043 4919 4919
q2 2048 144 136 136
q3 10597 939 921 921
q4 4745 791 785 785
q5 8332 2901 2841 2841
q6 184 123 119 119
q7 1175 748 740 740
q8 9441 2065 2073 2065
q9 7781 6482 6415 6415
q10 8064 2423 2433 2423
q11 406 216 205 205
q12 781 291 286 286
q13 18011 3308 3271 3271
q14 279 254 262 254
q15 525 493 498 493
q16 457 431 416 416
q17 958 567 530 530
q18 7078 6240 6066 6066
q19 1562 1354 1310 1310
q20 622 331 346 331
q21 7265 3119 3177 3119
q22 813 290 287 287
Total cold run time: 108746 ms
Total hot run time: 37932 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5060 5242 4947 4947
q2 358 233 246 233
q3 2988 2688 2783 2688
q4 1802 1602 1647 1602
q5 5208 5327 5130 5130
q6 200 115 115 115
q7 2131 1837 1816 1816
q8 3127 3251 3293 3251
q9 8672 8667 21998 8667
q10 6332 3483 3494 3483
q11 545 454 472 454
q12 738 580 606 580
q13 16982 3102 3075 3075
q14 289 251 254 251
q15 530 497 491 491
q16 537 473 464 464
q17 1994 1612 1733 1612
q18 8850 8392 8273 8273
q19 23798 1594 1526 1526
q20 4600 1926 1894 1894
q21 14784 4811 4916 4811
q22 1057 473 448 448
Total cold run time: 110582 ms
Total hot run time: 55811 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org