[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #40: GitHub actions and OSX fixes

[GitBox <gi...@apache.org>]

rm5248 commented on a change in pull request #40:
URL: https://github.com/apache/logging-log4cxx/pull/40#discussion_r485957409



##########
File path: .gitattributes
##########
@@ -0,0 +1 @@
+* text eol=lf

Review comment:
       It doesn't look like it, but we could perhaps be a bit more specific.  I think we could do something like
   ```
   src/test/witness/* -text
   ```
   to tell git to not normalize the line endings, and then having a `* text=auto` entry for everything else(I haven't tried this out).  I don't view it as a big deal, since most(all?) IDEs should take care of that, although it's possible that we could get into a situation where \r\n is mixed with \n in the same file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org