You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "Kyle Schoonover (Jira)" <ji...@apache.org> on 2022/01/31 03:35:00 UTC

[jira] [Created] (AVRO-3334) Simplify getNullableType in CodeGen

Kyle Schoonover created AVRO-3334:
-------------------------------------

             Summary: Simplify getNullableType in CodeGen
                 Key: AVRO-3334
                 URL: https://issues.apache.org/jira/browse/AVRO-3334
             Project: Apache Avro
          Issue Type: Improvement
          Components: csharp
    Affects Versions: 1.11.1
            Reporter: Kyle Schoonover


First issue: C# naming for methods uses Pascal casing.  Update getNullableType to GetNullableType.  I do not see a reason to preserve anything from the Java library with this naming style.  Additionally, the java library does not have this method.

Second issue: This is a publicly exposed method it has no specific error handling on the input (UnionSchema schema).  It should be evaluated for null and throw an ArgumentNullException, if null, before being used.

Third issue: We should evaluate the null return scenarios first. 
The first validation is that the schema has 2 elements.
The second evaluation is to determine if all of the elements (Schema.Tag) is not of type null.

If these evaluations are not met the existing logic will return the schema where the Schema.Tag is not Schema.Type.Null



--
This message was sent by Atlassian Jira
(v8.20.1#820001)