You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/10/27 06:42:54 UTC
Review Request 53217: LENS-968 : Timeout long running queries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968
Repository: lens
Description
-------
Adds configurable timeout for queries, which is overridable at driver level and even at query level.
Adds a period checker which checks if any of queries timedout and canel them.
Diffs
-----
lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
lens-server/src/main/resources/lenssession-default.xml 9a8f9da
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
lens-server/src/test/resources/lens-site.xml d96659f
lens-server/src/test/resources/logback.xml 6b91a77
src/site/apt/admin/config.apt f22fc0c
src/site/apt/admin/esdriver-config.apt ce952ae
src/site/apt/admin/jdbcdriver-config.apt c64d6ee
src/site/apt/admin/session-config.apt d480f88
Diff: https://reviews.apache.org/r/53217/diff/
Testing
-------
Running org.apache.lens.server.query.TestQueryService
Tests run: 68, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 382.464 sec - in org.apache.lens.server.query.TestQueryService
Results :
Tests run: 68, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154834
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Nov. 3, 2016, 11:40 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2016, 11:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds configurable timeout for queries, which is overridable at driver level and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f9db2a
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
> lens-server/src/main/resources/lensserver-default.xml a00048b
> lens-server/src/main/resources/lenssession-default.xml 9a8f9da
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
> lens-server/src/test/resources/lens-site.xml d96659f
> lens-server/src/test/resources/logback.xml 6b91a77
> src/site/apt/admin/config.apt 4d49781
> src/site/apt/admin/esdriver-config.apt ce952ae
> src/site/apt/admin/jdbcdriver-config.apt c64d6ee
> src/site/apt/admin/session-config.apt d480f88
>
> Diff: https://reviews.apache.org/r/53217/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
> [INFO] Lens .............................................. SUCCESS [2.843s]
> [INFO] Lens API .......................................... SUCCESS [21.049s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
> [INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
> [INFO] Lens DB storage ................................... SUCCESS [16.439s]
> [INFO] Lens Query Library ................................ SUCCESS [12.739s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
> [INFO] Lens Server ....................................... SUCCESS [16:28.932s]
> [INFO] Lens client ....................................... SUCCESS [1:21.876s]
> [INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
> [INFO] Lens Examples ..................................... SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
> [INFO] Lens Distribution ................................. SUCCESS [8.981s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [12.315s]
> [INFO] Lens UI ........................................... SUCCESS [30.001s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
> [INFO] Lens Python Client ................................ SUCCESS [0.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
-----------------------------------------------------------
(Updated Nov. 3, 2016, 11:40 a.m.)
Review request for lens.
Changes
-------
All review comments fixed.
Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968
Repository: lens
Description
-------
Adds configurable timeout for queries, which is overridable at driver level and even at query level.
Adds a period checker which checks if any of queries timedout and canel them.
Diffs (updated)
-----
lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 8f9db2a
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
lens-server/src/main/resources/lensserver-default.xml a00048b
lens-server/src/main/resources/lenssession-default.xml 9a8f9da
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
lens-server/src/test/resources/lens-site.xml d96659f
lens-server/src/test/resources/logback.xml 6b91a77
src/site/apt/admin/config.apt 4d49781
src/site/apt/admin/esdriver-config.apt ce952ae
src/site/apt/admin/jdbcdriver-config.apt c64d6ee
src/site/apt/admin/session-config.apt d480f88
Diff: https://reviews.apache.org/r/53217/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
[INFO] Lens .............................................. SUCCESS [2.843s]
[INFO] Lens API .......................................... SUCCESS [21.049s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
[INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
[INFO] Lens DB storage ................................... SUCCESS [16.439s]
[INFO] Lens Query Library ................................ SUCCESS [12.739s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
[INFO] Lens Server ....................................... SUCCESS [16:28.932s]
[INFO] Lens client ....................................... SUCCESS [1:21.876s]
[INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
[INFO] Lens Examples ..................................... SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
[INFO] Lens Distribution ................................. SUCCESS [8.981s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
[INFO] Lens Regression ................................... SUCCESS [12.315s]
[INFO] Lens UI ........................................... SUCCESS [30.001s]
[INFO] Lens Contrib ...................................... SUCCESS [0.328s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
[INFO] Lens Python Client ................................ SUCCESS [0.334s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
-----------------------------------------------------------
(Updated Nov. 2, 2016, 7:47 a.m.)
Review request for lens.
Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968
Repository: lens
Description
-------
Adds configurable timeout for queries, which is overridable at driver level and even at query level.
Adds a period checker which checks if any of queries timedout and canel them.
Diffs (updated)
-----
lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
lens-server/src/main/resources/lenssession-default.xml 9a8f9da
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
lens-server/src/test/resources/lens-site.xml d96659f
lens-server/src/test/resources/logback.xml 6b91a77
src/site/apt/admin/config.apt f22fc0c
src/site/apt/admin/esdriver-config.apt ce952ae
src/site/apt/admin/jdbcdriver-config.apt c64d6ee
src/site/apt/admin/session-config.apt d480f88
Diff: https://reviews.apache.org/r/53217/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
[INFO] Lens .............................................. SUCCESS [2.843s]
[INFO] Lens API .......................................... SUCCESS [21.049s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
[INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
[INFO] Lens DB storage ................................... SUCCESS [16.439s]
[INFO] Lens Query Library ................................ SUCCESS [12.739s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
[INFO] Lens Server ....................................... SUCCESS [16:28.932s]
[INFO] Lens client ....................................... SUCCESS [1:21.876s]
[INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
[INFO] Lens Examples ..................................... SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
[INFO] Lens Distribution ................................. SUCCESS [8.981s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
[INFO] Lens Regression ................................... SUCCESS [12.315s]
[INFO] Lens UI ........................................... SUCCESS [30.001s]
[INFO] Lens Contrib ...................................... SUCCESS [0.328s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
[INFO] Lens Python Client ................................ SUCCESS [0.334s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
-----------------------------------------------------------
(Updated Nov. 2, 2016, 7:44 a.m.)
Review request for lens.
Changes
-------
Fixed review comments
Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968
Repository: lens
Description
-------
Adds configurable timeout for queries, which is overridable at driver level and even at query level.
Adds a period checker which checks if any of queries timedout and canel them.
Diffs (updated)
-----
lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
lens-server/src/main/resources/lenssession-default.xml 9a8f9da
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
lens-server/src/test/resources/lens-site.xml d96659f
lens-server/src/test/resources/logback.xml 6b91a77
src/site/apt/admin/config.apt f22fc0c
src/site/apt/admin/esdriver-config.apt ce952ae
src/site/apt/admin/jdbcdriver-config.apt c64d6ee
src/site/apt/admin/session-config.apt d480f88
Diff: https://reviews.apache.org/r/53217/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
[INFO] Lens .............................................. SUCCESS [2.843s]
[INFO] Lens API .......................................... SUCCESS [21.049s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
[INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
[INFO] Lens DB storage ................................... SUCCESS [16.439s]
[INFO] Lens Query Library ................................ SUCCESS [12.739s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
[INFO] Lens Server ....................................... SUCCESS [16:28.932s]
[INFO] Lens client ....................................... SUCCESS [1:21.876s]
[INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
[INFO] Lens Examples ..................................... SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
[INFO] Lens Distribution ................................. SUCCESS [8.981s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
[INFO] Lens Regression ................................... SUCCESS [12.315s]
[INFO] Lens UI ........................................... SUCCESS [30.001s]
[INFO] Lens Contrib ...................................... SUCCESS [0.328s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
[INFO] Lens Python Client ................................ SUCCESS [0.334s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Nov. 2, 2016, 6:58 a.m., Puneet Gupta wrote:
> > lens-server/src/main/resources/lensserver-default.xml, line 296
> > <https://reviews.apache.org/r/53217/diff/1/?file=1547145#file1547145line296>
> >
> > We might need a smaller default check interval if in most cases "query lens.query.timeout.millis" is very small.
Have kept the default to 1hr, as the default of query timeout is 1day. Have updated documentation to reduce the value if deployment expects lower values for query timeout. Otherwise, should we make the default to few seconds?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154118
-----------------------------------------------------------
On Nov. 2, 2016, 7:44 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2016, 7:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds configurable timeout for queries, which is overridable at driver level and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
> lens-server/src/main/resources/lenssession-default.xml 9a8f9da
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
> lens-server/src/test/resources/lens-site.xml d96659f
> lens-server/src/test/resources/logback.xml 6b91a77
> src/site/apt/admin/config.apt f22fc0c
> src/site/apt/admin/esdriver-config.apt ce952ae
> src/site/apt/admin/jdbcdriver-config.apt c64d6ee
> src/site/apt/admin/session-config.apt d480f88
>
> Diff: https://reviews.apache.org/r/53217/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
> [INFO] Lens .............................................. SUCCESS [2.843s]
> [INFO] Lens API .......................................... SUCCESS [21.049s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
> [INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
> [INFO] Lens DB storage ................................... SUCCESS [16.439s]
> [INFO] Lens Query Library ................................ SUCCESS [12.739s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
> [INFO] Lens Server ....................................... SUCCESS [16:28.932s]
> [INFO] Lens client ....................................... SUCCESS [1:21.876s]
> [INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
> [INFO] Lens Examples ..................................... SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
> [INFO] Lens Distribution ................................. SUCCESS [8.981s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [12.315s]
> [INFO] Lens UI ........................................... SUCCESS [30.001s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
> [INFO] Lens Python Client ................................ SUCCESS [0.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154118
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 1180)
<https://reviews.apache.org/r/53217/#comment223620>
should we call this "query.expiry.check.interval.millis"
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1636)
<https://reviews.apache.org/r/53217/#comment224089>
The log message needs to be updated for time unit.
lens-server/src/main/resources/lensserver-default.xml (line 296)
<https://reviews.apache.org/r/53217/#comment224090>
We might need a smaller default check interval if in most cases "query lens.query.timeout.millis" is very small.
- Puneet Gupta
On Oct. 27, 2016, 9:04 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2016, 9:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds configurable timeout for queries, which is overridable at driver level and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
> lens-server/src/main/resources/lenssession-default.xml 9a8f9da
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
> lens-server/src/test/resources/lens-site.xml d96659f
> lens-server/src/test/resources/logback.xml 6b91a77
> src/site/apt/admin/config.apt f22fc0c
> src/site/apt/admin/esdriver-config.apt ce952ae
> src/site/apt/admin/jdbcdriver-config.apt c64d6ee
> src/site/apt/admin/session-config.apt d480f88
>
> Diff: https://reviews.apache.org/r/53217/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
> [INFO] Lens .............................................. SUCCESS [2.843s]
> [INFO] Lens API .......................................... SUCCESS [21.049s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
> [INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
> [INFO] Lens DB storage ................................... SUCCESS [16.439s]
> [INFO] Lens Query Library ................................ SUCCESS [12.739s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
> [INFO] Lens Server ....................................... SUCCESS [16:28.932s]
> [INFO] Lens client ....................................... SUCCESS [1:21.876s]
> [INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
> [INFO] Lens Examples ..................................... SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
> [INFO] Lens Distribution ................................. SUCCESS [8.981s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [12.315s]
> [INFO] Lens UI ........................................... SUCCESS [30.001s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
> [INFO] Lens Python Client ................................ SUCCESS [0.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Oct. 31, 2016, 12:46 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 218
> > <https://reviews.apache.org/r/53217/diff/1/?file=1547144#file1547144line218>
> >
> > Can we add it to health status as well?
> >
> > Can we termintate queryExpirer when query service is stopped? Seems thread is not getting terminated now.
Thanks for checking this. Fixed it now.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154240
-----------------------------------------------------------
On Nov. 2, 2016, 7:44 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2016, 7:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds configurable timeout for queries, which is overridable at driver level and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
> lens-server/src/main/resources/lenssession-default.xml 9a8f9da
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
> lens-server/src/test/resources/lens-site.xml d96659f
> lens-server/src/test/resources/logback.xml 6b91a77
> src/site/apt/admin/config.apt f22fc0c
> src/site/apt/admin/esdriver-config.apt ce952ae
> src/site/apt/admin/jdbcdriver-config.apt c64d6ee
> src/site/apt/admin/session-config.apt d480f88
>
> Diff: https://reviews.apache.org/r/53217/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
> [INFO] Lens .............................................. SUCCESS [2.843s]
> [INFO] Lens API .......................................... SUCCESS [21.049s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
> [INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
> [INFO] Lens DB storage ................................... SUCCESS [16.439s]
> [INFO] Lens Query Library ................................ SUCCESS [12.739s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
> [INFO] Lens Server ....................................... SUCCESS [16:28.932s]
> [INFO] Lens client ....................................... SUCCESS [1:21.876s]
> [INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
> [INFO] Lens Examples ..................................... SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
> [INFO] Lens Distribution ................................. SUCCESS [8.981s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [12.315s]
> [INFO] Lens UI ........................................... SUCCESS [30.001s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
> [INFO] Lens Python Client ................................ SUCCESS [0.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154240
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 218)
<https://reviews.apache.org/r/53217/#comment223732>
Can we add it to health status as well?
Can we termintate queryExpirer when query service is stopped? Seems thread is not getting terminated now.
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 2016)
<https://reviews.apache.org/r/53217/#comment223733>
[Minor] typo in comment.
instead of timeout value *1 second* to *300 millis*
- Raju Bairishetti
On Oct. 27, 2016, 9:04 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2016, 9:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
>
>
> Repository: lens
>
>
> Description
> -------
>
> Adds configurable timeout for queries, which is overridable at driver level and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
> lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
> lens-server/src/main/resources/lenssession-default.xml 9a8f9da
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
> lens-server/src/test/resources/lens-site.xml d96659f
> lens-server/src/test/resources/logback.xml 6b91a77
> src/site/apt/admin/config.apt f22fc0c
> src/site/apt/admin/esdriver-config.apt ce952ae
> src/site/apt/admin/jdbcdriver-config.apt c64d6ee
> src/site/apt/admin/session-config.apt d480f88
>
> Diff: https://reviews.apache.org/r/53217/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
> [INFO] Lens .............................................. SUCCESS [2.843s]
> [INFO] Lens API .......................................... SUCCESS [21.049s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
> [INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
> [INFO] Lens DB storage ................................... SUCCESS [16.439s]
> [INFO] Lens Query Library ................................ SUCCESS [12.739s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
> [INFO] Lens Server ....................................... SUCCESS [16:28.932s]
> [INFO] Lens client ....................................... SUCCESS [1:21.876s]
> [INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
> [INFO] Lens Examples ..................................... SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
> [INFO] Lens Distribution ................................. SUCCESS [8.981s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [12.315s]
> [INFO] Lens UI ........................................... SUCCESS [30.001s]
> [INFO] Lens Contrib ...................................... SUCCESS [0.328s]
> [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
> [INFO] Lens Python Client ................................ SUCCESS [0.334s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:44.416s
> [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
> [INFO] Final Memory: 272M/3119M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 53217: LENS-968 : Timeout long running queries
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/
-----------------------------------------------------------
(Updated Oct. 27, 2016, 9:04 a.m.)
Review request for lens.
Bugs: LENS-968
https://issues.apache.org/jira/browse/LENS-968
Repository: lens
Description
-------
Adds configurable timeout for queries, which is overridable at driver level and even at query level.
Adds a period checker which checks if any of queries timedout and canel them.
Diffs
-----
lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 3ae59c6
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 64c7145
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 2a2963f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java b5e996f
lens-server/src/main/resources/lensserver-default.xml 8e5fe8a
lens-server/src/main/resources/lenssession-default.xml 9a8f9da
lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java 5a8d5e6
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java ecbd689
lens-server/src/test/resources/lens-site.xml d96659f
lens-server/src/test/resources/logback.xml 6b91a77
src/site/apt/admin/config.apt f22fc0c
src/site/apt/admin/esdriver-config.apt ce952ae
src/site/apt/admin/jdbcdriver-config.apt c64d6ee
src/site/apt/admin/session-config.apt d480f88
Diff: https://reviews.apache.org/r/53217/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s]
[INFO] Lens .............................................. SUCCESS [2.843s]
[INFO] Lens API .......................................... SUCCESS [21.049s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.230s]
[INFO] Lens Cube ......................................... SUCCESS [14:06.805s]
[INFO] Lens DB storage ................................... SUCCESS [16.439s]
[INFO] Lens Query Library ................................ SUCCESS [12.739s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s]
[INFO] Lens Server ....................................... SUCCESS [16:28.932s]
[INFO] Lens client ....................................... SUCCESS [1:21.876s]
[INFO] Lens CLI .......................................... SUCCESS [1:12.501s]
[INFO] Lens Examples ..................................... SUCCESS [8.167s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
[INFO] Lens Distribution ................................. SUCCESS [8.981s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
[INFO] Lens Regression ................................... SUCCESS [12.315s]
[INFO] Lens UI ........................................... SUCCESS [30.001s]
[INFO] Lens Contrib ...................................... SUCCESS [0.328s]
[INFO] Lens Contributed Clients .......................... SUCCESS [0.325s]
[INFO] Lens Python Client ................................ SUCCESS [0.334s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:44.416s
[INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016
[INFO] Final Memory: 272M/3119M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu