You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/01/21 11:50:17 UTC
[GitHub] [commons-beanutils] korzha opened a new pull request #72: Skip trace logging string concatenation if it's off
korzha opened a new pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] korzha commented on pull request #72: Refactor logger usage
Posted by GitBox <gi...@apache.org>.
korzha commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764994484
@garydgregory I've fixed all other logger misusages. I didn't touch single string parameter calls since they do level checks inside by themselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory merged pull request #72: Refactor logger usage
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] korzha closed pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
korzha closed pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory merged pull request #72: Refactor logger usage
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764787758
What about the 32 other calls to trace? What should we do (if anything) about those? If we are going to guard against wasteful string construction, let's do it consistently instead of one-off PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] korzha closed pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
korzha closed pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory edited a comment on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764787758
What about the 32 other calls to trace, some of which are not guarded? What should we do (if anything) about those? If we are going to guard against wasteful string construction, let's do it consistently instead of one-off PRs.
Actually, most are guarded which is nice, but not all it seems...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] korzha commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
korzha commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764679968
@melloware Thanks for approval!
But 17-ea build fails for some odd reason "Locale provider adapter "CLDR"cannot be instantiated."
Is there something missing in master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764680649
Its a known issue with Jacoco plugin. Once Jacoco 0.8.7 is released it will be fixed for JDK17 so there is nothing for you to do right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] korzha commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
korzha commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764679968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764787758
What about the 32 other calls to trace? What should we do (if anything) about those? If we are going to guard against wasteful string construction, let's do it consistently instead of one-off PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] melloware commented on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764680649
Its a known issue with Jacoco plugin. Once Jacoco 0.8.7 is released it will be fixed for JDK17 so there is nothing for you to do right now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory edited a comment on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764787758
What about the 32 other calls to trace, some of which are not guarded? What should we do (if anything) about those? If we are going to guard against wasteful string construction, let's do it consistently instead of one-off PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-beanutils] garydgregory edited a comment on pull request #72: Skip trace logging string concatenation if it's off
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #72:
URL: https://github.com/apache/commons-beanutils/pull/72#issuecomment-764787758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org