[GitHub] [thrift] ulidtko commented on a change in pull request #2151: THRIFT-5186: Rewrite address resolution in T{Nonblocking,}ServerSocket

[GitBox <gi...@apache.org>]

ulidtko commented on a change in pull request #2151:
URL: https://github.com/apache/thrift/pull/2151#discussion_r431449964



##########
File path: lib/cpp/src/thrift/transport/TSocketUtils.h
##########
@@ -0,0 +1,185 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ * Copyright (c) 2020 Max Ivanov <ul...@gmail.com>
+ */

Review comment:
       Hey Jens, sorry I don't get this... The top-level NOTICE file has only 4 lines, you want me to move this copyright notice (line 21) to there?..
   
   This doesn't make sense to me; this line here basically says "I wrote this file" (which is true); the same line in top-level NOTICE would say "I wrote the whole Apache Thrift" (which is blatantly not true). So, a very bad refactoring, that would be.
   
   Just above line 21, it says *Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements*. I did sign ASF CLA. So, despite me claiming copyright credit for the file, ASF is perfectly allowed to do everything that Apache-2.0 license allows.
   
   This is the golden arrangement for all parties here, at least according to my understanding.
   
   Would you please explain? The page you linked talks mostly about dependencies, and doesn't describe my use case at all (contributing a new file).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org