You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "eolivelli (via GitHub)" <gi...@apache.org> on 2023/02/07 07:38:34 UTC
[GitHub] [pulsar] eolivelli commented on a diff in pull request #19446: [fix][broker] Expect msgs after server initiated CloseProducer
eolivelli commented on code in PR #19446:
URL: https://github.com/apache/pulsar/pull/19446#discussion_r1098273478
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1622,6 +1625,14 @@ protected void handleSend(CommandSend send, ByteBuf headersAndPayload) {
CompletableFuture<Producer> producerFuture = producers.get(send.getProducerId());
if (producerFuture == null || !producerFuture.isDone() || producerFuture.isCompletedExceptionally()) {
+ if (recentlyClosedProducers.containsKey(send.getProducerId())) {
Review Comment:
should we compare the "epoch" here ? maybe it is unnecessary, but I am not expert in this part of the protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org